Style - #119
Conversation
twynb
left a comment
There was a problem hiding this comment.
attempting to build throws a build error, because PyInstaller doesn't accept svg files as app icons. Please re-add logo.ico and use it in build.spec.
resolved |
twynb
left a comment
There was a problem hiding this comment.
I'm not sure if I'm a fan of this design - the way it is now, the input fields/switches are way too far away from the labels, which makes them feel disconnected. I think having them closer together would be better.
|
When you increase window width a little then max width will be set again to 80%. What do you think? |
|
That behavior doesn't happen on my end - when i widen the window, the max width grows a little, but nowhere near where it was before |
have reverted |
|
@ChrisItisdud can you also check whether icon's quality in system tray after build is better or not. I cant check because in linux there is no icon |
|
i can't see the change being reverted, to me building the app and running the built app looks like this:
maybe those xl/lg rules don't work properly when running in an app like this? also i never bothered to check the tray icon quality, it does look pretty low res though |
twynb
left a comment
There was a problem hiding this comment.
looks better now - not perfect but i think further changes can be saved for another issue after publishing
* finalise docs * delete no longer necessary files * Style (#119) * Fix Doc tags * style: update * revert: change * add better logo.ico * revert: change in settings * style --------- Co-authored-by: 4lex0017 <alex.kern@live.de> Co-authored-by: Christina / Itisdud / twyn!b <92167981+ChrisItisdud@users.noreply.github.com> * finalise docs * chore: remove d.ts --------- Co-authored-by: phat.nguyen <89086602+chubetho@users.noreply.github.com> Co-authored-by: 4lex0017 <alex.kern@live.de> Co-authored-by: phatnguyen <phatnguyen@gmx.de>
No description provided.