DPL Analysis: prevent HistogramRegistry from including ASoA.h#15557
Merged
Conversation
aalkin
commented
Jun 25, 2026
Member
- Remove ASoA.h and TableBuilder.h includes from HistogramRegistry.h as it is used in various inclusion chains in PWG code
- Temporarily deprecate "fill with filter" feature, as it not used in O2Physics and requires rework to be efficient
Collaborator
|
Error while checking build/O2/fullCI_slc9 for a75e0bf at 2026-06-26 12:42: Full log here. |
a75e0bf to
07c3332
Compare
Collaborator
ktf
reviewed
Jun 28, 2026
| void HistFiller::fillHistAny(std::shared_ptr<R> hist, const T& table, const o2::framework::expressions::Filter& filter) | ||
| void HistFiller::fillHistAny(std::shared_ptr<R>, const T&, const o2::framework::expressions::Filter&) | ||
| { | ||
| HistFiller::badHistogramFill(hist->GetName()); |
Member
There was a problem hiding this comment.
how is this supposed to work? why not simply dropping the method?
Member
Author
There was a problem hiding this comment.
There is still a histogram registry example code in Tutorials that uses this code path. And I intend to rework this feature in the future rather than completely removing it, this is left for compatibility.
Member
There was a problem hiding this comment.
Maybe add a FATAL "not implemented"?
Member
Author
There was a problem hiding this comment.
It is not used anywhere except that one tutorial, there is no point.
Member
|
Merged. Please do not leave the broken API for too long, though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.