From 699e9bfd1e054d53bc0521deef2e0083a3e26cc3 Mon Sep 17 00:00:00 2001 From: Alessandro Barbieri Date: Thu, 6 Aug 2026 00:17:59 +0200 Subject: [PATCH 1/3] Remove Elemental Devastation from spellcrit Elemental Devastation gives melee+ranged crit --- Modules/Data/Constants.lua | 3 --- 1 file changed, 3 deletions(-) diff --git a/Modules/Data/Constants.lua b/Modules/Data/Constants.lua index 0645eb1c..76384a01 100755 --- a/Modules/Data/Constants.lua +++ b/Modules/Data/Constants.lua @@ -286,9 +286,6 @@ Data.Aura = { }, SpellCrit = { [24907] = ((not ECS.IsClassic) and 5 or nil), -- Moonkin Aura - [29177] = 6, -- Elemental Devastation Rank 2 - [29178] = 9, -- Elemental Devastation Rank 3 - [30165] = 3, -- Elemental Devastation Rank 1 [51466] = 3, -- Elemental Oath Rank 1 [51470] = 5, -- Elemental Oath Rank 2 }, From e5c50b62ae8f9685dcc8b489e4594116595ff10a Mon Sep 17 00:00:00 2001 From: Alessandro Barbieri Date: Thu, 6 Aug 2026 02:59:57 +0200 Subject: [PATCH 2/3] Remove SpellCrit data from Constants.lua Removed SpellCrit entries from Constants.lua. --- Modules/Data/Constants.lua | 5 ----- 1 file changed, 5 deletions(-) diff --git a/Modules/Data/Constants.lua b/Modules/Data/Constants.lua index 76384a01..353b5aac 100755 --- a/Modules/Data/Constants.lua +++ b/Modules/Data/Constants.lua @@ -284,11 +284,6 @@ Data.Aura = { [25894] = (ECS.IsClassic and 1 or nil), -- Greater Blessing of Wisdom rank 1 [25918] = (ECS.IsClassic and 1 or nil), -- Greater Blessing of Wisdom rank 2 }, - SpellCrit = { - [24907] = ((not ECS.IsClassic) and 5 or nil), -- Moonkin Aura - [51466] = 3, -- Elemental Oath Rank 1 - [51470] = 5, -- Elemental Oath Rank 2 - }, SpellHaste = { [1714] = -50, -- Curse of Tongues Rank 1 [3603] = -35, -- Distracting Pain From 820bb0fda2878436f614be876286ec4bd64b0efe Mon Sep 17 00:00:00 2001 From: Alessandro Barbieri Date: Thu, 6 Aug 2026 03:03:13 +0200 Subject: [PATCH 3/3] fix spellcrit being counted twice wow API now consider the spellcrit from auras --- Modules/Data/SpellCrit.lua | 1 - 1 file changed, 1 deletion(-) diff --git a/Modules/Data/SpellCrit.lua b/Modules/Data/SpellCrit.lua index 3f8ab430..e045d76c 100755 --- a/Modules/Data/SpellCrit.lua +++ b/Modules/Data/SpellCrit.lua @@ -34,7 +34,6 @@ function _SpellCrit:GetSpellCritFromBuffs(school) local aura = C_UnitAuras.GetBuffDataByIndex("player", i) i = i + 1 if aura and aura.spellId then - mod = mod + (Data.Aura.SpellCrit[aura.spellId] or 0) if school == Data.FIRE_SCHOOL then if aura.spellId == 28682 then mod = mod + (aura.applications * 10) -- 10% for each stack from Combustion