From 16cd3a1383b662abdef2047160b874a1369f80e9 Mon Sep 17 00:00:00 2001 From: eyob tech Date: Thu, 30 Jul 2026 01:55:37 +0100 Subject: [PATCH 1/6] Fix book library bugs: render syntax error, wrong array reference, author field, delete button, read status logic --- debugging/book-library/script.js | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/debugging/book-library/script.js b/debugging/book-library/script.js index 75ce6c1d..cb0445e2 100644 --- a/debugging/book-library/script.js +++ b/debugging/book-library/script.js @@ -37,8 +37,8 @@ function submit() { alert("Please fill all fields!"); return false; } else { - let book = new Book(title.value, title.value, pages.value, check.checked); - library.push(book); + let book = new Book(title.value, author.value, pages.value, check.checked); + myLibrary.push(book); render(); } } @@ -54,7 +54,7 @@ function render() { let table = document.getElementById("display"); let rowsNumber = table.rows.length; //delete old table - for (let n = rowsNumber - 1; n > 0; n-- { + for (let n = rowsNumber - 1; n > 0; n--) { table.deleteRow(n); } //insert updated row and cells @@ -77,9 +77,9 @@ function render() { wasReadCell.appendChild(changeBut); let readStatus = ""; if (myLibrary[i].check == false) { - readStatus = "Yes"; - } else { readStatus = "No"; + } else { + readStatus = "Yes"; } changeBut.innerText = readStatus; @@ -90,14 +90,14 @@ function render() { //add delete button to every row and render again let delButton = document.createElement("button"); - delBut.id = i + 5; - deleteCell.appendChild(delBut); - delBut.className = "btn btn-warning"; - delBut.innerHTML = "Delete"; - delBut.addEventListener("clicks", function () { - alert(`You've deleted title: ${myLibrary[i].title}`); + delButton.id = i + 5; + deleteCell.appendChild(delButton); + delButton.className = "btn btn-warning"; + delButton.innerHTML = "Delete"; + delButton.addEventListener("click", function () { + alert(You've deleted title: ${myLibrary[i].title}); myLibrary.splice(i, 1); render(); }); } -} +} \ No newline at end of file From f717abe0342acd29a9d3e7c816b8b451b802f427 Mon Sep 17 00:00:00 2001 From: eyob tech Date: Thu, 30 Jul 2026 02:15:31 +0100 Subject: [PATCH 2/6] Fix book library bugs: render syntax error, wrong array reference, author field, delete button, read status logic, missing author validation --- debugging/book-library/script.js | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/debugging/book-library/script.js b/debugging/book-library/script.js index cb0445e2..9ef68e7a 100644 --- a/debugging/book-library/script.js +++ b/debugging/book-library/script.js @@ -29,11 +29,13 @@ const check = document.getElementById("check"); //via Book function and start render function function submit() { if ( - title.value == null || - title.value == "" || - pages.value == null || - pages.value == "" - ) { + title.value == null || + title.value == "" || + author.value == null || + author.value == "" || + pages.value == null || + pages.value == "" +) { alert("Please fill all fields!"); return false; } else { @@ -95,7 +97,7 @@ function render() { delButton.className = "btn btn-warning"; delButton.innerHTML = "Delete"; delButton.addEventListener("click", function () { - alert(You've deleted title: ${myLibrary[i].title}); + alert(`You've deleted title: ${myLibrary[i].title}`); myLibrary.splice(i, 1); render(); }); From b90249eb4defa84949d37828403fbba1a64248aa Mon Sep 17 00:00:00 2001 From: eyob tech Date: Wed, 5 Aug 2026 00:25:47 +0100 Subject: [PATCH 3/6] Apply code review feedback: remove duplicate render call, fix id collisions, simplify delete timing, use const and textContent, improve naming --- debugging/book-library/script.js | 81 +++++++++++++++----------------- 1 file changed, 39 insertions(+), 42 deletions(-) diff --git a/debugging/book-library/script.js b/debugging/book-library/script.js index 9ef68e7a..de5c4c43 100644 --- a/debugging/book-library/script.js +++ b/debugging/book-library/script.js @@ -7,8 +7,8 @@ window.addEventListener("load", function (e) { function populateStorage() { if (myLibrary.length == 0) { - let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true); - let book2 = new Book( + const book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true); + const book2 = new Book( "The Old Man and the Sea", "Ernest Hemingway", "127", @@ -16,30 +16,34 @@ function populateStorage() { ); myLibrary.push(book1); myLibrary.push(book2); - render(); } } -const title = document.getElementById("title"); -const author = document.getElementById("author"); -const pages = document.getElementById("pages"); -const check = document.getElementById("check"); +const titleInput = document.getElementById("title"); +const authorInput = document.getElementById("author"); +const pagesInput = document.getElementById("pages"); +const checkInput = document.getElementById("check"); //check the right input from forms and if its ok -> add the new book (object in array) //via Book function and start render function function submit() { if ( - title.value == null || - title.value == "" || - author.value == null || - author.value == "" || - pages.value == null || - pages.value == "" -) { + titleInput.value == null || + titleInput.value == "" || + authorInput.value == null || + authorInput.value == "" || + pagesInput.value == null || + pagesInput.value == "" + ) { alert("Please fill all fields!"); return false; } else { - let book = new Book(title.value, author.value, pages.value, check.checked); + let book = new Book( + titleInput.value, + authorInput.value, + pagesInput.value, + checkInput.checked + ); myLibrary.push(book); render(); } @@ -53,53 +57,46 @@ function Book(title, author, pages, check) { } function render() { - let table = document.getElementById("display"); - let rowsNumber = table.rows.length; + const table = document.getElementById("display"); + const rowsNumber = table.rows.length; //delete old table for (let n = rowsNumber - 1; n > 0; n--) { table.deleteRow(n); } //insert updated row and cells - let length = myLibrary.length; + const length = myLibrary.length; for (let i = 0; i < length; i++) { - let row = table.insertRow(1); - let titleCell = row.insertCell(0); - let authorCell = row.insertCell(1); - let pagesCell = row.insertCell(2); - let wasReadCell = row.insertCell(3); - let deleteCell = row.insertCell(4); - titleCell.innerHTML = myLibrary[i].title; - authorCell.innerHTML = myLibrary[i].author; - pagesCell.innerHTML = myLibrary[i].pages; + const row = table.insertRow(1); + const titleCell = row.insertCell(0); + const authorCell = row.insertCell(1); + const pagesCell = row.insertCell(2); + const wasReadCell = row.insertCell(3); + const deleteCell = row.insertCell(4); + titleCell.textContent = myLibrary[i].title; + authorCell.textContent = myLibrary[i].author; + pagesCell.textContent = myLibrary[i].pages; //add and wait for action for read/unread button - let changeBut = document.createElement("button"); - changeBut.id = i; - changeBut.className = "btn btn-success"; - wasReadCell.appendChild(changeBut); - let readStatus = ""; - if (myLibrary[i].check == false) { - readStatus = "No"; - } else { - readStatus = "Yes"; - } - changeBut.innerText = readStatus; + const changeButton = document.createElement("button"); + changeButton.className = "btn btn-success"; + wasReadCell.appendChild(changeButton); + changeButton.innerText = myLibrary[i].check ? "Yes" : "No"; - changeBut.addEventListener("click", function () { + changeButton.addEventListener("click", function () { myLibrary[i].check = !myLibrary[i].check; render(); }); //add delete button to every row and render again - let delButton = document.createElement("button"); - delButton.id = i + 5; + const delButton = document.createElement("button"); deleteCell.appendChild(delButton); delButton.className = "btn btn-warning"; delButton.innerHTML = "Delete"; delButton.addEventListener("click", function () { - alert(`You've deleted title: ${myLibrary[i].title}`); + const deletedTitle = myLibrary[i].title; myLibrary.splice(i, 1); render(); + alert(`You've deleted title: ${deletedTitle}`); }); } } \ No newline at end of file From 71075a984f1ad93d64eae5f75b40895fb7a27569 Mon Sep 17 00:00:00 2001 From: eyob tech Date: Wed, 5 Aug 2026 00:35:13 +0100 Subject: [PATCH 4/6] Apply HTML feedback: fix title tag, correct input types, add min for pages --- debugging/book-library/index.html | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/debugging/book-library/index.html b/debugging/book-library/index.html index 23acfa71..c68606f9 100644 --- a/debugging/book-library/index.html +++ b/debugging/book-library/index.html @@ -1,7 +1,7 @@ - + Library Library
Library /> Library class="form-control" id="pages" name="pages" + min="1" required />