From eca3d9e2256049e658961cf84036692ca2ca0515 Mon Sep 17 00:00:00 2001 From: dzmitry-lahoda Date: Sat, 5 Aug 2023 11:04:51 +0100 Subject: [PATCH 1/3] ci(test): trigger integration test Signed-off-by: dzmitry-lahoda --- code/integration-tests/runtime-tests/runtime-tests.nix | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/code/integration-tests/runtime-tests/runtime-tests.nix b/code/integration-tests/runtime-tests/runtime-tests.nix index 396485897d8..506a7b48f84 100644 --- a/code/integration-tests/runtime-tests/runtime-tests.nix +++ b/code/integration-tests/runtime-tests/runtime-tests.nix @@ -17,7 +17,9 @@ } 2>&1 & ) | tee devnet-xc.log & process-compose-stop() { - for i in $(process-compose process list); do process-compose process stop "$i"; done + for i in $(process-compose process list); do + process-compose process stop "$i" + done } TRIES=0 From 163df5f137dcd62b1220e2031c01383bab018a70 Mon Sep 17 00:00:00 2001 From: dzmitry-lahoda Date: Sat, 5 Aug 2023 11:06:18 +0100 Subject: [PATCH 2/3] Update runtime-tests.nix Signed-off-by: dzmitry-lahoda --- code/integration-tests/runtime-tests/runtime-tests.nix | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/code/integration-tests/runtime-tests/runtime-tests.nix b/code/integration-tests/runtime-tests/runtime-tests.nix index 506a7b48f84..3a58f7044b2 100644 --- a/code/integration-tests/runtime-tests/runtime-tests.nix +++ b/code/integration-tests/runtime-tests/runtime-tests.nix @@ -17,7 +17,8 @@ } 2>&1 & ) | tee devnet-xc.log & process-compose-stop() { - for i in $(process-compose process list); do + for i in $(process-compose process list) + do process-compose process stop "$i" done } From 2ef6730e004e041e7b024819f444baecccf1fe44 Mon Sep 17 00:00:00 2001 From: dzmitry-lahoda Date: Sat, 5 Aug 2023 11:59:39 +0100 Subject: [PATCH 3/3] Create README.md Signed-off-by: dzmitry-lahoda --- code/integration-tests/runtime-tests/README.md | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 code/integration-tests/runtime-tests/README.md diff --git a/code/integration-tests/runtime-tests/README.md b/code/integration-tests/runtime-tests/README.md new file mode 100644 index 00000000000..9f13eb34b00 --- /dev/null +++ b/code/integration-tests/runtime-tests/README.md @@ -0,0 +1,7 @@ +# Priorities + +1. No false negatives. Such tests to be deleted (see rfc about brittle and flaky tests) +2. Time to merge into main. Should be fast. +3. Super low maintainance. 20% of tests for critical paths cover 80% of failures. Easy to find why in the internet why. Use same tools as ops and devs. +4. No bugs into main merged. +5. Readability of tests output. Easy to reproduce tests locally and doing smoke tests in repeatable way so can just eyeball what wrong.