From 4189861f6c4d8bbbe2b59c988a33a715a878c4ab Mon Sep 17 00:00:00 2001 From: Stuart McCulloch Date: Mon, 29 Jun 2026 21:11:29 +0100 Subject: [PATCH] Extend WellKnownTagsTest coverage and migrate it to Java --- .../trace/api/WellKnownTagsTest.groovy | 19 ----------- .../datadog/trace/api/WellKnownTagsTest.java | 32 +++++++++++++++++++ 2 files changed, 32 insertions(+), 19 deletions(-) delete mode 100644 internal-api/src/test/groovy/datadog/trace/api/WellKnownTagsTest.groovy create mode 100644 internal-api/src/test/java/datadog/trace/api/WellKnownTagsTest.java diff --git a/internal-api/src/test/groovy/datadog/trace/api/WellKnownTagsTest.groovy b/internal-api/src/test/groovy/datadog/trace/api/WellKnownTagsTest.groovy deleted file mode 100644 index 6474142bced..00000000000 --- a/internal-api/src/test/groovy/datadog/trace/api/WellKnownTagsTest.groovy +++ /dev/null @@ -1,19 +0,0 @@ -package datadog.trace.api - -import datadog.trace.test.util.DDSpecification - -class WellKnownTagsTest extends DDSpecification { - - def "well known tags doesn't modify its inputs"() { - given: - WellKnownTags wellKnownTags = - new WellKnownTags("runtimeid", "hostname", "env", "service", "version","language") - expect: - wellKnownTags.getRuntimeId() as String == "runtimeid" - wellKnownTags.getHostname() as String == "hostname" - wellKnownTags.getEnv() as String == "env" - wellKnownTags.getService() as String == "service" - wellKnownTags.getVersion() as String == "version" - wellKnownTags.getLanguage() as String == "language" - } -} diff --git a/internal-api/src/test/java/datadog/trace/api/WellKnownTagsTest.java b/internal-api/src/test/java/datadog/trace/api/WellKnownTagsTest.java new file mode 100644 index 00000000000..f164ab7006d --- /dev/null +++ b/internal-api/src/test/java/datadog/trace/api/WellKnownTagsTest.java @@ -0,0 +1,32 @@ +package datadog.trace.api; + +import static org.junit.jupiter.api.Assertions.assertEquals; + +import org.junit.jupiter.api.Test; + +class WellKnownTagsTest { + + @Test + void wellKnownTagsDoesNotModifyInputs() { + WellKnownTags wellKnownTags = + new WellKnownTags("runtimeid", "hostname", "env", "service", "version", "language"); + + assertEquals("runtimeid", wellKnownTags.getRuntimeId().toString()); + assertEquals("hostname", wellKnownTags.getHostname().toString()); + assertEquals("env", wellKnownTags.getEnv().toString()); + assertEquals("service", wellKnownTags.getService().toString()); + assertEquals("version", wellKnownTags.getVersion().toString()); + assertEquals("language", wellKnownTags.getLanguage().toString()); + } + + @Test + void toStringIncludesAllFields() { + WellKnownTags wellKnownTags = + new WellKnownTags("runtimeid", "hostname", "env", "service", "version", "language"); + + assertEquals( + "WellKnownTags{runtimeId=runtimeid, hostname=hostname, env=env," + + " service=service, version=version, language=language}", + wellKnownTags.toString()); + } +}