From 5cb839f198db7cc61f3ec4b54629ed2293643dbf Mon Sep 17 00:00:00 2001 From: zackees Date: Thu, 2 Jul 2026 12:48:25 -0700 Subject: [PATCH 1/2] fix(config): derive Default for BoardConfig (unbreaks workspace check) PR #941 added probe_rs tests constructing BoardConfig with ..Default::default(), but the struct never derived Default, so 'soldr cargo check/test --all-targets' has failed workspace-wide on main since (Check ubuntu/macos + Documentation red on every PR). All fields are String/Option types; the derive is purely additive. Co-Authored-By: Claude Fable 5 --- crates/fbuild-config/src/board/types.rs | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/crates/fbuild-config/src/board/types.rs b/crates/fbuild-config/src/board/types.rs index 8ff560a8..fdaf416a 100644 --- a/crates/fbuild-config/src/board/types.rs +++ b/crates/fbuild-config/src/board/types.rs @@ -30,7 +30,11 @@ pub(super) const EMULATOR_TOOL_NAMES: &[&str] = &["simavr", "qemu", "renode", "ovpsim", "verilator"]; /// Board configuration loaded from boards.txt or built-in defaults. -#[derive(Debug, Clone, Serialize, Deserialize)] +/// +/// `Default` exists for struct-update test construction +/// (`BoardConfig { mcu: ..., ..Default::default() }`); a defaulted +/// config is not a usable board definition. +#[derive(Debug, Clone, Default, Serialize, Deserialize)] pub struct BoardConfig { pub name: String, pub mcu: String, From a0494ba7fd4afcaa3826eae4401e9c04df4969f4 Mon Sep 17 00:00:00 2001 From: zackees Date: Thu, 2 Jul 2026 13:18:16 -0700 Subject: [PATCH 2/2] docs(deploy): drop bracket link syntax on framework-arduino-lpc8xx mention rustdoc treated it as an intra-doc link and -D warnings failed the Documentation workflow (also since #941). Co-Authored-By: Claude Fable 5 --- crates/fbuild-deploy/src/probe_rs.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/fbuild-deploy/src/probe_rs.rs b/crates/fbuild-deploy/src/probe_rs.rs index 46b63a43..481cb675 100644 --- a/crates/fbuild-deploy/src/probe_rs.rs +++ b/crates/fbuild-deploy/src/probe_rs.rs @@ -1,7 +1,7 @@ //! probe-rs SWD flash path (FastLED/fbuild#935, #936). //! //! The FastLED fork of `probe-rs` — sources maintained on the `tools` -//! branch of [`FastLED/framework-arduino-lpc8xx`], cross-compiled by +//! branch of `FastLED/framework-arduino-lpc8xx`, cross-compiled by //! `.github/workflows/fastled-release-cross.yml` — carries three //! patches on top of upstream that together allow it to talk to the //! LPC-Link2 v1.0.7 CMSIS-DAP firmware that ships on the LPC845-BRK: