feat: add support for min ready instances - #1496
Merged
Merged
Conversation
enocom
marked this pull request as draft
October 19, 2022 20:38
Contributor
|
Would this make more sense as a query parameter on the endpoint? Might be less invasive if the change is limited there as well |
Member
Author
|
Great idea. I love it. |
enocom
marked this pull request as ready for review
October 21, 2022 18:24
hessjcg
requested changes
Oct 21, 2022
hessjcg
left a comment
Collaborator
There was a problem hiding this comment.
Needs a unit test for when min-ready is not set. Optional: the ready() logic could be simplified and made clearer.
kurtisvg
suggested changes
Oct 24, 2022
kurtisvg
suggested changes
Oct 25, 2022
Also, return 503 is min ready exceeds total number of instances.
enocom
force-pushed
the
config-readiness
branch
from
October 26, 2022 15:29
410de70 to
d15373a
Compare
hessjcg
approved these changes
Oct 31, 2022
hessjcg
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. The logic is correct. I provided a comment on the logic in ready() I'm curious for my own learning what you think.
enocom
added a commit
to GoogleCloudPlatform/alloydb-auth-proxy
that referenced
this pull request
Jan 15, 2023
enocom
added a commit
to GoogleCloudPlatform/alloydb-auth-proxy
that referenced
this pull request
Jan 18, 2023
enocom
added a commit
to GoogleCloudPlatform/alloydb-auth-proxy
that referenced
this pull request
Jan 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1375.