From 15ab733c4de2d69d761fb8159ed21487e86d1e5f Mon Sep 17 00:00:00 2001 From: JSONbored <49853598+JSONbored@users.noreply.github.com> Date: Mon, 22 Jun 2026 02:02:50 -0700 Subject: [PATCH] ci: revert concurrency cancel-in-progress to a literal boolean The expression form (cancel-in-progress: ${{ github.event_name == 'pull_request' }}) from #1006 caused GitHub to fail ci.yml at startup (startup_failure) on both push and pull_request, so the required `validate` check never reported and PRs sat stuck 'waiting'. actionlint accepts the expression but GitHub's runtime parser does not start the run. Revert to the known-good literal. --- .github/workflows/ci.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 9326d322b2..12c7316be0 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -11,10 +11,10 @@ permissions: concurrency: group: ci-${{ github.ref }} - # Cancel only superseded PR runs (keep the newest). NEVER cancel main-branch push CI: - # back-to-back merges share group `ci-refs/heads/main`, and cancel-in-progress racing during - # startup turns those runs into `startup_failure` instead of giving each merge a complete run. - cancel-in-progress: ${{ github.event_name == 'pull_request' }} + # NB: keep this a literal boolean. An expression here (cancel-in-progress: ${{ ... }}) made GitHub + # fail the workflow at startup (startup_failure), so `validate` never reported. Avoid merging multiple + # PRs within seconds instead — racing main-push runs in this group can cancel each other on startup. + cancel-in-progress: true jobs: # Detect which areas a PR touches so the heavy jobs can skip when irrelevant.