From 9713f1bd021e3369656fe0a0294dcba217c2798e Mon Sep 17 00:00:00 2001 From: jeffrey701 Date: Sun, 5 Jul 2026 13:56:51 -0400 Subject: [PATCH] feat(enrichment): recognize more binary formats (audio/video/disk/ML) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit BINARY_FILE_EXTENSIONS covered many formats but missed common audio/video containers (m4a, m4v, aac, opus, wma, aiff, flv, wmv), disk images (iso, dmg), and ML artifacts (pkl, pickle, joblib, tflite, keras) — so a committed file of those types was treated as reviewable source. Adds them + extends the test. --- .../src/analyzers/binary-extensions.ts | 16 ++++++++++++++++ review-enrichment/test/binary-extensions.test.ts | 7 +++++++ 2 files changed, 23 insertions(+) diff --git a/review-enrichment/src/analyzers/binary-extensions.ts b/review-enrichment/src/analyzers/binary-extensions.ts index 5fbd052b4d..c77a27324d 100644 --- a/review-enrichment/src/analyzers/binary-extensions.ts +++ b/review-enrichment/src/analyzers/binary-extensions.ts @@ -88,6 +88,22 @@ export const BINARY_FILE_EXTENSIONS = [ "arrow", "orc", "msgpack", + // More common binary formats: audio/video containers, disk images, and ML artifacts. + "m4a", + "m4v", + "aac", + "opus", + "wma", + "aiff", + "flv", + "wmv", + "iso", + "dmg", + "pkl", + "pickle", + "joblib", + "tflite", + "keras", ] as const; const BINARY_EXT_SET = new Set(BINARY_FILE_EXTENSIONS); diff --git a/review-enrichment/test/binary-extensions.test.ts b/review-enrichment/test/binary-extensions.test.ts index 2ae0395202..a7fdf0c137 100644 --- a/review-enrichment/test/binary-extensions.test.ts +++ b/review-enrichment/test/binary-extensions.test.ts @@ -28,6 +28,13 @@ test("isBinaryFileExtension and BINARY_EXT_RE agree on known binary paths", () = "wire/msg.msgpack", "native/mod.pyd", "build/Release/addon.node", + "audio/track.m4a", + "audio/sound.opus", + "video/clip.flv", + "release/app.dmg", + "release/image.iso", + "models/scaler.pkl", + "models/model.tflite", ]) { const ext = path.slice(path.lastIndexOf(".") + 1); assert.equal(isBinaryFileExtension(ext), true, path);