From 5f479617448e0342b1a376658689bbd45cd1b588 Mon Sep 17 00:00:00 2001 From: JSONbored <49853598+JSONbored@users.noreply.github.com> Date: Sun, 12 Jul 2026 02:23:58 -0700 Subject: [PATCH] fix(chat): target publicSafeSummary in the private-lane-signal redaction test The private-lane-signal redaction test (#5149) seeded the private-lane phrasing into the action's why field, but #5106 already dropped why/ blockedBy from the grounding bundle entirely (a stronger data-minimization boundary than field-level redaction). The two changes don't textually conflict, but merged together the test asserts on content that no longer reaches the prompt at all -- currently failing on main. publicSafeSummary is the one action field #5106 still forwards through redactGroundingText, so it's the field this test needs to seed. --- test/unit/ai-chat-qa.test.ts | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/test/unit/ai-chat-qa.test.ts b/test/unit/ai-chat-qa.test.ts index 2cb6be391e..b59407eb2c 100644 --- a/test/unit/ai-chat-qa.test.ts +++ b/test/unit/ai-chat-qa.test.ts @@ -262,12 +262,11 @@ describe("generateChatQaAnswer", () => { const run = vi.fn(async () => ({ response: "Public-safe readiness answer." })); const env = createTestEnv({ AI_ADVISORY: { run } as unknown as Ai, AI_DAILY_NEURON_BUDGET: "10000" }); const result = await generateChatQaAnswer(env, { + // publicSafeSummary (unlike why/blockedBy, dropped from the grounding bundle entirely -- #5106) is the + // one action field that still reaches redactGroundingText, so it's the field this test must seed. bundle: bundleFixture(undefined, { - why: [ - "owner/repo: Maintainer cut: 1.", - "owner/repo: split lane (direct PR 1, issue-discovery 1); both lanes are useful here.", - "owner/repo: direct PR lane share 1 with no hard personal blocker.", - ], + publicSafeSummary: + "owner/repo: Maintainer cut: 1. owner/repo: split lane (direct PR 1, issue-discovery 1); both lanes are useful here. owner/repo: direct PR lane share 1 with no hard personal blocker.", }), question: "what should I know?", advisoryAiRouting: ADVISORY_ON,