From c1a9947e31c77361d7999b2b3f7079737b7f1e6b Mon Sep 17 00:00:00 2001 From: JSONbored <49853598+JSONbored@users.noreply.github.com> Date: Mon, 13 Jul 2026 00:22:48 -0700 Subject: [PATCH] fix(ci): build gittensory-engine before ui:build's miner-ui step MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit PR #5567 added `npm --workspace @jsonbored/gittensory-miner-ui run build` to the ui:build script chain, but gittensory-miner-ui's vite config transitively dynamic-imports @jsonbored/gittensory-miner's portfolio-dashboard.js (via vite-portfolio-queue-api.ts), which depends on @jsonbored/gittensory-engine. ui:build never builds the engine first, so its dist/ doesn't exist and vite's config bundler fails: "Failed to resolve entry for package '@jsonbored/gittensory- engine'". This worked by accident in `npm run test:ci` (an earlier step, build:miner, happens to build the engine first in that chain) but fails standalone wherever ui:build runs in isolation — confirmed via ui-preview.yml failing identically on this branch and on an unrelated renovate/npm-minor-patch branch at the same time, meaning it's been broken on main for every PR touching apps/gittensory-ui/** or packages/** since #5567 merged. ui:lint and ui:typecheck are unaffected: TS/ESLint resolve @jsonbored/gittensory-engine via tsconfig path-mapping to source, not the compiled package entry. --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 08fee7cc72..ba3dfbe5b4 100644 --- a/package.json +++ b/package.json @@ -48,7 +48,7 @@ "miner-extension:lint": "npm --workspace @jsonbored/gittensory-miner-extension run lint", "miner-extension:typecheck": "npm --workspace @jsonbored/gittensory-miner-extension run typecheck", "ui:kit:build": "npm run build --workspace @jsonbored/gittensory-ui-kit", - "ui:build": "npm run ui:kit:build && npm run ui:openapi && npm run extension:build && npm run miner-extension:build && npm --workspace @jsonbored/gittensory-ui run build && npm --workspace @jsonbored/gittensory-miner-ui run build", + "ui:build": "npm run ui:kit:build && npm run build --workspace @jsonbored/gittensory-engine && npm run ui:openapi && npm run extension:build && npm run miner-extension:build && npm --workspace @jsonbored/gittensory-ui run build && npm --workspace @jsonbored/gittensory-miner-ui run build", "ui:preview": "npm run ui:build && wrangler dev --config apps/gittensory-ui/dist/server/wrangler.json --ip 127.0.0.1 --port 4173 --local", "ui:lint": "npm run ui:kit:build && npm --workspace @jsonbored/gittensory-ui run lint && npm --workspace @jsonbored/gittensory-miner-ui run lint", "ui:typecheck": "npm run ui:kit:build && npm --workspace @jsonbored/gittensory-ui run typecheck && npm --workspace @jsonbored/gittensory-miner-ui run typecheck",