From e09423b6f63b19091145874d78b10f2709d3c356 Mon Sep 17 00:00:00 2001 From: oktofeesh1 <287075021+oktofeesh1@users.noreply.github.com> Date: Mon, 20 Jul 2026 01:24:10 +0200 Subject: [PATCH] chore(miner): migrate batch 4.5 foundational lib modules to TypeScript Converts 8 packages/loopover-miner/lib/** modules to real TypeScript (in-place .ts -> .js/.d.ts emit, import paths unchanged): deny-hooks, policy-doc-cache, pr-outcome, attempt-log, coding-task-spec, stack-detection, ci-poller, self-review-context. Refs #7313 --- packages/loopover-miner/lib/attempt-log.d.ts | 72 +- packages/loopover-miner/lib/attempt-log.js | 261 +++---- packages/loopover-miner/lib/attempt-log.ts | 260 +++++++ packages/loopover-miner/lib/ci-poller.d.ts | 46 +- packages/loopover-miner/lib/ci-poller.js | 376 +++++----- packages/loopover-miner/lib/ci-poller.ts | 286 ++++++++ .../loopover-miner/lib/coding-task-spec.d.ts | 110 +-- .../loopover-miner/lib/coding-task-spec.js | 295 +++----- .../loopover-miner/lib/coding-task-spec.ts | 282 ++++++++ packages/loopover-miner/lib/deny-hooks.d.ts | 30 +- packages/loopover-miner/lib/deny-hooks.js | 4 +- packages/loopover-miner/lib/deny-hooks.ts | 6 + .../loopover-miner/lib/policy-doc-cache.d.ts | 37 +- .../loopover-miner/lib/policy-doc-cache.js | 91 ++- .../loopover-miner/lib/policy-doc-cache.ts | 106 +++ packages/loopover-miner/lib/pr-outcome.d.ts | 80 ++- packages/loopover-miner/lib/pr-outcome.js | 112 +-- packages/loopover-miner/lib/pr-outcome.ts | 130 ++++ .../lib/self-review-context.d.ts | 110 +-- .../loopover-miner/lib/self-review-context.js | 652 +++++++++--------- .../loopover-miner/lib/self-review-context.ts | 536 ++++++++++++++ .../loopover-miner/lib/stack-detection.d.ts | 54 +- .../loopover-miner/lib/stack-detection.js | 386 +++++------ .../loopover-miner/lib/stack-detection.ts | 295 ++++++++ test/unit/miner-attempt-log.test.ts | 35 + test/unit/miner-ci-poller.test.ts | 135 ++++ .../miner-coding-task-spec-path-guard.test.ts | 54 ++ test/unit/miner-self-review-context.test.ts | 217 ++++++ test/unit/miner-stack-detection.test.ts | 4 + 29 files changed, 3625 insertions(+), 1437 deletions(-) create mode 100644 packages/loopover-miner/lib/attempt-log.ts create mode 100644 packages/loopover-miner/lib/ci-poller.ts create mode 100644 packages/loopover-miner/lib/coding-task-spec.ts create mode 100644 packages/loopover-miner/lib/deny-hooks.ts create mode 100644 packages/loopover-miner/lib/policy-doc-cache.ts create mode 100644 packages/loopover-miner/lib/pr-outcome.ts create mode 100644 packages/loopover-miner/lib/self-review-context.ts create mode 100644 packages/loopover-miner/lib/stack-detection.ts create mode 100644 test/unit/miner-coding-task-spec-path-guard.test.ts diff --git a/packages/loopover-miner/lib/attempt-log.d.ts b/packages/loopover-miner/lib/attempt-log.d.ts index 9f6528803e..1d5354d12e 100644 --- a/packages/loopover-miner/lib/attempt-log.d.ts +++ b/packages/loopover-miner/lib/attempt-log.d.ts @@ -1,45 +1,41 @@ import type { AttemptLogEvent } from "@loopover/engine"; - export type AttemptLogEntry = { - id: number; - seq: number; - eventType: string; - attemptId: string; - actionClass: string; - mode: string; - reason: string; - payload: Record; - /** Coding-agent provider name, when the event set one (#5185). Null for every event type that predates this - * field. */ - provider: string | null; - /** Real dollar cost, when the event set one (#5185). Null (not 0) when absent -- never fabricated. */ - costUsd: number | null; - /** Real token count, when some future driver reports one (#5185). Always null today -- no driver reports real - * token usage yet (#5395). */ - tokensUsed: number | null; - createdAt: string; + id: number; + seq: number; + eventType: string; + attemptId: string; + actionClass: string; + mode: string; + reason: string; + payload: Record; + /** Coding-agent provider name, when the event set one (#5185). Null for every event type that predates this + * field. */ + provider: string | null; + /** Real dollar cost, when the event set one (#5185). Null (not 0) when absent -- never fabricated. */ + costUsd: number | null; + /** Real token count, when some future driver reports one (#5185). Always null today -- no driver reports real + * token usage yet (#5395). */ + tokensUsed: number | null; + createdAt: string; }; - export type ReadAttemptLogEventsFilter = { - attemptId?: string | null; + attemptId?: string | null; }; - export type AttemptLog = { - dbPath: string; - appendAttemptLogEvent(event: AttemptLogEvent): AttemptLogEntry; - readAttemptLogEvents(filter?: ReadAttemptLogEventsFilter): AttemptLogEntry[]; - exportAttemptLogJsonl(attemptId: string): string; - close(): void; + dbPath: string; + appendAttemptLogEvent(event: AttemptLogEvent): AttemptLogEntry; + readAttemptLogEvents(filter?: ReadAttemptLogEventsFilter): AttemptLogEntry[]; + exportAttemptLogJsonl(attemptId: string): string; + close(): void; }; - -export function resolveAttemptLogDbPath(env?: Record): string; - -export function initAttemptLog(dbPath?: string): AttemptLog; - -export function appendAttemptLogEvent(event: AttemptLogEvent): AttemptLogEntry; - -export function readAttemptLogEvents(filter?: ReadAttemptLogEventsFilter): AttemptLogEntry[]; - -export function exportAttemptLogJsonl(attemptId: string): string; - -export function closeDefaultAttemptLog(): void; +export declare function resolveAttemptLogDbPath(env?: Record): string; +/** + * Opens the append-only attempt log, creating the table on first use. `seq` is a monotonically increasing counter + * maintained by this module (next = current MAX(seq) + 1) with a UNIQUE(seq) constraint. Rows read back in seq ASC + * order. (#4294) + */ +export declare function initAttemptLog(dbPath?: string): AttemptLog; +export declare function appendAttemptLogEvent(event: AttemptLogEvent): AttemptLogEntry; +export declare function readAttemptLogEvents(filter?: ReadAttemptLogEventsFilter): AttemptLogEntry[]; +export declare function exportAttemptLogJsonl(attemptId: string): string; +export declare function closeDefaultAttemptLog(): void; diff --git a/packages/loopover-miner/lib/attempt-log.js b/packages/loopover-miner/lib/attempt-log.js index b16be599aa..e5ca9f7f8b 100644 --- a/packages/loopover-miner/lib/attempt-log.js +++ b/packages/loopover-miner/lib/attempt-log.js @@ -1,111 +1,99 @@ import { formatAttemptLogJsonl, normalizeAttemptLogEvent } from "@loopover/engine"; import { normalizeLocalStoreDbPath, openLocalStoreDb, resolveLocalStoreDbPath } from "./local-store.js"; - -// Append-only driver attempt log (#4294): a structured, attempt-scoped event trace for every CodingAgentDriver run -// (started, tool/edit, succeeded/failed/aborted). IMMUTABILITY INVARIANT: INSERT + SELECT only — rows are never -// rewritten or removed after append. -// -// Why a sibling store instead of extending event-ledger.js: event-ledger is the general miner-loop audit trail -// (discovered_issue, plan_built, pr_prepared, …) keyed by repo scope with a growing free-form type vocabulary. -// Attempt events are keyed by attempt_id, validated against the engine's fixed ATTEMPT_LOG_EVENT_TYPES, and are -// exported per attempt as JSONL — mixing both into one table would couple unrelated lifecycles and complicate the -// per-attempt dump path. This module mirrors governor-ledger.js: engine holds pure normalization, miner holds SQLite. - const defaultDbFileName = "attempt-log.sqlite3"; let defaultAttemptLog = null; - export function resolveAttemptLogDbPath(env = process.env) { - return resolveLocalStoreDbPath(defaultDbFileName, "LOOPOVER_MINER_ATTEMPT_LOG_DB", env); + return resolveLocalStoreDbPath(defaultDbFileName, "LOOPOVER_MINER_ATTEMPT_LOG_DB", env); } - function normalizeDbPath(dbPath) { - return normalizeLocalStoreDbPath(dbPath, resolveAttemptLogDbPath(), "invalid_attempt_log_db_path"); + return normalizeLocalStoreDbPath(dbPath, resolveAttemptLogDbPath(), "invalid_attempt_log_db_path"); } - /** Read-filter attempt scope: omitted/nullish → unscoped (all events); otherwise a non-empty attempt id. */ function normalizeReadAttemptIdFilter(attemptId) { - if (attemptId === undefined || attemptId === null) return undefined; - if (typeof attemptId !== "string") throw new Error("invalid_attempt_id"); - const trimmed = attemptId.trim(); - if (!trimmed) throw new Error("invalid_attempt_id"); - return trimmed; + if (attemptId === undefined || attemptId === null) + return undefined; + if (typeof attemptId !== "string") + throw new Error("invalid_attempt_id"); + const trimmed = attemptId.trim(); + if (!trimmed) + throw new Error("invalid_attempt_id"); + return trimmed; } - /** Export requires an explicit attempt id — JSONL dumps are always per attempt. */ function normalizeRequiredAttemptId(attemptId) { - const normalized = normalizeReadAttemptIdFilter(attemptId); - if (normalized === undefined) throw new Error("invalid_attempt_id"); - return normalized; + const normalized = normalizeReadAttemptIdFilter(attemptId); + if (normalized === undefined) + throw new Error("invalid_attempt_id"); + return normalized; } - function rowToEntry(row) { - let payload; - try { - payload = JSON.parse(row.payload_json); - if (payload === null || typeof payload !== "object" || Array.isArray(payload)) { - throw new Error("corrupted_attempt_log_row"); + let payload; + try { + const parsed = JSON.parse(row.payload_json); + if (parsed === null || typeof parsed !== "object" || Array.isArray(parsed)) { + throw new Error("corrupted_attempt_log_row"); + } + payload = parsed; } - } catch { - throw new Error("corrupted_attempt_log_row"); - } - return { - id: row.id, - seq: row.seq, - eventType: row.event_type, - attemptId: row.attempt_id, - actionClass: row.action_class, - mode: row.mode, - reason: row.reason, - payload, - provider: row.provider, - costUsd: row.cost_usd, - tokensUsed: row.tokens_used, - createdAt: row.created_at, - }; + catch { + throw new Error("corrupted_attempt_log_row"); + } + return { + id: row.id, + seq: row.seq, + eventType: row.event_type, + attemptId: row.attempt_id, + actionClass: row.action_class, + mode: row.mode, + reason: row.reason, + payload, + provider: row.provider, + costUsd: row.cost_usd, + tokensUsed: row.tokens_used, + createdAt: row.created_at, + }; } - +// `event_type`/`mode` are cast to their literal-union types: every row was written through +// appendAttemptLogEvent's own normalizeAttemptLogEvent call, which already validates both against the engine's +// fixed vocabulary, so a row read back from this table always carries a recognized value. function rowToNormalized(row) { - return { - eventType: row.event_type, - attemptId: row.attempt_id, - actionClass: row.action_class, - mode: row.mode, - reason: row.reason, - payloadJson: row.payload_json, - provider: row.provider, - costUsd: row.cost_usd, - tokensUsed: row.tokens_used, - }; + return { + eventType: row.event_type, + attemptId: row.attempt_id, + actionClass: row.action_class, + mode: row.mode, + reason: row.reason, + payloadJson: row.payload_json, + provider: row.provider, + costUsd: row.cost_usd, + tokensUsed: row.tokens_used, + }; } - // Add the provider/cost_usd/tokens_used columns (#5185) to an on-disk file created before they existed. `CREATE // TABLE IF NOT EXISTS` above is a no-op against an already-existing table, so a pre-#5185 file needs this // explicit ALTER -- guarded by a per-column presence check (same technique as governor-state.js's own // ensurePauseColumns) so a file missing only one of the three still gets exactly what it's missing. function ensureOutcomeColumns(db) { - const existingColumns = new Set( - db.prepare("PRAGMA table_info(attempt_log_events)").all().map((column) => column.name), - ); - if (!existingColumns.has("provider")) { - db.exec("ALTER TABLE attempt_log_events ADD COLUMN provider TEXT"); - } - if (!existingColumns.has("cost_usd")) { - db.exec("ALTER TABLE attempt_log_events ADD COLUMN cost_usd REAL"); - } - if (!existingColumns.has("tokens_used")) { - db.exec("ALTER TABLE attempt_log_events ADD COLUMN tokens_used INTEGER"); - } + const existingColumns = new Set(db.prepare("PRAGMA table_info(attempt_log_events)").all().map((column) => column.name)); + if (!existingColumns.has("provider")) { + db.exec("ALTER TABLE attempt_log_events ADD COLUMN provider TEXT"); + } + if (!existingColumns.has("cost_usd")) { + db.exec("ALTER TABLE attempt_log_events ADD COLUMN cost_usd REAL"); + } + if (!existingColumns.has("tokens_used")) { + db.exec("ALTER TABLE attempt_log_events ADD COLUMN tokens_used INTEGER"); + } } - /** * Opens the append-only attempt log, creating the table on first use. `seq` is a monotonically increasing counter * maintained by this module (next = current MAX(seq) + 1) with a UNIQUE(seq) constraint. Rows read back in seq ASC * order. (#4294) */ export function initAttemptLog(dbPath = resolveAttemptLogDbPath()) { - const resolvedPath = normalizeDbPath(dbPath); - const db = openLocalStoreDb(resolvedPath); - db.exec(` + const resolvedPath = normalizeDbPath(dbPath); + const db = openLocalStoreDb(resolvedPath); + db.exec(` CREATE TABLE IF NOT EXISTS attempt_log_events ( id INTEGER PRIMARY KEY AUTOINCREMENT, seq INTEGER NOT NULL UNIQUE, @@ -118,90 +106,69 @@ export function initAttemptLog(dbPath = resolveAttemptLogDbPath()) { created_at TEXT NOT NULL ) `); - ensureOutcomeColumns(db); - db.exec( - "CREATE INDEX IF NOT EXISTS idx_attempt_log_attempt ON attempt_log_events (attempt_id, seq)", - ); - - const nextSeqStatement = db.prepare("SELECT COALESCE(MAX(seq), 0) + 1 AS nextSeq FROM attempt_log_events"); - const appendStatement = db.prepare(` + ensureOutcomeColumns(db); + db.exec("CREATE INDEX IF NOT EXISTS idx_attempt_log_attempt ON attempt_log_events (attempt_id, seq)"); + const nextSeqStatement = db.prepare("SELECT COALESCE(MAX(seq), 0) + 1 AS nextSeq FROM attempt_log_events"); + const appendStatement = db.prepare(` INSERT INTO attempt_log_events ( seq, attempt_id, event_type, action_class, mode, reason, payload_json, provider, cost_usd, tokens_used, created_at ) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?) `); - const getByIdStatement = db.prepare("SELECT * FROM attempt_log_events WHERE id = ?"); - const readAllStatement = db.prepare("SELECT * FROM attempt_log_events ORDER BY seq ASC"); - const readByAttemptStatement = db.prepare( - "SELECT * FROM attempt_log_events WHERE attempt_id = ? ORDER BY seq ASC", - ); - - return { - dbPath: resolvedPath, - appendAttemptLogEvent(event) { - const normalized = normalizeAttemptLogEvent(event); - const createdAt = new Date().toISOString(); - db.exec("BEGIN IMMEDIATE"); - try { - const { nextSeq } = nextSeqStatement.get(); - const result = appendStatement.run( - nextSeq, - normalized.attemptId, - normalized.eventType, - normalized.actionClass, - normalized.mode, - normalized.reason, - normalized.payloadJson, - normalized.provider, - normalized.costUsd, - normalized.tokensUsed, - createdAt, - ); - const entry = rowToEntry(getByIdStatement.get(Number(result.lastInsertRowid))); - db.exec("COMMIT"); - return entry; - } catch (error) { - db.exec("ROLLBACK"); - throw error; - } - }, - readAttemptLogEvents(filter = {}) { - const attemptId = normalizeReadAttemptIdFilter(filter.attemptId); - const rows = - attemptId === undefined ? readAllStatement.all() : readByAttemptStatement.all(attemptId); - return rows.map(rowToEntry); - }, - exportAttemptLogJsonl(attemptId) { - const scopedAttemptId = normalizeRequiredAttemptId(attemptId); - const rows = readByAttemptStatement.all(scopedAttemptId); - return formatAttemptLogJsonl(rows.map(rowToNormalized)); - }, - close() { - db.close(); - }, - }; + const getByIdStatement = db.prepare("SELECT * FROM attempt_log_events WHERE id = ?"); + const readAllStatement = db.prepare("SELECT * FROM attempt_log_events ORDER BY seq ASC"); + const readByAttemptStatement = db.prepare("SELECT * FROM attempt_log_events WHERE attempt_id = ? ORDER BY seq ASC"); + return { + dbPath: resolvedPath, + appendAttemptLogEvent(event) { + const normalized = normalizeAttemptLogEvent(event); + const createdAt = new Date().toISOString(); + db.exec("BEGIN IMMEDIATE"); + try { + const { nextSeq } = nextSeqStatement.get(); + const result = appendStatement.run(nextSeq, normalized.attemptId, normalized.eventType, normalized.actionClass, normalized.mode, normalized.reason, normalized.payloadJson, normalized.provider, normalized.costUsd, normalized.tokensUsed, createdAt); + const entry = rowToEntry(getByIdStatement.get(Number(result.lastInsertRowid))); + db.exec("COMMIT"); + return entry; + } + catch (error) { + db.exec("ROLLBACK"); + throw error; + } + }, + readAttemptLogEvents(filter = {}) { + const attemptId = normalizeReadAttemptIdFilter(filter.attemptId); + const rows = attemptId === undefined ? readAllStatement.all() : readByAttemptStatement.all(attemptId); + return rows.map(rowToEntry); + }, + exportAttemptLogJsonl(attemptId) { + const scopedAttemptId = normalizeRequiredAttemptId(attemptId); + const rows = readByAttemptStatement.all(scopedAttemptId); + return formatAttemptLogJsonl(rows.map(rowToNormalized)); + }, + close() { + db.close(); + }, + }; } - function getDefaultAttemptLog() { - defaultAttemptLog ??= initAttemptLog(); - return defaultAttemptLog; + defaultAttemptLog ??= initAttemptLog(); + return defaultAttemptLog; } - export function appendAttemptLogEvent(event) { - return getDefaultAttemptLog().appendAttemptLogEvent(event); + return getDefaultAttemptLog().appendAttemptLogEvent(event); } - export function readAttemptLogEvents(filter) { - return getDefaultAttemptLog().readAttemptLogEvents(filter); + return getDefaultAttemptLog().readAttemptLogEvents(filter); } - export function exportAttemptLogJsonl(attemptId) { - return getDefaultAttemptLog().exportAttemptLogJsonl(attemptId); + return getDefaultAttemptLog().exportAttemptLogJsonl(attemptId); } - export function closeDefaultAttemptLog() { - if (!defaultAttemptLog) return; - defaultAttemptLog.close(); - defaultAttemptLog = null; + if (!defaultAttemptLog) + return; + defaultAttemptLog.close(); + defaultAttemptLog = null; } +//# sourceMappingURL=data:application/json;base64,eyJ2ZXJzaW9uIjozLCJmaWxlIjoiYXR0ZW1wdC1sb2cuanMiLCJzb3VyY2VSb290IjoiIiwic291cmNlcyI6WyJhdHRlbXB0LWxvZy50cyJdLCJuYW1lcyI6W10sIm1hcHBpbmdzIjoiQUFBQSxPQUFPLEVBQUUscUJBQXFCLEVBQUUsd0JBQXdCLEVBQUUsTUFBTSxrQkFBa0IsQ0FBQztBQUduRixPQUFPLEVBQUUseUJBQXlCLEVBQUUsZ0JBQWdCLEVBQUUsdUJBQXVCLEVBQUUsTUFBTSxrQkFBa0IsQ0FBQztBQTRDeEcsTUFBTSxpQkFBaUIsR0FBRyxxQkFBcUIsQ0FBQztBQUNoRCxJQUFJLGlCQUFpQixHQUFzQixJQUFJLENBQUM7QUFFaEQsTUFBTSxVQUFVLHVCQUF1QixDQUFDLE1BQTBDLE9BQU8sQ0FBQyxHQUFHO0lBQzNGLE9BQU8sdUJBQXVCLENBQUMsaUJBQWlCLEVBQUUsK0JBQStCLEVBQUUsR0FBRyxDQUFDLENBQUM7QUFDMUYsQ0FBQztBQUVELFNBQVMsZUFBZSxDQUFDLE1BQWM7SUFDckMsT0FBTyx5QkFBeUIsQ0FBQyxNQUFNLEVBQUUsdUJBQXVCLEVBQUUsRUFBRSw2QkFBNkIsQ0FBQyxDQUFDO0FBQ3JHLENBQUM7QUFFRCw0R0FBNEc7QUFDNUcsU0FBUyw0QkFBNEIsQ0FBQyxTQUFvQztJQUN4RSxJQUFJLFNBQVMsS0FBSyxTQUFTLElBQUksU0FBUyxLQUFLLElBQUk7UUFBRSxPQUFPLFNBQVMsQ0FBQztJQUNwRSxJQUFJLE9BQU8sU0FBUyxLQUFLLFFBQVE7UUFBRSxNQUFNLElBQUksS0FBSyxDQUFDLG9CQUFvQixDQUFDLENBQUM7SUFDekUsTUFBTSxPQUFPLEdBQUcsU0FBUyxDQUFDLElBQUksRUFBRSxDQUFDO0lBQ2pDLElBQUksQ0FBQyxPQUFPO1FBQUUsTUFBTSxJQUFJLEtBQUssQ0FBQyxvQkFBb0IsQ0FBQyxDQUFDO0lBQ3BELE9BQU8sT0FBTyxDQUFDO0FBQ2pCLENBQUM7QUFFRCxtRkFBbUY7QUFDbkYsU0FBUywwQkFBMEIsQ0FBQyxTQUFpQjtJQUNuRCxNQUFNLFVBQVUsR0FBRyw0QkFBNEIsQ0FBQyxTQUFTLENBQUMsQ0FBQztJQUMzRCxJQUFJLFVBQVUsS0FBSyxTQUFTO1FBQUUsTUFBTSxJQUFJLEtBQUssQ0FBQyxvQkFBb0IsQ0FBQyxDQUFDO0lBQ3BFLE9BQU8sVUFBVSxDQUFDO0FBQ3BCLENBQUM7QUFpQkQsU0FBUyxVQUFVLENBQUMsR0FBa0I7SUFDcEMsSUFBSSxPQUFnQyxDQUFDO0lBQ3JDLElBQUksQ0FBQztRQUNILE1BQU0sTUFBTSxHQUFZLElBQUksQ0FBQyxLQUFLLENBQUMsR0FBRyxDQUFDLFlBQVksQ0FBQyxDQUFDO1FBQ3JELElBQUksTUFBTSxLQUFLLElBQUksSUFBSSxPQUFPLE1BQU0sS0FBSyxRQUFRLElBQUksS0FBSyxDQUFDLE9BQU8sQ0FBQyxNQUFNLENBQUMsRUFBRSxDQUFDO1lBQzNFLE1BQU0sSUFBSSxLQUFLLENBQUMsMkJBQTJCLENBQUMsQ0FBQztRQUMvQyxDQUFDO1FBQ0QsT0FBTyxHQUFHLE1BQWlDLENBQUM7SUFDOUMsQ0FBQztJQUFDLE1BQU0sQ0FBQztRQUNQLE1BQU0sSUFBSSxLQUFLLENBQUMsMkJBQTJCLENBQUMsQ0FBQztJQUMvQyxDQUFDO0lBQ0QsT0FBTztRQUNMLEVBQUUsRUFBRSxHQUFHLENBQUMsRUFBRTtRQUNWLEdBQUcsRUFBRSxHQUFHLENBQUMsR0FBRztRQUNaLFNBQVMsRUFBRSxHQUFHLENBQUMsVUFBVTtRQUN6QixTQUFTLEVBQUUsR0FBRyxDQUFDLFVBQVU7UUFDekIsV0FBVyxFQUFFLEdBQUcsQ0FBQyxZQUFZO1FBQzdCLElBQUksRUFBRSxHQUFHLENBQUMsSUFBSTtRQUNkLE1BQU0sRUFBRSxHQUFHLENBQUMsTUFBTTtRQUNsQixPQUFPO1FBQ1AsUUFBUSxFQUFFLEdBQUcsQ0FBQyxRQUFRO1FBQ3RCLE9BQU8sRUFBRSxHQUFHLENBQUMsUUFBUTtRQUNyQixVQUFVLEVBQUUsR0FBRyxDQUFDLFdBQVc7UUFDM0IsU0FBUyxFQUFFLEdBQUcsQ0FBQyxVQUFVO0tBQzFCLENBQUM7QUFDSixDQUFDO0FBRUQsMkZBQTJGO0FBQzNGLCtHQUErRztBQUMvRywwRkFBMEY7QUFDMUYsU0FBUyxlQUFlLENBQUMsR0FBa0I7SUFDekMsT0FBTztRQUNMLFNBQVMsRUFBRSxHQUFHLENBQUMsVUFBb0Q7UUFDbkUsU0FBUyxFQUFFLEdBQUcsQ0FBQyxVQUFVO1FBQ3pCLFdBQVcsRUFBRSxHQUFHLENBQUMsWUFBWTtRQUM3QixJQUFJLEVBQUUsR0FBRyxDQUFDLElBQXlDO1FBQ25ELE1BQU0sRUFBRSxHQUFHLENBQUMsTUFBTTtRQUNsQixXQUFXLEVBQUUsR0FBRyxDQUFDLFlBQVk7UUFDN0IsUUFBUSxFQUFFLEdBQUcsQ0FBQyxRQUFRO1FBQ3RCLE9BQU8sRUFBRSxHQUFHLENBQUMsUUFBUTtRQUNyQixVQUFVLEVBQUUsR0FBRyxDQUFDLFdBQVc7S0FDNUIsQ0FBQztBQUNKLENBQUM7QUFFRCxnSEFBZ0g7QUFDaEgsMEdBQTBHO0FBQzFHLHNHQUFzRztBQUN0RyxvR0FBb0c7QUFDcEcsU0FBUyxvQkFBb0IsQ0FBQyxFQUFnQjtJQUM1QyxNQUFNLGVBQWUsR0FBRyxJQUFJLEdBQUcsQ0FDN0IsRUFBRSxDQUFDLE9BQU8sQ0FBQyx1Q0FBdUMsQ0FBQyxDQUFDLEdBQUcsRUFBRSxDQUFDLEdBQUcsQ0FBQyxDQUFDLE1BQU0sRUFBRSxFQUFFLENBQUMsTUFBTSxDQUFDLElBQWMsQ0FBQyxDQUNqRyxDQUFDO0lBQ0YsSUFBSSxDQUFDLGVBQWUsQ0FBQyxHQUFHLENBQUMsVUFBVSxDQUFDLEVBQUUsQ0FBQztRQUNyQyxFQUFFLENBQUMsSUFBSSxDQUFDLHlEQUF5RCxDQUFDLENBQUM7SUFDckUsQ0FBQztJQUNELElBQUksQ0FBQyxlQUFlLENBQUMsR0FBRyxDQUFDLFVBQVUsQ0FBQyxFQUFFLENBQUM7UUFDckMsRUFBRSxDQUFDLElBQUksQ0FBQyx5REFBeUQsQ0FBQyxDQUFDO0lBQ3JFLENBQUM7SUFDRCxJQUFJLENBQUMsZUFBZSxDQUFDLEdBQUcsQ0FBQyxhQUFhLENBQUMsRUFBRSxDQUFDO1FBQ3hDLEVBQUUsQ0FBQyxJQUFJLENBQUMsK0RBQStELENBQUMsQ0FBQztJQUMzRSxDQUFDO0FBQ0gsQ0FBQztBQUVEOzs7O0dBSUc7QUFDSCxNQUFNLFVBQVUsY0FBYyxDQUFDLFNBQWlCLHVCQUF1QixFQUFFO0lBQ3ZFLE1BQU0sWUFBWSxHQUFHLGVBQWUsQ0FBQyxNQUFNLENBQUMsQ0FBQztJQUM3QyxNQUFNLEVBQUUsR0FBRyxnQkFBZ0IsQ0FBQyxZQUFZLENBQUMsQ0FBQztJQUMxQyxFQUFFLENBQUMsSUFBSSxDQUFDOzs7Ozs7Ozs7Ozs7R0FZUCxDQUFDLENBQUM7SUFDSCxvQkFBb0IsQ0FBQyxFQUFFLENBQUMsQ0FBQztJQUN6QixFQUFFLENBQUMsSUFBSSxDQUNMLDRGQUE0RixDQUM3RixDQUFDO0lBRUYsTUFBTSxnQkFBZ0IsR0FBRyxFQUFFLENBQUMsT0FBTyxDQUFDLHFFQUFxRSxDQUFDLENBQUM7SUFDM0csTUFBTSxlQUFlLEdBQUcsRUFBRSxDQUFDLE9BQU8sQ0FBQzs7Ozs7O0dBTWxDLENBQUMsQ0FBQztJQUNILE1BQU0sZ0JBQWdCLEdBQUcsRUFBRSxDQUFDLE9BQU8sQ0FBQywrQ0FBK0MsQ0FBQyxDQUFDO0lBQ3JGLE1BQU0sZ0JBQWdCLEdBQUcsRUFBRSxDQUFDLE9BQU8sQ0FBQyxtREFBbUQsQ0FBQyxDQUFDO0lBQ3pGLE1BQU0sc0JBQXNCLEdBQUcsRUFBRSxDQUFDLE9BQU8sQ0FDdkMsd0VBQXdFLENBQ3pFLENBQUM7SUFFRixPQUFPO1FBQ0wsTUFBTSxFQUFFLFlBQVk7UUFDcEIscUJBQXFCLENBQUMsS0FBc0I7WUFDMUMsTUFBTSxVQUFVLEdBQUcsd0JBQXdCLENBQUMsS0FBSyxDQUFDLENBQUM7WUFDbkQsTUFBTSxTQUFTLEdBQUcsSUFBSSxJQUFJLEVBQUUsQ0FBQyxXQUFXLEVBQUUsQ0FBQztZQUMzQyxFQUFFLENBQUMsSUFBSSxDQUFDLGlCQUFpQixDQUFDLENBQUM7WUFDM0IsSUFBSSxDQUFDO2dCQUNILE1BQU0sRUFBRSxPQUFPLEVBQUUsR0FBRyxnQkFBZ0IsQ0FBQyxHQUFHLEVBQXlCLENBQUM7Z0JBQ2xFLE1BQU0sTUFBTSxHQUFHLGVBQWUsQ0FBQyxHQUFHLENBQ2hDLE9BQU8sRUFDUCxVQUFVLENBQUMsU0FBUyxFQUNwQixVQUFVLENBQUMsU0FBUyxFQUNwQixVQUFVLENBQUMsV0FBVyxFQUN0QixVQUFVLENBQUMsSUFBSSxFQUNmLFVBQVUsQ0FBQyxNQUFNLEVBQ2pCLFVBQVUsQ0FBQyxXQUFXLEVBQ3RCLFVBQVUsQ0FBQyxRQUFRLEVBQ25CLFVBQVUsQ0FBQyxPQUFPLEVBQ2xCLFVBQVUsQ0FBQyxVQUFVLEVBQ3JCLFNBQVMsQ0FDVixDQUFDO2dCQUNGLE1BQU0sS0FBSyxHQUFHLFVBQVUsQ0FBQyxnQkFBZ0IsQ0FBQyxHQUFHLENBQUMsTUFBTSxDQUFDLE1BQU0sQ0FBQyxlQUFlLENBQUMsQ0FBNkIsQ0FBQyxDQUFDO2dCQUMzRyxFQUFFLENBQUMsSUFBSSxDQUFDLFFBQVEsQ0FBQyxDQUFDO2dCQUNsQixPQUFPLEtBQUssQ0FBQztZQUNmLENBQUM7WUFBQyxPQUFPLEtBQUssRUFBRSxDQUFDO2dCQUNmLEVBQUUsQ0FBQyxJQUFJLENBQUMsVUFBVSxDQUFDLENBQUM7Z0JBQ3BCLE1BQU0sS0FBSyxDQUFDO1lBQ2QsQ0FBQztRQUNILENBQUM7UUFDRCxvQkFBb0IsQ0FBQyxTQUFxQyxFQUFFO1lBQzFELE1BQU0sU0FBUyxHQUFHLDRCQUE0QixDQUFDLE1BQU0sQ0FBQyxTQUFTLENBQUMsQ0FBQztZQUNqRSxNQUFNLElBQUksR0FDUixTQUFTLEtBQUssU0FBUyxDQUFDLENBQUMsQ0FBQyxnQkFBZ0IsQ0FBQyxHQUFHLEVBQUUsQ0FBQyxDQUFDLENBQUMsc0JBQXNCLENBQUMsR0FBRyxDQUFDLFNBQVMsQ0FBQyxDQUFDO1lBQzNGLE9BQVEsSUFBbUMsQ0FBQyxHQUFHLENBQUMsVUFBVSxDQUFDLENBQUM7UUFDOUQsQ0FBQztRQUNELHFCQUFxQixDQUFDLFNBQWlCO1lBQ3JDLE1BQU0sZUFBZSxHQUFHLDBCQUEwQixDQUFDLFNBQVMsQ0FBQyxDQUFDO1lBQzlELE1BQU0sSUFBSSxHQUFHLHNCQUFzQixDQUFDLEdBQUcsQ0FBQyxlQUFlLENBQStCLENBQUM7WUFDdkYsT0FBTyxxQkFBcUIsQ0FBQyxJQUFJLENBQUMsR0FBRyxDQUFDLGVBQWUsQ0FBQyxDQUFDLENBQUM7UUFDMUQsQ0FBQztRQUNELEtBQUs7WUFDSCxFQUFFLENBQUMsS0FBSyxFQUFFLENBQUM7UUFDYixDQUFDO0tBQ0YsQ0FBQztBQUNKLENBQUM7QUFFRCxTQUFTLG9CQUFvQjtJQUMzQixpQkFBaUIsS0FBSyxjQUFjLEVBQUUsQ0FBQztJQUN2QyxPQUFPLGlCQUFpQixDQUFDO0FBQzNCLENBQUM7QUFFRCxNQUFNLFVBQVUscUJBQXFCLENBQUMsS0FBc0I7SUFDMUQsT0FBTyxvQkFBb0IsRUFBRSxDQUFDLHFCQUFxQixDQUFDLEtBQUssQ0FBQyxDQUFDO0FBQzdELENBQUM7QUFFRCxNQUFNLFVBQVUsb0JBQW9CLENBQUMsTUFBbUM7SUFDdEUsT0FBTyxvQkFBb0IsRUFBRSxDQUFDLG9CQUFvQixDQUFDLE1BQU0sQ0FBQyxDQUFDO0FBQzdELENBQUM7QUFFRCxNQUFNLFVBQVUscUJBQXFCLENBQUMsU0FBaUI7SUFDckQsT0FBTyxvQkFBb0IsRUFBRSxDQUFDLHFCQUFxQixDQUFDLFNBQVMsQ0FBQyxDQUFDO0FBQ2pFLENBQUM7QUFFRCxNQUFNLFVBQVUsc0JBQXNCO0lBQ3BDLElBQUksQ0FBQyxpQkFBaUI7UUFBRSxPQUFPO0lBQy9CLGlCQUFpQixDQUFDLEtBQUssRUFBRSxDQUFDO0lBQzFCLGlCQUFpQixHQUFHLElBQUksQ0FBQztBQUMzQixDQUFDIn0= \ No newline at end of file diff --git a/packages/loopover-miner/lib/attempt-log.ts b/packages/loopover-miner/lib/attempt-log.ts new file mode 100644 index 0000000000..11dde07246 --- /dev/null +++ b/packages/loopover-miner/lib/attempt-log.ts @@ -0,0 +1,260 @@ +import { formatAttemptLogJsonl, normalizeAttemptLogEvent } from "@loopover/engine"; +import type { AttemptLogEvent, NormalizedAttemptLogEvent } from "@loopover/engine"; +import type { DatabaseSync } from "node:sqlite"; +import { normalizeLocalStoreDbPath, openLocalStoreDb, resolveLocalStoreDbPath } from "./local-store.js"; + +// Append-only driver attempt log (#4294): a structured, attempt-scoped event trace for every CodingAgentDriver run +// (started, tool/edit, succeeded/failed/aborted). IMMUTABILITY INVARIANT: INSERT + SELECT only — rows are never +// rewritten or removed after append. +// +// Why a sibling store instead of extending event-ledger.js: event-ledger is the general miner-loop audit trail +// (discovered_issue, plan_built, pr_prepared, …) keyed by repo scope with a growing free-form type vocabulary. +// Attempt events are keyed by attempt_id, validated against the engine's fixed ATTEMPT_LOG_EVENT_TYPES, and are +// exported per attempt as JSONL — mixing both into one table would couple unrelated lifecycles and complicate the +// per-attempt dump path. This module mirrors governor-ledger.js: engine holds pure normalization, miner holds SQLite. + +export type AttemptLogEntry = { + id: number; + seq: number; + eventType: string; + attemptId: string; + actionClass: string; + mode: string; + reason: string; + payload: Record; + /** Coding-agent provider name, when the event set one (#5185). Null for every event type that predates this + * field. */ + provider: string | null; + /** Real dollar cost, when the event set one (#5185). Null (not 0) when absent -- never fabricated. */ + costUsd: number | null; + /** Real token count, when some future driver reports one (#5185). Always null today -- no driver reports real + * token usage yet (#5395). */ + tokensUsed: number | null; + createdAt: string; +}; + +export type ReadAttemptLogEventsFilter = { + attemptId?: string | null; +}; + +export type AttemptLog = { + dbPath: string; + appendAttemptLogEvent(event: AttemptLogEvent): AttemptLogEntry; + readAttemptLogEvents(filter?: ReadAttemptLogEventsFilter): AttemptLogEntry[]; + exportAttemptLogJsonl(attemptId: string): string; + close(): void; +}; + +const defaultDbFileName = "attempt-log.sqlite3"; +let defaultAttemptLog: AttemptLog | null = null; + +export function resolveAttemptLogDbPath(env: Record = process.env): string { + return resolveLocalStoreDbPath(defaultDbFileName, "LOOPOVER_MINER_ATTEMPT_LOG_DB", env); +} + +function normalizeDbPath(dbPath: string): string { + return normalizeLocalStoreDbPath(dbPath, resolveAttemptLogDbPath(), "invalid_attempt_log_db_path"); +} + +/** Read-filter attempt scope: omitted/nullish → unscoped (all events); otherwise a non-empty attempt id. */ +function normalizeReadAttemptIdFilter(attemptId: string | null | undefined): string | undefined { + if (attemptId === undefined || attemptId === null) return undefined; + if (typeof attemptId !== "string") throw new Error("invalid_attempt_id"); + const trimmed = attemptId.trim(); + if (!trimmed) throw new Error("invalid_attempt_id"); + return trimmed; +} + +/** Export requires an explicit attempt id — JSONL dumps are always per attempt. */ +function normalizeRequiredAttemptId(attemptId: string): string { + const normalized = normalizeReadAttemptIdFilter(attemptId); + if (normalized === undefined) throw new Error("invalid_attempt_id"); + return normalized; +} + +type AttemptLogRow = { + id: number; + seq: number; + event_type: string; + attempt_id: string; + action_class: string; + mode: string; + reason: string; + payload_json: string; + provider: string | null; + cost_usd: number | null; + tokens_used: number | null; + created_at: string; +}; + +function rowToEntry(row: AttemptLogRow): AttemptLogEntry { + let payload: Record; + try { + const parsed: unknown = JSON.parse(row.payload_json); + if (parsed === null || typeof parsed !== "object" || Array.isArray(parsed)) { + throw new Error("corrupted_attempt_log_row"); + } + payload = parsed as Record; + } catch { + throw new Error("corrupted_attempt_log_row"); + } + return { + id: row.id, + seq: row.seq, + eventType: row.event_type, + attemptId: row.attempt_id, + actionClass: row.action_class, + mode: row.mode, + reason: row.reason, + payload, + provider: row.provider, + costUsd: row.cost_usd, + tokensUsed: row.tokens_used, + createdAt: row.created_at, + }; +} + +// `event_type`/`mode` are cast to their literal-union types: every row was written through +// appendAttemptLogEvent's own normalizeAttemptLogEvent call, which already validates both against the engine's +// fixed vocabulary, so a row read back from this table always carries a recognized value. +function rowToNormalized(row: AttemptLogRow): NormalizedAttemptLogEvent { + return { + eventType: row.event_type as NormalizedAttemptLogEvent["eventType"], + attemptId: row.attempt_id, + actionClass: row.action_class, + mode: row.mode as NormalizedAttemptLogEvent["mode"], + reason: row.reason, + payloadJson: row.payload_json, + provider: row.provider, + costUsd: row.cost_usd, + tokensUsed: row.tokens_used, + }; +} + +// Add the provider/cost_usd/tokens_used columns (#5185) to an on-disk file created before they existed. `CREATE +// TABLE IF NOT EXISTS` above is a no-op against an already-existing table, so a pre-#5185 file needs this +// explicit ALTER -- guarded by a per-column presence check (same technique as governor-state.js's own +// ensurePauseColumns) so a file missing only one of the three still gets exactly what it's missing. +function ensureOutcomeColumns(db: DatabaseSync): void { + const existingColumns = new Set( + db.prepare("PRAGMA table_info(attempt_log_events)").all().map((column) => column.name as string), + ); + if (!existingColumns.has("provider")) { + db.exec("ALTER TABLE attempt_log_events ADD COLUMN provider TEXT"); + } + if (!existingColumns.has("cost_usd")) { + db.exec("ALTER TABLE attempt_log_events ADD COLUMN cost_usd REAL"); + } + if (!existingColumns.has("tokens_used")) { + db.exec("ALTER TABLE attempt_log_events ADD COLUMN tokens_used INTEGER"); + } +} + +/** + * Opens the append-only attempt log, creating the table on first use. `seq` is a monotonically increasing counter + * maintained by this module (next = current MAX(seq) + 1) with a UNIQUE(seq) constraint. Rows read back in seq ASC + * order. (#4294) + */ +export function initAttemptLog(dbPath: string = resolveAttemptLogDbPath()): AttemptLog { + const resolvedPath = normalizeDbPath(dbPath); + const db = openLocalStoreDb(resolvedPath); + db.exec(` + CREATE TABLE IF NOT EXISTS attempt_log_events ( + id INTEGER PRIMARY KEY AUTOINCREMENT, + seq INTEGER NOT NULL UNIQUE, + attempt_id TEXT NOT NULL, + event_type TEXT NOT NULL, + action_class TEXT NOT NULL, + mode TEXT NOT NULL, + reason TEXT NOT NULL, + payload_json TEXT NOT NULL, + created_at TEXT NOT NULL + ) + `); + ensureOutcomeColumns(db); + db.exec( + "CREATE INDEX IF NOT EXISTS idx_attempt_log_attempt ON attempt_log_events (attempt_id, seq)", + ); + + const nextSeqStatement = db.prepare("SELECT COALESCE(MAX(seq), 0) + 1 AS nextSeq FROM attempt_log_events"); + const appendStatement = db.prepare(` + INSERT INTO attempt_log_events ( + seq, attempt_id, event_type, action_class, mode, reason, payload_json, provider, cost_usd, tokens_used, + created_at + ) + VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?) + `); + const getByIdStatement = db.prepare("SELECT * FROM attempt_log_events WHERE id = ?"); + const readAllStatement = db.prepare("SELECT * FROM attempt_log_events ORDER BY seq ASC"); + const readByAttemptStatement = db.prepare( + "SELECT * FROM attempt_log_events WHERE attempt_id = ? ORDER BY seq ASC", + ); + + return { + dbPath: resolvedPath, + appendAttemptLogEvent(event: AttemptLogEvent): AttemptLogEntry { + const normalized = normalizeAttemptLogEvent(event); + const createdAt = new Date().toISOString(); + db.exec("BEGIN IMMEDIATE"); + try { + const { nextSeq } = nextSeqStatement.get() as { nextSeq: number }; + const result = appendStatement.run( + nextSeq, + normalized.attemptId, + normalized.eventType, + normalized.actionClass, + normalized.mode, + normalized.reason, + normalized.payloadJson, + normalized.provider, + normalized.costUsd, + normalized.tokensUsed, + createdAt, + ); + const entry = rowToEntry(getByIdStatement.get(Number(result.lastInsertRowid)) as unknown as AttemptLogRow); + db.exec("COMMIT"); + return entry; + } catch (error) { + db.exec("ROLLBACK"); + throw error; + } + }, + readAttemptLogEvents(filter: ReadAttemptLogEventsFilter = {}): AttemptLogEntry[] { + const attemptId = normalizeReadAttemptIdFilter(filter.attemptId); + const rows = + attemptId === undefined ? readAllStatement.all() : readByAttemptStatement.all(attemptId); + return (rows as unknown as AttemptLogRow[]).map(rowToEntry); + }, + exportAttemptLogJsonl(attemptId: string): string { + const scopedAttemptId = normalizeRequiredAttemptId(attemptId); + const rows = readByAttemptStatement.all(scopedAttemptId) as unknown as AttemptLogRow[]; + return formatAttemptLogJsonl(rows.map(rowToNormalized)); + }, + close() { + db.close(); + }, + }; +} + +function getDefaultAttemptLog(): AttemptLog { + defaultAttemptLog ??= initAttemptLog(); + return defaultAttemptLog; +} + +export function appendAttemptLogEvent(event: AttemptLogEvent): AttemptLogEntry { + return getDefaultAttemptLog().appendAttemptLogEvent(event); +} + +export function readAttemptLogEvents(filter?: ReadAttemptLogEventsFilter): AttemptLogEntry[] { + return getDefaultAttemptLog().readAttemptLogEvents(filter); +} + +export function exportAttemptLogJsonl(attemptId: string): string { + return getDefaultAttemptLog().exportAttemptLogJsonl(attemptId); +} + +export function closeDefaultAttemptLog(): void { + if (!defaultAttemptLog) return; + defaultAttemptLog.close(); + defaultAttemptLog = null; +} diff --git a/packages/loopover-miner/lib/ci-poller.d.ts b/packages/loopover-miner/lib/ci-poller.d.ts index 08718c4a8f..fe1d647282 100644 --- a/packages/loopover-miner/lib/ci-poller.d.ts +++ b/packages/loopover-miner/lib/ci-poller.d.ts @@ -1,34 +1,26 @@ export type CheckRunConclusion = "pending" | "success" | "failure" | "neutral"; - export type NormalizedCheckRun = { - name: string; - status: string; - conclusion: CheckRunConclusion; - detailsUrl: string | null; - startedAt: string | null; - completedAt: string | null; + name: string; + status: string; + conclusion: CheckRunConclusion; + detailsUrl: string | null; + startedAt: string | null; + completedAt: string | null; }; - export type PollCheckRunsResult = { - conclusion: CheckRunConclusion; - checks: NormalizedCheckRun[]; - headSha: string; - attempts: number; + conclusion: CheckRunConclusion; + checks: NormalizedCheckRun[]; + headSha: string; + attempts: number; }; - export type PollCheckRunsOptions = { - apiBaseUrl?: string; - fetchFn?: typeof fetch; - githubToken?: string; - maxAttempts?: number; - minIntervalMs?: number; - maxIntervalMs?: number; - requestTimeoutMs?: number; - sleepFn?: (delayMs: number) => Promise; + apiBaseUrl?: string; + fetchFn?: typeof fetch; + githubToken?: string; + maxAttempts?: number; + minIntervalMs?: number; + maxIntervalMs?: number; + requestTimeoutMs?: number; + sleepFn?: (delayMs: number) => Promise; }; - -export function pollCheckRuns( - repoFullName: string, - prNumber: number, - options?: PollCheckRunsOptions, -): Promise; +export declare function pollCheckRuns(repoFullName: string, prNumber: number, options?: PollCheckRunsOptions): Promise; diff --git a/packages/loopover-miner/lib/ci-poller.js b/packages/loopover-miner/lib/ci-poller.js index 538a50b1de..f5fd9af8ae 100644 --- a/packages/loopover-miner/lib/ci-poller.js +++ b/packages/loopover-miner/lib/ci-poller.js @@ -1,237 +1,221 @@ import { fetchWithRetry } from "./http-retry.js"; - const defaultApiBaseUrl = "https://api.github.com"; const defaultMinIntervalMs = 60_000; const defaultMaxIntervalMs = 5 * 60_000; const defaultMaxAttempts = 1; const defaultRequestTimeoutMs = 10_000; const githubApiVersion = "2022-11-28"; - function normalizeApiBaseUrl(value) { - if (value === undefined) return defaultApiBaseUrl; - if (typeof value !== "string" || !value.trim()) return defaultApiBaseUrl; - let parsed; - try { - parsed = new URL(value.trim()); - } catch { - throw new Error("invalid_api_base_url"); - } - if (parsed.protocol !== "https:" || parsed.hostname !== "api.github.com") { - throw new Error("invalid_api_base_url"); - } - parsed.pathname = parsed.pathname.replace(/\/+$/, ""); - parsed.search = ""; - parsed.hash = ""; - return parsed.toString().replace(/\/+$/, ""); -} - + if (value === undefined) + return defaultApiBaseUrl; + if (typeof value !== "string" || !value.trim()) + return defaultApiBaseUrl; + let parsed; + try { + parsed = new URL(value.trim()); + } + catch { + throw new Error("invalid_api_base_url"); + } + if (parsed.protocol !== "https:" || parsed.hostname !== "api.github.com") { + throw new Error("invalid_api_base_url"); + } + parsed.pathname = parsed.pathname.replace(/\/+$/, ""); + parsed.search = ""; + parsed.hash = ""; + return parsed.toString().replace(/\/+$/, ""); +} function normalizePositiveInt(value, fallback, min, max) { - if (!Number.isFinite(value)) return fallback; - return Math.min(max, Math.max(min, Math.floor(value))); + if (!Number.isFinite(value)) + return fallback; + return Math.min(max, Math.max(min, Math.floor(value))); } - function normalizeOptions(options = {}) { - return { - apiBaseUrl: normalizeApiBaseUrl(options.apiBaseUrl), - fetchFn: options.fetchFn ?? fetch, - githubToken: typeof options.githubToken === "string" ? options.githubToken.trim() : "", - maxAttempts: normalizePositiveInt(options.maxAttempts, defaultMaxAttempts, 1, 20), - minIntervalMs: normalizePositiveInt(options.minIntervalMs, defaultMinIntervalMs, 1, 60 * 60_000), - maxIntervalMs: normalizePositiveInt(options.maxIntervalMs, defaultMaxIntervalMs, 1, 60 * 60_000), - requestTimeoutMs: normalizePositiveInt(options.requestTimeoutMs, defaultRequestTimeoutMs, 1, 60_000), - sleepFn: - options.sleepFn ?? - ((delayMs) => new Promise((resolve) => setTimeout(resolve, delayMs))), - }; -} - + return { + apiBaseUrl: normalizeApiBaseUrl(options.apiBaseUrl), + fetchFn: options.fetchFn ?? fetch, + githubToken: typeof options.githubToken === "string" ? options.githubToken.trim() : "", + maxAttempts: normalizePositiveInt(options.maxAttempts, defaultMaxAttempts, 1, 20), + minIntervalMs: normalizePositiveInt(options.minIntervalMs, defaultMinIntervalMs, 1, 60 * 60_000), + maxIntervalMs: normalizePositiveInt(options.maxIntervalMs, defaultMaxIntervalMs, 1, 60 * 60_000), + requestTimeoutMs: normalizePositiveInt(options.requestTimeoutMs, defaultRequestTimeoutMs, 1, 60_000), + sleepFn: options.sleepFn ?? + ((delayMs) => new Promise((resolve) => setTimeout(resolve, delayMs))), + }; +} function parseRepoFullName(repoFullName) { - if (typeof repoFullName !== "string") throw new Error("invalid_repo_full_name"); - const [owner, repo, extra] = repoFullName.split("/"); - if (!owner?.trim() || !repo?.trim() || extra !== undefined) { - throw new Error("invalid_repo_full_name"); - } - return { owner: owner.trim(), repo: repo.trim() }; -} - + if (typeof repoFullName !== "string") + throw new Error("invalid_repo_full_name"); + const [owner, repo, extra] = repoFullName.split("/"); + if (!owner?.trim() || !repo?.trim() || extra !== undefined) { + throw new Error("invalid_repo_full_name"); + } + return { owner: owner.trim(), repo: repo.trim() }; +} function normalizePullNumber(value) { - if (!Number.isInteger(value) || value <= 0) throw new Error("invalid_pr_number"); - return value; + if (!Number.isInteger(value) || value <= 0) + throw new Error("invalid_pr_number"); + return value; } - function githubHeaders(githubToken) { - const headers = { - accept: "application/vnd.github+json", - "user-agent": "loopover-miner", - "x-github-api-version": githubApiVersion, - }; - if (githubToken) headers.authorization = `Bearer ${githubToken}`; - return headers; -} - + const headers = { + accept: "application/vnd.github+json", + "user-agent": "loopover-miner", + "x-github-api-version": githubApiVersion, + }; + if (githubToken) + headers.authorization = `Bearer ${githubToken}`; + return headers; +} function repoPath(target, suffix) { - return `/repos/${encodeURIComponent(target.owner)}/${encodeURIComponent(target.repo)}${suffix}`; + return `/repos/${encodeURIComponent(target.owner)}/${encodeURIComponent(target.repo)}${suffix}`; } - function apiUrl(apiBaseUrl, path, query = "") { - return `${apiBaseUrl}${path}${query}`; + return `${apiBaseUrl}${path}${query}`; } - function githubError(response, payload) { - const code = `github_${response.status}`; - const githubMessage = - typeof payload?.message === "string" && payload.message.trim() ? payload.message : null; - const message = githubMessage ? `${code}: ${githubMessage}` : code; - return Object.assign(new Error(message), { code, githubMessage }); + const code = `github_${response.status}`; + const record = payload; + const githubMessage = typeof record?.message === "string" && record.message.trim() ? record.message : null; + const message = githubMessage ? `${code}: ${githubMessage}` : code; + return Object.assign(new Error(message), { code, githubMessage }); } - async function githubGetJsonResponse(url, options) { - // Retry transient network errors / 5xx around this single call (#4829), distinct from the poller's own - // pending-retry loop; the poller's injected sleepFn keeps tests instant. requestTimeoutMs bounds each - // individual attempt (a stalled connection previously hung this call forever -- #miner-github-read-timeouts). - const response = await fetchWithRetry( - options.fetchFn, - url, - { method: "GET", headers: githubHeaders(options.githubToken) }, - { sleepFn: options.sleepFn, timeoutMs: options.requestTimeoutMs }, - ); - const payload = await response.json().catch(() => null); - if (!response.ok) { - throw githubError(response, payload); - } - return { payload, response }; -} - + // Retry transient network errors / 5xx around this single call (#4829), distinct from the poller's own + // pending-retry loop; the poller's injected sleepFn keeps tests instant. requestTimeoutMs bounds each + // individual attempt (a stalled connection previously hung this call forever -- #miner-github-read-timeouts). + const response = await fetchWithRetry(options.fetchFn, url, { method: "GET", headers: githubHeaders(options.githubToken) }, { sleepFn: options.sleepFn, timeoutMs: options.requestTimeoutMs }); + const payload = await response.json().catch(() => null); + if (!response.ok) { + throw githubError(response, payload); + } + return { payload, response }; +} async function githubGetJson(url, options) { - const { payload } = await githubGetJsonResponse(url, options); - return payload; + const { payload } = await githubGetJsonResponse(url, options); + return payload; } - function hasNextLink(response) { - return /<[^>]+>;\s*rel="next"/.test(response.headers.get("link") ?? ""); + return /<[^>]+>;\s*rel="next"/.test(response.headers.get("link") ?? ""); } - function payloadTotalCount(payload) { - const totalCount = Number(payload?.total_count); - return Number.isInteger(totalCount) && totalCount >= 0 ? totalCount : null; + const record = payload; + const totalCount = Number(record?.total_count); + return Number.isInteger(totalCount) && totalCount >= 0 ? totalCount : null; } - function normalizeConclusion(checkRun) { - if (!checkRun || typeof checkRun !== "object") return "pending"; - if (checkRun.status !== "completed") return "pending"; - switch (checkRun.conclusion) { - case "success": - case "skipped": - return "success"; - case "neutral": - return "neutral"; - case "failure": - case "cancelled": - case "timed_out": - case "action_required": - case "stale": - case "startup_failure": - return "failure"; - default: - return "pending"; - } -} - + if (!checkRun || typeof checkRun !== "object") + return "pending"; + const record = checkRun; + if (record.status !== "completed") + return "pending"; + switch (record.conclusion) { + case "success": + case "skipped": + return "success"; + case "neutral": + return "neutral"; + case "failure": + case "cancelled": + case "timed_out": + case "action_required": + case "stale": + case "startup_failure": + return "failure"; + default: + return "pending"; + } +} function normalizeCheckRun(checkRun) { - return { - name: typeof checkRun?.name === "string" ? checkRun.name : "", - status: typeof checkRun?.status === "string" ? checkRun.status : "unknown", - conclusion: normalizeConclusion(checkRun), - detailsUrl: typeof checkRun?.details_url === "string" ? checkRun.details_url : null, - startedAt: typeof checkRun?.started_at === "string" ? checkRun.started_at : null, - completedAt: typeof checkRun?.completed_at === "string" ? checkRun.completed_at : null, - }; -} - + const record = checkRun; + return { + name: typeof record?.name === "string" ? record.name : "", + status: typeof record?.status === "string" ? record.status : "unknown", + conclusion: normalizeConclusion(checkRun), + detailsUrl: typeof record?.details_url === "string" ? record.details_url : null, + startedAt: typeof record?.started_at === "string" ? record.started_at : null, + completedAt: typeof record?.completed_at === "string" ? record.completed_at : null, + }; +} function aggregateConclusion(checks) { - if (checks.length === 0) return "pending"; - if (checks.some((check) => check.conclusion === "failure")) return "failure"; - if (checks.some((check) => check.conclusion === "pending")) return "pending"; - if (checks.every((check) => check.conclusion === "success")) return "success"; - return "neutral"; + if (checks.length === 0) + return "pending"; + if (checks.some((check) => check.conclusion === "failure")) + return "failure"; + if (checks.some((check) => check.conclusion === "pending")) + return "pending"; + if (checks.every((check) => check.conclusion === "success")) + return "success"; + return "neutral"; } - function backoffDelayMs(attemptIndex, options) { - const exponent = Math.min(10, Math.max(0, attemptIndex)); - return Math.min(options.maxIntervalMs, options.minIntervalMs * 2 ** exponent); + const exponent = Math.min(10, Math.max(0, attemptIndex)); + return Math.min(options.maxIntervalMs, options.minIntervalMs * 2 ** exponent); } - async function fetchHeadSha(target, prNumber, options) { - const payload = await githubGetJson( - apiUrl(options.apiBaseUrl, repoPath(target, `/pulls/${prNumber}`)), - options, - ); - const headSha = payload?.head?.sha; - if (typeof headSha !== "string" || !headSha) throw new Error("github_pr_head_sha_missing"); - return headSha; -} - + const payload = await githubGetJson(apiUrl(options.apiBaseUrl, repoPath(target, `/pulls/${prNumber}`)), options); + const record = payload; + const headSha = record?.head?.sha; + if (typeof headSha !== "string" || !headSha) + throw new Error("github_pr_head_sha_missing"); + return headSha; +} async function fetchCheckRuns(target, headSha, options) { - const checks = []; - let page = 1; - let expectedTotalCount = null; - while (true) { - const { payload, response } = await githubGetJsonResponse( - apiUrl( - options.apiBaseUrl, - repoPath(target, `/commits/${encodeURIComponent(headSha)}/check-runs`), - `?per_page=100&page=${page}`, - ), - options, - ); - if (!Array.isArray(payload?.check_runs)) { - throw new Error("github_check_runs_malformed"); - } - const pageChecks = payload.check_runs.map(normalizeCheckRun); - checks.push(...pageChecks); - expectedTotalCount = payloadTotalCount(payload) ?? expectedTotalCount; - if (!hasNextLink(response) && (expectedTotalCount === null || checks.length >= expectedTotalCount)) { - return checks; - } - if (pageChecks.length === 0) { - throw new Error("github_check_runs_pagination_incomplete"); + const checks = []; + let page = 1; + let expectedTotalCount = null; + for (;;) { + const { payload, response } = await githubGetJsonResponse(apiUrl(options.apiBaseUrl, repoPath(target, `/commits/${encodeURIComponent(headSha)}/check-runs`), `?per_page=100&page=${page}`), options); + const record = payload; + if (!Array.isArray(record?.check_runs)) { + throw new Error("github_check_runs_malformed"); + } + const pageChecks = record.check_runs.map(normalizeCheckRun); + checks.push(...pageChecks); + expectedTotalCount = payloadTotalCount(payload) ?? expectedTotalCount; + if (!hasNextLink(response) && (expectedTotalCount === null || checks.length >= expectedTotalCount)) { + return checks; + } + if (pageChecks.length === 0) { + throw new Error("github_check_runs_pagination_incomplete"); + } + page += 1; } - page += 1; - } } - export async function pollCheckRuns(repoFullName, prNumber, options = {}) { - const target = parseRepoFullName(repoFullName); - const normalizedPrNumber = normalizePullNumber(prNumber); - const normalizedOptions = normalizeOptions(options); - - let latest = { conclusion: "pending", checks: [], headSha: "", attempts: 0 }; - for (let attempt = 0; attempt < normalizedOptions.maxAttempts; attempt += 1) { - const headSha = await fetchHeadSha(target, normalizedPrNumber, normalizedOptions); - const checks = await fetchCheckRuns(target, headSha, normalizedOptions); - latest = { - conclusion: aggregateConclusion(checks), - checks, - headSha, - attempts: attempt + 1, - }; - if (latest.conclusion !== "pending") { - const currentHeadSha = await fetchHeadSha(target, normalizedPrNumber, normalizedOptions); - if (currentHeadSha === headSha) { - return latest; - } - latest = { - conclusion: "pending", - checks: [], - headSha: currentHeadSha, - attempts: attempt + 1, - }; - } - if (attempt === normalizedOptions.maxAttempts - 1) { - return latest; + const target = parseRepoFullName(repoFullName); + const normalizedPrNumber = normalizePullNumber(prNumber); + const normalizedOptions = normalizeOptions(options); + let latest = { conclusion: "pending", checks: [], headSha: "", attempts: 0 }; + for (let attempt = 0; attempt < normalizedOptions.maxAttempts; attempt += 1) { + const headSha = await fetchHeadSha(target, normalizedPrNumber, normalizedOptions); + const checks = await fetchCheckRuns(target, headSha, normalizedOptions); + latest = { + conclusion: aggregateConclusion(checks), + checks, + headSha, + attempts: attempt + 1, + }; + if (latest.conclusion !== "pending") { + const currentHeadSha = await fetchHeadSha(target, normalizedPrNumber, normalizedOptions); + if (currentHeadSha === headSha) { + return latest; + } + latest = { + conclusion: "pending", + checks: [], + headSha: currentHeadSha, + attempts: attempt + 1, + }; + } + if (attempt === normalizedOptions.maxAttempts - 1) { + return latest; + } + await normalizedOptions.sleepFn(backoffDelayMs(attempt, normalizedOptions)); } - await normalizedOptions.sleepFn(backoffDelayMs(attempt, normalizedOptions)); - } - - return latest; + // Unreachable at runtime: normalizeOptions clamps maxAttempts to a minimum of 1 (normalizePositiveInt's own + // `min` argument), so the loop above always returns internally on its final iteration (line 267 or 277). + // Kept only because TypeScript's control-flow analysis can't see that runtime guarantee through the loop. + return latest; } +//# sourceMappingURL=data:application/json;base64,{"version":3,"file":"ci-poller.js","sourceRoot":"","sources":["ci-poller.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,cAAc,EAAE,MAAM,iBAAiB,CAAC;AA0CjD,MAAM,iBAAiB,GAAG,wBAAwB,CAAC;AACnD,MAAM,oBAAoB,GAAG,MAAM,CAAC;AACpC,MAAM,oBAAoB,GAAG,CAAC,GAAG,MAAM,CAAC;AACxC,MAAM,kBAAkB,GAAG,CAAC,CAAC;AAC7B,MAAM,uBAAuB,GAAG,MAAM,CAAC;AACvC,MAAM,gBAAgB,GAAG,YAAY,CAAC;AAEtC,SAAS,mBAAmB,CAAC,KAAyB;IACpD,IAAI,KAAK,KAAK,SAAS;QAAE,OAAO,iBAAiB,CAAC;IAClD,IAAI,OAAO,KAAK,KAAK,QAAQ,IAAI,CAAC,KAAK,CAAC,IAAI,EAAE;QAAE,OAAO,iBAAiB,CAAC;IACzE,IAAI,MAAW,CAAC;IAChB,IAAI,CAAC;QACH,MAAM,GAAG,IAAI,GAAG,CAAC,KAAK,CAAC,IAAI,EAAE,CAAC,CAAC;IACjC,CAAC;IAAC,MAAM,CAAC;QACP,MAAM,IAAI,KAAK,CAAC,sBAAsB,CAAC,CAAC;IAC1C,CAAC;IACD,IAAI,MAAM,CAAC,QAAQ,KAAK,QAAQ,IAAI,MAAM,CAAC,QAAQ,KAAK,gBAAgB,EAAE,CAAC;QACzE,MAAM,IAAI,KAAK,CAAC,sBAAsB,CAAC,CAAC;IAC1C,CAAC;IACD,MAAM,CAAC,QAAQ,GAAG,MAAM,CAAC,QAAQ,CAAC,OAAO,CAAC,MAAM,EAAE,EAAE,CAAC,CAAC;IACtD,MAAM,CAAC,MAAM,GAAG,EAAE,CAAC;IACnB,MAAM,CAAC,IAAI,GAAG,EAAE,CAAC;IACjB,OAAO,MAAM,CAAC,QAAQ,EAAE,CAAC,OAAO,CAAC,MAAM,EAAE,EAAE,CAAC,CAAC;AAC/C,CAAC;AAED,SAAS,oBAAoB,CAAC,KAAyB,EAAE,QAAgB,EAAE,GAAW,EAAE,GAAW;IACjG,IAAI,CAAC,MAAM,CAAC,QAAQ,CAAC,KAAK,CAAC;QAAE,OAAO,QAAQ,CAAC;IAC7C,OAAO,IAAI,CAAC,GAAG,CAAC,GAAG,EAAE,IAAI,CAAC,GAAG,CAAC,GAAG,EAAE,IAAI,CAAC,KAAK,CAAC,KAAe,CAAC,CAAC,CAAC,CAAC;AACnE,CAAC;AAED,SAAS,gBAAgB,CAAC,UAAgC,EAAE;IAC1D,OAAO;QACL,UAAU,EAAE,mBAAmB,CAAC,OAAO,CAAC,UAAU,CAAC;QACnD,OAAO,EAAE,OAAO,CAAC,OAAO,IAAI,KAAK;QACjC,WAAW,EAAE,OAAO,OAAO,CAAC,WAAW,KAAK,QAAQ,CAAC,CAAC,CAAC,OAAO,CAAC,WAAW,CAAC,IAAI,EAAE,CAAC,CAAC,CAAC,EAAE;QACtF,WAAW,EAAE,oBAAoB,CAAC,OAAO,CAAC,WAAW,EAAE,kBAAkB,EAAE,CAAC,EAAE,EAAE,CAAC;QACjF,aAAa,EAAE,oBAAoB,CAAC,OAAO,CAAC,aAAa,EAAE,oBAAoB,EAAE,CAAC,EAAE,EAAE,GAAG,MAAM,CAAC;QAChG,aAAa,EAAE,oBAAoB,CAAC,OAAO,CAAC,aAAa,EAAE,oBAAoB,EAAE,CAAC,EAAE,EAAE,GAAG,MAAM,CAAC;QAChG,gBAAgB,EAAE,oBAAoB,CAAC,OAAO,CAAC,gBAAgB,EAAE,uBAAuB,EAAE,CAAC,EAAE,MAAM,CAAC;QACpG,OAAO,EACL,OAAO,CAAC,OAAO;YACf,CAAC,CAAC,OAAe,EAAE,EAAE,CAAC,IAAI,OAAO,CAAC,CAAC,OAAO,EAAE,EAAE,CAAC,UAAU,CAAC,OAAO,EAAE,OAAO,CAAC,CAAC,CAAC;KAChF,CAAC;AACJ,CAAC;AAED,SAAS,iBAAiB,CAAC,YAAoB;IAC7C,IAAI,OAAO,YAAY,KAAK,QAAQ;QAAE,MAAM,IAAI,KAAK,CAAC,wBAAwB,CAAC,CAAC;IAChF,MAAM,CAAC,KAAK,EAAE,IAAI,EAAE,KAAK,CAAC,GAAG,YAAY,CAAC,KAAK,CAAC,GAAG,CAAC,CAAC;IACrD,IAAI,CAAC,KAAK,EAAE,IAAI,EAAE,IAAI,CAAC,IAAI,EAAE,IAAI,EAAE,IAAI,KAAK,KAAK,SAAS,EAAE,CAAC;QAC3D,MAAM,IAAI,KAAK,CAAC,wBAAwB,CAAC,CAAC;IAC5C,CAAC;IACD,OAAO,EAAE,KAAK,EAAE,KAAK,CAAC,IAAI,EAAE,EAAE,IAAI,EAAE,IAAI,CAAC,IAAI,EAAE,EAAE,CAAC;AACpD,CAAC;AAED,SAAS,mBAAmB,CAAC,KAAa;IACxC,IAAI,CAAC,MAAM,CAAC,SAAS,CAAC,KAAK,CAAC,IAAI,KAAK,IAAI,CAAC;QAAE,MAAM,IAAI,KAAK,CAAC,mBAAmB,CAAC,CAAC;IACjF,OAAO,KAAK,CAAC;AACf,CAAC;AAED,SAAS,aAAa,CAAC,WAAmB;IACxC,MAAM,OAAO,GAA2B;QACtC,MAAM,EAAE,6BAA6B;QACrC,YAAY,EAAE,gBAAgB;QAC9B,sBAAsB,EAAE,gBAAgB;KACzC,CAAC;IACF,IAAI,WAAW;QAAE,OAAO,CAAC,aAAa,GAAG,UAAU,WAAW,EAAE,CAAC;IACjE,OAAO,OAAO,CAAC;AACjB,CAAC;AAED,SAAS,QAAQ,CAAC,MAAuC,EAAE,MAAc;IACvE,OAAO,UAAU,kBAAkB,CAAC,MAAM,CAAC,KAAK,CAAC,IAAI,kBAAkB,CAAC,MAAM,CAAC,IAAI,CAAC,GAAG,MAAM,EAAE,CAAC;AAClG,CAAC;AAED,SAAS,MAAM,CAAC,UAAkB,EAAE,IAAY,EAAE,KAAK,GAAG,EAAE;IAC1D,OAAO,GAAG,UAAU,GAAG,IAAI,GAAG,KAAK,EAAE,CAAC;AACxC,CAAC;AAED,SAAS,WAAW,CAAC,QAAkB,EAAE,OAAgB;IACvD,MAAM,IAAI,GAAG,UAAU,QAAQ,CAAC,MAAM,EAAE,CAAC;IACzC,MAAM,MAAM,GAAG,OAAuC,CAAC;IACvD,MAAM,aAAa,GACjB,OAAO,MAAM,EAAE,OAAO,KAAK,QAAQ,IAAI,MAAM,CAAC,OAAO,CAAC,IAAI,EAAE,CAAC,CAAC,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC,CAAC,IAAI,CAAC;IACvF,MAAM,OAAO,GAAG,aAAa,CAAC,CAAC,CAAC,GAAG,IAAI,KAAK,aAAa,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC;IACnE,OAAO,MAAM,CAAC,MAAM,CAAC,IAAI,KAAK,CAAC,OAAO,CAAC,EAAE,EAAE,IAAI,EAAE,aAAa,EAAE,CAAC,CAAC;AACpE,CAAC;AAED,KAAK,UAAU,qBAAqB,CAAC,GAAW,EAAE,OAA8B;IAC9E,uGAAuG;IACvG,sGAAsG;IACtG,8GAA8G;IAC9G,MAAM,QAAQ,GAAG,MAAM,cAAc,CACnC,OAAO,CAAC,OAAyE,EACjF,GAAG,EACH,EAAE,MAAM,EAAE,KAAK,EAAE,OAAO,EAAE,aAAa,CAAC,OAAO,CAAC,WAAW,CAAC,EAAE,EAC9D,EAAE,OAAO,EAAE,OAAO,CAAC,OAAO,EAAE,SAAS,EAAE,OAAO,CAAC,gBAAgB,EAAE,CAClE,CAAC;IACF,MAAM,OAAO,GAAG,MAAM,QAAQ,CAAC,IAAI,EAAE,CAAC,KAAK,CAAC,GAAG,EAAE,CAAC,IAAI,CAAC,CAAC;IACxD,IAAI,CAAC,QAAQ,CAAC,EAAE,EAAE,CAAC;QACjB,MAAM,WAAW,CAAC,QAAQ,EAAE,OAAO,CAAC,CAAC;IACvC,CAAC;IACD,OAAO,EAAE,OAAO,EAAE,QAAQ,EAAE,CAAC;AAC/B,CAAC;AAED,KAAK,UAAU,aAAa,CAAC,GAAW,EAAE,OAA8B;IACtE,MAAM,EAAE,OAAO,EAAE,GAAG,MAAM,qBAAqB,CAAC,GAAG,EAAE,OAAO,CAAC,CAAC;IAC9D,OAAO,OAAO,CAAC;AACjB,CAAC;AAED,SAAS,WAAW,CAAC,QAAkB;IACrC,OAAO,uBAAuB,CAAC,IAAI,CAAC,QAAQ,CAAC,OAAO,CAAC,GAAG,CAAC,MAAM,CAAC,IAAI,EAAE,CAAC,CAAC;AAC1E,CAAC;AAED,SAAS,iBAAiB,CAAC,OAAgB;IACzC,MAAM,MAAM,GAAG,OAA2C,CAAC;IAC3D,MAAM,UAAU,GAAG,MAAM,CAAC,MAAM,EAAE,WAAW,CAAC,CAAC;IAC/C,OAAO,MAAM,CAAC,SAAS,CAAC,UAAU,CAAC,IAAI,UAAU,IAAI,CAAC,CAAC,CAAC,CAAC,UAAU,CAAC,CAAC,CAAC,IAAI,CAAC;AAC7E,CAAC;AAED,SAAS,mBAAmB,CAAC,QAAiB;IAC5C,IAAI,CAAC,QAAQ,IAAI,OAAO,QAAQ,KAAK,QAAQ;QAAE,OAAO,SAAS,CAAC;IAChE,MAAM,MAAM,GAAG,QAAsD,CAAC;IACtE,IAAI,MAAM,CAAC,MAAM,KAAK,WAAW;QAAE,OAAO,SAAS,CAAC;IACpD,QAAQ,MAAM,CAAC,UAAU,EAAE,CAAC;QAC1B,KAAK,SAAS,CAAC;QACf,KAAK,SAAS;YACZ,OAAO,SAAS,CAAC;QACnB,KAAK,SAAS;YACZ,OAAO,SAAS,CAAC;QACnB,KAAK,SAAS,CAAC;QACf,KAAK,WAAW,CAAC;QACjB,KAAK,WAAW,CAAC;QACjB,KAAK,iBAAiB,CAAC;QACvB,KAAK,OAAO,CAAC;QACb,KAAK,iBAAiB;YACpB,OAAO,SAAS,CAAC;QACnB;YACE,OAAO,SAAS,CAAC;IACrB,CAAC;AACH,CAAC;AAED,SAAS,iBAAiB,CAAC,QAAiB;IAC1C,MAAM,MAAM,GAAG,QAA4H,CAAC;IAC5I,OAAO;QACL,IAAI,EAAE,OAAO,MAAM,EAAE,IAAI,KAAK,QAAQ,CAAC,CAAC,CAAC,MAAM,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE;QACzD,MAAM,EAAE,OAAO,MAAM,EAAE,MAAM,KAAK,QAAQ,CAAC,CAAC,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,CAAC,SAAS;QACtE,UAAU,EAAE,mBAAmB,CAAC,QAAQ,CAAC;QACzC,UAAU,EAAE,OAAO,MAAM,EAAE,WAAW,KAAK,QAAQ,CAAC,CAAC,CAAC,MAAM,CAAC,WAAW,CAAC,CAAC,CAAC,IAAI;QAC/E,SAAS,EAAE,OAAO,MAAM,EAAE,UAAU,KAAK,QAAQ,CAAC,CAAC,CAAC,MAAM,CAAC,UAAU,CAAC,CAAC,CAAC,IAAI;QAC5E,WAAW,EAAE,OAAO,MAAM,EAAE,YAAY,KAAK,QAAQ,CAAC,CAAC,CAAC,MAAM,CAAC,YAAY,CAAC,CAAC,CAAC,IAAI;KACnF,CAAC;AACJ,CAAC;AAED,SAAS,mBAAmB,CAAC,MAA4B;IACvD,IAAI,MAAM,CAAC,MAAM,KAAK,CAAC;QAAE,OAAO,SAAS,CAAC;IAC1C,IAAI,MAAM,CAAC,IAAI,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,UAAU,KAAK,SAAS,CAAC;QAAE,OAAO,SAAS,CAAC;IAC7E,IAAI,MAAM,CAAC,IAAI,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,UAAU,KAAK,SAAS,CAAC;QAAE,OAAO,SAAS,CAAC;IAC7E,IAAI,MAAM,CAAC,KAAK,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,UAAU,KAAK,SAAS,CAAC;QAAE,OAAO,SAAS,CAAC;IAC9E,OAAO,SAAS,CAAC;AACnB,CAAC;AAED,SAAS,cAAc,CAAC,YAAoB,EAAE,OAA8B;IAC1E,MAAM,QAAQ,GAAG,IAAI,CAAC,GAAG,CAAC,EAAE,EAAE,IAAI,CAAC,GAAG,CAAC,CAAC,EAAE,YAAY,CAAC,CAAC,CAAC;IACzD,OAAO,IAAI,CAAC,GAAG,CAAC,OAAO,CAAC,aAAa,EAAE,OAAO,CAAC,aAAa,GAAG,CAAC,IAAI,QAAQ,CAAC,CAAC;AAChF,CAAC;AAED,KAAK,UAAU,YAAY,CAAC,MAAuC,EAAE,QAAgB,EAAE,OAA8B;IACnH,MAAM,OAAO,GAAG,MAAM,aAAa,CACjC,MAAM,CAAC,OAAO,CAAC,UAAU,EAAE,QAAQ,CAAC,MAAM,EAAE,UAAU,QAAQ,EAAE,CAAC,CAAC,EAClE,OAAO,CACR,CAAC;IACF,MAAM,MAAM,GAAG,OAA8C,CAAC;IAC9D,MAAM,OAAO,GAAG,MAAM,EAAE,IAAI,EAAE,GAAG,CAAC;IAClC,IAAI,OAAO,OAAO,KAAK,QAAQ,IAAI,CAAC,OAAO;QAAE,MAAM,IAAI,KAAK,CAAC,4BAA4B,CAAC,CAAC;IAC3F,OAAO,OAAO,CAAC;AACjB,CAAC;AAED,KAAK,UAAU,cAAc,CAAC,MAAuC,EAAE,OAAe,EAAE,OAA8B;IACpH,MAAM,MAAM,GAAyB,EAAE,CAAC;IACxC,IAAI,IAAI,GAAG,CAAC,CAAC;IACb,IAAI,kBAAkB,GAAkB,IAAI,CAAC;IAC7C,SAAS,CAAC;QACR,MAAM,EAAE,OAAO,EAAE,QAAQ,EAAE,GAAG,MAAM,qBAAqB,CACvD,MAAM,CACJ,OAAO,CAAC,UAAU,EAClB,QAAQ,CAAC,MAAM,EAAE,YAAY,kBAAkB,CAAC,OAAO,CAAC,aAAa,CAAC,EACtE,sBAAsB,IAAI,EAAE,CAC7B,EACD,OAAO,CACR,CAAC;QACF,MAAM,MAAM,GAAG,OAA0C,CAAC;QAC1D,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,MAAM,EAAE,UAAU,CAAC,EAAE,CAAC;YACvC,MAAM,IAAI,KAAK,CAAC,6BAA6B,CAAC,CAAC;QACjD,CAAC;QACD,MAAM,UAAU,GAAG,MAAM,CAAC,UAAU,CAAC,GAAG,CAAC,iBAAiB,CAAC,CAAC;QAC5D,MAAM,CAAC,IAAI,CAAC,GAAG,UAAU,CAAC,CAAC;QAC3B,kBAAkB,GAAG,iBAAiB,CAAC,OAAO,CAAC,IAAI,kBAAkB,CAAC;QACtE,IAAI,CAAC,WAAW,CAAC,QAAQ,CAAC,IAAI,CAAC,kBAAkB,KAAK,IAAI,IAAI,MAAM,CAAC,MAAM,IAAI,kBAAkB,CAAC,EAAE,CAAC;YACnG,OAAO,MAAM,CAAC;QAChB,CAAC;QACD,IAAI,UAAU,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;YAC5B,MAAM,IAAI,KAAK,CAAC,yCAAyC,CAAC,CAAC;QAC7D,CAAC;QACD,IAAI,IAAI,CAAC,CAAC;IACZ,CAAC;AACH,CAAC;AAED,MAAM,CAAC,KAAK,UAAU,aAAa,CAAC,YAAoB,EAAE,QAAgB,EAAE,UAAgC,EAAE;IAC5G,MAAM,MAAM,GAAG,iBAAiB,CAAC,YAAY,CAAC,CAAC;IAC/C,MAAM,kBAAkB,GAAG,mBAAmB,CAAC,QAAQ,CAAC,CAAC;IACzD,MAAM,iBAAiB,GAAG,gBAAgB,CAAC,OAAO,CAAC,CAAC;IAEpD,IAAI,MAAM,GAAwB,EAAE,UAAU,EAAE,SAAS,EAAE,MAAM,EAAE,EAAE,EAAE,OAAO,EAAE,EAAE,EAAE,QAAQ,EAAE,CAAC,EAAE,CAAC;IAClG,KAAK,IAAI,OAAO,GAAG,CAAC,EAAE,OAAO,GAAG,iBAAiB,CAAC,WAAW,EAAE,OAAO,IAAI,CAAC,EAAE,CAAC;QAC5E,MAAM,OAAO,GAAG,MAAM,YAAY,CAAC,MAAM,EAAE,kBAAkB,EAAE,iBAAiB,CAAC,CAAC;QAClF,MAAM,MAAM,GAAG,MAAM,cAAc,CAAC,MAAM,EAAE,OAAO,EAAE,iBAAiB,CAAC,CAAC;QACxE,MAAM,GAAG;YACP,UAAU,EAAE,mBAAmB,CAAC,MAAM,CAAC;YACvC,MAAM;YACN,OAAO;YACP,QAAQ,EAAE,OAAO,GAAG,CAAC;SACtB,CAAC;QACF,IAAI,MAAM,CAAC,UAAU,KAAK,SAAS,EAAE,CAAC;YACpC,MAAM,cAAc,GAAG,MAAM,YAAY,CAAC,MAAM,EAAE,kBAAkB,EAAE,iBAAiB,CAAC,CAAC;YACzF,IAAI,cAAc,KAAK,OAAO,EAAE,CAAC;gBAC/B,OAAO,MAAM,CAAC;YAChB,CAAC;YACD,MAAM,GAAG;gBACP,UAAU,EAAE,SAAS;gBACrB,MAAM,EAAE,EAAE;gBACV,OAAO,EAAE,cAAc;gBACvB,QAAQ,EAAE,OAAO,GAAG,CAAC;aACtB,CAAC;QACJ,CAAC;QACD,IAAI,OAAO,KAAK,iBAAiB,CAAC,WAAW,GAAG,CAAC,EAAE,CAAC;YAClD,OAAO,MAAM,CAAC;QAChB,CAAC;QACD,MAAM,iBAAiB,CAAC,OAAO,CAAC,cAAc,CAAC,OAAO,EAAE,iBAAiB,CAAC,CAAC,CAAC;IAC9E,CAAC;IAED,4GAA4G;IAC5G,yGAAyG;IACzG,0GAA0G;IAC1G,OAAO,MAAM,CAAC;AAChB,CAAC"} \ No newline at end of file diff --git a/packages/loopover-miner/lib/ci-poller.ts b/packages/loopover-miner/lib/ci-poller.ts new file mode 100644 index 0000000000..a3bf199ac4 --- /dev/null +++ b/packages/loopover-miner/lib/ci-poller.ts @@ -0,0 +1,286 @@ +import { fetchWithRetry } from "./http-retry.js"; + +export type CheckRunConclusion = "pending" | "success" | "failure" | "neutral"; + +export type NormalizedCheckRun = { + name: string; + status: string; + conclusion: CheckRunConclusion; + detailsUrl: string | null; + startedAt: string | null; + completedAt: string | null; +}; + +export type PollCheckRunsResult = { + conclusion: CheckRunConclusion; + checks: NormalizedCheckRun[]; + headSha: string; + attempts: number; +}; + +export type PollCheckRunsOptions = { + apiBaseUrl?: string; + fetchFn?: typeof fetch; + githubToken?: string; + maxAttempts?: number; + minIntervalMs?: number; + maxIntervalMs?: number; + requestTimeoutMs?: number; + sleepFn?: (delayMs: number) => Promise; +}; + +type NormalizedPollOptions = { + apiBaseUrl: string; + fetchFn: typeof fetch; + githubToken: string; + maxAttempts: number; + minIntervalMs: number; + maxIntervalMs: number; + requestTimeoutMs: number; + sleepFn: (delayMs: number) => Promise; +}; + +const defaultApiBaseUrl = "https://api.github.com"; +const defaultMinIntervalMs = 60_000; +const defaultMaxIntervalMs = 5 * 60_000; +const defaultMaxAttempts = 1; +const defaultRequestTimeoutMs = 10_000; +const githubApiVersion = "2022-11-28"; + +function normalizeApiBaseUrl(value: string | undefined): string { + if (value === undefined) return defaultApiBaseUrl; + if (typeof value !== "string" || !value.trim()) return defaultApiBaseUrl; + let parsed: URL; + try { + parsed = new URL(value.trim()); + } catch { + throw new Error("invalid_api_base_url"); + } + if (parsed.protocol !== "https:" || parsed.hostname !== "api.github.com") { + throw new Error("invalid_api_base_url"); + } + parsed.pathname = parsed.pathname.replace(/\/+$/, ""); + parsed.search = ""; + parsed.hash = ""; + return parsed.toString().replace(/\/+$/, ""); +} + +function normalizePositiveInt(value: number | undefined, fallback: number, min: number, max: number): number { + if (!Number.isFinite(value)) return fallback; + return Math.min(max, Math.max(min, Math.floor(value as number))); +} + +function normalizeOptions(options: PollCheckRunsOptions = {}): NormalizedPollOptions { + return { + apiBaseUrl: normalizeApiBaseUrl(options.apiBaseUrl), + fetchFn: options.fetchFn ?? fetch, + githubToken: typeof options.githubToken === "string" ? options.githubToken.trim() : "", + maxAttempts: normalizePositiveInt(options.maxAttempts, defaultMaxAttempts, 1, 20), + minIntervalMs: normalizePositiveInt(options.minIntervalMs, defaultMinIntervalMs, 1, 60 * 60_000), + maxIntervalMs: normalizePositiveInt(options.maxIntervalMs, defaultMaxIntervalMs, 1, 60 * 60_000), + requestTimeoutMs: normalizePositiveInt(options.requestTimeoutMs, defaultRequestTimeoutMs, 1, 60_000), + sleepFn: + options.sleepFn ?? + ((delayMs: number) => new Promise((resolve) => setTimeout(resolve, delayMs))), + }; +} + +function parseRepoFullName(repoFullName: string): { owner: string; repo: string } { + if (typeof repoFullName !== "string") throw new Error("invalid_repo_full_name"); + const [owner, repo, extra] = repoFullName.split("/"); + if (!owner?.trim() || !repo?.trim() || extra !== undefined) { + throw new Error("invalid_repo_full_name"); + } + return { owner: owner.trim(), repo: repo.trim() }; +} + +function normalizePullNumber(value: number): number { + if (!Number.isInteger(value) || value <= 0) throw new Error("invalid_pr_number"); + return value; +} + +function githubHeaders(githubToken: string): Record { + const headers: Record = { + accept: "application/vnd.github+json", + "user-agent": "loopover-miner", + "x-github-api-version": githubApiVersion, + }; + if (githubToken) headers.authorization = `Bearer ${githubToken}`; + return headers; +} + +function repoPath(target: { owner: string; repo: string }, suffix: string): string { + return `/repos/${encodeURIComponent(target.owner)}/${encodeURIComponent(target.repo)}${suffix}`; +} + +function apiUrl(apiBaseUrl: string, path: string, query = ""): string { + return `${apiBaseUrl}${path}${query}`; +} + +function githubError(response: Response, payload: unknown): Error & { code: string; githubMessage: string | null } { + const code = `github_${response.status}`; + const record = payload as { message?: unknown } | null; + const githubMessage = + typeof record?.message === "string" && record.message.trim() ? record.message : null; + const message = githubMessage ? `${code}: ${githubMessage}` : code; + return Object.assign(new Error(message), { code, githubMessage }); +} + +async function githubGetJsonResponse(url: string, options: NormalizedPollOptions): Promise<{ payload: unknown; response: Response }> { + // Retry transient network errors / 5xx around this single call (#4829), distinct from the poller's own + // pending-retry loop; the poller's injected sleepFn keeps tests instant. requestTimeoutMs bounds each + // individual attempt (a stalled connection previously hung this call forever -- #miner-github-read-timeouts). + const response = await fetchWithRetry( + options.fetchFn as unknown as (url: unknown, init?: unknown) => Promise, + url, + { method: "GET", headers: githubHeaders(options.githubToken) }, + { sleepFn: options.sleepFn, timeoutMs: options.requestTimeoutMs }, + ); + const payload = await response.json().catch(() => null); + if (!response.ok) { + throw githubError(response, payload); + } + return { payload, response }; +} + +async function githubGetJson(url: string, options: NormalizedPollOptions): Promise { + const { payload } = await githubGetJsonResponse(url, options); + return payload; +} + +function hasNextLink(response: Response): boolean { + return /<[^>]+>;\s*rel="next"/.test(response.headers.get("link") ?? ""); +} + +function payloadTotalCount(payload: unknown): number | null { + const record = payload as { total_count?: unknown } | null; + const totalCount = Number(record?.total_count); + return Number.isInteger(totalCount) && totalCount >= 0 ? totalCount : null; +} + +function normalizeConclusion(checkRun: unknown): CheckRunConclusion { + if (!checkRun || typeof checkRun !== "object") return "pending"; + const record = checkRun as { status?: unknown; conclusion?: unknown }; + if (record.status !== "completed") return "pending"; + switch (record.conclusion) { + case "success": + case "skipped": + return "success"; + case "neutral": + return "neutral"; + case "failure": + case "cancelled": + case "timed_out": + case "action_required": + case "stale": + case "startup_failure": + return "failure"; + default: + return "pending"; + } +} + +function normalizeCheckRun(checkRun: unknown): NormalizedCheckRun { + const record = checkRun as { name?: unknown; status?: unknown; details_url?: unknown; started_at?: unknown; completed_at?: unknown } | null; + return { + name: typeof record?.name === "string" ? record.name : "", + status: typeof record?.status === "string" ? record.status : "unknown", + conclusion: normalizeConclusion(checkRun), + detailsUrl: typeof record?.details_url === "string" ? record.details_url : null, + startedAt: typeof record?.started_at === "string" ? record.started_at : null, + completedAt: typeof record?.completed_at === "string" ? record.completed_at : null, + }; +} + +function aggregateConclusion(checks: NormalizedCheckRun[]): CheckRunConclusion { + if (checks.length === 0) return "pending"; + if (checks.some((check) => check.conclusion === "failure")) return "failure"; + if (checks.some((check) => check.conclusion === "pending")) return "pending"; + if (checks.every((check) => check.conclusion === "success")) return "success"; + return "neutral"; +} + +function backoffDelayMs(attemptIndex: number, options: NormalizedPollOptions): number { + const exponent = Math.min(10, Math.max(0, attemptIndex)); + return Math.min(options.maxIntervalMs, options.minIntervalMs * 2 ** exponent); +} + +async function fetchHeadSha(target: { owner: string; repo: string }, prNumber: number, options: NormalizedPollOptions): Promise { + const payload = await githubGetJson( + apiUrl(options.apiBaseUrl, repoPath(target, `/pulls/${prNumber}`)), + options, + ); + const record = payload as { head?: { sha?: unknown } } | null; + const headSha = record?.head?.sha; + if (typeof headSha !== "string" || !headSha) throw new Error("github_pr_head_sha_missing"); + return headSha; +} + +async function fetchCheckRuns(target: { owner: string; repo: string }, headSha: string, options: NormalizedPollOptions): Promise { + const checks: NormalizedCheckRun[] = []; + let page = 1; + let expectedTotalCount: number | null = null; + for (;;) { + const { payload, response } = await githubGetJsonResponse( + apiUrl( + options.apiBaseUrl, + repoPath(target, `/commits/${encodeURIComponent(headSha)}/check-runs`), + `?per_page=100&page=${page}`, + ), + options, + ); + const record = payload as { check_runs?: unknown } | null; + if (!Array.isArray(record?.check_runs)) { + throw new Error("github_check_runs_malformed"); + } + const pageChecks = record.check_runs.map(normalizeCheckRun); + checks.push(...pageChecks); + expectedTotalCount = payloadTotalCount(payload) ?? expectedTotalCount; + if (!hasNextLink(response) && (expectedTotalCount === null || checks.length >= expectedTotalCount)) { + return checks; + } + if (pageChecks.length === 0) { + throw new Error("github_check_runs_pagination_incomplete"); + } + page += 1; + } +} + +export async function pollCheckRuns(repoFullName: string, prNumber: number, options: PollCheckRunsOptions = {}): Promise { + const target = parseRepoFullName(repoFullName); + const normalizedPrNumber = normalizePullNumber(prNumber); + const normalizedOptions = normalizeOptions(options); + + let latest: PollCheckRunsResult = { conclusion: "pending", checks: [], headSha: "", attempts: 0 }; + for (let attempt = 0; attempt < normalizedOptions.maxAttempts; attempt += 1) { + const headSha = await fetchHeadSha(target, normalizedPrNumber, normalizedOptions); + const checks = await fetchCheckRuns(target, headSha, normalizedOptions); + latest = { + conclusion: aggregateConclusion(checks), + checks, + headSha, + attempts: attempt + 1, + }; + if (latest.conclusion !== "pending") { + const currentHeadSha = await fetchHeadSha(target, normalizedPrNumber, normalizedOptions); + if (currentHeadSha === headSha) { + return latest; + } + latest = { + conclusion: "pending", + checks: [], + headSha: currentHeadSha, + attempts: attempt + 1, + }; + } + if (attempt === normalizedOptions.maxAttempts - 1) { + return latest; + } + await normalizedOptions.sleepFn(backoffDelayMs(attempt, normalizedOptions)); + } + + // Unreachable at runtime: normalizeOptions clamps maxAttempts to a minimum of 1 (normalizePositiveInt's own + // `min` argument), so the loop above always returns internally on its final iteration (line 267 or 277). + // Kept only because TypeScript's control-flow analysis can't see that runtime guarantee through the loop. + return latest; +} diff --git a/packages/loopover-miner/lib/coding-task-spec.d.ts b/packages/loopover-miner/lib/coding-task-spec.d.ts index 3398e8696d..0e797df00c 100644 --- a/packages/loopover-miner/lib/coding-task-spec.d.ts +++ b/packages/loopover-miner/lib/coding-task-spec.d.ts @@ -1,47 +1,75 @@ import type { AcceptanceCriteria, FeasibilityGateResult, FeasibilityVerdict, IssueRecord, PullRequestRecord } from "@loopover/engine"; import type { RepoStackResult } from "./stack-detection.js"; - -export type CodingTaskIssue = { number: number; title: string; body?: string | null | undefined; labels?: string[] | undefined }; - +export type CodingTaskIssue = { + number: number; + title: string; + body?: string | null | undefined; + labels?: string[] | undefined; +}; export type CodingTaskClaimLedger = { - listClaims(filter: { repoFullName: string; status: string }): Array<{ issueNumber: number }>; + listClaims(filter: { + repoFullName: string; + status: string; + }): Array<{ + issueNumber: number; + }>; +}; +export type CodingTaskContext = { + issues: IssueRecord[]; + pullRequests: PullRequestRecord[]; +}; +/** + * Compute the feasibility verdict for one target issue, from real signals: whether the issue is present in + * the fetched context, its real claim status (the claim ledger), and its real duplicate-cluster risk + * (buildCollisionReport over the fetched issues/pullRequests). issueStatus is left to its documented + * "ready" default -- see this file's header for why that's honest, not fabricated. + */ +export declare function buildCodingTaskFeasibility(repoFullName: string, issue: CodingTaskIssue, context: CodingTaskContext, claimLedger: CodingTaskClaimLedger): FeasibilityGateResult; +/** + * Compose the immutable AcceptanceCriteria document for one target issue + its feasibility verdict. + */ +export declare function buildCodingTaskAcceptanceCriteria(issue: CodingTaskIssue, feasibility: FeasibilityGateResult): AcceptanceCriteria; +/** + * Write the acceptance-criteria document into the prepared worktree -- only when its own verdict authorizes + * it (shouldWriteAcceptanceCriteria: verdict === "go"). A raise/avoid verdict writes nothing; the caller is + * expected to abandon the attempt rather than start it, per acceptance-criteria.ts's own documented design. + */ +export declare function writeAcceptanceCriteriaFile(workingDirectory: string, acceptanceCriteria: AcceptanceCriteria): { + written: boolean; + path: string | null; }; - -export type CodingTaskContext = { issues: IssueRecord[]; pullRequests: PullRequestRecord[] }; - -export function buildCodingTaskFeasibility( - repoFullName: string, - issue: CodingTaskIssue, - context: CodingTaskContext, - claimLedger: CodingTaskClaimLedger, -): FeasibilityGateResult; - -export function buildCodingTaskAcceptanceCriteria(issue: CodingTaskIssue, feasibility: FeasibilityGateResult): AcceptanceCriteria; - -export function writeAcceptanceCriteriaFile(workingDirectory: string, acceptanceCriteria: AcceptanceCriteria): { written: boolean; path: string | null }; - export type CodingTaskSpecInput = { - repoFullName: string; - issue: CodingTaskIssue; - context: CodingTaskContext; - claimLedger: CodingTaskClaimLedger; - workingDirectory: string; - /** Injectable stack detector (#4786); omitted falls back to stack-detection.js's real `detectRepoStack`. */ - detectRepoStack?: (repoPath: string) => RepoStackResult; + repoFullName: string; + issue: CodingTaskIssue; + context: CodingTaskContext; + claimLedger: CodingTaskClaimLedger; + workingDirectory: string; + /** Injectable stack detector (#4786); omitted falls back to stack-detection.js's real `detectRepoStack`. */ + detectRepoStack?: (repoPath: string) => RepoStackResult; +}; +export type CodingTaskSpecResult = { + ready: false; + verdict: FeasibilityVerdict; + feasibility: FeasibilityGateResult; +} | { + ready: true; + verdict: FeasibilityVerdict; + feasibility: FeasibilityGateResult; + acceptanceCriteriaPath: string; + instructions: string; + title: string; + body: string | undefined; + labels: string[] | undefined; + linkedIssues: number[]; }; - -export type CodingTaskSpecResult = - | { ready: false; verdict: FeasibilityVerdict; feasibility: FeasibilityGateResult } - | { - ready: true; - verdict: FeasibilityVerdict; - feasibility: FeasibilityGateResult; - acceptanceCriteriaPath: string; - instructions: string; - title: string; - body: string | undefined; - labels: string[] | undefined; - linkedIssues: number[]; - }; - -export function buildCodingTaskSpec(input: CodingTaskSpecInput): CodingTaskSpecResult; +/** + * Full composition: feasibility -> acceptance criteria -> (if authorized) write the file -> detect the + * target-repo stack (#4786) -> instructions. Returns `ready: false` (with the computed feasibility verdict, + * for the caller to report) when the verdict is `raise`/`avoid` -- the caller should abandon the attempt + * rather than proceed with no real acceptance-criteria file on disk. + * + * `detectRepoStack` is injectable so tests can assert both the detected and fail-closed undiscovered stack + * branches without depending on real filesystem probes; omitted falls back to stack-detection.js's real + * `detectRepoStack` (the production default). + */ +export declare function buildCodingTaskSpec(input: CodingTaskSpecInput): CodingTaskSpecResult; diff --git a/packages/loopover-miner/lib/coding-task-spec.js b/packages/loopover-miner/lib/coding-task-spec.js index 1071548910..63abe95adf 100644 --- a/packages/loopover-miner/lib/coding-task-spec.js +++ b/packages/loopover-miner/lib/coding-task-spec.js @@ -1,71 +1,29 @@ import { closeSync, constants as fsConstants, openSync, realpathSync, writeFileSync } from "node:fs"; import { isAbsolute, join, relative } from "node:path"; -import { - ACCEPTANCE_CRITERIA_FILENAME, - buildAcceptanceCriteria, - buildCollisionReport, - buildFeasibilityVerdict, - buildPromptPacket, - feasibilityInputFromPreStartCheck, - serializeAcceptanceCriteria, - shouldWriteAcceptanceCriteria, -} from "@loopover/engine"; +import { ACCEPTANCE_CRITERIA_FILENAME, buildAcceptanceCriteria, buildCollisionReport, buildFeasibilityVerdict, buildPromptPacket, feasibilityInputFromPreStartCheck, serializeAcceptanceCriteria, shouldWriteAcceptanceCriteria, } from "@loopover/engine"; import { neutralizePromptInjection } from "./prompt-injection-defense.js"; import { detectRepoStack, renderStackSummary } from "./stack-detection.js"; - -// Coding-task-spec builder (#5132, Wave 3.5 follow-up). The second gap discovered alongside #5132's CLI -// wiring: `IterateLoopInput.title`/`instructions`/`acceptanceCriteriaPath` had no builder anywhere in this -// package. `packages/loopover-engine/src/miner/acceptance-criteria.ts` already composes a PromptPacket + -// FeasibilityGateResult into an immutable AcceptanceCriteria document (and deliberately does NOT write it -- -// "actually writing it into the attempt's worktree is the worktree primitive's job", per its own header) -- -// this module is that caller: derives the four inputs from a real target issue + the already-fetched -// SelfReviewContext (#5145), then writes the file for real. -// -// issueStatus is intentionally left undefined when computing feasibility: buildIssueQualityReport (the only -// thing that could supply it) lives only in root src/signals/engine.ts and has never been extracted into -// @loopover/engine (same gap #5145's own header documents for `issueQuality`). This is not a -// fabrication -- feasibilityInputFromPreStartCheck's OWN documented default for a missing -// issueQualityStatus/lifecycle is "ready", the same honest-default precedent already established. -// -// Target-repo stack detection (#4786 / #4785 follow-up): `detectRepoStack` already returned a structured -// language/package-manager/command description, but nothing in the attempt path consumed it -- instructions -// were issue text + an acceptance-criteria path only. This module now appends that real stack summary (and -// any confidently-inferred validation commands) to the coding-agent prompt so the agent validates against -// THIS repository's tooling rather than assuming LoopOver/loopover CI, Codecov, or `npm run test:ci`. -// -// Prompt-injection defense (#4795): a target issue's title/body is a customer repo's own content -- on -// Rent-a-Loop, anyone who can open an issue on that repo can shape text the coding agent later reads as -// part of its own instructions. `neutralizePromptInjection` runs on both fields before they reach either -// the coding agent's instructions (buildInstructions) or the acceptance-criteria document's taskBrief -// (buildTaskBrief) -- the two places raw issue text is embedded into agent-facing prose. This is a -// DIFFERENT concern from prompt-packet.ts's sanitizePromptPacketField (already applied downstream to -// taskBrief via buildPromptPacket): that scrubs economic/identity terms and local paths, not -// manipulation-shaped instructions, so both layers run and neither substitutes for the other. - function buildTaskBrief(issue) { - const title = neutralizePromptInjection(issue.title).text; - const body = neutralizePromptInjection((issue.body ?? "").trim()).text; - return body ? `${title}\n\n${body}` : title; + const title = neutralizePromptInjection(issue.title).text; + const body = neutralizePromptInjection((issue.body ?? "").trim()).text; + return body ? `${title}\n\n${body}` : title; } - function buildConstraints(issue) { - if (!Array.isArray(issue.labels) || issue.labels.length === 0) return ""; - return `Labels on this issue: ${issue.labels.join(", ")}.`; + if (!Array.isArray(issue.labels) || issue.labels.length === 0) + return ""; + return `Labels on this issue: ${issue.labels.join(", ")}.`; } - function buildFeasibilityNotes(feasibility) { - return [feasibility.summary, ...feasibility.avoidReasons, ...feasibility.raiseReasons].join("\n"); + return [feasibility.summary, ...feasibility.avoidReasons, ...feasibility.raiseReasons].join("\n"); } - // Only ever resolves to "claimed"/"unclaimed": the claim ledger's own ClaimStatus vocabulary // ("active"|"released"|"expired") has no "solved" concept for FeasibilityClaimStatus's "solved" value to // map from -- that would need real evidence a PR already resolved the issue (e.g. a merged, linked PR), // which this function doesn't have access to. Not fabricated; genuinely undetectable from claim data alone. function resolveClaimStatus(claimLedger, repoFullName, issueNumber) { - const claims = claimLedger.listClaims({ repoFullName, status: "active" }); - return claims.some((claim) => claim.issueNumber === issueNumber) ? "claimed" : "unclaimed"; + const claims = claimLedger.listClaims({ repoFullName, status: "active" }); + return claims.some((claim) => claim.issueNumber === issueNumber) ? "claimed" : "unclaimed"; } - // The target issue's own raw cluster risk from buildCollisionReport (newly exported from // @loopover/engine's public barrel) -- "none" when the issue isn't part of any cluster at all. // DELIBERATELY does NOT apply #5145's ">= 2 pull_request items" threshold: that gate exists specifically to @@ -75,114 +33,91 @@ function resolveClaimStatus(claimLedger, repoFullName, issueNumber) { // against it (buildCollisionReport's pairwise "shared linked issue" rule, which fires at "high" for exactly // one PR) is a meaningful, real caution signal, not a false positive to filter out. function resolveDuplicateClusterRisk(repoFullName, issues, pullRequests, issueNumber) { - const report = buildCollisionReport(repoFullName, issues, pullRequests); - const cluster = report.clusters.find((entry) => entry.items.some((item) => item.type === "issue" && item.number === issueNumber)); - return cluster ? cluster.risk : "none"; + const report = buildCollisionReport(repoFullName, issues, pullRequests); + const cluster = report.clusters.find((entry) => entry.items.some((item) => item.type === "issue" && item.number === issueNumber)); + return cluster ? cluster.risk : "none"; } - /** * Compute the feasibility verdict for one target issue, from real signals: whether the issue is present in * the fetched context, its real claim status (the claim ledger), and its real duplicate-cluster risk * (buildCollisionReport over the fetched issues/pullRequests). issueStatus is left to its documented * "ready" default -- see this file's header for why that's honest, not fabricated. - * - * @param {string} repoFullName - * @param {{ number: number }} issue - * @param {{ issues: Array<{ number: number }>, pullRequests: unknown[] }} context - * @param {{ listClaims: (filter: { repoFullName: string, status: string }) => Array<{ issueNumber: number }> }} claimLedger - * @returns {import("@loopover/engine").FeasibilityGateResult} */ export function buildCodingTaskFeasibility(repoFullName, issue, context, claimLedger) { - const found = context.issues.some((candidate) => candidate.number === issue.number); - const claimStatus = resolveClaimStatus(claimLedger, repoFullName, issue.number); - const duplicateClusterRisk = resolveDuplicateClusterRisk(repoFullName, context.issues, context.pullRequests, issue.number); - const feasibilityInput = feasibilityInputFromPreStartCheck({ found, claimStatus, duplicateClusterRisk }); - return buildFeasibilityVerdict(feasibilityInput); + const found = context.issues.some((candidate) => candidate.number === issue.number); + const claimStatus = resolveClaimStatus(claimLedger, repoFullName, issue.number); + const duplicateClusterRisk = resolveDuplicateClusterRisk(repoFullName, context.issues, context.pullRequests, issue.number); + const feasibilityInput = feasibilityInputFromPreStartCheck({ found, claimStatus, duplicateClusterRisk }); + return buildFeasibilityVerdict(feasibilityInput); } - /** * Compose the immutable AcceptanceCriteria document for one target issue + its feasibility verdict. - * - * @param {{ title: string, body?: string | null, labels?: string[] }} issue - * @param {import("@loopover/engine").FeasibilityGateResult} feasibility - * @returns {import("@loopover/engine").AcceptanceCriteria} */ export function buildCodingTaskAcceptanceCriteria(issue, feasibility) { - const promptPacket = buildPromptPacket({ - taskBrief: buildTaskBrief(issue), - constraints: buildConstraints(issue), - feasibilityNotes: buildFeasibilityNotes(feasibility), - retrievalContext: "", - }); - return buildAcceptanceCriteria({ promptPacket, feasibility }); + const promptPacket = buildPromptPacket({ + taskBrief: buildTaskBrief(issue), + constraints: buildConstraints(issue), + feasibilityNotes: buildFeasibilityNotes(feasibility), + retrievalContext: "", + }); + return buildAcceptanceCriteria({ promptPacket, feasibility }); +} +function assertContainedPath(root, path) { + const relativePath = relative(root, path); + if (relativePath === "" || (!relativePath.startsWith("..") && !isAbsolute(relativePath))) + return; + throw new Error(`Refusing to write acceptance criteria outside the worktree: ${path}`); } - /** * Write the acceptance-criteria document into the prepared worktree -- only when its own verdict authorizes * it (shouldWriteAcceptanceCriteria: verdict === "go"). A raise/avoid verdict writes nothing; the caller is * expected to abandon the attempt rather than start it, per acceptance-criteria.ts's own documented design. - * - * @param {string} workingDirectory - * @param {import("@loopover/engine").AcceptanceCriteria} acceptanceCriteria - * @returns {{ written: boolean, path: string | null }} */ -function assertContainedPath(root, path) { - const relativePath = relative(root, path); - if (relativePath === "" || (!relativePath.startsWith("..") && !isAbsolute(relativePath))) return; - throw new Error(`Refusing to write acceptance criteria outside the worktree: ${path}`); -} - export function writeAcceptanceCriteriaFile(workingDirectory, acceptanceCriteria) { - if (!shouldWriteAcceptanceCriteria(acceptanceCriteria.verdict)) return { written: false, path: null }; - const root = realpathSync(workingDirectory); - const path = join(root, ACCEPTANCE_CRITERIA_FILENAME); - assertContainedPath(root, path); - - let fd; - try { - fd = openSync(path, fsConstants.O_WRONLY | fsConstants.O_CREAT | fsConstants.O_EXCL | fsConstants.O_NOFOLLOW, 0o600); - writeFileSync(fd, serializeAcceptanceCriteria(acceptanceCriteria), "utf8"); - } finally { - if (fd !== undefined) closeSync(fd); - } - - return { written: true, path }; + if (!shouldWriteAcceptanceCriteria(acceptanceCriteria.verdict)) + return { written: false, path: null }; + const root = realpathSync(workingDirectory); + const path = join(root, ACCEPTANCE_CRITERIA_FILENAME); + assertContainedPath(root, path); + let fd; + try { + fd = openSync(path, fsConstants.O_WRONLY | fsConstants.O_CREAT | fsConstants.O_EXCL | fsConstants.O_NOFOLLOW, 0o600); + writeFileSync(fd, serializeAcceptanceCriteria(acceptanceCriteria), "utf8"); + } + finally { + if (fd !== undefined) + closeSync(fd); + } + return { written: true, path }; } - /** * Prompt guidance derived from a real `detectRepoStack` result (#4786). Lists only commands the detector * confidently inferred -- a `null` command stays omitted rather than guessed -- and always tells the agent * not to assume LoopOver/loopover's own CI/coverage conventions. - * - * @param {import("./stack-detection.js").RepoStackResult} stack - * @returns {string} */ function buildValidationGuidance(stack) { - const lines = [ - `Detected target-repo stack: ${renderStackSummary(stack)}`, - "", - "Validate your change with THIS repository's own build/test/lint tooling from the stack summary above.", - "Do not assume LoopOver/loopover CI conventions, Codecov patch coverage, or `npm run test:ci` unless those commands appear in the detected stack.", - ]; - if (stack?.detected === true) { - const commands = [ - stack.testCommand ? `- test: \`${stack.testCommand}\`` : null, - stack.lintCommand ? `- lint: \`${stack.lintCommand}\`` : null, - stack.buildCommand ? `- build: \`${stack.buildCommand}\`` : null, - stack.formatCommand ? `- format: \`${stack.formatCommand}\`` : null, - ].filter((entry) => entry !== null); - if (commands.length > 0) { - lines.push("", "Run these commands before finishing:", ...commands); - } else { - lines.push( + const lines = [ + `Detected target-repo stack: ${renderStackSummary(stack)}`, "", - "No build/test/lint/format commands were confidently inferred — discover and use this repo's own tooling rather than guessing.", - ); + "Validate your change with THIS repository's own build/test/lint tooling from the stack summary above.", + "Do not assume LoopOver/loopover CI conventions, Codecov patch coverage, or `npm run test:ci` unless those commands appear in the detected stack.", + ]; + if (stack?.detected === true) { + const commands = [ + stack.testCommand ? `- test: \`${stack.testCommand}\`` : null, + stack.lintCommand ? `- lint: \`${stack.lintCommand}\`` : null, + stack.buildCommand ? `- build: \`${stack.buildCommand}\`` : null, + stack.formatCommand ? `- format: \`${stack.formatCommand}\`` : null, + ].filter((entry) => entry !== null); + if (commands.length > 0) { + lines.push("", "Run these commands before finishing:", ...commands); + } + else { + lines.push("", "No build/test/lint/format commands were confidently inferred — discover and use this repo's own tooling rather than guessing."); + } } - } - return lines.join("\n"); + return lines.join("\n"); } - /** * The coding-agent driver's own prompt text (agent-sdk-driver.ts's header: "forwarded verbatim as the * prompt -- the acceptance-criteria document already lives inside the worktree", so this points to it @@ -192,34 +127,27 @@ function buildValidationGuidance(stack) { * The issue's title/body are neutralized against prompt-injection (#4795) before embedding -- this is the * literal `prompt:` handoff to the coding agent (agent-sdk-driver.ts), so it's the primary place untrusted * repo content could otherwise redirect agent behavior. - * - * @param {{ number: number, title: string, body?: string | null }} issue - * @param {string} acceptanceCriteriaPath - * @param {import("./stack-detection.js").RepoStackResult} stack */ function buildInstructions(issue, acceptanceCriteriaPath, stack) { - const title = neutralizePromptInjection(issue.title); - const body = neutralizePromptInjection((issue.body ?? "").trim()); - if (title.injected || body.injected) { - console.log( - JSON.stringify({ - event: "prompt_injection_neutralized", - issueNumber: issue.number, - fields: [title.injected ? "title" : null, body.injected ? "body" : null].filter(Boolean), - }), - ); - } - return [ - `Resolve the following GitHub issue in this repository: #${issue.number} -- ${title.text}`, - "", - body.text, - "", - `A structured acceptance-criteria document describing what "done" means for this attempt is at ${acceptanceCriteriaPath} -- read it and ensure your change satisfies every criterion before finishing.`, - "", - buildValidationGuidance(stack), - ].join("\n"); + const title = neutralizePromptInjection(issue.title); + const body = neutralizePromptInjection((issue.body ?? "").trim()); + if (title.injected || body.injected) { + console.log(JSON.stringify({ + event: "prompt_injection_neutralized", + issueNumber: issue.number, + fields: [title.injected ? "title" : null, body.injected ? "body" : null].filter(Boolean), + })); + } + return [ + `Resolve the following GitHub issue in this repository: #${issue.number} -- ${title.text}`, + "", + body.text, + "", + `A structured acceptance-criteria document describing what "done" means for this attempt is at ${acceptanceCriteriaPath} -- read it and ensure your change satisfies every criterion before finishing.`, + "", + buildValidationGuidance(stack), + ].join("\n"); } - /** * Full composition: feasibility -> acceptance criteria -> (if authorized) write the file -> detect the * target-repo stack (#4786) -> instructions. Returns `ready: false` (with the computed feasibility verdict, @@ -229,40 +157,29 @@ function buildInstructions(issue, acceptanceCriteriaPath, stack) { * `detectRepoStack` is injectable so tests can assert both the detected and fail-closed undiscovered stack * branches without depending on real filesystem probes; omitted falls back to stack-detection.js's real * `detectRepoStack` (the production default). - * - * @param {{ - * repoFullName: string, issue: { number: number, title: string, body?: string | null, labels?: string[] }, - * context: { issues: Array<{ number: number }>, pullRequests: unknown[] }, - * claimLedger: { listClaims: (filter: { repoFullName: string, status: string }) => Array<{ issueNumber: number }> }, - * workingDirectory: string, - * detectRepoStack?: (repoPath: string) => import("./stack-detection.js").RepoStackResult, - * }} input - * @returns {import("./coding-task-spec.js").CodingTaskSpecResult} */ export function buildCodingTaskSpec(input) { - const feasibility = buildCodingTaskFeasibility(input.repoFullName, input.issue, input.context, input.claimLedger); - const acceptanceCriteria = buildCodingTaskAcceptanceCriteria(input.issue, feasibility); - const writeResult = writeAcceptanceCriteriaFile(input.workingDirectory, acceptanceCriteria); - - if (!writeResult.written) { - return { ready: false, verdict: feasibility.verdict, feasibility }; - } - - // Real target-repo stack (#4786): detected from the prepared worktree's own manifests, not guessed from - // loopover conventions. Fail-closed `{ detected: false }` results still reach the prompt (via - // renderStackSummary) so the agent is told detection failed rather than silently defaulting to npm/Codecov. - const detect = input.detectRepoStack ?? detectRepoStack; - const stack = detect(input.workingDirectory); - - return { - ready: true, - verdict: feasibility.verdict, - feasibility, - acceptanceCriteriaPath: writeResult.path, - instructions: buildInstructions(input.issue, writeResult.path, stack), - title: input.issue.title, - body: input.issue.body ?? undefined, - labels: input.issue.labels, - linkedIssues: [input.issue.number], - }; + const feasibility = buildCodingTaskFeasibility(input.repoFullName, input.issue, input.context, input.claimLedger); + const acceptanceCriteria = buildCodingTaskAcceptanceCriteria(input.issue, feasibility); + const writeResult = writeAcceptanceCriteriaFile(input.workingDirectory, acceptanceCriteria); + if (!writeResult.written) { + return { ready: false, verdict: feasibility.verdict, feasibility }; + } + // Real target-repo stack (#4786): detected from the prepared worktree's own manifests, not guessed from + // loopover conventions. Fail-closed `{ detected: false }` results still reach the prompt (via + // renderStackSummary) so the agent is told detection failed rather than silently defaulting to npm/Codecov. + const detect = input.detectRepoStack ?? detectRepoStack; + const stack = detect(input.workingDirectory); + return { + ready: true, + verdict: feasibility.verdict, + feasibility, + acceptanceCriteriaPath: writeResult.path, + instructions: buildInstructions(input.issue, writeResult.path, stack), + title: input.issue.title, + body: input.issue.body ?? undefined, + labels: input.issue.labels, + linkedIssues: [input.issue.number], + }; } +//# sourceMappingURL=data:application/json;base64,{"version":3,"file":"coding-task-spec.js","sourceRoot":"","sources":["coding-task-spec.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,SAAS,EAAE,SAAS,IAAI,WAAW,EAAE,QAAQ,EAAE,YAAY,EAAE,aAAa,EAAE,MAAM,SAAS,CAAC;AACrG,OAAO,EAAE,UAAU,EAAE,IAAI,EAAE,QAAQ,EAAE,MAAM,WAAW,CAAC;AACvD,OAAO,EACL,4BAA4B,EAC5B,uBAAuB,EACvB,oBAAoB,EACpB,uBAAuB,EACvB,iBAAiB,EACjB,iCAAiC,EACjC,2BAA2B,EAC3B,6BAA6B,GAC9B,MAAM,kBAAkB,CAAC;AAE1B,OAAO,EAAE,yBAAyB,EAAE,MAAM,+BAA+B,CAAC;AAC1E,OAAO,EAAE,eAAe,EAAE,kBAAkB,EAAE,MAAM,sBAAsB,CAAC;AAwC3E,SAAS,cAAc,CAAC,KAAsB;IAC5C,MAAM,KAAK,GAAG,yBAAyB,CAAC,KAAK,CAAC,KAAK,CAAC,CAAC,IAAI,CAAC;IAC1D,MAAM,IAAI,GAAG,yBAAyB,CAAC,CAAC,KAAK,CAAC,IAAI,IAAI,EAAE,CAAC,CAAC,IAAI,EAAE,CAAC,CAAC,IAAI,CAAC;IACvE,OAAO,IAAI,CAAC,CAAC,CAAC,GAAG,KAAK,OAAO,IAAI,EAAE,CAAC,CAAC,CAAC,KAAK,CAAC;AAC9C,CAAC;AAED,SAAS,gBAAgB,CAAC,KAAsB;IAC9C,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,KAAK,CAAC,MAAM,CAAC,IAAI,KAAK,CAAC,MAAM,CAAC,MAAM,KAAK,CAAC;QAAE,OAAO,EAAE,CAAC;IACzE,OAAO,yBAAyB,KAAK,CAAC,MAAM,CAAC,IAAI,CAAC,IAAI,CAAC,GAAG,CAAC;AAC7D,CAAC;AAED,SAAS,qBAAqB,CAAC,WAAkC;IAC/D,OAAO,CAAC,WAAW,CAAC,OAAO,EAAE,GAAG,WAAW,CAAC,YAAY,EAAE,GAAG,WAAW,CAAC,YAAY,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;AACpG,CAAC;AAED,6FAA6F;AAC7F,yGAAyG;AACzG,wGAAwG;AACxG,4GAA4G;AAC5G,SAAS,kBAAkB,CAAC,WAAkC,EAAE,YAAoB,EAAE,WAAmB;IACvG,MAAM,MAAM,GAAG,WAAW,CAAC,UAAU,CAAC,EAAE,YAAY,EAAE,MAAM,EAAE,QAAQ,EAAE,CAAC,CAAC;IAC1E,OAAO,MAAM,CAAC,IAAI,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,WAAW,KAAK,WAAW,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC,CAAC,CAAC,WAAW,CAAC;AAC7F,CAAC;AAED,yFAAyF;AACzF,+FAA+F;AAC/F,4GAA4G;AAC5G,6GAA6G;AAC7G,4GAA4G;AAC5G,uGAAuG;AACvG,4GAA4G;AAC5G,oFAAoF;AACpF,SAAS,2BAA2B,CAClC,YAAoB,EACpB,MAAqB,EACrB,YAAiC,EACjC,WAAmB;IAEnB,MAAM,MAAM,GAAG,oBAAoB,CAAC,YAAY,EAAE,MAAM,EAAE,YAAY,CAAC,CAAC;IACxE,MAAM,OAAO,GAAG,MAAM,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,IAAI,CAAC,IAAI,KAAK,OAAO,IAAI,IAAI,CAAC,MAAM,KAAK,WAAW,CAAC,CAAC,CAAC;IAClI,OAAO,OAAO,CAAC,CAAC,CAAC,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,MAAM,CAAC;AACzC,CAAC;AAED;;;;;GAKG;AACH,MAAM,UAAU,0BAA0B,CACxC,YAAoB,EACpB,KAAsB,EACtB,OAA0B,EAC1B,WAAkC;IAElC,MAAM,KAAK,GAAG,OAAO,CAAC,MAAM,CAAC,IAAI,CAAC,CAAC,SAAS,EAAE,EAAE,CAAC,SAAS,CAAC,MAAM,KAAK,KAAK,CAAC,MAAM,CAAC,CAAC;IACpF,MAAM,WAAW,GAAG,kBAAkB,CAAC,WAAW,EAAE,YAAY,EAAE,KAAK,CAAC,MAAM,CAAC,CAAC;IAChF,MAAM,oBAAoB,GAAG,2BAA2B,CAAC,YAAY,EAAE,OAAO,CAAC,MAAM,EAAE,OAAO,CAAC,YAAY,EAAE,KAAK,CAAC,MAAM,CAAC,CAAC;IAC3H,MAAM,gBAAgB,GAAG,iCAAiC,CAAC,EAAE,KAAK,EAAE,WAAW,EAAE,oBAAoB,EAAE,CAAC,CAAC;IACzG,OAAO,uBAAuB,CAAC,gBAAgB,CAAC,CAAC;AACnD,CAAC;AAED;;GAEG;AACH,MAAM,UAAU,iCAAiC,CAAC,KAAsB,EAAE,WAAkC;IAC1G,MAAM,YAAY,GAAG,iBAAiB,CAAC;QACrC,SAAS,EAAE,cAAc,CAAC,KAAK,CAAC;QAChC,WAAW,EAAE,gBAAgB,CAAC,KAAK,CAAC;QACpC,gBAAgB,EAAE,qBAAqB,CAAC,WAAW,CAAC;QACpD,gBAAgB,EAAE,EAAE;KACrB,CAAC,CAAC;IACH,OAAO,uBAAuB,CAAC,EAAE,YAAY,EAAE,WAAW,EAAE,CAAC,CAAC;AAChE,CAAC;AAED,SAAS,mBAAmB,CAAC,IAAY,EAAE,IAAY;IACrD,MAAM,YAAY,GAAG,QAAQ,CAAC,IAAI,EAAE,IAAI,CAAC,CAAC;IAC1C,IAAI,YAAY,KAAK,EAAE,IAAI,CAAC,CAAC,YAAY,CAAC,UAAU,CAAC,IAAI,CAAC,IAAI,CAAC,UAAU,CAAC,YAAY,CAAC,CAAC;QAAE,OAAO;IACjG,MAAM,IAAI,KAAK,CAAC,+DAA+D,IAAI,EAAE,CAAC,CAAC;AACzF,CAAC;AAED;;;;GAIG;AACH,MAAM,UAAU,2BAA2B,CAAC,gBAAwB,EAAE,kBAAsC;IAC1G,IAAI,CAAC,6BAA6B,CAAC,kBAAkB,CAAC,OAAO,CAAC;QAAE,OAAO,EAAE,OAAO,EAAE,KAAK,EAAE,IAAI,EAAE,IAAI,EAAE,CAAC;IACtG,MAAM,IAAI,GAAG,YAAY,CAAC,gBAAgB,CAAC,CAAC;IAC5C,MAAM,IAAI,GAAG,IAAI,CAAC,IAAI,EAAE,4BAA4B,CAAC,CAAC;IACtD,mBAAmB,CAAC,IAAI,EAAE,IAAI,CAAC,CAAC;IAEhC,IAAI,EAAsB,CAAC;IAC3B,IAAI,CAAC;QACH,EAAE,GAAG,QAAQ,CAAC,IAAI,EAAE,WAAW,CAAC,QAAQ,GAAG,WAAW,CAAC,OAAO,GAAG,WAAW,CAAC,MAAM,GAAG,WAAW,CAAC,UAAU,EAAE,KAAK,CAAC,CAAC;QACrH,aAAa,CAAC,EAAE,EAAE,2BAA2B,CAAC,kBAAkB,CAAC,EAAE,MAAM,CAAC,CAAC;IAC7E,CAAC;YAAS,CAAC;QACT,IAAI,EAAE,KAAK,SAAS;YAAE,SAAS,CAAC,EAAE,CAAC,CAAC;IACtC,CAAC;IAED,OAAO,EAAE,OAAO,EAAE,IAAI,EAAE,IAAI,EAAE,CAAC;AACjC,CAAC;AAED;;;;GAIG;AACH,SAAS,uBAAuB,CAAC,KAAsB;IACrD,MAAM,KAAK,GAAG;QACZ,+BAA+B,kBAAkB,CAAC,KAAK,CAAC,EAAE;QAC1D,EAAE;QACF,uGAAuG;QACvG,kJAAkJ;KACnJ,CAAC;IACF,IAAI,KAAK,EAAE,QAAQ,KAAK,IAAI,EAAE,CAAC;QAC7B,MAAM,QAAQ,GAAG;YACf,KAAK,CAAC,WAAW,CAAC,CAAC,CAAC,aAAa,KAAK,CAAC,WAAW,IAAI,CAAC,CAAC,CAAC,IAAI;YAC7D,KAAK,CAAC,WAAW,CAAC,CAAC,CAAC,aAAa,KAAK,CAAC,WAAW,IAAI,CAAC,CAAC,CAAC,IAAI;YAC7D,KAAK,CAAC,YAAY,CAAC,CAAC,CAAC,cAAc,KAAK,CAAC,YAAY,IAAI,CAAC,CAAC,CAAC,IAAI;YAChE,KAAK,CAAC,aAAa,CAAC,CAAC,CAAC,eAAe,KAAK,CAAC,aAAa,IAAI,CAAC,CAAC,CAAC,IAAI;SACpE,CAAC,MAAM,CAAC,CAAC,KAAK,EAAmB,EAAE,CAAC,KAAK,KAAK,IAAI,CAAC,CAAC;QACrD,IAAI,QAAQ,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;YACxB,KAAK,CAAC,IAAI,CAAC,EAAE,EAAE,sCAAsC,EAAE,GAAG,QAAQ,CAAC,CAAC;QACtE,CAAC;aAAM,CAAC;YACN,KAAK,CAAC,IAAI,CACR,EAAE,EACF,+HAA+H,CAChI,CAAC;QACJ,CAAC;IACH,CAAC;IACD,OAAO,KAAK,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;AAC1B,CAAC;AAED;;;;;;;;;GASG;AACH,SAAS,iBAAiB,CAAC,KAA0E,EAAE,sBAA8B,EAAE,KAAsB;IAC3J,MAAM,KAAK,GAAG,yBAAyB,CAAC,KAAK,CAAC,KAAK,CAAC,CAAC;IACrD,MAAM,IAAI,GAAG,yBAAyB,CAAC,CAAC,KAAK,CAAC,IAAI,IAAI,EAAE,CAAC,CAAC,IAAI,EAAE,CAAC,CAAC;IAClE,IAAI,KAAK,CAAC,QAAQ,IAAI,IAAI,CAAC,QAAQ,EAAE,CAAC;QACpC,OAAO,CAAC,GAAG,CACT,IAAI,CAAC,SAAS,CAAC;YACb,KAAK,EAAE,8BAA8B;YACrC,WAAW,EAAE,KAAK,CAAC,MAAM;YACzB,MAAM,EAAE,CAAC,KAAK,CAAC,QAAQ,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,CAAC,IAAI,EAAE,IAAI,CAAC,QAAQ,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,MAAM,CAAC,OAAO,CAAC;SACzF,CAAC,CACH,CAAC;IACJ,CAAC;IACD,OAAO;QACL,2DAA2D,KAAK,CAAC,MAAM,OAAO,KAAK,CAAC,IAAI,EAAE;QAC1F,EAAE;QACF,IAAI,CAAC,IAAI;QACT,EAAE;QACF,iGAAiG,sBAAsB,gFAAgF;QACvM,EAAE;QACF,uBAAuB,CAAC,KAAK,CAAC;KAC/B,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;AACf,CAAC;AA0BD;;;;;;;;;GASG;AACH,MAAM,UAAU,mBAAmB,CAAC,KAA0B;IAC5D,MAAM,WAAW,GAAG,0BAA0B,CAAC,KAAK,CAAC,YAAY,EAAE,KAAK,CAAC,KAAK,EAAE,KAAK,CAAC,OAAO,EAAE,KAAK,CAAC,WAAW,CAAC,CAAC;IAClH,MAAM,kBAAkB,GAAG,iCAAiC,CAAC,KAAK,CAAC,KAAK,EAAE,WAAW,CAAC,CAAC;IACvF,MAAM,WAAW,GAAG,2BAA2B,CAAC,KAAK,CAAC,gBAAgB,EAAE,kBAAkB,CAAC,CAAC;IAE5F,IAAI,CAAC,WAAW,CAAC,OAAO,EAAE,CAAC;QACzB,OAAO,EAAE,KAAK,EAAE,KAAK,EAAE,OAAO,EAAE,WAAW,CAAC,OAAO,EAAE,WAAW,EAAE,CAAC;IACrE,CAAC;IAED,wGAAwG;IACxG,8FAA8F;IAC9F,4GAA4G;IAC5G,MAAM,MAAM,GAAG,KAAK,CAAC,eAAe,IAAI,eAAe,CAAC;IACxD,MAAM,KAAK,GAAG,MAAM,CAAC,KAAK,CAAC,gBAAgB,CAAC,CAAC;IAE7C,OAAO;QACL,KAAK,EAAE,IAAI;QACX,OAAO,EAAE,WAAW,CAAC,OAAO;QAC5B,WAAW;QACX,sBAAsB,EAAE,WAAW,CAAC,IAAc;QAClD,YAAY,EAAE,iBAAiB,CAAC,KAAK,CAAC,KAAK,EAAE,WAAW,CAAC,IAAc,EAAE,KAAK,CAAC;QAC/E,KAAK,EAAE,KAAK,CAAC,KAAK,CAAC,KAAK;QACxB,IAAI,EAAE,KAAK,CAAC,KAAK,CAAC,IAAI,IAAI,SAAS;QACnC,MAAM,EAAE,KAAK,CAAC,KAAK,CAAC,MAAM;QAC1B,YAAY,EAAE,CAAC,KAAK,CAAC,KAAK,CAAC,MAAM,CAAC;KACnC,CAAC;AACJ,CAAC"} \ No newline at end of file diff --git a/packages/loopover-miner/lib/coding-task-spec.ts b/packages/loopover-miner/lib/coding-task-spec.ts new file mode 100644 index 0000000000..a6b3ca284a --- /dev/null +++ b/packages/loopover-miner/lib/coding-task-spec.ts @@ -0,0 +1,282 @@ +import { closeSync, constants as fsConstants, openSync, realpathSync, writeFileSync } from "node:fs"; +import { isAbsolute, join, relative } from "node:path"; +import { + ACCEPTANCE_CRITERIA_FILENAME, + buildAcceptanceCriteria, + buildCollisionReport, + buildFeasibilityVerdict, + buildPromptPacket, + feasibilityInputFromPreStartCheck, + serializeAcceptanceCriteria, + shouldWriteAcceptanceCriteria, +} from "@loopover/engine"; +import type { AcceptanceCriteria, FeasibilityGateResult, FeasibilityVerdict, IssueRecord, PullRequestRecord } from "@loopover/engine"; +import { neutralizePromptInjection } from "./prompt-injection-defense.js"; +import { detectRepoStack, renderStackSummary } from "./stack-detection.js"; +import type { RepoStackResult } from "./stack-detection.js"; + +// Coding-task-spec builder (#5132, Wave 3.5 follow-up). The second gap discovered alongside #5132's CLI +// wiring: `IterateLoopInput.title`/`instructions`/`acceptanceCriteriaPath` had no builder anywhere in this +// package. `packages/loopover-engine/src/miner/acceptance-criteria.ts` already composes a PromptPacket + +// FeasibilityGateResult into an immutable AcceptanceCriteria document (and deliberately does NOT write it -- +// "actually writing it into the attempt's worktree is the worktree primitive's job", per its own header) -- +// this module is that caller: derives the four inputs from a real target issue + the already-fetched +// SelfReviewContext (#5145), then writes the file for real. +// +// issueStatus is intentionally left undefined when computing feasibility: buildIssueQualityReport (the only +// thing that could supply it) lives only in root src/signals/engine.ts and has never been extracted into +// @loopover/engine (same gap #5145's own header documents for `issueQuality`). This is not a +// fabrication -- feasibilityInputFromPreStartCheck's OWN documented default for a missing +// issueQualityStatus/lifecycle is "ready", the same honest-default precedent already established. +// +// Target-repo stack detection (#4786 / #4785 follow-up): `detectRepoStack` already returned a structured +// language/package-manager/command description, but nothing in the attempt path consumed it -- instructions +// were issue text + an acceptance-criteria path only. This module now appends that real stack summary (and +// any confidently-inferred validation commands) to the coding-agent prompt so the agent validates against +// THIS repository's tooling rather than assuming LoopOver/loopover CI, Codecov, or `npm run test:ci`. +// +// Prompt-injection defense (#4795): a target issue's title/body is a customer repo's own content -- on +// Rent-a-Loop, anyone who can open an issue on that repo can shape text the coding agent later reads as +// part of its own instructions. `neutralizePromptInjection` runs on both fields before they reach either +// the coding agent's instructions (buildInstructions) or the acceptance-criteria document's taskBrief +// (buildTaskBrief) -- the two places raw issue text is embedded into agent-facing prose. This is a +// DIFFERENT concern from prompt-packet.ts's sanitizePromptPacketField (already applied downstream to +// taskBrief via buildPromptPacket): that scrubs economic/identity terms and local paths, not +// manipulation-shaped instructions, so both layers run and neither substitutes for the other. + +export type CodingTaskIssue = { number: number; title: string; body?: string | null | undefined; labels?: string[] | undefined }; + +export type CodingTaskClaimLedger = { + listClaims(filter: { repoFullName: string; status: string }): Array<{ issueNumber: number }>; +}; + +export type CodingTaskContext = { issues: IssueRecord[]; pullRequests: PullRequestRecord[] }; + +function buildTaskBrief(issue: CodingTaskIssue): string { + const title = neutralizePromptInjection(issue.title).text; + const body = neutralizePromptInjection((issue.body ?? "").trim()).text; + return body ? `${title}\n\n${body}` : title; +} + +function buildConstraints(issue: CodingTaskIssue): string { + if (!Array.isArray(issue.labels) || issue.labels.length === 0) return ""; + return `Labels on this issue: ${issue.labels.join(", ")}.`; +} + +function buildFeasibilityNotes(feasibility: FeasibilityGateResult): string { + return [feasibility.summary, ...feasibility.avoidReasons, ...feasibility.raiseReasons].join("\n"); +} + +// Only ever resolves to "claimed"/"unclaimed": the claim ledger's own ClaimStatus vocabulary +// ("active"|"released"|"expired") has no "solved" concept for FeasibilityClaimStatus's "solved" value to +// map from -- that would need real evidence a PR already resolved the issue (e.g. a merged, linked PR), +// which this function doesn't have access to. Not fabricated; genuinely undetectable from claim data alone. +function resolveClaimStatus(claimLedger: CodingTaskClaimLedger, repoFullName: string, issueNumber: number): "claimed" | "unclaimed" { + const claims = claimLedger.listClaims({ repoFullName, status: "active" }); + return claims.some((claim) => claim.issueNumber === issueNumber) ? "claimed" : "unclaimed"; +} + +// The target issue's own raw cluster risk from buildCollisionReport (newly exported from +// @loopover/engine's public barrel) -- "none" when the issue isn't part of any cluster at all. +// DELIBERATELY does NOT apply #5145's ">= 2 pull_request items" threshold: that gate exists specifically to +// stop inDuplicateCluster (self-review, "does MY OWN just-created submission look redundant") from firing on +// the ordinary case of one existing PR already legitimately closing the issue. Feasibility asks a different +// question -- "should I even START working on this issue" -- where an issue already having ANY open PR +// against it (buildCollisionReport's pairwise "shared linked issue" rule, which fires at "high" for exactly +// one PR) is a meaningful, real caution signal, not a false positive to filter out. +function resolveDuplicateClusterRisk( + repoFullName: string, + issues: IssueRecord[], + pullRequests: PullRequestRecord[], + issueNumber: number, +): "none" | "low" | "medium" | "high" { + const report = buildCollisionReport(repoFullName, issues, pullRequests); + const cluster = report.clusters.find((entry) => entry.items.some((item) => item.type === "issue" && item.number === issueNumber)); + return cluster ? cluster.risk : "none"; +} + +/** + * Compute the feasibility verdict for one target issue, from real signals: whether the issue is present in + * the fetched context, its real claim status (the claim ledger), and its real duplicate-cluster risk + * (buildCollisionReport over the fetched issues/pullRequests). issueStatus is left to its documented + * "ready" default -- see this file's header for why that's honest, not fabricated. + */ +export function buildCodingTaskFeasibility( + repoFullName: string, + issue: CodingTaskIssue, + context: CodingTaskContext, + claimLedger: CodingTaskClaimLedger, +): FeasibilityGateResult { + const found = context.issues.some((candidate) => candidate.number === issue.number); + const claimStatus = resolveClaimStatus(claimLedger, repoFullName, issue.number); + const duplicateClusterRisk = resolveDuplicateClusterRisk(repoFullName, context.issues, context.pullRequests, issue.number); + const feasibilityInput = feasibilityInputFromPreStartCheck({ found, claimStatus, duplicateClusterRisk }); + return buildFeasibilityVerdict(feasibilityInput); +} + +/** + * Compose the immutable AcceptanceCriteria document for one target issue + its feasibility verdict. + */ +export function buildCodingTaskAcceptanceCriteria(issue: CodingTaskIssue, feasibility: FeasibilityGateResult): AcceptanceCriteria { + const promptPacket = buildPromptPacket({ + taskBrief: buildTaskBrief(issue), + constraints: buildConstraints(issue), + feasibilityNotes: buildFeasibilityNotes(feasibility), + retrievalContext: "", + }); + return buildAcceptanceCriteria({ promptPacket, feasibility }); +} + +function assertContainedPath(root: string, path: string): void { + const relativePath = relative(root, path); + if (relativePath === "" || (!relativePath.startsWith("..") && !isAbsolute(relativePath))) return; + throw new Error(`Refusing to write acceptance criteria outside the worktree: ${path}`); +} + +/** + * Write the acceptance-criteria document into the prepared worktree -- only when its own verdict authorizes + * it (shouldWriteAcceptanceCriteria: verdict === "go"). A raise/avoid verdict writes nothing; the caller is + * expected to abandon the attempt rather than start it, per acceptance-criteria.ts's own documented design. + */ +export function writeAcceptanceCriteriaFile(workingDirectory: string, acceptanceCriteria: AcceptanceCriteria): { written: boolean; path: string | null } { + if (!shouldWriteAcceptanceCriteria(acceptanceCriteria.verdict)) return { written: false, path: null }; + const root = realpathSync(workingDirectory); + const path = join(root, ACCEPTANCE_CRITERIA_FILENAME); + assertContainedPath(root, path); + + let fd: number | undefined; + try { + fd = openSync(path, fsConstants.O_WRONLY | fsConstants.O_CREAT | fsConstants.O_EXCL | fsConstants.O_NOFOLLOW, 0o600); + writeFileSync(fd, serializeAcceptanceCriteria(acceptanceCriteria), "utf8"); + } finally { + if (fd !== undefined) closeSync(fd); + } + + return { written: true, path }; +} + +/** + * Prompt guidance derived from a real `detectRepoStack` result (#4786). Lists only commands the detector + * confidently inferred -- a `null` command stays omitted rather than guessed -- and always tells the agent + * not to assume LoopOver/loopover's own CI/coverage conventions. + */ +function buildValidationGuidance(stack: RepoStackResult): string { + const lines = [ + `Detected target-repo stack: ${renderStackSummary(stack)}`, + "", + "Validate your change with THIS repository's own build/test/lint tooling from the stack summary above.", + "Do not assume LoopOver/loopover CI conventions, Codecov patch coverage, or `npm run test:ci` unless those commands appear in the detected stack.", + ]; + if (stack?.detected === true) { + const commands = [ + stack.testCommand ? `- test: \`${stack.testCommand}\`` : null, + stack.lintCommand ? `- lint: \`${stack.lintCommand}\`` : null, + stack.buildCommand ? `- build: \`${stack.buildCommand}\`` : null, + stack.formatCommand ? `- format: \`${stack.formatCommand}\`` : null, + ].filter((entry): entry is string => entry !== null); + if (commands.length > 0) { + lines.push("", "Run these commands before finishing:", ...commands); + } else { + lines.push( + "", + "No build/test/lint/format commands were confidently inferred — discover and use this repo's own tooling rather than guessing.", + ); + } + } + return lines.join("\n"); +} + +/** + * The coding-agent driver's own prompt text (agent-sdk-driver.ts's header: "forwarded verbatim as the + * prompt -- the acceptance-criteria document already lives inside the worktree", so this points to it + * rather than repeating its content). Also carries the target repo's detected stack + validation commands + * (#4786) so the agent does not default to loopover-specific CI assumptions. + * + * The issue's title/body are neutralized against prompt-injection (#4795) before embedding -- this is the + * literal `prompt:` handoff to the coding agent (agent-sdk-driver.ts), so it's the primary place untrusted + * repo content could otherwise redirect agent behavior. + */ +function buildInstructions(issue: { number: number; title: string; body?: string | null | undefined }, acceptanceCriteriaPath: string, stack: RepoStackResult): string { + const title = neutralizePromptInjection(issue.title); + const body = neutralizePromptInjection((issue.body ?? "").trim()); + if (title.injected || body.injected) { + console.log( + JSON.stringify({ + event: "prompt_injection_neutralized", + issueNumber: issue.number, + fields: [title.injected ? "title" : null, body.injected ? "body" : null].filter(Boolean), + }), + ); + } + return [ + `Resolve the following GitHub issue in this repository: #${issue.number} -- ${title.text}`, + "", + body.text, + "", + `A structured acceptance-criteria document describing what "done" means for this attempt is at ${acceptanceCriteriaPath} -- read it and ensure your change satisfies every criterion before finishing.`, + "", + buildValidationGuidance(stack), + ].join("\n"); +} + +export type CodingTaskSpecInput = { + repoFullName: string; + issue: CodingTaskIssue; + context: CodingTaskContext; + claimLedger: CodingTaskClaimLedger; + workingDirectory: string; + /** Injectable stack detector (#4786); omitted falls back to stack-detection.js's real `detectRepoStack`. */ + detectRepoStack?: (repoPath: string) => RepoStackResult; +}; + +export type CodingTaskSpecResult = + | { ready: false; verdict: FeasibilityVerdict; feasibility: FeasibilityGateResult } + | { + ready: true; + verdict: FeasibilityVerdict; + feasibility: FeasibilityGateResult; + acceptanceCriteriaPath: string; + instructions: string; + title: string; + body: string | undefined; + labels: string[] | undefined; + linkedIssues: number[]; + }; + +/** + * Full composition: feasibility -> acceptance criteria -> (if authorized) write the file -> detect the + * target-repo stack (#4786) -> instructions. Returns `ready: false` (with the computed feasibility verdict, + * for the caller to report) when the verdict is `raise`/`avoid` -- the caller should abandon the attempt + * rather than proceed with no real acceptance-criteria file on disk. + * + * `detectRepoStack` is injectable so tests can assert both the detected and fail-closed undiscovered stack + * branches without depending on real filesystem probes; omitted falls back to stack-detection.js's real + * `detectRepoStack` (the production default). + */ +export function buildCodingTaskSpec(input: CodingTaskSpecInput): CodingTaskSpecResult { + const feasibility = buildCodingTaskFeasibility(input.repoFullName, input.issue, input.context, input.claimLedger); + const acceptanceCriteria = buildCodingTaskAcceptanceCriteria(input.issue, feasibility); + const writeResult = writeAcceptanceCriteriaFile(input.workingDirectory, acceptanceCriteria); + + if (!writeResult.written) { + return { ready: false, verdict: feasibility.verdict, feasibility }; + } + + // Real target-repo stack (#4786): detected from the prepared worktree's own manifests, not guessed from + // loopover conventions. Fail-closed `{ detected: false }` results still reach the prompt (via + // renderStackSummary) so the agent is told detection failed rather than silently defaulting to npm/Codecov. + const detect = input.detectRepoStack ?? detectRepoStack; + const stack = detect(input.workingDirectory); + + return { + ready: true, + verdict: feasibility.verdict, + feasibility, + acceptanceCriteriaPath: writeResult.path as string, + instructions: buildInstructions(input.issue, writeResult.path as string, stack), + title: input.issue.title, + body: input.issue.body ?? undefined, + labels: input.issue.labels, + linkedIssues: [input.issue.number], + }; +} diff --git a/packages/loopover-miner/lib/deny-hooks.d.ts b/packages/loopover-miner/lib/deny-hooks.d.ts index 402304a2bb..d0dcc55bad 100644 --- a/packages/loopover-miner/lib/deny-hooks.d.ts +++ b/packages/loopover-miner/lib/deny-hooks.d.ts @@ -1,28 +1,2 @@ -export type DenyRule = { - /** Tool-name glob (`*` = any within a segment, `**` across segments) or an exact tool name. */ - matcher: string; - /** Optional glob tested against every path-shaped string in the tool-call input. */ - pathPattern?: string; - /** Optional substrings that must ALL appear in one string-shaped input field (e.g. a shell command). */ - inputIncludesAll?: string[]; - /** Optional pattern that must match a whole whitespace-separated token (quotes stripped) of one - * string-shaped input field — for flag-shaped needles where a substring test would false-positive - * on an unrelated longer flag (e.g. `-f` vs. `--follow-tags`). */ - inputTokenPattern?: RegExp; - /** Human-readable reason surfaced when this rule blocks a call. */ - reason: string; -}; - -export type DenyVerdict = { - allowed: boolean; - blockedBy?: DenyRule; -}; - -export type ProposedToolCall = { - name: string; - input: Record; -}; - -export const DEFAULT_DENY_RULES: DenyRule[]; - -export function evaluateDenyHooks(toolCall: ProposedToolCall, rules?: DenyRule[]): DenyVerdict; +export { DEFAULT_DENY_RULES, evaluateDenyHooks } from "@loopover/engine"; +export type { DenyRule, DenyVerdict, ProposedToolCall } from "@loopover/engine"; diff --git a/packages/loopover-miner/lib/deny-hooks.js b/packages/loopover-miner/lib/deny-hooks.js index af2875c48e..2311a87510 100644 --- a/packages/loopover-miner/lib/deny-hooks.js +++ b/packages/loopover-miner/lib/deny-hooks.js @@ -1,6 +1,6 @@ // PreToolUse-style deny-hook primitives (#2295). Now a thin re-export of the engine's pure, deterministic deny // evaluator: the whole implementation moved into `@loopover/engine` (packages/loopover-engine/src/miner/ // deny-hooks.ts) by #5667 so the review stack and the miner share one copy. No behavior change — the evaluator is -// pure (no IO, no globals, no Date/random). See deny-hooks.d.ts for the type contract (DenyRule/DenyVerdict/ -// ProposedToolCall), which still declares the same shapes the engine module now implements. +// pure (no IO, no globals, no Date/random). export { DEFAULT_DENY_RULES, evaluateDenyHooks } from "@loopover/engine"; +//# sourceMappingURL=data:application/json;base64,eyJ2ZXJzaW9uIjozLCJmaWxlIjoiZGVueS1ob29rcy5qcyIsInNvdXJjZVJvb3QiOiIiLCJzb3VyY2VzIjpbImRlbnktaG9va3MudHMiXSwibmFtZXMiOltdLCJtYXBwaW5ncyI6IkFBQUEsK0dBQStHO0FBQy9HLHlHQUF5RztBQUN6RyxrSEFBa0g7QUFDbEgsNENBQTRDO0FBQzVDLE9BQU8sRUFBRSxrQkFBa0IsRUFBRSxpQkFBaUIsRUFBRSxNQUFNLGtCQUFrQixDQUFDIn0= \ No newline at end of file diff --git a/packages/loopover-miner/lib/deny-hooks.ts b/packages/loopover-miner/lib/deny-hooks.ts new file mode 100644 index 0000000000..a42c9a270d --- /dev/null +++ b/packages/loopover-miner/lib/deny-hooks.ts @@ -0,0 +1,6 @@ +// PreToolUse-style deny-hook primitives (#2295). Now a thin re-export of the engine's pure, deterministic deny +// evaluator: the whole implementation moved into `@loopover/engine` (packages/loopover-engine/src/miner/ +// deny-hooks.ts) by #5667 so the review stack and the miner share one copy. No behavior change — the evaluator is +// pure (no IO, no globals, no Date/random). +export { DEFAULT_DENY_RULES, evaluateDenyHooks } from "@loopover/engine"; +export type { DenyRule, DenyVerdict, ProposedToolCall } from "@loopover/engine"; diff --git a/packages/loopover-miner/lib/policy-doc-cache.d.ts b/packages/loopover-miner/lib/policy-doc-cache.d.ts index 4cd5a5e5c6..a90dddb97a 100644 --- a/packages/loopover-miner/lib/policy-doc-cache.d.ts +++ b/packages/loopover-miner/lib/policy-doc-cache.d.ts @@ -1,25 +1,28 @@ export type PolicyDocCacheEntry = { - etag: string; - content: string; + etag: string; + content: string; }; - export type PolicyDocCacheWrite = { - url: string; - etag: string; - content: string; - updatedAt: string; + url: string; + etag: string; + content: string; + updatedAt: string; }; - export type PolicyDocCacheStore = { - dbPath: string; - get(url: string): PolicyDocCacheEntry | null; - put(url: string, etag: string, content: string): PolicyDocCacheWrite; - close(): void; + dbPath: string; + get(url: string): PolicyDocCacheEntry | null; + put(url: string, etag: string, content: string): PolicyDocCacheWrite; + close(): void; }; - /** The read/write surface opportunity-fanout.js needs to inject a cache without depending on the SQLite store. */ export type PolicyDocCache = Pick; - -export function resolvePolicyDocCacheDbPath(env?: Record): string; - -export function initPolicyDocCacheStore(dbPath?: string): PolicyDocCacheStore; +export declare function resolvePolicyDocCacheDbPath(env?: Record): string; +/** + * Opens the 100% local/client-side miner policy-doc ETag cache. The database only lives on this machine; this + * module never uploads, syncs, or phones home with its contents. (#4842) + * + * Opened through the #7175 SqliteDriver seam (`openLocalStoreAdapter`): CRUD goes through `driver.query`, + * while schema creation/migrations still use the underlying DatabaseSync until those helpers are migrated. + * Public API stays synchronous so callers need no async cascade in this part-1 slice. + */ +export declare function initPolicyDocCacheStore(dbPath?: string): PolicyDocCacheStore; diff --git a/packages/loopover-miner/lib/policy-doc-cache.js b/packages/loopover-miner/lib/policy-doc-cache.js index 5cfd206c78..d4be4af4c8 100644 --- a/packages/loopover-miner/lib/policy-doc-cache.js +++ b/packages/loopover-miner/lib/policy-doc-cache.js @@ -1,32 +1,20 @@ import { normalizeLocalStoreDbPath, openLocalStoreAdapter, resolveLocalStoreDbPath } from "./local-store.js"; import { applySchemaMigrations } from "./schema-version.js"; - -// Local ETag cache for discovery's small policy-doc fetches (#4842). `discover` refetches each target repo's -// AI-USAGE.md/CONTRIBUTING.md on every run even though they rarely change, spending rate-limit budget on static -// content; this store lets opportunity-fanout.js revalidate with a conditional GET (If-None-Match) instead, and -// GitHub answers an unchanged doc with a 304 that costs no primary rate-limit budget. A 304 is a GitHub-confirmed -// unchanged body -- the cached content is only ever served AFTER a same-run revalidation, never blindly -- so this -// can never surface a stale policy that would wrongly permit autonomous work on an opted-out repo. Same 100% -// local/client-side discipline (mirrors run-state.js and the other stores this package owns via local-store.js): -// the file lives only on this machine and is never uploaded, synced, or phoned home with. - const defaultDbFileName = "policy-doc-cache.sqlite3"; - export function resolvePolicyDocCacheDbPath(env = process.env) { - return resolveLocalStoreDbPath(defaultDbFileName, "LOOPOVER_MINER_POLICY_DOC_CACHE_DB", env); + return resolveLocalStoreDbPath(defaultDbFileName, "LOOPOVER_MINER_POLICY_DOC_CACHE_DB", env); } - function normalizeDbPath(dbPath) { - return normalizeLocalStoreDbPath(dbPath, resolvePolicyDocCacheDbPath(), "invalid_policy_doc_cache_db_path"); + return normalizeLocalStoreDbPath(dbPath, resolvePolicyDocCacheDbPath(), "invalid_policy_doc_cache_db_path"); } - function normalizeUrl(url) { - if (typeof url !== "string") throw new Error("invalid_policy_doc_url"); - const trimmed = url.trim(); - if (!trimmed) throw new Error("invalid_policy_doc_url"); - return trimmed; + if (typeof url !== "string") + throw new Error("invalid_policy_doc_url"); + const trimmed = url.trim(); + if (!trimmed) + throw new Error("invalid_policy_doc_url"); + return trimmed; } - /** * Opens the 100% local/client-side miner policy-doc ETag cache. The database only lives on this machine; this * module never uploads, syncs, or phones home with its contents. (#4842) @@ -36,9 +24,9 @@ function normalizeUrl(url) { * Public API stays synchronous so callers need no async cascade in this part-1 slice. */ export function initPolicyDocCacheStore(dbPath = resolvePolicyDocCacheDbPath()) { - const resolvedPath = normalizeDbPath(dbPath); - const { db, driver } = openLocalStoreAdapter(resolvedPath); - db.exec(` + const resolvedPath = normalizeDbPath(dbPath); + const { db, driver } = openLocalStoreAdapter(resolvedPath); + db.exec(` CREATE TABLE IF NOT EXISTS policy_doc_cache ( url TEXT PRIMARY KEY, etag TEXT NOT NULL, @@ -46,11 +34,10 @@ export function initPolicyDocCacheStore(dbPath = resolvePolicyDocCacheDbPath()) updated_at TEXT NOT NULL ) `); - // Schema-version convention (#4832): stamp the baseline and run any post-baseline migrations (none yet). - applySchemaMigrations(db, []); - - const getSql = "SELECT etag, content FROM policy_doc_cache WHERE url = ?"; - const putSql = ` + // Schema-version convention (#4832): stamp the baseline and run any post-baseline migrations (none yet). + applySchemaMigrations(db, []); + const getSql = "SELECT etag, content FROM policy_doc_cache WHERE url = ?"; + const putSql = ` INSERT INTO policy_doc_cache (url, etag, content, updated_at) VALUES (?, ?, ?, ?) ON CONFLICT(url) DO UPDATE SET @@ -58,27 +45,29 @@ export function initPolicyDocCacheStore(dbPath = resolvePolicyDocCacheDbPath()) content = excluded.content, updated_at = excluded.updated_at `; - - return { - dbPath: resolvedPath, - /** The last-known `{ etag, content }` for a policy-doc URL, or null when it has never been cached. Both columns - * are `TEXT NOT NULL`, so a present row always carries string values. */ - get(url) { - const { rows } = driver.query(getSql, [normalizeUrl(url)]); - const row = rows[0]; - return row ? { etag: row.etag, content: row.content } : null; - }, - /** Record the fresh ETag + body so the next run can revalidate it with a conditional GET. */ - put(url, etag, content) { - const normalizedUrl = normalizeUrl(url); - if (typeof etag !== "string" || !etag.trim()) throw new Error("invalid_policy_doc_etag"); - if (typeof content !== "string") throw new Error("invalid_policy_doc_content"); - const updatedAt = new Date().toISOString(); - driver.query(putSql, [normalizedUrl, etag, content, updatedAt]); - return { url: normalizedUrl, etag, content, updatedAt }; - }, - close() { - db.close(); - }, - }; + return { + dbPath: resolvedPath, + /** The last-known `{ etag, content }` for a policy-doc URL, or null when it has never been cached. Both columns + * are `TEXT NOT NULL`, so a present row always carries string values. */ + get(url) { + const { rows } = driver.query(getSql, [normalizeUrl(url)]); + const row = rows[0]; + return row ? { etag: row.etag, content: row.content } : null; + }, + /** Record the fresh ETag + body so the next run can revalidate it with a conditional GET. */ + put(url, etag, content) { + const normalizedUrl = normalizeUrl(url); + if (typeof etag !== "string" || !etag.trim()) + throw new Error("invalid_policy_doc_etag"); + if (typeof content !== "string") + throw new Error("invalid_policy_doc_content"); + const updatedAt = new Date().toISOString(); + driver.query(putSql, [normalizedUrl, etag, content, updatedAt]); + return { url: normalizedUrl, etag, content, updatedAt }; + }, + close() { + db.close(); + }, + }; } +//# sourceMappingURL=data:application/json;base64,eyJ2ZXJzaW9uIjozLCJmaWxlIjoicG9saWN5LWRvYy1jYWNoZS5qcyIsInNvdXJjZVJvb3QiOiIiLCJzb3VyY2VzIjpbInBvbGljeS1kb2MtY2FjaGUudHMiXSwibmFtZXMiOltdLCJtYXBwaW5ncyI6IkFBQUEsT0FBTyxFQUFFLHlCQUF5QixFQUFFLHFCQUFxQixFQUFFLHVCQUF1QixFQUFFLE1BQU0sa0JBQWtCLENBQUM7QUFDN0csT0FBTyxFQUFFLHFCQUFxQixFQUFFLE1BQU0scUJBQXFCLENBQUM7QUFpQzVELE1BQU0saUJBQWlCLEdBQUcsMEJBQTBCLENBQUM7QUFFckQsTUFBTSxVQUFVLDJCQUEyQixDQUFDLE1BQTBDLE9BQU8sQ0FBQyxHQUFHO0lBQy9GLE9BQU8sdUJBQXVCLENBQUMsaUJBQWlCLEVBQUUsb0NBQW9DLEVBQUUsR0FBRyxDQUFDLENBQUM7QUFDL0YsQ0FBQztBQUVELFNBQVMsZUFBZSxDQUFDLE1BQWM7SUFDckMsT0FBTyx5QkFBeUIsQ0FBQyxNQUFNLEVBQUUsMkJBQTJCLEVBQUUsRUFBRSxrQ0FBa0MsQ0FBQyxDQUFDO0FBQzlHLENBQUM7QUFFRCxTQUFTLFlBQVksQ0FBQyxHQUFXO0lBQy9CLElBQUksT0FBTyxHQUFHLEtBQUssUUFBUTtRQUFFLE1BQU0sSUFBSSxLQUFLLENBQUMsd0JBQXdCLENBQUMsQ0FBQztJQUN2RSxNQUFNLE9BQU8sR0FBRyxHQUFHLENBQUMsSUFBSSxFQUFFLENBQUM7SUFDM0IsSUFBSSxDQUFDLE9BQU87UUFBRSxNQUFNLElBQUksS0FBSyxDQUFDLHdCQUF3QixDQUFDLENBQUM7SUFDeEQsT0FBTyxPQUFPLENBQUM7QUFDakIsQ0FBQztBQUVEOzs7Ozs7O0dBT0c7QUFDSCxNQUFNLFVBQVUsdUJBQXVCLENBQUMsU0FBaUIsMkJBQTJCLEVBQUU7SUFDcEYsTUFBTSxZQUFZLEdBQUcsZUFBZSxDQUFDLE1BQU0sQ0FBQyxDQUFDO0lBQzdDLE1BQU0sRUFBRSxFQUFFLEVBQUUsTUFBTSxFQUFFLEdBQUcscUJBQXFCLENBQUMsWUFBWSxDQUFDLENBQUM7SUFDM0QsRUFBRSxDQUFDLElBQUksQ0FBQzs7Ozs7OztHQU9QLENBQUMsQ0FBQztJQUNILHlHQUF5RztJQUN6RyxxQkFBcUIsQ0FBQyxFQUFFLEVBQUUsRUFBRSxDQUFDLENBQUM7SUFFOUIsTUFBTSxNQUFNLEdBQUcsMERBQTBELENBQUM7SUFDMUUsTUFBTSxNQUFNLEdBQUc7Ozs7Ozs7R0FPZCxDQUFDO0lBRUYsT0FBTztRQUNMLE1BQU0sRUFBRSxZQUFZO1FBQ3BCO2tGQUMwRTtRQUMxRSxHQUFHLENBQUMsR0FBVztZQUNiLE1BQU0sRUFBRSxJQUFJLEVBQUUsR0FBRyxNQUFNLENBQUMsS0FBSyxDQUFDLE1BQU0sRUFBRSxDQUFDLFlBQVksQ0FBQyxHQUFHLENBQUMsQ0FBQyxDQUFDLENBQUM7WUFDM0QsTUFBTSxHQUFHLEdBQUcsSUFBSSxDQUFDLENBQUMsQ0FBQyxDQUFDO1lBQ3BCLE9BQU8sR0FBRyxDQUFDLENBQUMsQ0FBQyxFQUFFLElBQUksRUFBRSxHQUFHLENBQUMsSUFBYyxFQUFFLE9BQU8sRUFBRSxHQUFHLENBQUMsT0FBaUIsRUFBRSxDQUFDLENBQUMsQ0FBQyxJQUFJLENBQUM7UUFDbkYsQ0FBQztRQUNELDZGQUE2RjtRQUM3RixHQUFHLENBQUMsR0FBVyxFQUFFLElBQVksRUFBRSxPQUFlO1lBQzVDLE1BQU0sYUFBYSxHQUFHLFlBQVksQ0FBQyxHQUFHLENBQUMsQ0FBQztZQUN4QyxJQUFJLE9BQU8sSUFBSSxLQUFLLFFBQVEsSUFBSSxDQUFDLElBQUksQ0FBQyxJQUFJLEVBQUU7Z0JBQUUsTUFBTSxJQUFJLEtBQUssQ0FBQyx5QkFBeUIsQ0FBQyxDQUFDO1lBQ3pGLElBQUksT0FBTyxPQUFPLEtBQUssUUFBUTtnQkFBRSxNQUFNLElBQUksS0FBSyxDQUFDLDRCQUE0QixDQUFDLENBQUM7WUFDL0UsTUFBTSxTQUFTLEdBQUcsSUFBSSxJQUFJLEVBQUUsQ0FBQyxXQUFXLEVBQUUsQ0FBQztZQUMzQyxNQUFNLENBQUMsS0FBSyxDQUFDLE1BQU0sRUFBRSxDQUFDLGFBQWEsRUFBRSxJQUFJLEVBQUUsT0FBTyxFQUFFLFNBQVMsQ0FBQyxDQUFDLENBQUM7WUFDaEUsT0FBTyxFQUFFLEdBQUcsRUFBRSxhQUFhLEVBQUUsSUFBSSxFQUFFLE9BQU8sRUFBRSxTQUFTLEVBQUUsQ0FBQztRQUMxRCxDQUFDO1FBQ0QsS0FBSztZQUNILEVBQUUsQ0FBQyxLQUFLLEVBQUUsQ0FBQztRQUNiLENBQUM7S0FDRixDQUFDO0FBQ0osQ0FBQyJ9 \ No newline at end of file diff --git a/packages/loopover-miner/lib/policy-doc-cache.ts b/packages/loopover-miner/lib/policy-doc-cache.ts new file mode 100644 index 0000000000..8b5d15d888 --- /dev/null +++ b/packages/loopover-miner/lib/policy-doc-cache.ts @@ -0,0 +1,106 @@ +import { normalizeLocalStoreDbPath, openLocalStoreAdapter, resolveLocalStoreDbPath } from "./local-store.js"; +import { applySchemaMigrations } from "./schema-version.js"; + +// Local ETag cache for discovery's small policy-doc fetches (#4842). `discover` refetches each target repo's +// AI-USAGE.md/CONTRIBUTING.md on every run even though they rarely change, spending rate-limit budget on static +// content; this store lets opportunity-fanout.js revalidate with a conditional GET (If-None-Match) instead, and +// GitHub answers an unchanged doc with a 304 that costs no primary rate-limit budget. A 304 is a GitHub-confirmed +// unchanged body -- the cached content is only ever served AFTER a same-run revalidation, never blindly -- so this +// can never surface a stale policy that would wrongly permit autonomous work on an opted-out repo. Same 100% +// local/client-side discipline (mirrors run-state.js and the other stores this package owns via local-store.js): +// the file lives only on this machine and is never uploaded, synced, or phoned home with. + +export type PolicyDocCacheEntry = { + etag: string; + content: string; +}; + +export type PolicyDocCacheWrite = { + url: string; + etag: string; + content: string; + updatedAt: string; +}; + +export type PolicyDocCacheStore = { + dbPath: string; + get(url: string): PolicyDocCacheEntry | null; + put(url: string, etag: string, content: string): PolicyDocCacheWrite; + close(): void; +}; + +/** The read/write surface opportunity-fanout.js needs to inject a cache without depending on the SQLite store. */ +export type PolicyDocCache = Pick; + +const defaultDbFileName = "policy-doc-cache.sqlite3"; + +export function resolvePolicyDocCacheDbPath(env: Record = process.env): string { + return resolveLocalStoreDbPath(defaultDbFileName, "LOOPOVER_MINER_POLICY_DOC_CACHE_DB", env); +} + +function normalizeDbPath(dbPath: string): string { + return normalizeLocalStoreDbPath(dbPath, resolvePolicyDocCacheDbPath(), "invalid_policy_doc_cache_db_path"); +} + +function normalizeUrl(url: string): string { + if (typeof url !== "string") throw new Error("invalid_policy_doc_url"); + const trimmed = url.trim(); + if (!trimmed) throw new Error("invalid_policy_doc_url"); + return trimmed; +} + +/** + * Opens the 100% local/client-side miner policy-doc ETag cache. The database only lives on this machine; this + * module never uploads, syncs, or phones home with its contents. (#4842) + * + * Opened through the #7175 SqliteDriver seam (`openLocalStoreAdapter`): CRUD goes through `driver.query`, + * while schema creation/migrations still use the underlying DatabaseSync until those helpers are migrated. + * Public API stays synchronous so callers need no async cascade in this part-1 slice. + */ +export function initPolicyDocCacheStore(dbPath: string = resolvePolicyDocCacheDbPath()): PolicyDocCacheStore { + const resolvedPath = normalizeDbPath(dbPath); + const { db, driver } = openLocalStoreAdapter(resolvedPath); + db.exec(` + CREATE TABLE IF NOT EXISTS policy_doc_cache ( + url TEXT PRIMARY KEY, + etag TEXT NOT NULL, + content TEXT NOT NULL, + updated_at TEXT NOT NULL + ) + `); + // Schema-version convention (#4832): stamp the baseline and run any post-baseline migrations (none yet). + applySchemaMigrations(db, []); + + const getSql = "SELECT etag, content FROM policy_doc_cache WHERE url = ?"; + const putSql = ` + INSERT INTO policy_doc_cache (url, etag, content, updated_at) + VALUES (?, ?, ?, ?) + ON CONFLICT(url) DO UPDATE SET + etag = excluded.etag, + content = excluded.content, + updated_at = excluded.updated_at + `; + + return { + dbPath: resolvedPath, + /** The last-known `{ etag, content }` for a policy-doc URL, or null when it has never been cached. Both columns + * are `TEXT NOT NULL`, so a present row always carries string values. */ + get(url: string): PolicyDocCacheEntry | null { + const { rows } = driver.query(getSql, [normalizeUrl(url)]); + const row = rows[0]; + return row ? { etag: row.etag as string, content: row.content as string } : null; + }, + /** Record the fresh ETag + body so the next run can revalidate it with a conditional GET. */ + put(url: string, etag: string, content: string): PolicyDocCacheWrite { + const normalizedUrl = normalizeUrl(url); + if (typeof etag !== "string" || !etag.trim()) throw new Error("invalid_policy_doc_etag"); + if (typeof content !== "string") throw new Error("invalid_policy_doc_content"); + const updatedAt = new Date().toISOString(); + driver.query(putSql, [normalizedUrl, etag, content, updatedAt]); + return { url: normalizedUrl, etag, content, updatedAt }; + }, + close() { + db.close(); + }, + }; +} diff --git a/packages/loopover-miner/lib/pr-outcome.d.ts b/packages/loopover-miner/lib/pr-outcome.d.ts index 4fe170faae..9c5bd3657a 100644 --- a/packages/loopover-miner/lib/pr-outcome.d.ts +++ b/packages/loopover-miner/lib/pr-outcome.d.ts @@ -1,41 +1,59 @@ import type { AppendEventInput, LedgerEntry } from "./event-ledger.js"; - -export const MINER_PR_OUTCOME_EVENT: "pr_outcome"; -export const MINER_PR_OUTCOME_DECISIONS: readonly ["merged", "closed"]; - +/** Event-ledger vocabulary for a miner-local PR outcome. */ +export declare const MINER_PR_OUTCOME_EVENT = "pr_outcome"; export type MinerPrOutcomeDecision = "merged" | "closed"; - +/** The terminal decisions a miner records for one of its own PRs. */ +export declare const MINER_PR_OUTCOME_DECISIONS: readonly MinerPrOutcomeDecision[]; export interface NormalizedPrOutcomePayload { - prNumber: number; - decision: MinerPrOutcomeDecision; - closedAt: string | null; - reason: string | null; + prNumber: number; + decision: MinerPrOutcomeDecision; + closedAt: string | null; + reason: string | null; } - export interface PrOutcomeInput { - repoFullName?: unknown; - prNumber?: unknown; - decision?: unknown; - closedAt?: unknown; - reason?: unknown; + repoFullName?: unknown; + prNumber?: unknown; + decision?: unknown; + closedAt?: unknown; + reason?: unknown; } - export interface RecordPrOutcomeOptions { - /** Optional at the type level so a caller can pass an unusable ledger to exercise the fail-closed guard; the - * writer throws `invalid_event_ledger` at runtime when this is absent or lacks `appendEvent`. Reuses the - * real EventLedger#appendEvent signature so a genuine EventLedger (not just a same-shaped stub) type-checks. */ - eventLedger?: { appendEvent(event: AppendEventInput): LedgerEntry }; + /** Optional at the type level so a caller can pass an unusable ledger to exercise the fail-closed guard; the + * writer throws `invalid_event_ledger` at runtime when this is absent or lacks `appendEvent`. */ + eventLedger?: { + appendEvent(event: AppendEventInput): LedgerEntry; + }; } - export interface PrOutcomeLedgerReader { - readEvents(filter?: { since?: number; repoFullName?: string }): unknown[]; + readEvents(filter?: { + since?: number; + repoFullName?: string; + }): unknown[]; } - -export function normalizePrOutcomePayload(payload: unknown): NormalizedPrOutcomePayload | null; - -export function recordPrOutcomeSnapshot(input: PrOutcomeInput, options?: RecordPrOutcomeOptions): unknown; - -export function readPrOutcomes( - eventLedger: PrOutcomeLedgerReader, - filter?: { since?: number; repoFullName?: string }, -): Map; +/** + * Validate + normalize a PR-outcome payload; returns `null` on any malformed shape (mirrors manage-status.js's + * `normalizeManageUpdatePayload`, so a bad row can neither be written nor read back). A `closed` decision may carry + * a reason bucket drawn from {@link REJECTION_REASONS} (shared with the rejection-state-machine sibling); a `merged` + * decision — or an unrecognized reason — normalizes the reason to `null` (a merged PR has no rejection reason). + */ +export declare function normalizePrOutcomePayload(payload: unknown): NormalizedPrOutcomePayload | null; +/** + * Thin writer over an INJECTED event ledger (same dependency-injection shape as manage-poll.js's + * `recordManagePollSnapshot`, so it's unit-testable without a real ledger file). Appends one + * {@link MINER_PR_OUTCOME_EVENT} scoped to the repo and returns the appended entry. Fail-soft on a malformed + * snapshot: a missing repo or an invalid payload returns `null` rather than throwing (an unusable ledger is the + * only hard error, since that is a programmer wiring mistake). + */ +export declare function recordPrOutcomeSnapshot(input: PrOutcomeInput, options?: RecordPrOutcomeOptions): LedgerEntry | null; +/** + * Reconstruct the latest outcome per repo/PR from the ledger's ascending append-only event stream (mirrors + * manage-status.js's `indexLatestManageUpdates`). Reads via the injected ledger's `readEvents(filter)` and reduces + * the pure result — a later event for the same repo/PR supersedes an earlier one. Returns a `Map` keyed by + * `repoFullName:prNumber`. + */ +export declare function readPrOutcomes(eventLedger: PrOutcomeLedgerReader, filter?: { + since?: number; + repoFullName?: string; +}): Map; diff --git a/packages/loopover-miner/lib/pr-outcome.js b/packages/loopover-miner/lib/pr-outcome.js index dce82bec6c..d66789e2d7 100644 --- a/packages/loopover-miner/lib/pr-outcome.js +++ b/packages/loopover-miner/lib/pr-outcome.js @@ -8,25 +8,21 @@ // loopover SERVER recording ground truth for every contributor. THIS is a laptop-mode miner's local record of // its own PRs (it may have no webhook relay at all): same concept name, different codebase layer, no shared code. // The distinct `MINER_PR_OUTCOME_EVENT` local constant keeps the two from being conflated. - import { REJECTION_REASONS } from "./rejection-templates.js"; - /** Event-ledger vocabulary for a miner-local PR outcome. */ export const MINER_PR_OUTCOME_EVENT = "pr_outcome"; - /** The terminal decisions a miner records for one of its own PRs. */ export const MINER_PR_OUTCOME_DECISIONS = Object.freeze(["merged", "closed"]); - const decisionSet = new Set(MINER_PR_OUTCOME_DECISIONS); const reasonSet = new Set(REJECTION_REASONS); - function optionalString(value) { - if (value === undefined || value === null) return null; - if (typeof value !== "string") return null; - const trimmed = value.trim(); - return trimmed || null; + if (value === undefined || value === null) + return null; + if (typeof value !== "string") + return null; + const trimmed = value.trim(); + return trimmed || null; } - /** * Validate + normalize a PR-outcome payload; returns `null` on any malformed shape (mirrors manage-status.js's * `normalizeManageUpdatePayload`, so a bad row can neither be written nor read back). A `closed` decision may carry @@ -34,20 +30,23 @@ function optionalString(value) { * decision — or an unrecognized reason — normalizes the reason to `null` (a merged PR has no rejection reason). */ export function normalizePrOutcomePayload(payload) { - if (!payload || typeof payload !== "object" || Array.isArray(payload)) return null; - if (!Number.isInteger(payload.prNumber) || payload.prNumber <= 0) return null; - const decision = optionalString(payload.decision); - if (!decision || !decisionSet.has(decision)) return null; - const reasonRaw = optionalString(payload.reason); - const reason = decision === "closed" && reasonRaw !== null && reasonSet.has(reasonRaw) ? reasonRaw : null; - return { - prNumber: payload.prNumber, - decision, - closedAt: optionalString(payload.closedAt), - reason, - }; + if (!payload || typeof payload !== "object" || Array.isArray(payload)) + return null; + const record = payload; + if (!Number.isInteger(record.prNumber) || record.prNumber <= 0) + return null; + const decision = optionalString(record.decision); + if (!decision || !decisionSet.has(decision)) + return null; + const reasonRaw = optionalString(record.reason); + const reason = decision === "closed" && reasonRaw !== null && reasonSet.has(reasonRaw) ? reasonRaw : null; + return { + prNumber: record.prNumber, + decision: decision, + closedAt: optionalString(record.closedAt), + reason, + }; } - /** * Thin writer over an INJECTED event ledger (same dependency-injection shape as manage-poll.js's * `recordManagePollSnapshot`, so it's unit-testable without a real ledger file). Appends one @@ -56,20 +55,22 @@ export function normalizePrOutcomePayload(payload) { * only hard error, since that is a programmer wiring mistake). */ export function recordPrOutcomeSnapshot(input, options = {}) { - const eventLedger = options.eventLedger; - if (!eventLedger || typeof eventLedger.appendEvent !== "function") throw new Error("invalid_event_ledger"); - const repoFullName = typeof input?.repoFullName === "string" ? input.repoFullName.trim() : ""; - if (!repoFullName) return null; - const payload = normalizePrOutcomePayload({ - prNumber: input?.prNumber, - decision: input?.decision, - closedAt: input?.closedAt, - reason: input?.reason, - }); - if (!payload) return null; - return eventLedger.appendEvent({ type: MINER_PR_OUTCOME_EVENT, repoFullName, payload }); + const eventLedger = options.eventLedger; + if (!eventLedger || typeof eventLedger.appendEvent !== "function") + throw new Error("invalid_event_ledger"); + const repoFullName = typeof input?.repoFullName === "string" ? input.repoFullName.trim() : ""; + if (!repoFullName) + return null; + const payload = normalizePrOutcomePayload({ + prNumber: input?.prNumber, + decision: input?.decision, + closedAt: input?.closedAt, + reason: input?.reason, + }); + if (!payload) + return null; + return eventLedger.appendEvent({ type: MINER_PR_OUTCOME_EVENT, repoFullName, payload: payload }); } - /** * Reconstruct the latest outcome per repo/PR from the ledger's ascending append-only event stream (mirrors * manage-status.js's `indexLatestManageUpdates`). Reads via the injected ledger's `readEvents(filter)` and reduces @@ -77,21 +78,26 @@ export function recordPrOutcomeSnapshot(input, options = {}) { * `repoFullName:prNumber`. */ export function readPrOutcomes(eventLedger, filter = {}) { - const events = eventLedger && typeof eventLedger.readEvents === "function" ? eventLedger.readEvents(filter) : []; - const latest = new Map(); - for (const event of Array.isArray(events) ? events : []) { - if (event?.type !== MINER_PR_OUTCOME_EVENT) continue; - if (typeof event.repoFullName !== "string" || !event.repoFullName.trim()) continue; - const normalized = normalizePrOutcomePayload(event.payload); - if (!normalized) continue; - // Re-key on every event so Map iteration order tracks most-recently-UPDATED last, not first-seen (#7222). A - // bare Map.set() on an existing key updates the value but leaves the key frozen at its original position, so a - // later outcome for the same PR (e.g. closed-without-merge, then reopened + merged) stayed at its old slot -- - // breaking recency-ordered consumers like loop-reentry.js's countConsecutiveDisengagements. Deleting first - // moves the freshly-updated entry to the end, matching this reducer's own "a later event supersedes" contract. - const key = `${event.repoFullName}:${normalized.prNumber}`; - latest.delete(key); - latest.set(key, { ...normalized, repoFullName: event.repoFullName }); - } - return latest; + const events = eventLedger && typeof eventLedger.readEvents === "function" ? eventLedger.readEvents(filter) : []; + const latest = new Map(); + for (const event of Array.isArray(events) ? events : []) { + const record = event; + if (record?.type !== MINER_PR_OUTCOME_EVENT) + continue; + if (typeof record.repoFullName !== "string" || !record.repoFullName.trim()) + continue; + const normalized = normalizePrOutcomePayload(record.payload); + if (!normalized) + continue; + // Re-key on every event so Map iteration order tracks most-recently-UPDATED last, not first-seen (#7222). A + // bare Map.set() on an existing key updates the value but leaves the key frozen at its original position, so a + // later outcome for the same PR (e.g. closed-without-merge, then reopened + merged) stayed at its old slot -- + // breaking recency-ordered consumers like loop-reentry.js's countConsecutiveDisengagements. Deleting first + // moves the freshly-updated entry to the end, matching this reducer's own "a later event supersedes" contract. + const key = `${record.repoFullName}:${normalized.prNumber}`; + latest.delete(key); + latest.set(key, { ...normalized, repoFullName: record.repoFullName }); + } + return latest; } +//# sourceMappingURL=data:application/json;base64,eyJ2ZXJzaW9uIjozLCJmaWxlIjoicHItb3V0Y29tZS5qcyIsInNvdXJjZVJvb3QiOiIiLCJzb3VyY2VzIjpbInByLW91dGNvbWUudHMiXSwibmFtZXMiOltdLCJtYXBwaW5ncyI6IkFBQUEsaUhBQWlIO0FBQ2pILDBHQUEwRztBQUMxRyxpSEFBaUg7QUFDakgsOEJBQThCO0FBQzlCLEVBQUU7QUFDRiw2R0FBNkc7QUFDN0csK0dBQStHO0FBQy9HLDhHQUE4RztBQUM5RyxrSEFBa0g7QUFDbEgsMkZBQTJGO0FBRTNGLE9BQU8sRUFBRSxpQkFBaUIsRUFBRSxNQUFNLDBCQUEwQixDQUFDO0FBRzdELDREQUE0RDtBQUM1RCxNQUFNLENBQUMsTUFBTSxzQkFBc0IsR0FBRyxZQUFZLENBQUM7QUFJbkQscUVBQXFFO0FBQ3JFLE1BQU0sQ0FBQyxNQUFNLDBCQUEwQixHQUFzQyxNQUFNLENBQUMsTUFBTSxDQUFDLENBQUMsUUFBUSxFQUFFLFFBQVEsQ0FBQyxDQUFDLENBQUM7QUEyQmpILE1BQU0sV0FBVyxHQUFnQixJQUFJLEdBQUcsQ0FBQywwQkFBMEIsQ0FBQyxDQUFDO0FBQ3JFLE1BQU0sU0FBUyxHQUFnQixJQUFJLEdBQUcsQ0FBQyxpQkFBaUIsQ0FBQyxDQUFDO0FBRTFELFNBQVMsY0FBYyxDQUFDLEtBQWM7SUFDcEMsSUFBSSxLQUFLLEtBQUssU0FBUyxJQUFJLEtBQUssS0FBSyxJQUFJO1FBQUUsT0FBTyxJQUFJLENBQUM7SUFDdkQsSUFBSSxPQUFPLEtBQUssS0FBSyxRQUFRO1FBQUUsT0FBTyxJQUFJLENBQUM7SUFDM0MsTUFBTSxPQUFPLEdBQUcsS0FBSyxDQUFDLElBQUksRUFBRSxDQUFDO0lBQzdCLE9BQU8sT0FBTyxJQUFJLElBQUksQ0FBQztBQUN6QixDQUFDO0FBRUQ7Ozs7O0dBS0c7QUFDSCxNQUFNLFVBQVUseUJBQXlCLENBQUMsT0FBZ0I7SUFDeEQsSUFBSSxDQUFDLE9BQU8sSUFBSSxPQUFPLE9BQU8sS0FBSyxRQUFRLElBQUksS0FBSyxDQUFDLE9BQU8sQ0FBQyxPQUFPLENBQUM7UUFBRSxPQUFPLElBQUksQ0FBQztJQUNuRixNQUFNLE1BQU0sR0FBRyxPQUFrQyxDQUFDO0lBQ2xELElBQUksQ0FBQyxNQUFNLENBQUMsU0FBUyxDQUFDLE1BQU0sQ0FBQyxRQUFRLENBQUMsSUFBSyxNQUFNLENBQUMsUUFBbUIsSUFBSSxDQUFDO1FBQUUsT0FBTyxJQUFJLENBQUM7SUFDeEYsTUFBTSxRQUFRLEdBQUcsY0FBYyxDQUFDLE1BQU0sQ0FBQyxRQUFRLENBQUMsQ0FBQztJQUNqRCxJQUFJLENBQUMsUUFBUSxJQUFJLENBQUMsV0FBVyxDQUFDLEdBQUcsQ0FBQyxRQUFRLENBQUM7UUFBRSxPQUFPLElBQUksQ0FBQztJQUN6RCxNQUFNLFNBQVMsR0FBRyxjQUFjLENBQUMsTUFBTSxDQUFDLE1BQU0sQ0FBQyxDQUFDO0lBQ2hELE1BQU0sTUFBTSxHQUFHLFFBQVEsS0FBSyxRQUFRLElBQUksU0FBUyxLQUFLLElBQUksSUFBSSxTQUFTLENBQUMsR0FBRyxDQUFDLFNBQVMsQ0FBQyxDQUFDLENBQUMsQ0FBQyxTQUFTLENBQUMsQ0FBQyxDQUFDLElBQUksQ0FBQztJQUMxRyxPQUFPO1FBQ0wsUUFBUSxFQUFFLE1BQU0sQ0FBQyxRQUFrQjtRQUNuQyxRQUFRLEVBQUUsUUFBa0M7UUFDNUMsUUFBUSxFQUFFLGNBQWMsQ0FBQyxNQUFNLENBQUMsUUFBUSxDQUFDO1FBQ3pDLE1BQU07S0FDUCxDQUFDO0FBQ0osQ0FBQztBQUVEOzs7Ozs7R0FNRztBQUNILE1BQU0sVUFBVSx1QkFBdUIsQ0FBQyxLQUFxQixFQUFFLFVBQWtDLEVBQUU7SUFDakcsTUFBTSxXQUFXLEdBQUcsT0FBTyxDQUFDLFdBQVcsQ0FBQztJQUN4QyxJQUFJLENBQUMsV0FBVyxJQUFJLE9BQU8sV0FBVyxDQUFDLFdBQVcsS0FBSyxVQUFVO1FBQUUsTUFBTSxJQUFJLEtBQUssQ0FBQyxzQkFBc0IsQ0FBQyxDQUFDO0lBQzNHLE1BQU0sWUFBWSxHQUFHLE9BQU8sS0FBSyxFQUFFLFlBQVksS0FBSyxRQUFRLENBQUMsQ0FBQyxDQUFDLEtBQUssQ0FBQyxZQUFZLENBQUMsSUFBSSxFQUFFLENBQUMsQ0FBQyxDQUFDLEVBQUUsQ0FBQztJQUM5RixJQUFJLENBQUMsWUFBWTtRQUFFLE9BQU8sSUFBSSxDQUFDO0lBQy9CLE1BQU0sT0FBTyxHQUFHLHlCQUF5QixDQUFDO1FBQ3hDLFFBQVEsRUFBRSxLQUFLLEVBQUUsUUFBUTtRQUN6QixRQUFRLEVBQUUsS0FBSyxFQUFFLFFBQVE7UUFDekIsUUFBUSxFQUFFLEtBQUssRUFBRSxRQUFRO1FBQ3pCLE1BQU0sRUFBRSxLQUFLLEVBQUUsTUFBTTtLQUN0QixDQUFDLENBQUM7SUFDSCxJQUFJLENBQUMsT0FBTztRQUFFLE9BQU8sSUFBSSxDQUFDO0lBQzFCLE9BQU8sV0FBVyxDQUFDLFdBQVcsQ0FBQyxFQUFFLElBQUksRUFBRSxzQkFBc0IsRUFBRSxZQUFZLEVBQUUsT0FBTyxFQUFFLE9BQTZDLEVBQUUsQ0FBQyxDQUFDO0FBQ3pJLENBQUM7QUFFRDs7Ozs7R0FLRztBQUNILE1BQU0sVUFBVSxjQUFjLENBQzVCLFdBQWtDLEVBQ2xDLFNBQW9ELEVBQUU7SUFFdEQsTUFBTSxNQUFNLEdBQUcsV0FBVyxJQUFJLE9BQU8sV0FBVyxDQUFDLFVBQVUsS0FBSyxVQUFVLENBQUMsQ0FBQyxDQUFDLFdBQVcsQ0FBQyxVQUFVLENBQUMsTUFBTSxDQUFDLENBQUMsQ0FBQyxDQUFDLEVBQUUsQ0FBQztJQUNqSCxNQUFNLE1BQU0sR0FBRyxJQUFJLEdBQUcsRUFBaUUsQ0FBQztJQUN4RixLQUFLLE1BQU0sS0FBSyxJQUFJLEtBQUssQ0FBQyxPQUFPLENBQUMsTUFBTSxDQUFDLENBQUMsQ0FBQyxDQUFDLE1BQU0sQ0FBQyxDQUFDLENBQUMsRUFBRSxFQUFFLENBQUM7UUFDeEQsTUFBTSxNQUFNLEdBQUcsS0FBNkUsQ0FBQztRQUM3RixJQUFJLE1BQU0sRUFBRSxJQUFJLEtBQUssc0JBQXNCO1lBQUUsU0FBUztRQUN0RCxJQUFJLE9BQU8sTUFBTSxDQUFDLFlBQVksS0FBSyxRQUFRLElBQUksQ0FBQyxNQUFNLENBQUMsWUFBWSxDQUFDLElBQUksRUFBRTtZQUFFLFNBQVM7UUFDckYsTUFBTSxVQUFVLEdBQUcseUJBQXlCLENBQUMsTUFBTSxDQUFDLE9BQU8sQ0FBQyxDQUFDO1FBQzdELElBQUksQ0FBQyxVQUFVO1lBQUUsU0FBUztRQUMxQiw0R0FBNEc7UUFDNUcsK0dBQStHO1FBQy9HLDhHQUE4RztRQUM5RywyR0FBMkc7UUFDM0csK0dBQStHO1FBQy9HLE1BQU0sR0FBRyxHQUFHLEdBQUcsTUFBTSxDQUFDLFlBQVksSUFBSSxVQUFVLENBQUMsUUFBUSxFQUFFLENBQUM7UUFDNUQsTUFBTSxDQUFDLE1BQU0sQ0FBQyxHQUFHLENBQUMsQ0FBQztRQUNuQixNQUFNLENBQUMsR0FBRyxDQUFDLEdBQUcsRUFBRSxFQUFFLEdBQUcsVUFBVSxFQUFFLFlBQVksRUFBRSxNQUFNLENBQUMsWUFBWSxFQUFFLENBQUMsQ0FBQztJQUN4RSxDQUFDO0lBQ0QsT0FBTyxNQUFNLENBQUM7QUFDaEIsQ0FBQyJ9 \ No newline at end of file diff --git a/packages/loopover-miner/lib/pr-outcome.ts b/packages/loopover-miner/lib/pr-outcome.ts new file mode 100644 index 0000000000..be01709f2c --- /dev/null +++ b/packages/loopover-miner/lib/pr-outcome.ts @@ -0,0 +1,130 @@ +// Miner-local PR-outcome record (#4274). The miner's OWN local record of the outcomes of its OWN PRs — merged or +// closed — written to the miner's local SQLite via the generic append-only event-ledger.js, mirroring how +// manage-status.js layers a specific typed event (MANAGE_PR_UPDATE_EVENT + a payload normalizer + a thin writer) +// on top of that same ledger. +// +// DISTINCT from the server-side `pr_outcome` concept: src/review/outcomes-wire.ts's `recordPrOutcome` writes +// `pr_outcome` rows to the HOSTED backend's D1 audit tables from the GitHub App's webhook stream — that is the +// loopover SERVER recording ground truth for every contributor. THIS is a laptop-mode miner's local record of +// its own PRs (it may have no webhook relay at all): same concept name, different codebase layer, no shared code. +// The distinct `MINER_PR_OUTCOME_EVENT` local constant keeps the two from being conflated. + +import { REJECTION_REASONS } from "./rejection-templates.js"; +import type { AppendEventInput, LedgerEntry } from "./event-ledger.js"; + +/** Event-ledger vocabulary for a miner-local PR outcome. */ +export const MINER_PR_OUTCOME_EVENT = "pr_outcome"; + +export type MinerPrOutcomeDecision = "merged" | "closed"; + +/** The terminal decisions a miner records for one of its own PRs. */ +export const MINER_PR_OUTCOME_DECISIONS: readonly MinerPrOutcomeDecision[] = Object.freeze(["merged", "closed"]); + +export interface NormalizedPrOutcomePayload { + prNumber: number; + decision: MinerPrOutcomeDecision; + closedAt: string | null; + reason: string | null; +} + +export interface PrOutcomeInput { + repoFullName?: unknown; + prNumber?: unknown; + decision?: unknown; + closedAt?: unknown; + reason?: unknown; +} + +export interface RecordPrOutcomeOptions { + /** Optional at the type level so a caller can pass an unusable ledger to exercise the fail-closed guard; the + * writer throws `invalid_event_ledger` at runtime when this is absent or lacks `appendEvent`. */ + eventLedger?: { appendEvent(event: AppendEventInput): LedgerEntry }; +} + +export interface PrOutcomeLedgerReader { + readEvents(filter?: { since?: number; repoFullName?: string }): unknown[]; +} + +const decisionSet: Set = new Set(MINER_PR_OUTCOME_DECISIONS); +const reasonSet: Set = new Set(REJECTION_REASONS); + +function optionalString(value: unknown): string | null { + if (value === undefined || value === null) return null; + if (typeof value !== "string") return null; + const trimmed = value.trim(); + return trimmed || null; +} + +/** + * Validate + normalize a PR-outcome payload; returns `null` on any malformed shape (mirrors manage-status.js's + * `normalizeManageUpdatePayload`, so a bad row can neither be written nor read back). A `closed` decision may carry + * a reason bucket drawn from {@link REJECTION_REASONS} (shared with the rejection-state-machine sibling); a `merged` + * decision — or an unrecognized reason — normalizes the reason to `null` (a merged PR has no rejection reason). + */ +export function normalizePrOutcomePayload(payload: unknown): NormalizedPrOutcomePayload | null { + if (!payload || typeof payload !== "object" || Array.isArray(payload)) return null; + const record = payload as Record; + if (!Number.isInteger(record.prNumber) || (record.prNumber as number) <= 0) return null; + const decision = optionalString(record.decision); + if (!decision || !decisionSet.has(decision)) return null; + const reasonRaw = optionalString(record.reason); + const reason = decision === "closed" && reasonRaw !== null && reasonSet.has(reasonRaw) ? reasonRaw : null; + return { + prNumber: record.prNumber as number, + decision: decision as MinerPrOutcomeDecision, + closedAt: optionalString(record.closedAt), + reason, + }; +} + +/** + * Thin writer over an INJECTED event ledger (same dependency-injection shape as manage-poll.js's + * `recordManagePollSnapshot`, so it's unit-testable without a real ledger file). Appends one + * {@link MINER_PR_OUTCOME_EVENT} scoped to the repo and returns the appended entry. Fail-soft on a malformed + * snapshot: a missing repo or an invalid payload returns `null` rather than throwing (an unusable ledger is the + * only hard error, since that is a programmer wiring mistake). + */ +export function recordPrOutcomeSnapshot(input: PrOutcomeInput, options: RecordPrOutcomeOptions = {}): LedgerEntry | null { + const eventLedger = options.eventLedger; + if (!eventLedger || typeof eventLedger.appendEvent !== "function") throw new Error("invalid_event_ledger"); + const repoFullName = typeof input?.repoFullName === "string" ? input.repoFullName.trim() : ""; + if (!repoFullName) return null; + const payload = normalizePrOutcomePayload({ + prNumber: input?.prNumber, + decision: input?.decision, + closedAt: input?.closedAt, + reason: input?.reason, + }); + if (!payload) return null; + return eventLedger.appendEvent({ type: MINER_PR_OUTCOME_EVENT, repoFullName, payload: payload as unknown as Record }); +} + +/** + * Reconstruct the latest outcome per repo/PR from the ledger's ascending append-only event stream (mirrors + * manage-status.js's `indexLatestManageUpdates`). Reads via the injected ledger's `readEvents(filter)` and reduces + * the pure result — a later event for the same repo/PR supersedes an earlier one. Returns a `Map` keyed by + * `repoFullName:prNumber`. + */ +export function readPrOutcomes( + eventLedger: PrOutcomeLedgerReader, + filter: { since?: number; repoFullName?: string } = {}, +): Map { + const events = eventLedger && typeof eventLedger.readEvents === "function" ? eventLedger.readEvents(filter) : []; + const latest = new Map(); + for (const event of Array.isArray(events) ? events : []) { + const record = event as { type?: unknown; repoFullName?: unknown; payload?: unknown } | null; + if (record?.type !== MINER_PR_OUTCOME_EVENT) continue; + if (typeof record.repoFullName !== "string" || !record.repoFullName.trim()) continue; + const normalized = normalizePrOutcomePayload(record.payload); + if (!normalized) continue; + // Re-key on every event so Map iteration order tracks most-recently-UPDATED last, not first-seen (#7222). A + // bare Map.set() on an existing key updates the value but leaves the key frozen at its original position, so a + // later outcome for the same PR (e.g. closed-without-merge, then reopened + merged) stayed at its old slot -- + // breaking recency-ordered consumers like loop-reentry.js's countConsecutiveDisengagements. Deleting first + // moves the freshly-updated entry to the end, matching this reducer's own "a later event supersedes" contract. + const key = `${record.repoFullName}:${normalized.prNumber}`; + latest.delete(key); + latest.set(key, { ...normalized, repoFullName: record.repoFullName }); + } + return latest; +} diff --git a/packages/loopover-miner/lib/self-review-context.d.ts b/packages/loopover-miner/lib/self-review-context.d.ts index 3fdcd3bcdc..2ae6828ad6 100644 --- a/packages/loopover-miner/lib/self-review-context.d.ts +++ b/packages/loopover-miner/lib/self-review-context.d.ts @@ -1,58 +1,68 @@ -import type { SelfReviewContext, FocusManifest } from "@loopover/engine"; - -// `bounties` is always omitted (see this file's own header comment for why), so the result is -// SelfReviewContext minus that optional field rather than the full type. `issueQuality` is populated (#6057). +import type { FocusManifest, SelfReviewContext } from "@loopover/engine"; export type SelfReviewContextResult = Omit; - -// A narrower shape than `typeof fetch` on purpose: this module only ever calls it with a string URL and a -// plain GET init, and the ambient `fetch` type in this repo's TS program is Cloudflare-Workers-flavored -// (RequestInfo | URL), which is both irrelevant here (this package runs under plain Node) and -// stricter than any real caller needs -- same rationale as live-issue-snapshot.js's own LiveIssueSnapshotFetch. -export type SelfReviewContextFetch = ( - url: string, - init?: { method?: string; headers?: Record; signal?: AbortSignal }, -) => Promise<{ - ok: boolean; - status: number; - json: () => Promise; - text: () => Promise; +export type SelfReviewContextFetch = (url: string, init?: { + method?: string; + headers?: Record; + signal?: AbortSignal; +}) => Promise<{ + ok: boolean; + status: number; + json: () => Promise; + text: () => Promise; + headers?: { + get(name: string): string | null; + }; + body?: { + getReader(): { + read(): Promise<{ + done: boolean; + value?: Uint8Array; + }>; + cancel(): Promise; + releaseLock(): void; + }; + } | null; }>; - export type LiveGateThresholdFields = { - confidence_floor: number | null; - scope_cap_files: number | null; - scope_cap_lines: number | null; + confidence_floor: number | null; + scope_cap_files: number | null; + scope_cap_lines: number | null; }; - export type LoopoverBackendSessionAuth = { - apiUrl?: string; - sessionToken: string; + apiUrl?: string; + sessionToken: string; }; - export type FetchSelfReviewContextOptions = { - githubToken?: string; - contributorLogin?: string; - linkedIssues?: number[]; - apiBaseUrl?: string; - rawContentBaseUrl?: string; - gittensorApiBase?: string; - fetchImpl?: SelfReviewContextFetch; - perPage?: number; - maxPages?: number; - requestTimeoutMs?: number; - /** Short ORB live-gate-thresholds probe budget (#6487). Default 400ms. */ - liveGateProbeTimeoutMs?: number; - /** Explicit session auth for the ORB probe; `null` forces standalone (skip probe). */ - loopoverAuth?: LoopoverBackendSessionAuth | null; - /** Env used to resolve loopover-mcp session when `loopoverAuth` is omitted. */ - env?: NodeJS.ProcessEnv; + githubToken?: string; + contributorLogin?: string; + linkedIssues?: number[]; + apiBaseUrl?: string; + rawContentBaseUrl?: string; + gittensorApiBase?: string; + fetchImpl?: SelfReviewContextFetch; + perPage?: number; + maxPages?: number; + requestTimeoutMs?: number; + /** Short ORB live-gate-thresholds probe budget (#6487). Default 400ms. */ + liveGateProbeTimeoutMs?: number; + /** Explicit session auth for the ORB probe; `null` forces standalone (skip probe). */ + loopoverAuth?: LoopoverBackendSessionAuth | null; + /** Env used to resolve loopover-mcp session when `loopoverAuth` is omitted. */ + env?: Record; }; - -export function parseLiveGateThresholdFields(payload: unknown): LiveGateThresholdFields | null; - -export function applyLiveGateThresholdsToManifest( - manifest: FocusManifest, - fields: LiveGateThresholdFields | null, -): FocusManifest; - -export function fetchSelfReviewContext(repoFullName: string, options?: FetchSelfReviewContextOptions): Promise; +/** Validate the field-limited #6486/#6487 payload; null when nothing usable is present. */ +export declare function parseLiveGateThresholdFields(payload: unknown): LiveGateThresholdFields | null; +/** + * Overlay live ORB thresholds onto a statically-reconstructed FocusManifest (#6487). + * - confidence_floor → raise-only readinessMinScore (mirrors applySelfTuneOverrideToSettings). + * - scope_cap_files / scope_cap_lines → prefer live sizeMaxFiles / sizeMaxLines when present. + * Other gate fields are left untouched. + */ +export declare function applyLiveGateThresholdsToManifest(manifest: FocusManifest, fields: LiveGateThresholdFields | null): FocusManifest; +/** + * Build a real SelfReviewContext from live GitHub data, at the same fidelity the live gate's own DB-backed + * construction produces. See this file's header for the one field (bounties) deliberately left undefined + * and why; issueQuality is populated from the live GitHub snapshot. Optionally overlays ORB live gate + * thresholds onto the static `.loopover.yml` reconstruction (#6487). + */ +export declare function fetchSelfReviewContext(repoFullName: string, options?: FetchSelfReviewContextOptions): Promise; diff --git a/packages/loopover-miner/lib/self-review-context.js b/packages/loopover-miner/lib/self-review-context.js index bc5682ef54..eac31ec8a0 100644 --- a/packages/loopover-miner/lib/self-review-context.js +++ b/packages/loopover-miner/lib/self-review-context.js @@ -1,30 +1,5 @@ -import { - buildCollisionReport, - buildIssueQualityReport, - MAX_FOCUS_MANIFEST_BYTES, - parseFocusManifestContent, -} from "@loopover/engine"; +import { buildCollisionReport, buildIssueQualityReport, MAX_FOCUS_MANIFEST_BYTES, parseFocusManifestContent, } from "@loopover/engine"; import { resolveLoopoverBackendSession } from "./github-token-resolution.js"; - -// Real SelfReviewContext fetcher (#5145, Wave 3.5). Builds the context object the miner's self-review pass -// (packages/loopover-engine/src/miner/self-review-adapter.ts) needs, at the SAME fidelity the live gate's -// own DB-backed construction produces (src/db/repositories.ts's toRepositoryRecord/toIssueRecord/ -// toPullRequestRecord) -- just built fresh from live GitHub data instead of a DB round-trip, since the miner -// has no database. One of SelfReviewContext's eight fields is DELIBERATELY left undefined, not stubbed: -// -// - `bounties`: bounty data is not GitHub-native in this codebase -- it comes from an external "Gitt" -// system that PUSHES data into the live gate's own internal ingest route (src/api/routes.ts). There is -// no public endpoint the miner could legitimately pull from instead. -// -// `issueQuality` is populated via buildIssueQualityReport (exported from @loopover/engine as a package-local -// twin of the host engine helper — see #6057). Bounty rows and recent-merged PR history are passed as empty -// arrays because this fetcher does not yet pull either source. `bounties` remains omitted for the reason above. -// -// #6487: after the static `.loopover.yml` reconstruction, optionally probe ORB's live-gate-thresholds endpoint -// (same loopover-mcp session posture as resolveGitHubToken). On success, overlay confidence_floor / -// scope_cap_files / scope_cap_lines onto the parsed manifest gate; on 403/timeout/404/no-session, keep the -// static reconstruction unchanged. Fully-standalone (ORB-absent) paths stay byte-identical. - const GITHUB_API_VERSION = "2022-11-28"; const DEFAULT_API_BASE_URL = "https://api.github.com"; const DEFAULT_RAW_CONTENT_BASE_URL = "https://raw.githubusercontent.com"; @@ -34,78 +9,78 @@ const DEFAULT_MAX_PAGES = 10; const DEFAULT_REQUEST_TIMEOUT_MS = 10_000; /** Short ORB probe budget (#6487) — must never make discover/gate-prediction meaningfully slower when ORB is absent. */ const DEFAULT_LIVE_GATE_PROBE_TIMEOUT_MS = 400; - // Mirrors src/signals/focus-manifest-loader.ts's MANIFEST_FILE_CANDIDATES exactly -- first candidate that // resolves wins, same as the live gate's own lookup order. const MANIFEST_FILE_CANDIDATES = [".loopover.yml", ".github/loopover.yml", ".loopover.json", ".github/loopover.json"]; - function parseRepoFullName(repoFullName) { - if (typeof repoFullName !== "string") return null; - const [owner, repo, extra] = repoFullName.split("/"); - if (!owner || !repo || extra !== undefined) return null; - return { owner, repo }; + if (typeof repoFullName !== "string") + return null; + const [owner, repo, extra] = repoFullName.split("/"); + if (!owner || !repo || extra !== undefined) + return null; + return { owner, repo }; } - +// `githubToken` is always a real string here: this function is private and its sole caller (githubGetJson, +// via resolved.githubToken) already comes from normalizeOptions' own `options.githubToken ?? env.GITHUB_TOKEN +// ?? ""` fallback chain, which always resolves to a string. function githubHeaders(githubToken) { - const headers = { - accept: "application/vnd.github+json", - "user-agent": "loopover-miner", - "x-github-api-version": GITHUB_API_VERSION, - }; - const token = typeof githubToken === "string" ? githubToken.trim() : ""; - if (token) headers.authorization = `Bearer ${token}`; - return headers; + const headers = { + accept: "application/vnd.github+json", + "user-agent": "loopover-miner", + "x-github-api-version": GITHUB_API_VERSION, + }; + if (githubToken) + headers.authorization = `Bearer ${githubToken}`; + return headers; } - +// resolveLoopoverBackendSession types `env` as the ambient (Cloudflare-Workers-augmented) `NodeJS.ProcessEnv`, +// stricter than this file's own `Record` -- github-token-resolution.js isn't +// converted to TypeScript yet, and any object matching this shape genuinely satisfies it at runtime either way. +const resolveBackendSession = resolveLoopoverBackendSession; function normalizeOptions(options = {}) { - const env = options.env ?? process.env; - // Explicit null skips the probe (tests / forced-standalone). Undefined ⇒ resolve from loopover-mcp session. - const loopoverAuth = - options.loopoverAuth === null - ? null - : options.loopoverAuth && typeof options.loopoverAuth.sessionToken === "string" && options.loopoverAuth.sessionToken - ? { - apiUrl: - typeof options.loopoverAuth.apiUrl === "string" && options.loopoverAuth.apiUrl.trim() - ? options.loopoverAuth.apiUrl.replace(/\/+$/, "") - : (resolveLoopoverBackendSession(env)?.apiUrl ?? "https://api.loopover.ai"), - sessionToken: options.loopoverAuth.sessionToken, - } - : resolveLoopoverBackendSession(env); - return { - githubToken: options.githubToken ?? env.GITHUB_TOKEN ?? "", - apiBaseUrl: typeof options.apiBaseUrl === "string" && options.apiBaseUrl.trim() ? options.apiBaseUrl.trim() : DEFAULT_API_BASE_URL, - rawContentBaseUrl: - typeof options.rawContentBaseUrl === "string" && options.rawContentBaseUrl.trim() ? options.rawContentBaseUrl.trim() : DEFAULT_RAW_CONTENT_BASE_URL, - gittensorApiBase: - typeof options.gittensorApiBase === "string" && options.gittensorApiBase.trim() ? options.gittensorApiBase.trim() : DEFAULT_GITTENSOR_API_BASE, - fetchImpl: options.fetchImpl ?? fetch, - perPage: Number.isInteger(options.perPage) && options.perPage > 0 ? options.perPage : DEFAULT_PER_PAGE, - maxPages: Number.isInteger(options.maxPages) && options.maxPages > 0 ? options.maxPages : DEFAULT_MAX_PAGES, - contributorLogin: typeof options.contributorLogin === "string" ? options.contributorLogin.trim() : "", - linkedIssues: Array.isArray(options.linkedIssues) ? options.linkedIssues.filter((n) => Number.isInteger(n)) : [], - requestTimeoutMs: Number.isInteger(options.requestTimeoutMs) && options.requestTimeoutMs > 0 ? options.requestTimeoutMs : DEFAULT_REQUEST_TIMEOUT_MS, - liveGateProbeTimeoutMs: - Number.isInteger(options.liveGateProbeTimeoutMs) && options.liveGateProbeTimeoutMs > 0 - ? options.liveGateProbeTimeoutMs - : DEFAULT_LIVE_GATE_PROBE_TIMEOUT_MS, - loopoverAuth, - }; + const env = options.env ?? process.env; + // Explicit null skips the probe (tests / forced-standalone). Undefined ⇒ resolve from loopover-mcp session. + const loopoverAuth = options.loopoverAuth === null + ? null + : options.loopoverAuth && typeof options.loopoverAuth.sessionToken === "string" && options.loopoverAuth.sessionToken + ? { + apiUrl: typeof options.loopoverAuth.apiUrl === "string" && options.loopoverAuth.apiUrl.trim() + ? options.loopoverAuth.apiUrl.replace(/\/+$/, "") + : (resolveBackendSession(env)?.apiUrl ?? "https://api.loopover.ai"), + sessionToken: options.loopoverAuth.sessionToken, + } + : resolveBackendSession(env); + return { + githubToken: options.githubToken ?? env.GITHUB_TOKEN ?? "", + apiBaseUrl: typeof options.apiBaseUrl === "string" && options.apiBaseUrl.trim() ? options.apiBaseUrl.trim() : DEFAULT_API_BASE_URL, + rawContentBaseUrl: typeof options.rawContentBaseUrl === "string" && options.rawContentBaseUrl.trim() ? options.rawContentBaseUrl.trim() : DEFAULT_RAW_CONTENT_BASE_URL, + gittensorApiBase: typeof options.gittensorApiBase === "string" && options.gittensorApiBase.trim() ? options.gittensorApiBase.trim() : DEFAULT_GITTENSOR_API_BASE, + fetchImpl: options.fetchImpl ?? fetch, + perPage: Number.isInteger(options.perPage) && options.perPage > 0 ? options.perPage : DEFAULT_PER_PAGE, + maxPages: Number.isInteger(options.maxPages) && options.maxPages > 0 ? options.maxPages : DEFAULT_MAX_PAGES, + contributorLogin: typeof options.contributorLogin === "string" ? options.contributorLogin.trim() : "", + linkedIssues: Array.isArray(options.linkedIssues) ? options.linkedIssues.filter((n) => Number.isInteger(n)) : [], + requestTimeoutMs: Number.isInteger(options.requestTimeoutMs) && options.requestTimeoutMs > 0 ? options.requestTimeoutMs : DEFAULT_REQUEST_TIMEOUT_MS, + liveGateProbeTimeoutMs: Number.isInteger(options.liveGateProbeTimeoutMs) && options.liveGateProbeTimeoutMs > 0 + ? options.liveGateProbeTimeoutMs + : DEFAULT_LIVE_GATE_PROBE_TIMEOUT_MS, + loopoverAuth, + }; } - /** Validate the field-limited #6486/#6487 payload; null when nothing usable is present. */ export function parseLiveGateThresholdFields(payload) { - if (!payload || typeof payload !== "object" || Array.isArray(payload)) return null; - const confidence_floor = - typeof payload.confidence_floor === "number" && payload.confidence_floor >= 0 && payload.confidence_floor <= 1 - ? payload.confidence_floor - : null; - const scope_cap_files = typeof payload.scope_cap_files === "number" && payload.scope_cap_files > 0 ? payload.scope_cap_files : null; - const scope_cap_lines = typeof payload.scope_cap_lines === "number" && payload.scope_cap_lines > 0 ? payload.scope_cap_lines : null; - if (confidence_floor === null && scope_cap_files === null && scope_cap_lines === null) return null; - return { confidence_floor, scope_cap_files, scope_cap_lines }; + if (!payload || typeof payload !== "object" || Array.isArray(payload)) + return null; + const record = payload; + const confidence_floor = typeof record.confidence_floor === "number" && record.confidence_floor >= 0 && record.confidence_floor <= 1 + ? record.confidence_floor + : null; + const scope_cap_files = typeof record.scope_cap_files === "number" && record.scope_cap_files > 0 ? record.scope_cap_files : null; + const scope_cap_lines = typeof record.scope_cap_lines === "number" && record.scope_cap_lines > 0 ? record.scope_cap_lines : null; + if (confidence_floor === null && scope_cap_files === null && scope_cap_lines === null) + return null; + return { confidence_floor, scope_cap_files, scope_cap_lines }; } - /** * Overlay live ORB thresholds onto a statically-reconstructed FocusManifest (#6487). * - confidence_floor → raise-only readinessMinScore (mirrors applySelfTuneOverrideToSettings). @@ -113,276 +88,278 @@ export function parseLiveGateThresholdFields(payload) { * Other gate fields are left untouched. */ export function applyLiveGateThresholdsToManifest(manifest, fields) { - if (!manifest || !fields) return manifest; - const gate = { ...manifest.gate }; - if (typeof fields.confidence_floor === "number") { - const floorScore = Math.max(0, Math.min(100, Math.round(fields.confidence_floor * 100))); - if (typeof gate.readinessMinScore === "number" && floorScore > gate.readinessMinScore) { - gate.readinessMinScore = floorScore; + if (!manifest || !fields) + return manifest; + const gate = { ...manifest.gate }; + if (typeof fields.confidence_floor === "number") { + const floorScore = Math.max(0, Math.min(100, Math.round(fields.confidence_floor * 100))); + if (typeof gate.readinessMinScore === "number" && floorScore > gate.readinessMinScore) { + gate.readinessMinScore = floorScore; + } } - } - if (typeof fields.scope_cap_files === "number" && fields.scope_cap_files > 0) { - gate.sizeMaxFiles = fields.scope_cap_files; - } - if (typeof fields.scope_cap_lines === "number" && fields.scope_cap_lines > 0) { - gate.sizeMaxLines = fields.scope_cap_lines; - } - return { ...manifest, gate }; + if (typeof fields.scope_cap_files === "number" && fields.scope_cap_files > 0) { + gate.sizeMaxFiles = fields.scope_cap_files; + } + if (typeof fields.scope_cap_lines === "number" && fields.scope_cap_lines > 0) { + gate.sizeMaxLines = fields.scope_cap_lines; + } + return { ...manifest, gate }; } - async function probeLiveGateThresholds(target, resolved) { - const auth = resolved.loopoverAuth; - if (!auth?.sessionToken) return null; - const url = `${auth.apiUrl}/v1/repos/${encodeURIComponent(target.owner)}/${encodeURIComponent(target.repo)}/live-gate-thresholds`; - try { - const response = await fetchWithTimeout( - resolved.fetchImpl, - url, - { - method: "GET", - headers: { - authorization: `Bearer ${auth.sessionToken}`, - accept: "application/json", - "user-agent": "loopover-miner", - }, - }, - resolved.liveGateProbeTimeoutMs, - ); - if (!response.ok) return null; - const payload = await response.json().catch(() => null); - return parseLiveGateThresholdFields(payload); - } catch { - return null; - } + const auth = resolved.loopoverAuth; + if (!auth?.sessionToken) + return null; + const url = `${auth.apiUrl}/v1/repos/${encodeURIComponent(target.owner)}/${encodeURIComponent(target.repo)}/live-gate-thresholds`; + try { + const response = await fetchWithTimeout(resolved.fetchImpl, url, { + method: "GET", + headers: { + authorization: `Bearer ${auth.sessionToken}`, + accept: "application/json", + "user-agent": "loopover-miner", + }, + }, resolved.liveGateProbeTimeoutMs); + if (!response.ok) + return null; + const payload = await response.json().catch(() => null); + return parseLiveGateThresholdFields(payload); + } + catch { + return null; + } } - // A fresh AbortSignal.timeout() per call, so a stalled connection can't hang context construction forever // (#miner-github-read-timeouts) -- shared by this file's three independent fetch call sites (GitHub REST, raw // manifest content, the Gittensor contributor lookup). async function fetchWithTimeout(fetchImpl, url, init, timeoutMs) { - return fetchImpl(url, { ...init, signal: AbortSignal.timeout(timeoutMs) }); + return fetchImpl(url, { ...init, signal: AbortSignal.timeout(timeoutMs) }); } - async function githubGetJson(url, resolved) { - const response = await fetchWithTimeout(resolved.fetchImpl, url, { method: "GET", headers: githubHeaders(resolved.githubToken) }, resolved.requestTimeoutMs); - const payload = await response.json().catch(() => null); - return { response, payload }; + const response = await fetchWithTimeout(resolved.fetchImpl, url, { method: "GET", headers: githubHeaders(resolved.githubToken) }, resolved.requestTimeoutMs); + const payload = await response.json().catch(() => null); + return { response, payload }; } - async function fetchPaginated(pathWithQuery, resolved) { - const results = []; - for (let page = 1; page <= resolved.maxPages; page += 1) { - const separator = pathWithQuery.includes("?") ? "&" : "?"; - const url = `${resolved.apiBaseUrl}${pathWithQuery}${separator}per_page=${resolved.perPage}&page=${page}`; - const { response, payload } = await githubGetJson(url, resolved); - if (!response.ok || !Array.isArray(payload)) break; - results.push(...payload); - if (payload.length < resolved.perPage) break; - } - return results; + const results = []; + for (let page = 1; page <= resolved.maxPages; page += 1) { + const separator = pathWithQuery.includes("?") ? "&" : "?"; + const url = `${resolved.apiBaseUrl}${pathWithQuery}${separator}per_page=${resolved.perPage}&page=${page}`; + const { response, payload } = await githubGetJson(url, resolved); + if (!response.ok || !Array.isArray(payload)) + break; + results.push(...payload); + if (payload.length < resolved.perPage) + break; + } + return results; } - // Mirrors src/db/repositories.ts's toRepositoryRecord + upsertRepositoryFromGitHub's field mapping. The // miner has no App installation/DB, so installationId/isInstalled/isRegistered/registryConfig are honest // "unregistered" defaults, not values pulled from GitHub -- GitHub's own repo payload carries none of them. async function fetchRepositoryRecord(target, resolved) { - const url = `${resolved.apiBaseUrl}/repos/${encodeURIComponent(target.owner)}/${encodeURIComponent(target.repo)}`; - const { response, payload } = await githubGetJson(url, resolved); - if (!response.ok || !payload || typeof payload !== "object") return null; - return { - fullName: `${target.owner}/${target.repo}`, - owner: payload.owner?.login ?? target.owner, - name: payload.name ?? target.repo, - installationId: undefined, - isInstalled: false, - isRegistered: false, - isPrivate: payload.private ?? false, - htmlUrl: payload.html_url ?? null, - defaultBranch: payload.default_branch ?? null, - registryConfig: null, - }; + const url = `${resolved.apiBaseUrl}/repos/${encodeURIComponent(target.owner)}/${encodeURIComponent(target.repo)}`; + const { response, payload } = await githubGetJson(url, resolved); + if (!response.ok || !payload || typeof payload !== "object") + return null; + const record = payload; + return { + fullName: `${target.owner}/${target.repo}`, + owner: record.owner?.login ?? target.owner, + name: record.name ?? target.repo, + installationId: undefined, + isInstalled: false, + isRegistered: false, + isPrivate: record.private ?? false, + htmlUrl: record.html_url ?? null, + defaultBranch: record.default_branch ?? null, + registryConfig: null, + }; } - // Mirrors src/db/repositories.ts's extractLinkedPrNumbers: a real link needs a CLOSING KEYWORD, not a bare // mention (#6769). Without the keyword prefix, an incidental "similar to what we saw in PR #501" in an issue // body counted as a linked PR, so the issue-quality report read the issue as "already references a PR" and the // miner skipped an available issue (the host's own #issue-body-pr-mention-pollution fix, never ported here). const LINKED_PR_PATTERN = /\b(?:close[sd]?|fix(?:e[sd])?|resolve[sd]?)\s+(?:PR|pull request)\s+#(\d+)\b/gi; function extractLinkedPrNumbers(body) { - const numbers = []; - for (const match of body.matchAll(LINKED_PR_PATTERN)) { - const number = Number(match[1]); - if (Number.isInteger(number) && number > 0) numbers.push(number); - } - return numbers; + const numbers = []; + for (const match of body.matchAll(LINKED_PR_PATTERN)) { + const number = Number(match[1]); + if (Number.isInteger(number) && number > 0) + numbers.push(number); + } + return numbers; } - // Mirrors src/db/repositories.ts's extractLinkedIssueNumbers: GitHub's own closing-keyword vocabulary, only // counting a fully-qualified owner/repo#N reference when it targets the SAME repo being fetched. const LINKED_ISSUE_PATTERN = /\b(?:close[sd]?|fix(?:e[sd])?|resolve[sd]?)\s+(?:([\w.-]+\/[\w.-]+)#|#)(\d+)\b/gi; function extractLinkedIssueNumbers(body, repoFullName) { - // Strip backtick code spans first so a closing-keyword pattern quoted as example code doesn't count. - const withoutCodeSpans = body.replace(/`[^`]*`/g, ""); - const numbers = []; - const normalizedRepo = repoFullName.toLowerCase(); - for (const match of withoutCodeSpans.matchAll(LINKED_ISSUE_PATTERN)) { - const qualifiedRepo = match[1]; - if (qualifiedRepo !== undefined && qualifiedRepo.toLowerCase() !== normalizedRepo) continue; - const number = Number(match[2]); - if (Number.isInteger(number) && number > 0) numbers.push(number); - } - return numbers; + // Strip backtick code spans first so a closing-keyword pattern quoted as example code doesn't count. + const withoutCodeSpans = body.replace(/`[^`]*`/g, ""); + const numbers = []; + const normalizedRepo = repoFullName.toLowerCase(); + for (const match of withoutCodeSpans.matchAll(LINKED_ISSUE_PATTERN)) { + const qualifiedRepo = match[1]; + if (qualifiedRepo !== undefined && qualifiedRepo.toLowerCase() !== normalizedRepo) + continue; + const number = Number(match[2]); + if (Number.isInteger(number) && number > 0) + numbers.push(number); + } + return numbers; } - function labelNames(labels) { - if (!Array.isArray(labels)) return []; - return labels.flatMap((label) => (label && typeof label === "object" && typeof label.name === "string" ? [label.name] : [])); + if (!Array.isArray(labels)) + return []; + return labels.flatMap((label) => (label && typeof label === "object" && typeof label.name === "string" ? [label.name] : [])); } - // Mirrors src/db/repositories.ts's toIssueRecord, populated straight from the live payload (createdAt/ // updatedAt/closedAt come from the DB-row read path there only as a caching artifact, not a semantic // transform -- the live REST fields are the real source). function toIssueRecord(repoFullName, issue) { - const body = issue.body ?? ""; - return { - repoFullName, - number: issue.number, - title: issue.title, - state: issue.state, - authorLogin: issue.user?.login ?? null, - authorAssociation: issue.author_association ?? null, - htmlUrl: issue.html_url ?? null, - body, - createdAt: issue.created_at ?? null, - updatedAt: issue.updated_at ?? null, - closedAt: issue.closed_at ?? null, - labels: labelNames(issue.labels), - linkedPrs: extractLinkedPrNumbers(body), - }; + const body = issue.body ?? ""; + const user = issue.user; + return { + repoFullName, + number: issue.number, + title: issue.title, + state: issue.state, + authorLogin: user?.login ?? null, + authorAssociation: issue.author_association ?? null, + htmlUrl: issue.html_url ?? null, + body, + createdAt: issue.created_at ?? null, + updatedAt: issue.updated_at ?? null, + closedAt: issue.closed_at ?? null, + labels: labelNames(issue.labels), + linkedPrs: extractLinkedPrNumbers(body), + }; } - async function fetchOpenIssueRecords(target, resolved) { - const payloads = await fetchPaginated( - `/repos/${encodeURIComponent(target.owner)}/${encodeURIComponent(target.repo)}/issues?state=open&sort=created&direction=asc`, - resolved, - ); - // GitHub's Issues endpoint also returns pull requests -- filter them out, same as the live gate's own fetch. - return payloads.filter((issue) => issue && typeof issue === "object" && !issue.pull_request).map((issue) => toIssueRecord(`${target.owner}/${target.repo}`, issue)); + const payloads = await fetchPaginated(`/repos/${encodeURIComponent(target.owner)}/${encodeURIComponent(target.repo)}/issues?state=open&sort=created&direction=asc`, resolved); + // GitHub's Issues endpoint also returns pull requests -- filter them out, same as the live gate's own fetch. + return payloads + .filter((issue) => Boolean(issue) && typeof issue === "object" && !issue.pull_request) + .map((issue) => toIssueRecord(`${target.owner}/${target.repo}`, issue)); } - function mergeableBooleanState(mergeable) { - if (mergeable === true) return "clean"; - if (mergeable === false) return "dirty"; - return null; + if (mergeable === true) + return "clean"; + if (mergeable === false) + return "dirty"; + return null; } - // Mirrors src/db/repositories.ts's toPullRequestRecord. Only the fields SelfReviewContext/buildCollisionReport // actually consume are populated with real precision; merge/RC3 gate-plumbing fields the live gate's fuller // PullRequestRecord carries (mergeAttemptCount, approvedHeadSha, ...) don't exist on the engine package's // leaner mirror type and aren't meaningful for a miner attempt anyway. function toPullRequestRecord(repoFullName, pr) { - const body = pr.body ?? ""; - return { - repoFullName, - number: pr.number, - title: pr.title, - state: pr.state, - authorLogin: pr.user?.login ?? null, - authorAssociation: pr.author_association ?? null, - headSha: pr.head?.sha ?? null, - headRef: pr.head?.ref ?? null, - baseRef: pr.base?.ref ?? null, - htmlUrl: pr.html_url ?? null, - mergedAt: pr.merged_at ?? null, - isDraft: pr.draft ?? null, - mergeableState: pr.mergeable_state ?? mergeableBooleanState(pr.mergeable), - reviewDecision: null, - body, - createdAt: pr.created_at ?? null, - updatedAt: pr.updated_at ?? null, - closedAt: pr.closed_at ?? null, - labels: labelNames(pr.labels), - linkedIssues: extractLinkedIssueNumbers(body, repoFullName), - }; + const body = pr.body ?? ""; + const user = pr.user; + const head = pr.head; + const base = pr.base; + return { + repoFullName, + number: pr.number, + title: pr.title, + state: pr.state, + authorLogin: user?.login ?? null, + authorAssociation: pr.author_association ?? null, + headSha: head?.sha ?? null, + headRef: head?.ref ?? null, + baseRef: base?.ref ?? null, + htmlUrl: pr.html_url ?? null, + mergedAt: pr.merged_at ?? null, + isDraft: pr.draft ?? null, + mergeableState: pr.mergeable_state ?? mergeableBooleanState(pr.mergeable), + reviewDecision: null, + body, + createdAt: pr.created_at ?? null, + updatedAt: pr.updated_at ?? null, + closedAt: pr.closed_at ?? null, + labels: labelNames(pr.labels), + linkedIssues: extractLinkedIssueNumbers(body, repoFullName), + }; } - async function fetchOpenPullRequestRecords(target, resolved) { - const payloads = await fetchPaginated( - `/repos/${encodeURIComponent(target.owner)}/${encodeURIComponent(target.repo)}/pulls?state=open&sort=created&direction=asc`, - resolved, - ); - return payloads.map((pr) => toPullRequestRecord(`${target.owner}/${target.repo}`, pr)); + const payloads = await fetchPaginated(`/repos/${encodeURIComponent(target.owner)}/${encodeURIComponent(target.repo)}/pulls?state=open&sort=created&direction=asc`, resolved); + return payloads.map((pr) => toPullRequestRecord(`${target.owner}/${target.repo}`, pr)); } - // Mirrors src/signals/focus-manifest-loader.ts's raw-content lookup order and bounded body read: // first candidate path that resolves wins, but hostile manifests never exceed the parser byte cap in memory. async function readBoundedManifestResponseText(response) { - const contentLength = response.headers?.get?.("content-length") ?? null; - if (contentLength !== null) { - const parsedLength = Number.parseInt(contentLength, 10); - if (Number.isFinite(parsedLength) && parsedLength > MAX_FOCUS_MANIFEST_BYTES) return null; - } - if (!response.body?.getReader) { - const text = await response.text(); - if (typeof text !== "string") return null; - return new TextEncoder().encode(text).byteLength > MAX_FOCUS_MANIFEST_BYTES ? null : text; - } - - const reader = response.body.getReader(); - const decoder = new TextDecoder(); - let totalBytes = 0; - let text = ""; - try { - while (true) { - const { done, value } = await reader.read(); - if (done) break; - totalBytes += value.byteLength; - if (totalBytes > MAX_FOCUS_MANIFEST_BYTES) { - await reader.cancel(); - return null; - } - text += decoder.decode(value, { stream: true }); + const contentLength = response.headers?.get?.("content-length") ?? null; + if (contentLength !== null) { + const parsedLength = Number.parseInt(contentLength, 10); + if (Number.isFinite(parsedLength) && parsedLength > MAX_FOCUS_MANIFEST_BYTES) + return null; + } + if (!response.body?.getReader) { + const text = await response.text(); + if (typeof text !== "string") + return null; + return new TextEncoder().encode(text).byteLength > MAX_FOCUS_MANIFEST_BYTES ? null : text; + } + const reader = response.body.getReader(); + const decoder = new TextDecoder(); + let totalBytes = 0; + let text = ""; + try { + for (;;) { + const { done, value } = await reader.read(); + if (done) + break; + totalBytes += value?.byteLength ?? 0; + if (totalBytes > MAX_FOCUS_MANIFEST_BYTES) { + await reader.cancel(); + return null; + } + if (value) + text += decoder.decode(value, { stream: true }); + } + text += decoder.decode(); + return text; + } + finally { + reader.releaseLock(); } - text += decoder.decode(); - return text; - } finally { - reader.releaseLock(); - } } - async function fetchManifestContent(target, resolved) { - for (const path of MANIFEST_FILE_CANDIDATES) { - const url = `${resolved.rawContentBaseUrl}/${encodeURIComponent(target.owner)}/${encodeURIComponent(target.repo)}/HEAD/${path}`; - try { - const response = await fetchWithTimeout(resolved.fetchImpl, url, { method: "GET", headers: { accept: "application/json", "user-agent": "loopover-miner" } }, resolved.requestTimeoutMs); - if (response.ok) { - const text = await readBoundedManifestResponseText(response); - if (typeof text === "string") return text; - } - } catch { - // Try the next candidate path. + for (const path of MANIFEST_FILE_CANDIDATES) { + const url = `${resolved.rawContentBaseUrl}/${encodeURIComponent(target.owner)}/${encodeURIComponent(target.repo)}/HEAD/${path}`; + try { + const response = await fetchWithTimeout(resolved.fetchImpl, url, { method: "GET", headers: { accept: "application/json", "user-agent": "loopover-miner" } }, resolved.requestTimeoutMs); + if (response.ok) { + const text = await readBoundedManifestResponseText(response); + if (typeof text === "string") + return text; + } + } + catch { + // Try the next candidate path. + } } - } - return null; + return null; } - // Mirrors src/gittensor/api.ts's fetchGittensorContributorSnapshot/fetchOfficialGittensorMiner: a public, // unauthenticated GET against the Gittensor API (not GitHub) -- confirmed only when a real entry with a // matching GitHub login is found; any transport/parse failure fails closed to "not confirmed", never throws. async function fetchConfirmedContributor(login, resolved) { - if (!login) return false; - try { - const response = await fetchWithTimeout(resolved.fetchImpl, `${resolved.gittensorApiBase}/miners`, { method: "GET", headers: { accept: "application/json" } }, resolved.requestTimeoutMs); - if (!response.ok) return false; - const payload = await response.json().catch(() => null); - if (!Array.isArray(payload)) return false; - const normalizedLogin = login.toLowerCase(); - return payload.some((miner) => typeof miner?.githubUsername === "string" && miner.githubUsername.toLowerCase() === normalizedLogin); - } catch { - return false; - } + if (!login) + return false; + try { + const response = await fetchWithTimeout(resolved.fetchImpl, `${resolved.gittensorApiBase}/miners`, { method: "GET", headers: { accept: "application/json" } }, resolved.requestTimeoutMs); + if (!response.ok) + return false; + const payload = await response.json().catch(() => null); + if (!Array.isArray(payload)) + return false; + const normalizedLogin = login.toLowerCase(); + return payload.some((miner) => typeof miner?.githubUsername === "string" && miner.githubUsername.toLowerCase() === normalizedLogin); + } + catch { + return false; + } } - // Per self-review-adapter.ts's own doc comment: the caller computes inDuplicateCluster "the same way the // live gate's collision report would" -- adapted from src/signals/engine.ts's real // isPullRequestInDuplicateCluster (root src/, not extracted to the engine package), which requires >= 2 @@ -394,63 +371,48 @@ async function fetchConfirmedContributor(login, resolved) { // not-yet-existing PR number, since the miner's own submission doesn't exist as a real PullRequestRecord yet. // Takes a prebuilt CollisionReport so issueQuality and inDuplicateCluster share one collision pass. function computeInDuplicateCluster(collisionReport, targetIssueNumbers) { - if (targetIssueNumbers.length === 0) return false; - return collisionReport.clusters.some( - (cluster) => - cluster.risk === "high" && - cluster.items.filter((item) => item.type === "pull_request").length >= 2 && - cluster.items.some((item) => item.type === "issue" && targetIssueNumbers.includes(item.number)), - ); + if (targetIssueNumbers.length === 0) + return false; + return collisionReport.clusters.some((cluster) => cluster.risk === "high" && + cluster.items.filter((item) => item.type === "pull_request").length >= 2 && + cluster.items.some((item) => item.type === "issue" && targetIssueNumbers.includes(item.number))); } - /** * Build a real SelfReviewContext from live GitHub data, at the same fidelity the live gate's own DB-backed * construction produces. See this file's header for the one field (bounties) deliberately left undefined * and why; issueQuality is populated from the live GitHub snapshot. Optionally overlays ORB live gate * thresholds onto the static `.loopover.yml` reconstruction (#6487). - * - * @param {string} repoFullName - * @param {{ - * githubToken?: string, contributorLogin?: string, linkedIssues?: number[], - * apiBaseUrl?: string, rawContentBaseUrl?: string, gittensorApiBase?: string, - * fetchImpl?: typeof fetch, perPage?: number, maxPages?: number, requestTimeoutMs?: number, - * liveGateProbeTimeoutMs?: number, - * loopoverAuth?: { apiUrl?: string, sessionToken: string } | null, - * env?: NodeJS.ProcessEnv, - * }} [options] - * @returns {Promise} */ export async function fetchSelfReviewContext(repoFullName, options = {}) { - const target = parseRepoFullName(repoFullName); - if (!target) throw new Error("invalid_repo_full_name"); - const resolved = normalizeOptions(options); - - const [repo, issues, pullRequests, manifestContent, confirmedContributor, liveGateThresholds] = await Promise.all([ - fetchRepositoryRecord(target, resolved), - fetchOpenIssueRecords(target, resolved), - fetchOpenPullRequestRecords(target, resolved), - fetchManifestContent(target, resolved), - fetchConfirmedContributor(resolved.contributorLogin, resolved), - probeLiveGateThresholds(target, resolved), - ]); - - const staticManifest = parseFocusManifestContent(manifestContent, "repo_file"); - const manifest = applyLiveGateThresholdsToManifest(staticManifest, liveGateThresholds); - // Positional args match buildIssueQualityReport(repo, issues, pullRequests, fullName, bounties, collisions, recentMerged): - // repo is the full RepositoryRecord from fetchRepositoryRecord (not a string); empty bounties/recentMerged - // because this fetcher has no external bounty source and does not yet pull merge history. - const fullName = `${target.owner}/${target.repo}`; - const collisions = buildCollisionReport(fullName, issues, pullRequests); - const inDuplicateCluster = computeInDuplicateCluster(collisions, resolved.linkedIssues); - const issueQuality = buildIssueQualityReport(repo, issues, pullRequests, fullName, [], collisions, []); - - return { - manifest, - repo, - issues, - pullRequests, - confirmedContributor, - inDuplicateCluster, - issueQuality, - }; + const target = parseRepoFullName(repoFullName); + if (!target) + throw new Error("invalid_repo_full_name"); + const resolved = normalizeOptions(options); + const [repo, issues, pullRequests, manifestContent, confirmedContributor, liveGateThresholds] = await Promise.all([ + fetchRepositoryRecord(target, resolved), + fetchOpenIssueRecords(target, resolved), + fetchOpenPullRequestRecords(target, resolved), + fetchManifestContent(target, resolved), + fetchConfirmedContributor(resolved.contributorLogin, resolved), + probeLiveGateThresholds(target, resolved), + ]); + const staticManifest = parseFocusManifestContent(manifestContent, "repo_file"); + const manifest = applyLiveGateThresholdsToManifest(staticManifest, liveGateThresholds); + // Positional args match buildIssueQualityReport(repo, issues, pullRequests, fullName, bounties, collisions, recentMerged): + // repo is the full RepositoryRecord from fetchRepositoryRecord (not a string); empty bounties/recentMerged + // because this fetcher has no external bounty source and does not yet pull merge history. + const fullName = `${target.owner}/${target.repo}`; + const collisions = buildCollisionReport(fullName, issues, pullRequests); + const inDuplicateCluster = computeInDuplicateCluster(collisions, resolved.linkedIssues); + const issueQuality = buildIssueQualityReport(repo, issues, pullRequests, fullName, [], collisions, []); + return { + manifest, + repo, + issues, + pullRequests, + confirmedContributor, + inDuplicateCluster, + issueQuality, + }; } +//# sourceMappingURL=data:application/json;base64,{"version":3,"file":"self-review-context.js","sourceRoot":"","sources":["self-review-context.ts"],"names":[],"mappings":"AAAA,OAAO,EACL,oBAAoB,EACpB,uBAAuB,EACvB,wBAAwB,EACxB,yBAAyB,GAC1B,MAAM,kBAAkB,CAAC;AAE1B,OAAO,EAAE,6BAA6B,EAAE,MAAM,8BAA8B,CAAC;AAyF7E,MAAM,kBAAkB,GAAG,YAAY,CAAC;AACxC,MAAM,oBAAoB,GAAG,wBAAwB,CAAC;AACtD,MAAM,4BAA4B,GAAG,mCAAmC,CAAC;AACzE,MAAM,0BAA0B,GAAG,0BAA0B,CAAC;AAC9D,MAAM,gBAAgB,GAAG,GAAG,CAAC;AAC7B,MAAM,iBAAiB,GAAG,EAAE,CAAC;AAC7B,MAAM,0BAA0B,GAAG,MAAM,CAAC;AAC1C,wHAAwH;AACxH,MAAM,kCAAkC,GAAG,GAAG,CAAC;AAE/C,0GAA0G;AAC1G,2DAA2D;AAC3D,MAAM,wBAAwB,GAAG,CAAC,eAAe,EAAE,sBAAsB,EAAE,gBAAgB,EAAE,uBAAuB,CAAC,CAAC;AAEtH,SAAS,iBAAiB,CAAC,YAAoB;IAC7C,IAAI,OAAO,YAAY,KAAK,QAAQ;QAAE,OAAO,IAAI,CAAC;IAClD,MAAM,CAAC,KAAK,EAAE,IAAI,EAAE,KAAK,CAAC,GAAG,YAAY,CAAC,KAAK,CAAC,GAAG,CAAC,CAAC;IACrD,IAAI,CAAC,KAAK,IAAI,CAAC,IAAI,IAAI,KAAK,KAAK,SAAS;QAAE,OAAO,IAAI,CAAC;IACxD,OAAO,EAAE,KAAK,EAAE,IAAI,EAAE,CAAC;AACzB,CAAC;AAED,2GAA2G;AAC3G,8GAA8G;AAC9G,4DAA4D;AAC5D,SAAS,aAAa,CAAC,WAAmB;IACxC,MAAM,OAAO,GAA2B;QACtC,MAAM,EAAE,6BAA6B;QACrC,YAAY,EAAE,gBAAgB;QAC9B,sBAAsB,EAAE,kBAAkB;KAC3C,CAAC;IACF,IAAI,WAAW;QAAE,OAAO,CAAC,aAAa,GAAG,UAAU,WAAW,EAAE,CAAC;IACjE,OAAO,OAAO,CAAC;AACjB,CAAC;AAED,+GAA+G;AAC/G,yGAAyG;AACzG,gHAAgH;AAChH,MAAM,qBAAqB,GAAG,6BAEQ,CAAC;AAEvC,SAAS,gBAAgB,CAAC,UAAyC,EAAE;IACnE,MAAM,GAAG,GAAG,OAAO,CAAC,GAAG,IAAI,OAAO,CAAC,GAAG,CAAC;IACvC,4GAA4G;IAC5G,MAAM,YAAY,GAChB,OAAO,CAAC,YAAY,KAAK,IAAI;QAC3B,CAAC,CAAC,IAAI;QACN,CAAC,CAAC,OAAO,CAAC,YAAY,IAAI,OAAO,OAAO,CAAC,YAAY,CAAC,YAAY,KAAK,QAAQ,IAAI,OAAO,CAAC,YAAY,CAAC,YAAY;YAClH,CAAC,CAAC;gBACE,MAAM,EACJ,OAAO,OAAO,CAAC,YAAY,CAAC,MAAM,KAAK,QAAQ,IAAI,OAAO,CAAC,YAAY,CAAC,MAAM,CAAC,IAAI,EAAE;oBACnF,CAAC,CAAC,OAAO,CAAC,YAAY,CAAC,MAAM,CAAC,OAAO,CAAC,MAAM,EAAE,EAAE,CAAC;oBACjD,CAAC,CAAC,CAAC,qBAAqB,CAAC,GAAG,CAAC,EAAE,MAAM,IAAI,yBAAyB,CAAC;gBACvE,YAAY,EAAE,OAAO,CAAC,YAAY,CAAC,YAAY;aAChD;YACH,CAAC,CAAC,qBAAqB,CAAC,GAAG,CAAC,CAAC;IACnC,OAAO;QACL,WAAW,EAAE,OAAO,CAAC,WAAW,IAAI,GAAG,CAAC,YAAY,IAAI,EAAE;QAC1D,UAAU,EAAE,OAAO,OAAO,CAAC,UAAU,KAAK,QAAQ,IAAI,OAAO,CAAC,UAAU,CAAC,IAAI,EAAE,CAAC,CAAC,CAAC,OAAO,CAAC,UAAU,CAAC,IAAI,EAAE,CAAC,CAAC,CAAC,oBAAoB;QAClI,iBAAiB,EACf,OAAO,OAAO,CAAC,iBAAiB,KAAK,QAAQ,IAAI,OAAO,CAAC,iBAAiB,CAAC,IAAI,EAAE,CAAC,CAAC,CAAC,OAAO,CAAC,iBAAiB,CAAC,IAAI,EAAE,CAAC,CAAC,CAAC,4BAA4B;QACrJ,gBAAgB,EACd,OAAO,OAAO,CAAC,gBAAgB,KAAK,QAAQ,IAAI,OAAO,CAAC,gBAAgB,CAAC,IAAI,EAAE,CAAC,CAAC,CAAC,OAAO,CAAC,gBAAgB,CAAC,IAAI,EAAE,CAAC,CAAC,CAAC,0BAA0B;QAChJ,SAAS,EAAE,OAAO,CAAC,SAAS,IAAK,KAA2C;QAC5E,OAAO,EAAE,MAAM,CAAC,SAAS,CAAC,OAAO,CAAC,OAAO,CAAC,IAAK,OAAO,CAAC,OAAkB,GAAG,CAAC,CAAC,CAAC,CAAE,OAAO,CAAC,OAAkB,CAAC,CAAC,CAAC,gBAAgB;QAC9H,QAAQ,EAAE,MAAM,CAAC,SAAS,CAAC,OAAO,CAAC,QAAQ,CAAC,IAAK,OAAO,CAAC,QAAmB,GAAG,CAAC,CAAC,CAAC,CAAE,OAAO,CAAC,QAAmB,CAAC,CAAC,CAAC,iBAAiB;QACnI,gBAAgB,EAAE,OAAO,OAAO,CAAC,gBAAgB,KAAK,QAAQ,CAAC,CAAC,CAAC,OAAO,CAAC,gBAAgB,CAAC,IAAI,EAAE,CAAC,CAAC,CAAC,EAAE;QACrG,YAAY,EAAE,KAAK,CAAC,OAAO,CAAC,OAAO,CAAC,YAAY,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,YAAY,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,MAAM,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,EAAE;QAChH,gBAAgB,EAAE,MAAM,CAAC,SAAS,CAAC,OAAO,CAAC,gBAAgB,CAAC,IAAK,OAAO,CAAC,gBAA2B,GAAG,CAAC,CAAC,CAAC,CAAE,OAAO,CAAC,gBAA2B,CAAC,CAAC,CAAC,0BAA0B;QAC5K,sBAAsB,EACpB,MAAM,CAAC,SAAS,CAAC,OAAO,CAAC,sBAAsB,CAAC,IAAK,OAAO,CAAC,sBAAiC,GAAG,CAAC;YAChG,CAAC,CAAE,OAAO,CAAC,sBAAiC;YAC5C,CAAC,CAAC,kCAAkC;QACxC,YAAY;KACb,CAAC;AACJ,CAAC;AAED,2FAA2F;AAC3F,MAAM,UAAU,4BAA4B,CAAC,OAAgB;IAC3D,IAAI,CAAC,OAAO,IAAI,OAAO,OAAO,KAAK,QAAQ,IAAI,KAAK,CAAC,OAAO,CAAC,OAAO,CAAC;QAAE,OAAO,IAAI,CAAC;IACnF,MAAM,MAAM,GAAG,OAA+F,CAAC;IAC/G,MAAM,gBAAgB,GACpB,OAAO,MAAM,CAAC,gBAAgB,KAAK,QAAQ,IAAI,MAAM,CAAC,gBAAgB,IAAI,CAAC,IAAI,MAAM,CAAC,gBAAgB,IAAI,CAAC;QACzG,CAAC,CAAC,MAAM,CAAC,gBAAgB;QACzB,CAAC,CAAC,IAAI,CAAC;IACX,MAAM,eAAe,GAAG,OAAO,MAAM,CAAC,eAAe,KAAK,QAAQ,IAAI,MAAM,CAAC,eAAe,GAAG,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC,eAAe,CAAC,CAAC,CAAC,IAAI,CAAC;IACjI,MAAM,eAAe,GAAG,OAAO,MAAM,CAAC,eAAe,KAAK,QAAQ,IAAI,MAAM,CAAC,eAAe,GAAG,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC,eAAe,CAAC,CAAC,CAAC,IAAI,CAAC;IACjI,IAAI,gBAAgB,KAAK,IAAI,IAAI,eAAe,KAAK,IAAI,IAAI,eAAe,KAAK,IAAI;QAAE,OAAO,IAAI,CAAC;IACnG,OAAO,EAAE,gBAAgB,EAAE,eAAe,EAAE,eAAe,EAAE,CAAC;AAChE,CAAC;AAED;;;;;GAKG;AACH,MAAM,UAAU,iCAAiC,CAAC,QAAuB,EAAE,MAAsC;IAC/G,IAAI,CAAC,QAAQ,IAAI,CAAC,MAAM;QAAE,OAAO,QAAQ,CAAC;IAC1C,MAAM,IAAI,GAAG,EAAE,GAAG,QAAQ,CAAC,IAAI,EAAE,CAAC;IAClC,IAAI,OAAO,MAAM,CAAC,gBAAgB,KAAK,QAAQ,EAAE,CAAC;QAChD,MAAM,UAAU,GAAG,IAAI,CAAC,GAAG,CAAC,CAAC,EAAE,IAAI,CAAC,GAAG,CAAC,GAAG,EAAE,IAAI,CAAC,KAAK,CAAC,MAAM,CAAC,gBAAgB,GAAG,GAAG,CAAC,CAAC,CAAC,CAAC;QACzF,IAAI,OAAO,IAAI,CAAC,iBAAiB,KAAK,QAAQ,IAAI,UAAU,GAAG,IAAI,CAAC,iBAAiB,EAAE,CAAC;YACtF,IAAI,CAAC,iBAAiB,GAAG,UAAU,CAAC;QACtC,CAAC;IACH,CAAC;IACD,IAAI,OAAO,MAAM,CAAC,eAAe,KAAK,QAAQ,IAAI,MAAM,CAAC,eAAe,GAAG,CAAC,EAAE,CAAC;QAC7E,IAAI,CAAC,YAAY,GAAG,MAAM,CAAC,eAAe,CAAC;IAC7C,CAAC;IACD,IAAI,OAAO,MAAM,CAAC,eAAe,KAAK,QAAQ,IAAI,MAAM,CAAC,eAAe,GAAG,CAAC,EAAE,CAAC;QAC7E,IAAI,CAAC,YAAY,GAAG,MAAM,CAAC,eAAe,CAAC;IAC7C,CAAC;IACD,OAAO,EAAE,GAAG,QAAQ,EAAE,IAAI,EAAE,CAAC;AAC/B,CAAC;AAED,KAAK,UAAU,uBAAuB,CAAC,MAAuC,EAAE,QAAyB;IACvG,MAAM,IAAI,GAAG,QAAQ,CAAC,YAAY,CAAC;IACnC,IAAI,CAAC,IAAI,EAAE,YAAY;QAAE,OAAO,IAAI,CAAC;IACrC,MAAM,GAAG,GAAG,GAAG,IAAI,CAAC,MAAM,aAAa,kBAAkB,CAAC,MAAM,CAAC,KAAK,CAAC,IAAI,kBAAkB,CAAC,MAAM,CAAC,IAAI,CAAC,uBAAuB,CAAC;IAClI,IAAI,CAAC;QACH,MAAM,QAAQ,GAAG,MAAM,gBAAgB,CACrC,QAAQ,CAAC,SAAS,EAClB,GAAG,EACH;YACE,MAAM,EAAE,KAAK;YACb,OAAO,EAAE;gBACP,aAAa,EAAE,UAAU,IAAI,CAAC,YAAY,EAAE;gBAC5C,MAAM,EAAE,kBAAkB;gBAC1B,YAAY,EAAE,gBAAgB;aAC/B;SACF,EACD,QAAQ,CAAC,sBAAsB,CAChC,CAAC;QACF,IAAI,CAAC,QAAQ,CAAC,EAAE;YAAE,OAAO,IAAI,CAAC;QAC9B,MAAM,OAAO,GAAG,MAAM,QAAQ,CAAC,IAAI,EAAE,CAAC,KAAK,CAAC,GAAG,EAAE,CAAC,IAAI,CAAC,CAAC;QACxD,OAAO,4BAA4B,CAAC,OAAO,CAAC,CAAC;IAC/C,CAAC;IAAC,MAAM,CAAC;QACP,OAAO,IAAI,CAAC;IACd,CAAC;AACH,CAAC;AAED,0GAA0G;AAC1G,8GAA8G;AAC9G,uDAAuD;AACvD,KAAK,UAAU,gBAAgB,CAC7B,SAAiC,EACjC,GAAW,EACX,IAA2D,EAC3D,SAAiB;IAEjB,OAAO,SAAS,CAAC,GAAG,EAAE,EAAE,GAAG,IAAI,EAAE,MAAM,EAAE,WAAW,CAAC,OAAO,CAAC,SAAS,CAAC,EAAE,CAAC,CAAC;AAC7E,CAAC;AAED,KAAK,UAAU,aAAa,CAAC,GAAW,EAAE,QAAyB;IACjE,MAAM,QAAQ,GAAG,MAAM,gBAAgB,CAAC,QAAQ,CAAC,SAAS,EAAE,GAAG,EAAE,EAAE,MAAM,EAAE,KAAK,EAAE,OAAO,EAAE,aAAa,CAAC,QAAQ,CAAC,WAAW,CAAC,EAAE,EAAE,QAAQ,CAAC,gBAAgB,CAAC,CAAC;IAC7J,MAAM,OAAO,GAAG,MAAM,QAAQ,CAAC,IAAI,EAAE,CAAC,KAAK,CAAC,GAAG,EAAE,CAAC,IAAI,CAAC,CAAC;IACxD,OAAO,EAAE,QAAQ,EAAE,OAAO,EAAE,CAAC;AAC/B,CAAC;AAED,KAAK,UAAU,cAAc,CAAC,aAAqB,EAAE,QAAyB;IAC5E,MAAM,OAAO,GAAc,EAAE,CAAC;IAC9B,KAAK,IAAI,IAAI,GAAG,CAAC,EAAE,IAAI,IAAI,QAAQ,CAAC,QAAQ,EAAE,IAAI,IAAI,CAAC,EAAE,CAAC;QACxD,MAAM,SAAS,GAAG,aAAa,CAAC,QAAQ,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,GAAG,CAAC;QAC1D,MAAM,GAAG,GAAG,GAAG,QAAQ,CAAC,UAAU,GAAG,aAAa,GAAG,SAAS,YAAY,QAAQ,CAAC,OAAO,SAAS,IAAI,EAAE,CAAC;QAC1G,MAAM,EAAE,QAAQ,EAAE,OAAO,EAAE,GAAG,MAAM,aAAa,CAAC,GAAG,EAAE,QAAQ,CAAC,CAAC;QACjE,IAAI,CAAC,QAAQ,CAAC,EAAE,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,OAAO,CAAC;YAAE,MAAM;QACnD,OAAO,CAAC,IAAI,CAAC,GAAG,OAAO,CAAC,CAAC;QACzB,IAAI,OAAO,CAAC,MAAM,GAAG,QAAQ,CAAC,OAAO;YAAE,MAAM;IAC/C,CAAC;IACD,OAAO,OAAO,CAAC;AACjB,CAAC;AAED,wGAAwG;AACxG,yGAAyG;AACzG,4GAA4G;AAC5G,KAAK,UAAU,qBAAqB,CAAC,MAAuC,EAAE,QAAyB;IACrG,MAAM,GAAG,GAAG,GAAG,QAAQ,CAAC,UAAU,UAAU,kBAAkB,CAAC,MAAM,CAAC,KAAK,CAAC,IAAI,kBAAkB,CAAC,MAAM,CAAC,IAAI,CAAC,EAAE,CAAC;IAClH,MAAM,EAAE,QAAQ,EAAE,OAAO,EAAE,GAAG,MAAM,aAAa,CAAC,GAAG,EAAE,QAAQ,CAAC,CAAC;IACjE,IAAI,CAAC,QAAQ,CAAC,EAAE,IAAI,CAAC,OAAO,IAAI,OAAO,OAAO,KAAK,QAAQ;QAAE,OAAO,IAAI,CAAC;IACzE,MAAM,MAAM,GAAG,OAA2H,CAAC;IAC3I,OAAO;QACL,QAAQ,EAAE,GAAG,MAAM,CAAC,KAAK,IAAI,MAAM,CAAC,IAAI,EAAE;QAC1C,KAAK,EAAG,MAAM,CAAC,KAAK,EAAE,KAA4B,IAAI,MAAM,CAAC,KAAK;QAClE,IAAI,EAAG,MAAM,CAAC,IAA2B,IAAI,MAAM,CAAC,IAAI;QACxD,cAAc,EAAE,SAAS;QACzB,WAAW,EAAE,KAAK;QAClB,YAAY,EAAE,KAAK;QACnB,SAAS,EAAG,MAAM,CAAC,OAA+B,IAAI,KAAK;QAC3D,OAAO,EAAG,MAAM,CAAC,QAA+B,IAAI,IAAI;QACxD,aAAa,EAAG,MAAM,CAAC,cAAqC,IAAI,IAAI;QACpE,cAAc,EAAE,IAAI;KACrB,CAAC;AACJ,CAAC;AAED,2GAA2G;AAC3G,6GAA6G;AAC7G,+GAA+G;AAC/G,6GAA6G;AAC7G,MAAM,iBAAiB,GAAG,gFAAgF,CAAC;AAC3G,SAAS,sBAAsB,CAAC,IAAY;IAC1C,MAAM,OAAO,GAAa,EAAE,CAAC;IAC7B,KAAK,MAAM,KAAK,IAAI,IAAI,CAAC,QAAQ,CAAC,iBAAiB,CAAC,EAAE,CAAC;QACrD,MAAM,MAAM,GAAG,MAAM,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC;QAChC,IAAI,MAAM,CAAC,SAAS,CAAC,MAAM,CAAC,IAAI,MAAM,GAAG,CAAC;YAAE,OAAO,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC;IACnE,CAAC;IACD,OAAO,OAAO,CAAC;AACjB,CAAC;AAED,4GAA4G;AAC5G,iGAAiG;AACjG,MAAM,oBAAoB,GAAG,kFAAkF,CAAC;AAChH,SAAS,yBAAyB,CAAC,IAAY,EAAE,YAAoB;IACnE,qGAAqG;IACrG,MAAM,gBAAgB,GAAG,IAAI,CAAC,OAAO,CAAC,UAAU,EAAE,EAAE,CAAC,CAAC;IACtD,MAAM,OAAO,GAAa,EAAE,CAAC;IAC7B,MAAM,cAAc,GAAG,YAAY,CAAC,WAAW,EAAE,CAAC;IAClD,KAAK,MAAM,KAAK,IAAI,gBAAgB,CAAC,QAAQ,CAAC,oBAAoB,CAAC,EAAE,CAAC;QACpE,MAAM,aAAa,GAAG,KAAK,CAAC,CAAC,CAAC,CAAC;QAC/B,IAAI,aAAa,KAAK,SAAS,IAAI,aAAa,CAAC,WAAW,EAAE,KAAK,cAAc;YAAE,SAAS;QAC5F,MAAM,MAAM,GAAG,MAAM,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC;QAChC,IAAI,MAAM,CAAC,SAAS,CAAC,MAAM,CAAC,IAAI,MAAM,GAAG,CAAC;YAAE,OAAO,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC;IACnE,CAAC;IACD,OAAO,OAAO,CAAC;AACjB,CAAC;AAED,SAAS,UAAU,CAAC,MAAe;IACjC,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,MAAM,CAAC;QAAE,OAAO,EAAE,CAAC;IACtC,OAAO,MAAM,CAAC,OAAO,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,CAAC,KAAK,IAAI,OAAO,KAAK,KAAK,QAAQ,IAAI,OAAQ,KAA4B,CAAC,IAAI,KAAK,QAAQ,CAAC,CAAC,CAAC,CAAE,KAA0B,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC;AAC7K,CAAC;AAED,uGAAuG;AACvG,qGAAqG;AACrG,0DAA0D;AAC1D,SAAS,aAAa,CAAC,YAAoB,EAAE,KAA8B;IACzE,MAAM,IAAI,GAAI,KAAK,CAAC,IAA2B,IAAI,EAAE,CAAC;IACtD,MAAM,IAAI,GAAG,KAAK,CAAC,IAAuC,CAAC;IAC3D,OAAO;QACL,YAAY;QACZ,MAAM,EAAE,KAAK,CAAC,MAAgB;QAC9B,KAAK,EAAE,KAAK,CAAC,KAAe;QAC5B,KAAK,EAAE,KAAK,CAAC,KAAe;QAC5B,WAAW,EAAG,IAAI,EAAE,KAA4B,IAAI,IAAI;QACxD,iBAAiB,EAAG,KAAK,CAAC,kBAAyC,IAAI,IAAI;QAC3E,OAAO,EAAG,KAAK,CAAC,QAA+B,IAAI,IAAI;QACvD,IAAI;QACJ,SAAS,EAAG,KAAK,CAAC,UAAiC,IAAI,IAAI;QAC3D,SAAS,EAAG,KAAK,CAAC,UAAiC,IAAI,IAAI;QAC3D,QAAQ,EAAG,KAAK,CAAC,SAAgC,IAAI,IAAI;QACzD,MAAM,EAAE,UAAU,CAAC,KAAK,CAAC,MAAM,CAAC;QAChC,SAAS,EAAE,sBAAsB,CAAC,IAAI,CAAC;KACxC,CAAC;AACJ,CAAC;AAED,KAAK,UAAU,qBAAqB,CAAC,MAAuC,EAAE,QAAyB;IACrG,MAAM,QAAQ,GAAG,MAAM,cAAc,CACnC,UAAU,kBAAkB,CAAC,MAAM,CAAC,KAAK,CAAC,IAAI,kBAAkB,CAAC,MAAM,CAAC,IAAI,CAAC,+CAA+C,EAC5H,QAAQ,CACT,CAAC;IACF,6GAA6G;IAC7G,OAAO,QAAQ;SACZ,MAAM,CAAC,CAAC,KAAK,EAAoC,EAAE,CAAC,OAAO,CAAC,KAAK,CAAC,IAAI,OAAO,KAAK,KAAK,QAAQ,IAAI,CAAE,KAAoC,CAAC,YAAY,CAAC;SACvJ,GAAG,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,aAAa,CAAC,GAAG,MAAM,CAAC,KAAK,IAAI,MAAM,CAAC,IAAI,EAAE,EAAE,KAAK,CAAC,CAAC,CAAC;AAC5E,CAAC;AAED,SAAS,qBAAqB,CAAC,SAAkB;IAC/C,IAAI,SAAS,KAAK,IAAI;QAAE,OAAO,OAAO,CAAC;IACvC,IAAI,SAAS,KAAK,KAAK;QAAE,OAAO,OAAO,CAAC;IACxC,OAAO,IAAI,CAAC;AACd,CAAC;AAED,+GAA+G;AAC/G,4GAA4G;AAC5G,0GAA0G;AAC1G,uEAAuE;AACvE,SAAS,mBAAmB,CAAC,YAAoB,EAAE,EAA2B;IAC5E,MAAM,IAAI,GAAI,EAAE,CAAC,IAA2B,IAAI,EAAE,CAAC;IACnD,MAAM,IAAI,GAAG,EAAE,CAAC,IAAuC,CAAC;IACxD,MAAM,IAAI,GAAG,EAAE,CAAC,IAAoD,CAAC;IACrE,MAAM,IAAI,GAAG,EAAE,CAAC,IAAqC,CAAC;IACtD,OAAO;QACL,YAAY;QACZ,MAAM,EAAE,EAAE,CAAC,MAAgB;QAC3B,KAAK,EAAE,EAAE,CAAC,KAAe;QACzB,KAAK,EAAE,EAAE,CAAC,KAAe;QACzB,WAAW,EAAG,IAAI,EAAE,KAA4B,IAAI,IAAI;QACxD,iBAAiB,EAAG,EAAE,CAAC,kBAAyC,IAAI,IAAI;QACxE,OAAO,EAAG,IAAI,EAAE,GAA0B,IAAI,IAAI;QAClD,OAAO,EAAG,IAAI,EAAE,GAA0B,IAAI,IAAI;QAClD,OAAO,EAAG,IAAI,EAAE,GAA0B,IAAI,IAAI;QAClD,OAAO,EAAG,EAAE,CAAC,QAA+B,IAAI,IAAI;QACpD,QAAQ,EAAG,EAAE,CAAC,SAAgC,IAAI,IAAI;QACtD,OAAO,EAAG,EAAE,CAAC,KAA6B,IAAI,IAAI;QAClD,cAAc,EAAG,EAAE,CAAC,eAAsC,IAAI,qBAAqB,CAAC,EAAE,CAAC,SAAS,CAAC;QACjG,cAAc,EAAE,IAAI;QACpB,IAAI;QACJ,SAAS,EAAG,EAAE,CAAC,UAAiC,IAAI,IAAI;QACxD,SAAS,EAAG,EAAE,CAAC,UAAiC,IAAI,IAAI;QACxD,QAAQ,EAAG,EAAE,CAAC,SAAgC,IAAI,IAAI;QACtD,MAAM,EAAE,UAAU,CAAC,EAAE,CAAC,MAAM,CAAC;QAC7B,YAAY,EAAE,yBAAyB,CAAC,IAAI,EAAE,YAAY,CAAC;KAC5D,CAAC;AACJ,CAAC;AAED,KAAK,UAAU,2BAA2B,CAAC,MAAuC,EAAE,QAAyB;IAC3G,MAAM,QAAQ,GAAG,MAAM,cAAc,CACnC,UAAU,kBAAkB,CAAC,MAAM,CAAC,KAAK,CAAC,IAAI,kBAAkB,CAAC,MAAM,CAAC,IAAI,CAAC,8CAA8C,EAC3H,QAAQ,CACT,CAAC;IACF,OAAQ,QAAsC,CAAC,GAAG,CAAC,CAAC,EAAE,EAAE,EAAE,CAAC,mBAAmB,CAAC,GAAG,MAAM,CAAC,KAAK,IAAI,MAAM,CAAC,IAAI,EAAE,EAAE,EAAE,CAAC,CAAC,CAAC;AACxH,CAAC;AAED,iGAAiG;AACjG,6GAA6G;AAC7G,KAAK,UAAU,+BAA+B,CAAC,QAAmC;IAChF,MAAM,aAAa,GAAG,QAAQ,CAAC,OAAO,EAAE,GAAG,EAAE,CAAC,gBAAgB,CAAC,IAAI,IAAI,CAAC;IACxE,IAAI,aAAa,KAAK,IAAI,EAAE,CAAC;QAC3B,MAAM,YAAY,GAAG,MAAM,CAAC,QAAQ,CAAC,aAAa,EAAE,EAAE,CAAC,CAAC;QACxD,IAAI,MAAM,CAAC,QAAQ,CAAC,YAAY,CAAC,IAAI,YAAY,GAAG,wBAAwB;YAAE,OAAO,IAAI,CAAC;IAC5F,CAAC;IACD,IAAI,CAAC,QAAQ,CAAC,IAAI,EAAE,SAAS,EAAE,CAAC;QAC9B,MAAM,IAAI,GAAG,MAAM,QAAQ,CAAC,IAAI,EAAE,CAAC;QACnC,IAAI,OAAO,IAAI,KAAK,QAAQ;YAAE,OAAO,IAAI,CAAC;QAC1C,OAAO,IAAI,WAAW,EAAE,CAAC,MAAM,CAAC,IAAI,CAAC,CAAC,UAAU,GAAG,wBAAwB,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,IAAI,CAAC;IAC5F,CAAC;IAED,MAAM,MAAM,GAAG,QAAQ,CAAC,IAAI,CAAC,SAAS,EAAE,CAAC;IACzC,MAAM,OAAO,GAAG,IAAI,WAAW,EAAE,CAAC;IAClC,IAAI,UAAU,GAAG,CAAC,CAAC;IACnB,IAAI,IAAI,GAAG,EAAE,CAAC;IACd,IAAI,CAAC;QACH,SAAS,CAAC;YACR,MAAM,EAAE,IAAI,EAAE,KAAK,EAAE,GAAG,MAAM,MAAM,CAAC,IAAI,EAAE,CAAC;YAC5C,IAAI,IAAI;gBAAE,MAAM;YAChB,UAAU,IAAI,KAAK,EAAE,UAAU,IAAI,CAAC,CAAC;YACrC,IAAI,UAAU,GAAG,wBAAwB,EAAE,CAAC;gBAC1C,MAAM,MAAM,CAAC,MAAM,EAAE,CAAC;gBACtB,OAAO,IAAI,CAAC;YACd,CAAC;YACD,IAAI,KAAK;gBAAE,IAAI,IAAI,OAAO,CAAC,MAAM,CAAC,KAAK,EAAE,EAAE,MAAM,EAAE,IAAI,EAAE,CAAC,CAAC;QAC7D,CAAC;QACD,IAAI,IAAI,OAAO,CAAC,MAAM,EAAE,CAAC;QACzB,OAAO,IAAI,CAAC;IACd,CAAC;YAAS,CAAC;QACT,MAAM,CAAC,WAAW,EAAE,CAAC;IACvB,CAAC;AACH,CAAC;AAED,KAAK,UAAU,oBAAoB,CAAC,MAAuC,EAAE,QAAyB;IACpG,KAAK,MAAM,IAAI,IAAI,wBAAwB,EAAE,CAAC;QAC5C,MAAM,GAAG,GAAG,GAAG,QAAQ,CAAC,iBAAiB,IAAI,kBAAkB,CAAC,MAAM,CAAC,KAAK,CAAC,IAAI,kBAAkB,CAAC,MAAM,CAAC,IAAI,CAAC,SAAS,IAAI,EAAE,CAAC;QAChI,IAAI,CAAC;YACH,MAAM,QAAQ,GAAG,MAAM,gBAAgB,CAAC,QAAQ,CAAC,SAAS,EAAE,GAAG,EAAE,EAAE,MAAM,EAAE,KAAK,EAAE,OAAO,EAAE,EAAE,MAAM,EAAE,kBAAkB,EAAE,YAAY,EAAE,gBAAgB,EAAE,EAAE,EAAE,QAAQ,CAAC,gBAAgB,CAAC,CAAC;YACxL,IAAI,QAAQ,CAAC,EAAE,EAAE,CAAC;gBAChB,MAAM,IAAI,GAAG,MAAM,+BAA+B,CAAC,QAAQ,CAAC,CAAC;gBAC7D,IAAI,OAAO,IAAI,KAAK,QAAQ;oBAAE,OAAO,IAAI,CAAC;YAC5C,CAAC;QACH,CAAC;QAAC,MAAM,CAAC;YACP,+BAA+B;QACjC,CAAC;IACH,CAAC;IACD,OAAO,IAAI,CAAC;AACd,CAAC;AAED,0GAA0G;AAC1G,wGAAwG;AACxG,6GAA6G;AAC7G,KAAK,UAAU,yBAAyB,CAAC,KAAa,EAAE,QAAyB;IAC/E,IAAI,CAAC,KAAK;QAAE,OAAO,KAAK,CAAC;IACzB,IAAI,CAAC;QACH,MAAM,QAAQ,GAAG,MAAM,gBAAgB,CAAC,QAAQ,CAAC,SAAS,EAAE,GAAG,QAAQ,CAAC,gBAAgB,SAAS,EAAE,EAAE,MAAM,EAAE,KAAK,EAAE,OAAO,EAAE,EAAE,MAAM,EAAE,kBAAkB,EAAE,EAAE,EAAE,QAAQ,CAAC,gBAAgB,CAAC,CAAC;QAC1L,IAAI,CAAC,QAAQ,CAAC,EAAE;YAAE,OAAO,KAAK,CAAC;QAC/B,MAAM,OAAO,GAAG,MAAM,QAAQ,CAAC,IAAI,EAAE,CAAC,KAAK,CAAC,GAAG,EAAE,CAAC,IAAI,CAAC,CAAC;QACxD,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,OAAO,CAAC;YAAE,OAAO,KAAK,CAAC;QAC1C,MAAM,eAAe,GAAG,KAAK,CAAC,WAAW,EAAE,CAAC;QAC5C,OAAO,OAAO,CAAC,IAAI,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,OAAQ,KAAsC,EAAE,cAAc,KAAK,QAAQ,IAAK,KAAoC,CAAC,cAAc,CAAC,WAAW,EAAE,KAAK,eAAe,CAAC,CAAC;IACxM,CAAC;IAAC,MAAM,CAAC;QACP,OAAO,KAAK,CAAC;IACf,CAAC;AACH,CAAC;AAED,yGAAyG;AACzG,mFAAmF;AACnF,wGAAwG;AACxG,wGAAwG;AACxG,qGAAqG;AACrG,2GAA2G;AAC3G,wGAAwG;AACxG,uGAAuG;AACvG,8GAA8G;AAC9G,oGAAoG;AACpG,SAAS,yBAAyB,CAAC,eAAwD,EAAE,kBAA4B;IACvH,IAAI,kBAAkB,CAAC,MAAM,KAAK,CAAC;QAAE,OAAO,KAAK,CAAC;IAClD,OAAO,eAAe,CAAC,QAAQ,CAAC,IAAI,CAClC,CAAC,OAAO,EAAE,EAAE,CACV,OAAO,CAAC,IAAI,KAAK,MAAM;QACvB,OAAO,CAAC,KAAK,CAAC,MAAM,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,IAAI,CAAC,IAAI,KAAK,cAAc,CAAC,CAAC,MAAM,IAAI,CAAC;QACxE,OAAO,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,IAAI,CAAC,IAAI,KAAK,OAAO,IAAI,kBAAkB,CAAC,QAAQ,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC,CAClG,CAAC;AACJ,CAAC;AAED;;;;;GAKG;AACH,MAAM,CAAC,KAAK,UAAU,sBAAsB,CAAC,YAAoB,EAAE,UAAyC,EAAE;IAC5G,MAAM,MAAM,GAAG,iBAAiB,CAAC,YAAY,CAAC,CAAC;IAC/C,IAAI,CAAC,MAAM;QAAE,MAAM,IAAI,KAAK,CAAC,wBAAwB,CAAC,CAAC;IACvD,MAAM,QAAQ,GAAG,gBAAgB,CAAC,OAAO,CAAC,CAAC;IAE3C,MAAM,CAAC,IAAI,EAAE,MAAM,EAAE,YAAY,EAAE,eAAe,EAAE,oBAAoB,EAAE,kBAAkB,CAAC,GAAG,MAAM,OAAO,CAAC,GAAG,CAAC;QAChH,qBAAqB,CAAC,MAAM,EAAE,QAAQ,CAAC;QACvC,qBAAqB,CAAC,MAAM,EAAE,QAAQ,CAAC;QACvC,2BAA2B,CAAC,MAAM,EAAE,QAAQ,CAAC;QAC7C,oBAAoB,CAAC,MAAM,EAAE,QAAQ,CAAC;QACtC,yBAAyB,CAAC,QAAQ,CAAC,gBAAgB,EAAE,QAAQ,CAAC;QAC9D,uBAAuB,CAAC,MAAM,EAAE,QAAQ,CAAC;KAC1C,CAAC,CAAC;IAEH,MAAM,cAAc,GAAG,yBAAyB,CAAC,eAAe,EAAE,WAAW,CAAC,CAAC;IAC/E,MAAM,QAAQ,GAAG,iCAAiC,CAAC,cAAc,EAAE,kBAAkB,CAAC,CAAC;IACvF,2HAA2H;IAC3H,2GAA2G;IAC3G,0FAA0F;IAC1F,MAAM,QAAQ,GAAG,GAAG,MAAM,CAAC,KAAK,IAAI,MAAM,CAAC,IAAI,EAAE,CAAC;IAClD,MAAM,UAAU,GAAG,oBAAoB,CAAC,QAAQ,EAAE,MAAM,EAAE,YAAY,CAAC,CAAC;IACxE,MAAM,kBAAkB,GAAG,yBAAyB,CAAC,UAAU,EAAE,QAAQ,CAAC,YAAY,CAAC,CAAC;IACxF,MAAM,YAAY,GAAG,uBAAuB,CAAC,IAAI,EAAE,MAAM,EAAE,YAAY,EAAE,QAAQ,EAAE,EAAE,EAAE,UAAU,EAAE,EAAE,CAAC,CAAC;IAEvG,OAAO;QACL,QAAQ;QACR,IAAI;QACJ,MAAM;QACN,YAAY;QACZ,oBAAoB;QACpB,kBAAkB;QAClB,YAAY;KACb,CAAC;AACJ,CAAC"} \ No newline at end of file diff --git a/packages/loopover-miner/lib/self-review-context.ts b/packages/loopover-miner/lib/self-review-context.ts new file mode 100644 index 0000000000..2c44eea1e6 --- /dev/null +++ b/packages/loopover-miner/lib/self-review-context.ts @@ -0,0 +1,536 @@ +import { + buildCollisionReport, + buildIssueQualityReport, + MAX_FOCUS_MANIFEST_BYTES, + parseFocusManifestContent, +} from "@loopover/engine"; +import type { FocusManifest, IssueRecord, PullRequestRecord, RepositoryRecord, SelfReviewContext } from "@loopover/engine"; +import { resolveLoopoverBackendSession } from "./github-token-resolution.js"; + +// Real SelfReviewContext fetcher (#5145, Wave 3.5). Builds the context object the miner's self-review pass +// (packages/loopover-engine/src/miner/self-review-adapter.ts) needs, at the SAME fidelity the live gate's +// own DB-backed construction produces (src/db/repositories.ts's toRepositoryRecord/toIssueRecord/ +// toPullRequestRecord) -- just built fresh from live GitHub data instead of a DB round-trip, since the miner +// has no database. One of SelfReviewContext's eight fields is DELIBERATELY left undefined, not stubbed: +// +// - `bounties`: bounty data is not GitHub-native in this codebase -- it comes from an external "Gitt" +// system that PUSHES data into the live gate's own internal ingest route (src/api/routes.ts). There is +// no public endpoint the miner could legitimately pull from instead. +// +// `issueQuality` is populated via buildIssueQualityReport (exported from @loopover/engine as a package-local +// twin of the host engine helper — see #6057). Bounty rows and recent-merged PR history are passed as empty +// arrays because this fetcher does not yet pull either source. `bounties` remains omitted for the reason above. +// +// #6487: after the static `.loopover.yml` reconstruction, optionally probe ORB's live-gate-thresholds endpoint +// (same loopover-mcp session posture as resolveGitHubToken). On success, overlay confidence_floor / +// scope_cap_files / scope_cap_lines onto the parsed manifest gate; on 403/timeout/404/no-session, keep the +// static reconstruction unchanged. Fully-standalone (ORB-absent) paths stay byte-identical. + +// `bounties` is always omitted (see this file's own header comment for why), so the result is +// SelfReviewContext minus that optional field rather than the full type. `issueQuality` is populated (#6057). +export type SelfReviewContextResult = Omit; + +// A narrower shape than `typeof fetch` on purpose (same rationale as live-issue-snapshot.js's own +// LiveIssueSnapshotFetch), but a bit richer than the shared narrow shape other modules use: this module's +// bounded manifest reader also needs `headers.get()` (content-length bound) and a streaming `body.getReader()` +// (bounded read without loading an oversized response fully into memory first) -- both OPTIONAL here so a +// caller that never supplies them (the plain-JSON GitHub/Gittensor call sites) still satisfies it. +export type SelfReviewContextFetch = ( + url: string, + init?: { method?: string; headers?: Record; signal?: AbortSignal }, +) => Promise<{ + ok: boolean; + status: number; + json: () => Promise; + text: () => Promise; + headers?: { get(name: string): string | null }; + body?: { getReader(): { read(): Promise<{ done: boolean; value?: Uint8Array }>; cancel(): Promise; releaseLock(): void } } | null; +}>; + +type SelfReviewContextResponse = Awaited>; + +export type LiveGateThresholdFields = { + confidence_floor: number | null; + scope_cap_files: number | null; + scope_cap_lines: number | null; +}; + +export type LoopoverBackendSessionAuth = { + apiUrl?: string; + sessionToken: string; +}; + +export type FetchSelfReviewContextOptions = { + githubToken?: string; + contributorLogin?: string; + linkedIssues?: number[]; + apiBaseUrl?: string; + rawContentBaseUrl?: string; + gittensorApiBase?: string; + fetchImpl?: SelfReviewContextFetch; + perPage?: number; + maxPages?: number; + requestTimeoutMs?: number; + /** Short ORB live-gate-thresholds probe budget (#6487). Default 400ms. */ + liveGateProbeTimeoutMs?: number; + /** Explicit session auth for the ORB probe; `null` forces standalone (skip probe). */ + loopoverAuth?: LoopoverBackendSessionAuth | null; + /** Env used to resolve loopover-mcp session when `loopoverAuth` is omitted. */ + env?: Record; +}; + +type ResolvedOptions = { + githubToken: string; + apiBaseUrl: string; + rawContentBaseUrl: string; + gittensorApiBase: string; + fetchImpl: SelfReviewContextFetch; + perPage: number; + maxPages: number; + contributorLogin: string; + linkedIssues: number[]; + requestTimeoutMs: number; + liveGateProbeTimeoutMs: number; + loopoverAuth: LoopoverBackendSessionAuth | null; +}; + +const GITHUB_API_VERSION = "2022-11-28"; +const DEFAULT_API_BASE_URL = "https://api.github.com"; +const DEFAULT_RAW_CONTENT_BASE_URL = "https://raw.githubusercontent.com"; +const DEFAULT_GITTENSOR_API_BASE = "https://api.gittensor.io"; +const DEFAULT_PER_PAGE = 100; +const DEFAULT_MAX_PAGES = 10; +const DEFAULT_REQUEST_TIMEOUT_MS = 10_000; +/** Short ORB probe budget (#6487) — must never make discover/gate-prediction meaningfully slower when ORB is absent. */ +const DEFAULT_LIVE_GATE_PROBE_TIMEOUT_MS = 400; + +// Mirrors src/signals/focus-manifest-loader.ts's MANIFEST_FILE_CANDIDATES exactly -- first candidate that +// resolves wins, same as the live gate's own lookup order. +const MANIFEST_FILE_CANDIDATES = [".loopover.yml", ".github/loopover.yml", ".loopover.json", ".github/loopover.json"]; + +function parseRepoFullName(repoFullName: string): { owner: string; repo: string } | null { + if (typeof repoFullName !== "string") return null; + const [owner, repo, extra] = repoFullName.split("/"); + if (!owner || !repo || extra !== undefined) return null; + return { owner, repo }; +} + +// `githubToken` is always a real string here: this function is private and its sole caller (githubGetJson, +// via resolved.githubToken) already comes from normalizeOptions' own `options.githubToken ?? env.GITHUB_TOKEN +// ?? ""` fallback chain, which always resolves to a string. +function githubHeaders(githubToken: string): Record { + const headers: Record = { + accept: "application/vnd.github+json", + "user-agent": "loopover-miner", + "x-github-api-version": GITHUB_API_VERSION, + }; + if (githubToken) headers.authorization = `Bearer ${githubToken}`; + return headers; +} + +// resolveLoopoverBackendSession types `env` as the ambient (Cloudflare-Workers-augmented) `NodeJS.ProcessEnv`, +// stricter than this file's own `Record` -- github-token-resolution.js isn't +// converted to TypeScript yet, and any object matching this shape genuinely satisfies it at runtime either way. +const resolveBackendSession = resolveLoopoverBackendSession as ( + env?: Record, +) => LoopoverBackendSessionAuth | null; + +function normalizeOptions(options: FetchSelfReviewContextOptions = {}): ResolvedOptions { + const env = options.env ?? process.env; + // Explicit null skips the probe (tests / forced-standalone). Undefined ⇒ resolve from loopover-mcp session. + const loopoverAuth: LoopoverBackendSessionAuth | null = + options.loopoverAuth === null + ? null + : options.loopoverAuth && typeof options.loopoverAuth.sessionToken === "string" && options.loopoverAuth.sessionToken + ? { + apiUrl: + typeof options.loopoverAuth.apiUrl === "string" && options.loopoverAuth.apiUrl.trim() + ? options.loopoverAuth.apiUrl.replace(/\/+$/, "") + : (resolveBackendSession(env)?.apiUrl ?? "https://api.loopover.ai"), + sessionToken: options.loopoverAuth.sessionToken, + } + : resolveBackendSession(env); + return { + githubToken: options.githubToken ?? env.GITHUB_TOKEN ?? "", + apiBaseUrl: typeof options.apiBaseUrl === "string" && options.apiBaseUrl.trim() ? options.apiBaseUrl.trim() : DEFAULT_API_BASE_URL, + rawContentBaseUrl: + typeof options.rawContentBaseUrl === "string" && options.rawContentBaseUrl.trim() ? options.rawContentBaseUrl.trim() : DEFAULT_RAW_CONTENT_BASE_URL, + gittensorApiBase: + typeof options.gittensorApiBase === "string" && options.gittensorApiBase.trim() ? options.gittensorApiBase.trim() : DEFAULT_GITTENSOR_API_BASE, + fetchImpl: options.fetchImpl ?? (fetch as unknown as SelfReviewContextFetch), + perPage: Number.isInteger(options.perPage) && (options.perPage as number) > 0 ? (options.perPage as number) : DEFAULT_PER_PAGE, + maxPages: Number.isInteger(options.maxPages) && (options.maxPages as number) > 0 ? (options.maxPages as number) : DEFAULT_MAX_PAGES, + contributorLogin: typeof options.contributorLogin === "string" ? options.contributorLogin.trim() : "", + linkedIssues: Array.isArray(options.linkedIssues) ? options.linkedIssues.filter((n) => Number.isInteger(n)) : [], + requestTimeoutMs: Number.isInteger(options.requestTimeoutMs) && (options.requestTimeoutMs as number) > 0 ? (options.requestTimeoutMs as number) : DEFAULT_REQUEST_TIMEOUT_MS, + liveGateProbeTimeoutMs: + Number.isInteger(options.liveGateProbeTimeoutMs) && (options.liveGateProbeTimeoutMs as number) > 0 + ? (options.liveGateProbeTimeoutMs as number) + : DEFAULT_LIVE_GATE_PROBE_TIMEOUT_MS, + loopoverAuth, + }; +} + +/** Validate the field-limited #6486/#6487 payload; null when nothing usable is present. */ +export function parseLiveGateThresholdFields(payload: unknown): LiveGateThresholdFields | null { + if (!payload || typeof payload !== "object" || Array.isArray(payload)) return null; + const record = payload as { confidence_floor?: unknown; scope_cap_files?: unknown; scope_cap_lines?: unknown }; + const confidence_floor = + typeof record.confidence_floor === "number" && record.confidence_floor >= 0 && record.confidence_floor <= 1 + ? record.confidence_floor + : null; + const scope_cap_files = typeof record.scope_cap_files === "number" && record.scope_cap_files > 0 ? record.scope_cap_files : null; + const scope_cap_lines = typeof record.scope_cap_lines === "number" && record.scope_cap_lines > 0 ? record.scope_cap_lines : null; + if (confidence_floor === null && scope_cap_files === null && scope_cap_lines === null) return null; + return { confidence_floor, scope_cap_files, scope_cap_lines }; +} + +/** + * Overlay live ORB thresholds onto a statically-reconstructed FocusManifest (#6487). + * - confidence_floor → raise-only readinessMinScore (mirrors applySelfTuneOverrideToSettings). + * - scope_cap_files / scope_cap_lines → prefer live sizeMaxFiles / sizeMaxLines when present. + * Other gate fields are left untouched. + */ +export function applyLiveGateThresholdsToManifest(manifest: FocusManifest, fields: LiveGateThresholdFields | null): FocusManifest { + if (!manifest || !fields) return manifest; + const gate = { ...manifest.gate }; + if (typeof fields.confidence_floor === "number") { + const floorScore = Math.max(0, Math.min(100, Math.round(fields.confidence_floor * 100))); + if (typeof gate.readinessMinScore === "number" && floorScore > gate.readinessMinScore) { + gate.readinessMinScore = floorScore; + } + } + if (typeof fields.scope_cap_files === "number" && fields.scope_cap_files > 0) { + gate.sizeMaxFiles = fields.scope_cap_files; + } + if (typeof fields.scope_cap_lines === "number" && fields.scope_cap_lines > 0) { + gate.sizeMaxLines = fields.scope_cap_lines; + } + return { ...manifest, gate }; +} + +async function probeLiveGateThresholds(target: { owner: string; repo: string }, resolved: ResolvedOptions): Promise { + const auth = resolved.loopoverAuth; + if (!auth?.sessionToken) return null; + const url = `${auth.apiUrl}/v1/repos/${encodeURIComponent(target.owner)}/${encodeURIComponent(target.repo)}/live-gate-thresholds`; + try { + const response = await fetchWithTimeout( + resolved.fetchImpl, + url, + { + method: "GET", + headers: { + authorization: `Bearer ${auth.sessionToken}`, + accept: "application/json", + "user-agent": "loopover-miner", + }, + }, + resolved.liveGateProbeTimeoutMs, + ); + if (!response.ok) return null; + const payload = await response.json().catch(() => null); + return parseLiveGateThresholdFields(payload); + } catch { + return null; + } +} + +// A fresh AbortSignal.timeout() per call, so a stalled connection can't hang context construction forever +// (#miner-github-read-timeouts) -- shared by this file's three independent fetch call sites (GitHub REST, raw +// manifest content, the Gittensor contributor lookup). +async function fetchWithTimeout( + fetchImpl: SelfReviewContextFetch, + url: string, + init: { method?: string; headers?: Record }, + timeoutMs: number, +): Promise { + return fetchImpl(url, { ...init, signal: AbortSignal.timeout(timeoutMs) }); +} + +async function githubGetJson(url: string, resolved: ResolvedOptions): Promise<{ response: SelfReviewContextResponse; payload: unknown }> { + const response = await fetchWithTimeout(resolved.fetchImpl, url, { method: "GET", headers: githubHeaders(resolved.githubToken) }, resolved.requestTimeoutMs); + const payload = await response.json().catch(() => null); + return { response, payload }; +} + +async function fetchPaginated(pathWithQuery: string, resolved: ResolvedOptions): Promise { + const results: unknown[] = []; + for (let page = 1; page <= resolved.maxPages; page += 1) { + const separator = pathWithQuery.includes("?") ? "&" : "?"; + const url = `${resolved.apiBaseUrl}${pathWithQuery}${separator}per_page=${resolved.perPage}&page=${page}`; + const { response, payload } = await githubGetJson(url, resolved); + if (!response.ok || !Array.isArray(payload)) break; + results.push(...payload); + if (payload.length < resolved.perPage) break; + } + return results; +} + +// Mirrors src/db/repositories.ts's toRepositoryRecord + upsertRepositoryFromGitHub's field mapping. The +// miner has no App installation/DB, so installationId/isInstalled/isRegistered/registryConfig are honest +// "unregistered" defaults, not values pulled from GitHub -- GitHub's own repo payload carries none of them. +async function fetchRepositoryRecord(target: { owner: string; repo: string }, resolved: ResolvedOptions): Promise { + const url = `${resolved.apiBaseUrl}/repos/${encodeURIComponent(target.owner)}/${encodeURIComponent(target.repo)}`; + const { response, payload } = await githubGetJson(url, resolved); + if (!response.ok || !payload || typeof payload !== "object") return null; + const record = payload as { owner?: { login?: unknown }; name?: unknown; private?: unknown; html_url?: unknown; default_branch?: unknown }; + return { + fullName: `${target.owner}/${target.repo}`, + owner: (record.owner?.login as string | undefined) ?? target.owner, + name: (record.name as string | undefined) ?? target.repo, + installationId: undefined, + isInstalled: false, + isRegistered: false, + isPrivate: (record.private as boolean | undefined) ?? false, + htmlUrl: (record.html_url as string | undefined) ?? null, + defaultBranch: (record.default_branch as string | undefined) ?? null, + registryConfig: null, + }; +} + +// Mirrors src/db/repositories.ts's extractLinkedPrNumbers: a real link needs a CLOSING KEYWORD, not a bare +// mention (#6769). Without the keyword prefix, an incidental "similar to what we saw in PR #501" in an issue +// body counted as a linked PR, so the issue-quality report read the issue as "already references a PR" and the +// miner skipped an available issue (the host's own #issue-body-pr-mention-pollution fix, never ported here). +const LINKED_PR_PATTERN = /\b(?:close[sd]?|fix(?:e[sd])?|resolve[sd]?)\s+(?:PR|pull request)\s+#(\d+)\b/gi; +function extractLinkedPrNumbers(body: string): number[] { + const numbers: number[] = []; + for (const match of body.matchAll(LINKED_PR_PATTERN)) { + const number = Number(match[1]); + if (Number.isInteger(number) && number > 0) numbers.push(number); + } + return numbers; +} + +// Mirrors src/db/repositories.ts's extractLinkedIssueNumbers: GitHub's own closing-keyword vocabulary, only +// counting a fully-qualified owner/repo#N reference when it targets the SAME repo being fetched. +const LINKED_ISSUE_PATTERN = /\b(?:close[sd]?|fix(?:e[sd])?|resolve[sd]?)\s+(?:([\w.-]+\/[\w.-]+)#|#)(\d+)\b/gi; +function extractLinkedIssueNumbers(body: string, repoFullName: string): number[] { + // Strip backtick code spans first so a closing-keyword pattern quoted as example code doesn't count. + const withoutCodeSpans = body.replace(/`[^`]*`/g, ""); + const numbers: number[] = []; + const normalizedRepo = repoFullName.toLowerCase(); + for (const match of withoutCodeSpans.matchAll(LINKED_ISSUE_PATTERN)) { + const qualifiedRepo = match[1]; + if (qualifiedRepo !== undefined && qualifiedRepo.toLowerCase() !== normalizedRepo) continue; + const number = Number(match[2]); + if (Number.isInteger(number) && number > 0) numbers.push(number); + } + return numbers; +} + +function labelNames(labels: unknown): string[] { + if (!Array.isArray(labels)) return []; + return labels.flatMap((label) => (label && typeof label === "object" && typeof (label as { name?: unknown }).name === "string" ? [(label as { name: string }).name] : [])); +} + +// Mirrors src/db/repositories.ts's toIssueRecord, populated straight from the live payload (createdAt/ +// updatedAt/closedAt come from the DB-row read path there only as a caching artifact, not a semantic +// transform -- the live REST fields are the real source). +function toIssueRecord(repoFullName: string, issue: Record): IssueRecord { + const body = (issue.body as string | undefined) ?? ""; + const user = issue.user as { login?: unknown } | undefined; + return { + repoFullName, + number: issue.number as number, + title: issue.title as string, + state: issue.state as string, + authorLogin: (user?.login as string | undefined) ?? null, + authorAssociation: (issue.author_association as string | undefined) ?? null, + htmlUrl: (issue.html_url as string | undefined) ?? null, + body, + createdAt: (issue.created_at as string | undefined) ?? null, + updatedAt: (issue.updated_at as string | undefined) ?? null, + closedAt: (issue.closed_at as string | undefined) ?? null, + labels: labelNames(issue.labels), + linkedPrs: extractLinkedPrNumbers(body), + }; +} + +async function fetchOpenIssueRecords(target: { owner: string; repo: string }, resolved: ResolvedOptions): Promise { + const payloads = await fetchPaginated( + `/repos/${encodeURIComponent(target.owner)}/${encodeURIComponent(target.repo)}/issues?state=open&sort=created&direction=asc`, + resolved, + ); + // GitHub's Issues endpoint also returns pull requests -- filter them out, same as the live gate's own fetch. + return payloads + .filter((issue): issue is Record => Boolean(issue) && typeof issue === "object" && !(issue as { pull_request?: unknown }).pull_request) + .map((issue) => toIssueRecord(`${target.owner}/${target.repo}`, issue)); +} + +function mergeableBooleanState(mergeable: unknown): string | null { + if (mergeable === true) return "clean"; + if (mergeable === false) return "dirty"; + return null; +} + +// Mirrors src/db/repositories.ts's toPullRequestRecord. Only the fields SelfReviewContext/buildCollisionReport +// actually consume are populated with real precision; merge/RC3 gate-plumbing fields the live gate's fuller +// PullRequestRecord carries (mergeAttemptCount, approvedHeadSha, ...) don't exist on the engine package's +// leaner mirror type and aren't meaningful for a miner attempt anyway. +function toPullRequestRecord(repoFullName: string, pr: Record): PullRequestRecord { + const body = (pr.body as string | undefined) ?? ""; + const user = pr.user as { login?: unknown } | undefined; + const head = pr.head as { sha?: unknown; ref?: unknown } | undefined; + const base = pr.base as { ref?: unknown } | undefined; + return { + repoFullName, + number: pr.number as number, + title: pr.title as string, + state: pr.state as string, + authorLogin: (user?.login as string | undefined) ?? null, + authorAssociation: (pr.author_association as string | undefined) ?? null, + headSha: (head?.sha as string | undefined) ?? null, + headRef: (head?.ref as string | undefined) ?? null, + baseRef: (base?.ref as string | undefined) ?? null, + htmlUrl: (pr.html_url as string | undefined) ?? null, + mergedAt: (pr.merged_at as string | undefined) ?? null, + isDraft: (pr.draft as boolean | undefined) ?? null, + mergeableState: (pr.mergeable_state as string | undefined) ?? mergeableBooleanState(pr.mergeable), + reviewDecision: null, + body, + createdAt: (pr.created_at as string | undefined) ?? null, + updatedAt: (pr.updated_at as string | undefined) ?? null, + closedAt: (pr.closed_at as string | undefined) ?? null, + labels: labelNames(pr.labels), + linkedIssues: extractLinkedIssueNumbers(body, repoFullName), + }; +} + +async function fetchOpenPullRequestRecords(target: { owner: string; repo: string }, resolved: ResolvedOptions): Promise { + const payloads = await fetchPaginated( + `/repos/${encodeURIComponent(target.owner)}/${encodeURIComponent(target.repo)}/pulls?state=open&sort=created&direction=asc`, + resolved, + ); + return (payloads as Record[]).map((pr) => toPullRequestRecord(`${target.owner}/${target.repo}`, pr)); +} + +// Mirrors src/signals/focus-manifest-loader.ts's raw-content lookup order and bounded body read: +// first candidate path that resolves wins, but hostile manifests never exceed the parser byte cap in memory. +async function readBoundedManifestResponseText(response: SelfReviewContextResponse): Promise { + const contentLength = response.headers?.get?.("content-length") ?? null; + if (contentLength !== null) { + const parsedLength = Number.parseInt(contentLength, 10); + if (Number.isFinite(parsedLength) && parsedLength > MAX_FOCUS_MANIFEST_BYTES) return null; + } + if (!response.body?.getReader) { + const text = await response.text(); + if (typeof text !== "string") return null; + return new TextEncoder().encode(text).byteLength > MAX_FOCUS_MANIFEST_BYTES ? null : text; + } + + const reader = response.body.getReader(); + const decoder = new TextDecoder(); + let totalBytes = 0; + let text = ""; + try { + for (;;) { + const { done, value } = await reader.read(); + if (done) break; + totalBytes += value?.byteLength ?? 0; + if (totalBytes > MAX_FOCUS_MANIFEST_BYTES) { + await reader.cancel(); + return null; + } + if (value) text += decoder.decode(value, { stream: true }); + } + text += decoder.decode(); + return text; + } finally { + reader.releaseLock(); + } +} + +async function fetchManifestContent(target: { owner: string; repo: string }, resolved: ResolvedOptions): Promise { + for (const path of MANIFEST_FILE_CANDIDATES) { + const url = `${resolved.rawContentBaseUrl}/${encodeURIComponent(target.owner)}/${encodeURIComponent(target.repo)}/HEAD/${path}`; + try { + const response = await fetchWithTimeout(resolved.fetchImpl, url, { method: "GET", headers: { accept: "application/json", "user-agent": "loopover-miner" } }, resolved.requestTimeoutMs); + if (response.ok) { + const text = await readBoundedManifestResponseText(response); + if (typeof text === "string") return text; + } + } catch { + // Try the next candidate path. + } + } + return null; +} + +// Mirrors src/gittensor/api.ts's fetchGittensorContributorSnapshot/fetchOfficialGittensorMiner: a public, +// unauthenticated GET against the Gittensor API (not GitHub) -- confirmed only when a real entry with a +// matching GitHub login is found; any transport/parse failure fails closed to "not confirmed", never throws. +async function fetchConfirmedContributor(login: string, resolved: ResolvedOptions): Promise { + if (!login) return false; + try { + const response = await fetchWithTimeout(resolved.fetchImpl, `${resolved.gittensorApiBase}/miners`, { method: "GET", headers: { accept: "application/json" } }, resolved.requestTimeoutMs); + if (!response.ok) return false; + const payload = await response.json().catch(() => null); + if (!Array.isArray(payload)) return false; + const normalizedLogin = login.toLowerCase(); + return payload.some((miner) => typeof (miner as { githubUsername?: unknown })?.githubUsername === "string" && (miner as { githubUsername: string }).githubUsername.toLowerCase() === normalizedLogin); + } catch { + return false; + } +} + +// Per self-review-adapter.ts's own doc comment: the caller computes inDuplicateCluster "the same way the +// live gate's collision report would" -- adapted from src/signals/engine.ts's real +// isPullRequestInDuplicateCluster (root src/, not extracted to the engine package), which requires >= 2 +// PULL REQUEST items in a high-risk cluster, not just any high-risk cluster containing the target. That +// threshold matters: buildCollisionReport's own pairwise "shared linked issue" rule already marks an +// issue+its-one-legitimately-closing-PR pair as a HIGH-risk cluster (confirmed empirically) -- without the +// >= 2 threshold, inDuplicateCluster would fire on the completely normal case of "one PR already closes +// this issue," not genuine overlapping/duplicate work. Checks the target ISSUE's presence instead of a +// not-yet-existing PR number, since the miner's own submission doesn't exist as a real PullRequestRecord yet. +// Takes a prebuilt CollisionReport so issueQuality and inDuplicateCluster share one collision pass. +function computeInDuplicateCluster(collisionReport: ReturnType, targetIssueNumbers: number[]): boolean { + if (targetIssueNumbers.length === 0) return false; + return collisionReport.clusters.some( + (cluster) => + cluster.risk === "high" && + cluster.items.filter((item) => item.type === "pull_request").length >= 2 && + cluster.items.some((item) => item.type === "issue" && targetIssueNumbers.includes(item.number)), + ); +} + +/** + * Build a real SelfReviewContext from live GitHub data, at the same fidelity the live gate's own DB-backed + * construction produces. See this file's header for the one field (bounties) deliberately left undefined + * and why; issueQuality is populated from the live GitHub snapshot. Optionally overlays ORB live gate + * thresholds onto the static `.loopover.yml` reconstruction (#6487). + */ +export async function fetchSelfReviewContext(repoFullName: string, options: FetchSelfReviewContextOptions = {}): Promise { + const target = parseRepoFullName(repoFullName); + if (!target) throw new Error("invalid_repo_full_name"); + const resolved = normalizeOptions(options); + + const [repo, issues, pullRequests, manifestContent, confirmedContributor, liveGateThresholds] = await Promise.all([ + fetchRepositoryRecord(target, resolved), + fetchOpenIssueRecords(target, resolved), + fetchOpenPullRequestRecords(target, resolved), + fetchManifestContent(target, resolved), + fetchConfirmedContributor(resolved.contributorLogin, resolved), + probeLiveGateThresholds(target, resolved), + ]); + + const staticManifest = parseFocusManifestContent(manifestContent, "repo_file"); + const manifest = applyLiveGateThresholdsToManifest(staticManifest, liveGateThresholds); + // Positional args match buildIssueQualityReport(repo, issues, pullRequests, fullName, bounties, collisions, recentMerged): + // repo is the full RepositoryRecord from fetchRepositoryRecord (not a string); empty bounties/recentMerged + // because this fetcher has no external bounty source and does not yet pull merge history. + const fullName = `${target.owner}/${target.repo}`; + const collisions = buildCollisionReport(fullName, issues, pullRequests); + const inDuplicateCluster = computeInDuplicateCluster(collisions, resolved.linkedIssues); + const issueQuality = buildIssueQualityReport(repo, issues, pullRequests, fullName, [], collisions, []); + + return { + manifest, + repo, + issues, + pullRequests, + confirmedContributor, + inDuplicateCluster, + issueQuality, + }; +} diff --git a/packages/loopover-miner/lib/stack-detection.d.ts b/packages/loopover-miner/lib/stack-detection.d.ts index e69b216fae..ba6133911b 100644 --- a/packages/loopover-miner/lib/stack-detection.d.ts +++ b/packages/loopover-miner/lib/stack-detection.d.ts @@ -1,41 +1,37 @@ -/** Stack auto-detection (#4785). `detectRepoStack` inspects an already-cloned repo's manifest / lockfile / config - * files and returns a structured stack description, or an explicit fail-closed result when the stack can't be - * confidently identified (no guessing). */ - /** Which manifest (and lockfile, when present) drove the detection. */ export type StackEvidence = { - manifest: string; - lockfile: string | null; + manifest: string; + lockfile: string | null; }; - /** A confidently-detected stack. Command fields are `null` when the command can't be inferred without guessing. */ export type DetectedRepoStack = { - detected: true; - language: string; - packageManager: string | null; - buildCommand: string | null; - testCommand: string | null; - lintCommand: string | null; - formatCommand: string | null; - evidence: StackEvidence; + detected: true; + language: string; + packageManager: string | null; + buildCommand: string | null; + testCommand: string | null; + lintCommand: string | null; + formatCommand: string | null; + evidence: StackEvidence; }; - /** A repo whose stack could not be confidently identified. */ export type UndetectedRepoStack = { - detected: false; - reason: string; + detected: false; + reason: string; }; - export type RepoStackResult = DetectedRepoStack | UndetectedRepoStack; - export type DetectRepoStackOptions = { - existsSync?: (path: string) => boolean; - readFileSync?: (path: string, encoding: "utf8") => string; + existsSync?: (path: string) => boolean; + readFileSync?: (path: string, encoding: "utf8") => string; }; - -/** Manifests, in the precedence order detection tries them (first match wins). */ -export const RECOGNIZED_MANIFESTS: readonly string[]; - -export function detectRepoStack(repoPath: string, options?: DetectRepoStackOptions): RepoStackResult; - -export function renderStackSummary(stack: RepoStackResult): string; +/** Manifests, in the precedence order detection tries them; the first matching primary manifest wins. A caller with + * a known polyglot repo can inspect `evidence.manifest` to see which one was chosen. */ +export declare const RECOGNIZED_MANIFESTS: readonly string[]; +/** + * Detect the stack of an already-cloned repository at `repoPath`. Returns `{ detected: true, ... }` with the + * language, package manager, and any confidently-inferred commands, or `{ detected: false, reason }` when no + * recognized manifest is present. Never throws. + */ +export declare function detectRepoStack(repoPath: string, options?: DetectRepoStackOptions): RepoStackResult; +/** One-line human summary of a detection result, suitable for a coding-agent prompt or an operator log. */ +export declare function renderStackSummary(stack: RepoStackResult | null | undefined): string; diff --git a/packages/loopover-miner/lib/stack-detection.js b/packages/loopover-miner/lib/stack-detection.js index ab2830afad..2a0fc2087d 100644 --- a/packages/loopover-miner/lib/stack-detection.js +++ b/packages/loopover-miner/lib/stack-detection.js @@ -7,242 +7,242 @@ * can't be confidently identified returns an explicit `{ detected: false, reason }` instead of guessing. */ import { existsSync, readFileSync } from "node:fs"; import { join } from "node:path"; - /** Manifests, in the precedence order detection tries them; the first matching primary manifest wins. A caller with * a known polyglot repo can inspect `evidence.manifest` to see which one was chosen. */ export const RECOGNIZED_MANIFESTS = Object.freeze([ - "package.json", - "pyproject.toml", - "setup.py", - "setup.cfg", - "requirements.txt", - "Pipfile", - "Cargo.toml", - "go.mod", - "pom.xml", - "build.gradle", - "build.gradle.kts", + "package.json", + "pyproject.toml", + "setup.py", + "setup.cfg", + "requirements.txt", + "Pipfile", + "Cargo.toml", + "go.mod", + "pom.xml", + "build.gradle", + "build.gradle.kts", ]); - -const NO_MANIFEST_REASON = - "No recognized dependency manifest (package.json, pyproject.toml, Cargo.toml, go.mod, pom.xml, or build.gradle) was found at the repository root."; - +const NO_MANIFEST_REASON = "No recognized dependency manifest (package.json, pyproject.toml, Cargo.toml, go.mod, pom.xml, or build.gradle) was found at the repository root."; const NODE_PACKAGE_MANAGERS = Object.freeze(["npm", "yarn", "pnpm", "bun"]); const NODE_LOCKFILES = Object.freeze([ - ["pnpm-lock.yaml", "pnpm"], - ["yarn.lock", "yarn"], - ["bun.lockb", "bun"], - ["package-lock.json", "npm"], + ["pnpm-lock.yaml", "pnpm"], + ["yarn.lock", "yarn"], + ["bun.lockb", "bun"], + ["package-lock.json", "npm"], ]); - /** Build a never-throwing accessor over the cloned repo. `exists` and `read` both swallow fs errors so the detector * treats an EACCES/ENOENT/binary file as simply "absent" instead of crashing the attempt. */ function makeAccess(repoPath, options) { - const existsImpl = options.existsSync ?? existsSync; - const readImpl = options.readFileSync ?? readFileSync; - const exists = (relativePath) => { + const existsImpl = options.existsSync ?? existsSync; + const readImpl = options.readFileSync ?? readFileSync; + const exists = (relativePath) => { + try { + return existsImpl(join(repoPath, relativePath)) === true; + } + catch { + return false; + } + }; + const read = (relativePath) => { + try { + if (!exists(relativePath)) + return null; + const content = readImpl(join(repoPath, relativePath), "utf8"); + return typeof content === "string" ? content : null; + } + catch { + return null; + } + }; + return { exists, read }; +} +function parseJson(text) { + if (typeof text !== "string") + return null; try { - return existsImpl(join(repoPath, relativePath)) === true; - } catch { - return false; + const parsed = JSON.parse(text); + return parsed && typeof parsed === "object" ? parsed : null; } - }; - const read = (relativePath) => { - try { - if (!exists(relativePath)) return null; - const content = readImpl(join(repoPath, relativePath), "utf8"); - return typeof content === "string" ? content : null; - } catch { - return null; + catch { + return null; } - }; - return { exists, read }; } - -function parseJson(text) { - if (typeof text !== "string") return null; - try { - const parsed = JSON.parse(text); - return parsed && typeof parsed === "object" ? parsed : null; - } catch { - return null; - } -} - /** Pick a package.json script by exact name first, then by pattern, considering only string-valued scripts. */ function pickScript(scripts, exactName, pattern) { - const names = Object.keys(scripts).filter((name) => typeof scripts[name] === "string"); - if (names.includes(exactName)) return exactName; - return names.find((name) => pattern.test(name)) ?? null; + const names = Object.keys(scripts).filter((name) => typeof scripts[name] === "string"); + if (names.includes(exactName)) + return exactName; + return names.find((name) => pattern.test(name)) ?? null; } - function nodeLockfile(exists) { - const match = NODE_LOCKFILES.find(([file]) => exists(file)); - return match ? match[0] : null; + const match = NODE_LOCKFILES.find(([file]) => exists(file)); + return match ? match[0] : null; } - function nodePackageManager(pkg, lockfile) { - const corepack = - typeof pkg?.packageManager === "string" ? pkg.packageManager.split("@")[0].trim().toLowerCase() : ""; - if (NODE_PACKAGE_MANAGERS.includes(corepack)) return corepack; - const byLock = NODE_LOCKFILES.find(([file]) => file === lockfile); - // A package.json with no lockfile is still a Node project; npm is its default runner (a default, not a guess). - return byLock ? byLock[1] : "npm"; + const corepack = typeof pkg?.packageManager === "string" ? pkg.packageManager.split("@")[0].trim().toLowerCase() : ""; + if (NODE_PACKAGE_MANAGERS.includes(corepack)) + return corepack; + const byLock = NODE_LOCKFILES.find(([file]) => file === lockfile); + // A package.json with no lockfile is still a Node project; npm is its default runner (a default, not a guess). + return byLock ? byLock[1] : "npm"; } - function hasTypescriptDependency(pkg) { - const deps = { ...(pkg?.dependencies ?? {}), ...(pkg?.devDependencies ?? {}) }; - return typeof deps.typescript === "string"; + const dependencies = (pkg?.dependencies ?? {}); + const devDependencies = (pkg?.devDependencies ?? {}); + const deps = { ...dependencies, ...devDependencies }; + return typeof deps.typescript === "string"; } - function detectNode({ exists, read }) { - if (!exists("package.json")) return null; - const pkg = parseJson(read("package.json")); - const scripts = - pkg && typeof pkg.scripts === "object" && pkg.scripts && !Array.isArray(pkg.scripts) ? pkg.scripts : {}; - const language = exists("tsconfig.json") || hasTypescriptDependency(pkg) ? "typescript" : "javascript"; - const lockfile = nodeLockfile(exists); - const packageManager = nodePackageManager(pkg, lockfile); - - const buildName = pickScript(scripts, "build", /^(build|compile|bundle)(:|$)/i); - const testName = pickScript(scripts, "test", /(^|:)test(:|$)/i); - const lintName = pickScript(scripts, "lint", /(^|:)lint(:|$)/i); - const formatName = pickScript(scripts, "format", /(^|:)(format|fmt)(:|$)/i); - - return { - language, - packageManager, - buildCommand: buildName ? `${packageManager} run ${buildName}` : null, - // ` test` is the built-in test lifecycle across npm/yarn/pnpm/bun; a non-"test" script uses `run`. - testCommand: testName ? (testName === "test" ? `${packageManager} test` : `${packageManager} run ${testName}`) : null, - lintCommand: lintName ? `${packageManager} run ${lintName}` : null, - formatCommand: formatName ? `${packageManager} run ${formatName}` : null, - evidence: { manifest: "package.json", lockfile }, - }; + if (!exists("package.json")) + return null; + const pkg = parseJson(read("package.json")); + const scripts = pkg && typeof pkg.scripts === "object" && pkg.scripts && !Array.isArray(pkg.scripts) ? pkg.scripts : {}; + const language = exists("tsconfig.json") || hasTypescriptDependency(pkg) ? "typescript" : "javascript"; + const lockfile = nodeLockfile(exists); + const packageManager = nodePackageManager(pkg, lockfile); + const buildName = pickScript(scripts, "build", /^(build|compile|bundle)(:|$)/i); + const testName = pickScript(scripts, "test", /(^|:)test(:|$)/i); + const lintName = pickScript(scripts, "lint", /(^|:)lint(:|$)/i); + const formatName = pickScript(scripts, "format", /(^|:)(format|fmt)(:|$)/i); + return { + language, + packageManager, + buildCommand: buildName ? `${packageManager} run ${buildName}` : null, + // ` test` is the built-in test lifecycle across npm/yarn/pnpm/bun; a non-"test" script uses `run`. + testCommand: testName ? (testName === "test" ? `${packageManager} test` : `${packageManager} run ${testName}`) : null, + lintCommand: lintName ? `${packageManager} run ${lintName}` : null, + formatCommand: formatName ? `${packageManager} run ${formatName}` : null, + evidence: { manifest: "package.json", lockfile }, + }; } - function detectPython({ exists, read }) { - const manifest = ["pyproject.toml", "setup.py", "setup.cfg", "requirements.txt", "Pipfile"].find(exists); - if (manifest === undefined) return null; - const pyproject = read("pyproject.toml") ?? ""; - - let packageManager; - let lockfile = null; - if (exists("poetry.lock") || /\[tool\.poetry\]/.test(pyproject)) { - packageManager = "poetry"; - lockfile = exists("poetry.lock") ? "poetry.lock" : null; - } else if (exists("uv.lock")) { - packageManager = "uv"; - lockfile = "uv.lock"; - } else if (exists("Pipfile") || exists("Pipfile.lock")) { - packageManager = "pipenv"; - lockfile = exists("Pipfile.lock") ? "Pipfile.lock" : null; - } else { - packageManager = "pip"; - } - - // Commands are inferred only from real config so an undeclared tool is never guessed (acceptance: fail safe). - const hasRuff = exists("ruff.toml") || exists(".ruff.toml") || /\[tool\.ruff\]/.test(pyproject); - const hasPytest = exists("pytest.ini") || exists("tox.ini") || /\[tool\.pytest\b/.test(pyproject); - - return { - language: "python", - packageManager, - buildCommand: /\[build-system\]/.test(pyproject) ? (packageManager === "poetry" ? "poetry build" : "python -m build") : null, - testCommand: hasPytest ? "pytest" : null, - lintCommand: hasRuff ? "ruff check ." : null, - formatCommand: hasRuff ? "ruff format ." : null, - evidence: { manifest, lockfile }, - }; + const manifest = ["pyproject.toml", "setup.py", "setup.cfg", "requirements.txt", "Pipfile"].find(exists); + if (manifest === undefined) + return null; + const pyproject = read("pyproject.toml") ?? ""; + let packageManager; + let lockfile = null; + if (exists("poetry.lock") || /\[tool\.poetry\]/.test(pyproject)) { + packageManager = "poetry"; + lockfile = exists("poetry.lock") ? "poetry.lock" : null; + } + else if (exists("uv.lock")) { + packageManager = "uv"; + lockfile = "uv.lock"; + } + else if (exists("Pipfile") || exists("Pipfile.lock")) { + packageManager = "pipenv"; + lockfile = exists("Pipfile.lock") ? "Pipfile.lock" : null; + } + else { + packageManager = "pip"; + } + // Commands are inferred only from real config so an undeclared tool is never guessed (acceptance: fail safe). + const hasRuff = exists("ruff.toml") || exists(".ruff.toml") || /\[tool\.ruff\]/.test(pyproject); + const hasPytest = exists("pytest.ini") || exists("tox.ini") || /\[tool\.pytest\b/.test(pyproject); + return { + language: "python", + packageManager, + buildCommand: /\[build-system\]/.test(pyproject) ? (packageManager === "poetry" ? "poetry build" : "python -m build") : null, + testCommand: hasPytest ? "pytest" : null, + lintCommand: hasRuff ? "ruff check ." : null, + formatCommand: hasRuff ? "ruff format ." : null, + evidence: { manifest, lockfile }, + }; } - function detectRust({ exists }) { - if (!exists("Cargo.toml")) return null; - return { - language: "rust", - packageManager: "cargo", - buildCommand: "cargo build", - testCommand: "cargo test", - lintCommand: "cargo clippy", - formatCommand: "cargo fmt", - evidence: { manifest: "Cargo.toml", lockfile: exists("Cargo.lock") ? "Cargo.lock" : null }, - }; + if (!exists("Cargo.toml")) + return null; + return { + language: "rust", + packageManager: "cargo", + buildCommand: "cargo build", + testCommand: "cargo test", + lintCommand: "cargo clippy", + formatCommand: "cargo fmt", + evidence: { manifest: "Cargo.toml", lockfile: exists("Cargo.lock") ? "Cargo.lock" : null }, + }; } - function detectGo({ exists }) { - if (!exists("go.mod")) return null; - const hasGolangci = exists(".golangci.yml") || exists(".golangci.yaml") || exists(".golangci.toml"); - return { - language: "go", - packageManager: "go", - buildCommand: "go build ./...", - testCommand: "go test ./...", - lintCommand: hasGolangci ? "golangci-lint run" : "go vet ./...", - formatCommand: "gofmt -l .", - evidence: { manifest: "go.mod", lockfile: exists("go.sum") ? "go.sum" : null }, - }; + if (!exists("go.mod")) + return null; + const hasGolangci = exists(".golangci.yml") || exists(".golangci.yaml") || exists(".golangci.toml"); + return { + language: "go", + packageManager: "go", + buildCommand: "go build ./...", + testCommand: "go test ./...", + lintCommand: hasGolangci ? "golangci-lint run" : "go vet ./...", + formatCommand: "gofmt -l .", + evidence: { manifest: "go.mod", lockfile: exists("go.sum") ? "go.sum" : null }, + }; } - function detectMaven({ exists }) { - if (!exists("pom.xml")) return null; - return { - language: "java", - packageManager: "maven", - buildCommand: "mvn -B package", - testCommand: "mvn -B test", - lintCommand: null, - formatCommand: null, - evidence: { manifest: "pom.xml", lockfile: null }, - }; + if (!exists("pom.xml")) + return null; + return { + language: "java", + packageManager: "maven", + buildCommand: "mvn -B package", + testCommand: "mvn -B test", + lintCommand: null, + formatCommand: null, + evidence: { manifest: "pom.xml", lockfile: null }, + }; } - function detectGradle({ exists }) { - const manifest = exists("build.gradle") ? "build.gradle" : exists("build.gradle.kts") ? "build.gradle.kts" : null; - if (manifest === null) return null; - const runner = exists("gradlew") ? "./gradlew" : "gradle"; - return { - language: "java", - packageManager: "gradle", - buildCommand: `${runner} build`, - testCommand: `${runner} test`, - lintCommand: null, - formatCommand: null, - evidence: { manifest, lockfile: null }, - }; + const manifest = exists("build.gradle") ? "build.gradle" : exists("build.gradle.kts") ? "build.gradle.kts" : null; + if (manifest === null) + return null; + const runner = exists("gradlew") ? "./gradlew" : "gradle"; + return { + language: "java", + packageManager: "gradle", + buildCommand: `${runner} build`, + testCommand: `${runner} test`, + lintCommand: null, + formatCommand: null, + evidence: { manifest, lockfile: null }, + }; } - -const DETECTORS = Object.freeze([detectNode, detectPython, detectRust, detectGo, detectMaven, detectGradle]); - +const DETECTORS = Object.freeze([ + detectNode, + detectPython, + detectRust, + detectGo, + detectMaven, + detectGradle, +]); /** * Detect the stack of an already-cloned repository at `repoPath`. Returns `{ detected: true, ... }` with the * language, package manager, and any confidently-inferred commands, or `{ detected: false, reason }` when no * recognized manifest is present. Never throws. */ export function detectRepoStack(repoPath, options = {}) { - if (typeof repoPath !== "string" || !repoPath.trim()) { - return { detected: false, reason: "A repository path is required to detect the stack." }; - } - const access = makeAccess(repoPath, options); - for (const detector of DETECTORS) { - const detected = detector(access); - if (detected !== null) { - return { detected: true, ...detected }; + if (typeof repoPath !== "string" || !repoPath.trim()) { + return { detected: false, reason: "A repository path is required to detect the stack." }; + } + const access = makeAccess(repoPath, options); + for (const detector of DETECTORS) { + const detected = detector(access); + if (detected !== null) { + return { detected: true, ...detected }; + } } - } - return { detected: false, reason: NO_MANIFEST_REASON }; + return { detected: false, reason: NO_MANIFEST_REASON }; } - /** One-line human summary of a detection result, suitable for a coding-agent prompt or an operator log. */ export function renderStackSummary(stack) { - if (!stack || stack.detected !== true) { - return `stack not detected: ${stack?.reason ?? "unknown reason"}`; - } - const commands = [ - stack.buildCommand ? `build=\`${stack.buildCommand}\`` : null, - stack.testCommand ? `test=\`${stack.testCommand}\`` : null, - stack.lintCommand ? `lint=\`${stack.lintCommand}\`` : null, - stack.formatCommand ? `format=\`${stack.formatCommand}\`` : null, - ].filter((entry) => entry !== null); - const suffix = commands.length > 0 ? ` (${commands.join(", ")})` : " (no validation commands detected)"; - return `${stack.language} via ${stack.packageManager ?? "unknown"}${suffix}`; + if (!stack || stack.detected !== true) { + return `stack not detected: ${stack?.reason ?? "unknown reason"}`; + } + const commands = [ + stack.buildCommand ? `build=\`${stack.buildCommand}\`` : null, + stack.testCommand ? `test=\`${stack.testCommand}\`` : null, + stack.lintCommand ? `lint=\`${stack.lintCommand}\`` : null, + stack.formatCommand ? `format=\`${stack.formatCommand}\`` : null, + ].filter((entry) => entry !== null); + const suffix = commands.length > 0 ? ` (${commands.join(", ")})` : " (no validation commands detected)"; + return `${stack.language} via ${stack.packageManager ?? "unknown"}${suffix}`; } +//# sourceMappingURL=data:application/json;base64,{"version":3,"file":"stack-detection.js","sourceRoot":"","sources":["stack-detection.ts"],"names":[],"mappings":"AAAA;;;;;;4GAM4G;AAC5G,OAAO,EAAE,UAAU,EAAE,YAAY,EAAE,MAAM,SAAS,CAAC;AACnD,OAAO,EAAE,IAAI,EAAE,MAAM,WAAW,CAAC;AAwCjC;wFACwF;AACxF,MAAM,CAAC,MAAM,oBAAoB,GAAsB,MAAM,CAAC,MAAM,CAAC;IACnE,cAAc;IACd,gBAAgB;IAChB,UAAU;IACV,WAAW;IACX,kBAAkB;IAClB,SAAS;IACT,YAAY;IACZ,QAAQ;IACR,SAAS;IACT,cAAc;IACd,kBAAkB;CACnB,CAAC,CAAC;AAEH,MAAM,kBAAkB,GACtB,kJAAkJ,CAAC;AAErJ,MAAM,qBAAqB,GAAG,MAAM,CAAC,MAAM,CAAC,CAAC,KAAK,EAAE,MAAM,EAAE,MAAM,EAAE,KAAK,CAAC,CAAC,CAAC;AAC5E,MAAM,cAAc,GAAgC,MAAM,CAAC,MAAM,CAAC;IAChE,CAAC,gBAAgB,EAAE,MAAM,CAAC;IAC1B,CAAC,WAAW,EAAE,MAAM,CAAC;IACrB,CAAC,WAAW,EAAE,KAAK,CAAC;IACpB,CAAC,mBAAmB,EAAE,KAAK,CAAC;CAC7B,CAAC,CAAC;AAEH;6FAC6F;AAC7F,SAAS,UAAU,CAAC,QAAgB,EAAE,OAA+B;IACnE,MAAM,UAAU,GAAG,OAAO,CAAC,UAAU,IAAI,UAAU,CAAC;IACpD,MAAM,QAAQ,GAAG,OAAO,CAAC,YAAY,IAAI,YAAY,CAAC;IACtD,MAAM,MAAM,GAAG,CAAC,YAAoB,EAAW,EAAE;QAC/C,IAAI,CAAC;YACH,OAAO,UAAU,CAAC,IAAI,CAAC,QAAQ,EAAE,YAAY,CAAC,CAAC,KAAK,IAAI,CAAC;QAC3D,CAAC;QAAC,MAAM,CAAC;YACP,OAAO,KAAK,CAAC;QACf,CAAC;IACH,CAAC,CAAC;IACF,MAAM,IAAI,GAAG,CAAC,YAAoB,EAAiB,EAAE;QACnD,IAAI,CAAC;YACH,IAAI,CAAC,MAAM,CAAC,YAAY,CAAC;gBAAE,OAAO,IAAI,CAAC;YACvC,MAAM,OAAO,GAAG,QAAQ,CAAC,IAAI,CAAC,QAAQ,EAAE,YAAY,CAAC,EAAE,MAAM,CAAC,CAAC;YAC/D,OAAO,OAAO,OAAO,KAAK,QAAQ,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,CAAC,IAAI,CAAC;QACtD,CAAC;QAAC,MAAM,CAAC;YACP,OAAO,IAAI,CAAC;QACd,CAAC;IACH,CAAC,CAAC;IACF,OAAO,EAAE,MAAM,EAAE,IAAI,EAAE,CAAC;AAC1B,CAAC;AAED,SAAS,SAAS,CAAC,IAAmB;IACpC,IAAI,OAAO,IAAI,KAAK,QAAQ;QAAE,OAAO,IAAI,CAAC;IAC1C,IAAI,CAAC;QACH,MAAM,MAAM,GAAY,IAAI,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC;QACzC,OAAO,MAAM,IAAI,OAAO,MAAM,KAAK,QAAQ,CAAC,CAAC,CAAE,MAAkC,CAAC,CAAC,CAAC,IAAI,CAAC;IAC3F,CAAC;IAAC,MAAM,CAAC;QACP,OAAO,IAAI,CAAC;IACd,CAAC;AACH,CAAC;AAED,+GAA+G;AAC/G,SAAS,UAAU,CAAC,OAAgC,EAAE,SAAiB,EAAE,OAAe;IACtF,MAAM,KAAK,GAAG,MAAM,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC,MAAM,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,OAAO,OAAO,CAAC,IAAI,CAAC,KAAK,QAAQ,CAAC,CAAC;IACvF,IAAI,KAAK,CAAC,QAAQ,CAAC,SAAS,CAAC;QAAE,OAAO,SAAS,CAAC;IAChD,OAAO,KAAK,CAAC,IAAI,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,OAAO,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,IAAI,IAAI,CAAC;AAC1D,CAAC;AAED,SAAS,YAAY,CAAC,MAAwB;IAC5C,MAAM,KAAK,GAAG,cAAc,CAAC,IAAI,CAAC,CAAC,CAAC,IAAI,CAAC,EAAE,EAAE,CAAC,MAAM,CAAC,IAAI,CAAC,CAAC,CAAC;IAC5D,OAAO,KAAK,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC;AACjC,CAAC;AAED,SAAS,kBAAkB,CAAC,GAAmC,EAAE,QAAuB;IACtF,MAAM,QAAQ,GACZ,OAAO,GAAG,EAAE,cAAc,KAAK,QAAQ,CAAC,CAAC,CAAC,GAAG,CAAC,cAAc,CAAC,KAAK,CAAC,GAAG,CAAC,CAAC,CAAC,CAAE,CAAC,IAAI,EAAE,CAAC,WAAW,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC;IACxG,IAAI,qBAAqB,CAAC,QAAQ,CAAC,QAAQ,CAAC;QAAE,OAAO,QAAQ,CAAC;IAC9D,MAAM,MAAM,GAAG,cAAc,CAAC,IAAI,CAAC,CAAC,CAAC,IAAI,CAAC,EAAE,EAAE,CAAC,IAAI,KAAK,QAAQ,CAAC,CAAC;IAClE,+GAA+G;IAC/G,OAAO,MAAM,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,KAAK,CAAC;AACpC,CAAC;AAED,SAAS,uBAAuB,CAAC,GAAmC;IAClE,MAAM,YAAY,GAAG,CAAC,GAAG,EAAE,YAAY,IAAI,EAAE,CAA4B,CAAC;IAC1E,MAAM,eAAe,GAAG,CAAC,GAAG,EAAE,eAAe,IAAI,EAAE,CAA4B,CAAC;IAChF,MAAM,IAAI,GAAG,EAAE,GAAG,YAAY,EAAE,GAAG,eAAe,EAAE,CAAC;IACrD,OAAO,OAAO,IAAI,CAAC,UAAU,KAAK,QAAQ,CAAC;AAC7C,CAAC;AAED,SAAS,UAAU,CAAC,EAAE,MAAM,EAAE,IAAI,EAAU;IAC1C,IAAI,CAAC,MAAM,CAAC,cAAc,CAAC;QAAE,OAAO,IAAI,CAAC;IACzC,MAAM,GAAG,GAAG,SAAS,CAAC,IAAI,CAAC,cAAc,CAAC,CAAC,CAAC;IAC5C,MAAM,OAAO,GACX,GAAG,IAAI,OAAO,GAAG,CAAC,OAAO,KAAK,QAAQ,IAAI,GAAG,CAAC,OAAO,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC,CAAC,CAAE,GAAG,CAAC,OAAmC,CAAC,CAAC,CAAC,EAAE,CAAC;IACvI,MAAM,QAAQ,GAAG,MAAM,CAAC,eAAe,CAAC,IAAI,uBAAuB,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,YAAY,CAAC;IACvG,MAAM,QAAQ,GAAG,YAAY,CAAC,MAAM,CAAC,CAAC;IACtC,MAAM,cAAc,GAAG,kBAAkB,CAAC,GAAG,EAAE,QAAQ,CAAC,CAAC;IAEzD,MAAM,SAAS,GAAG,UAAU,CAAC,OAAO,EAAE,OAAO,EAAE,+BAA+B,CAAC,CAAC;IAChF,MAAM,QAAQ,GAAG,UAAU,CAAC,OAAO,EAAE,MAAM,EAAE,iBAAiB,CAAC,CAAC;IAChE,MAAM,QAAQ,GAAG,UAAU,CAAC,OAAO,EAAE,MAAM,EAAE,iBAAiB,CAAC,CAAC;IAChE,MAAM,UAAU,GAAG,UAAU,CAAC,OAAO,EAAE,QAAQ,EAAE,yBAAyB,CAAC,CAAC;IAE5E,OAAO;QACL,QAAQ;QACR,cAAc;QACd,YAAY,EAAE,SAAS,CAAC,CAAC,CAAC,GAAG,cAAc,QAAQ,SAAS,EAAE,CAAC,CAAC,CAAC,IAAI;QACrE,uGAAuG;QACvG,WAAW,EAAE,QAAQ,CAAC,CAAC,CAAC,CAAC,QAAQ,KAAK,MAAM,CAAC,CAAC,CAAC,GAAG,cAAc,OAAO,CAAC,CAAC,CAAC,GAAG,cAAc,QAAQ,QAAQ,EAAE,CAAC,CAAC,CAAC,CAAC,IAAI;QACrH,WAAW,EAAE,QAAQ,CAAC,CAAC,CAAC,GAAG,cAAc,QAAQ,QAAQ,EAAE,CAAC,CAAC,CAAC,IAAI;QAClE,aAAa,EAAE,UAAU,CAAC,CAAC,CAAC,GAAG,cAAc,QAAQ,UAAU,EAAE,CAAC,CAAC,CAAC,IAAI;QACxE,QAAQ,EAAE,EAAE,QAAQ,EAAE,cAAc,EAAE,QAAQ,EAAE;KACjD,CAAC;AACJ,CAAC;AAED,SAAS,YAAY,CAAC,EAAE,MAAM,EAAE,IAAI,EAAU;IAC5C,MAAM,QAAQ,GAAG,CAAC,gBAAgB,EAAE,UAAU,EAAE,WAAW,EAAE,kBAAkB,EAAE,SAAS,CAAC,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC;IACzG,IAAI,QAAQ,KAAK,SAAS;QAAE,OAAO,IAAI,CAAC;IACxC,MAAM,SAAS,GAAG,IAAI,CAAC,gBAAgB,CAAC,IAAI,EAAE,CAAC;IAE/C,IAAI,cAAsB,CAAC;IAC3B,IAAI,QAAQ,GAAkB,IAAI,CAAC;IACnC,IAAI,MAAM,CAAC,aAAa,CAAC,IAAI,kBAAkB,CAAC,IAAI,CAAC,SAAS,CAAC,EAAE,CAAC;QAChE,cAAc,GAAG,QAAQ,CAAC;QAC1B,QAAQ,GAAG,MAAM,CAAC,aAAa,CAAC,CAAC,CAAC,CAAC,aAAa,CAAC,CAAC,CAAC,IAAI,CAAC;IAC1D,CAAC;SAAM,IAAI,MAAM,CAAC,SAAS,CAAC,EAAE,CAAC;QAC7B,cAAc,GAAG,IAAI,CAAC;QACtB,QAAQ,GAAG,SAAS,CAAC;IACvB,CAAC;SAAM,IAAI,MAAM,CAAC,SAAS,CAAC,IAAI,MAAM,CAAC,cAAc,CAAC,EAAE,CAAC;QACvD,cAAc,GAAG,QAAQ,CAAC;QAC1B,QAAQ,GAAG,MAAM,CAAC,cAAc,CAAC,CAAC,CAAC,CAAC,cAAc,CAAC,CAAC,CAAC,IAAI,CAAC;IAC5D,CAAC;SAAM,CAAC;QACN,cAAc,GAAG,KAAK,CAAC;IACzB,CAAC;IAED,8GAA8G;IAC9G,MAAM,OAAO,GAAG,MAAM,CAAC,WAAW,CAAC,IAAI,MAAM,CAAC,YAAY,CAAC,IAAI,gBAAgB,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC;IAChG,MAAM,SAAS,GAAG,MAAM,CAAC,YAAY,CAAC,IAAI,MAAM,CAAC,SAAS,CAAC,IAAI,kBAAkB,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC;IAElG,OAAO;QACL,QAAQ,EAAE,QAAQ;QAClB,cAAc;QACd,YAAY,EAAE,kBAAkB,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC,CAAC,cAAc,KAAK,QAAQ,CAAC,CAAC,CAAC,cAAc,CAAC,CAAC,CAAC,iBAAiB,CAAC,CAAC,CAAC,CAAC,IAAI;QAC5H,WAAW,EAAE,SAAS,CAAC,CAAC,CAAC,QAAQ,CAAC,CAAC,CAAC,IAAI;QACxC,WAAW,EAAE,OAAO,CAAC,CAAC,CAAC,cAAc,CAAC,CAAC,CAAC,IAAI;QAC5C,aAAa,EAAE,OAAO,CAAC,CAAC,CAAC,eAAe,CAAC,CAAC,CAAC,IAAI;QAC/C,QAAQ,EAAE,EAAE,QAAQ,EAAE,QAAQ,EAAE;KACjC,CAAC;AACJ,CAAC;AAED,SAAS,UAAU,CAAC,EAAE,MAAM,EAAU;IACpC,IAAI,CAAC,MAAM,CAAC,YAAY,CAAC;QAAE,OAAO,IAAI,CAAC;IACvC,OAAO;QACL,QAAQ,EAAE,MAAM;QAChB,cAAc,EAAE,OAAO;QACvB,YAAY,EAAE,aAAa;QAC3B,WAAW,EAAE,YAAY;QACzB,WAAW,EAAE,cAAc;QAC3B,aAAa,EAAE,WAAW;QAC1B,QAAQ,EAAE,EAAE,QAAQ,EAAE,YAAY,EAAE,QAAQ,EAAE,MAAM,CAAC,YAAY,CAAC,CAAC,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,IAAI,EAAE;KAC3F,CAAC;AACJ,CAAC;AAED,SAAS,QAAQ,CAAC,EAAE,MAAM,EAAU;IAClC,IAAI,CAAC,MAAM,CAAC,QAAQ,CAAC;QAAE,OAAO,IAAI,CAAC;IACnC,MAAM,WAAW,GAAG,MAAM,CAAC,eAAe,CAAC,IAAI,MAAM,CAAC,gBAAgB,CAAC,IAAI,MAAM,CAAC,gBAAgB,CAAC,CAAC;IACpG,OAAO;QACL,QAAQ,EAAE,IAAI;QACd,cAAc,EAAE,IAAI;QACpB,YAAY,EAAE,gBAAgB;QAC9B,WAAW,EAAE,eAAe;QAC5B,WAAW,EAAE,WAAW,CAAC,CAAC,CAAC,mBAAmB,CAAC,CAAC,CAAC,cAAc;QAC/D,aAAa,EAAE,YAAY;QAC3B,QAAQ,EAAE,EAAE,QAAQ,EAAE,QAAQ,EAAE,QAAQ,EAAE,MAAM,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,QAAQ,CAAC,CAAC,CAAC,IAAI,EAAE;KAC/E,CAAC;AACJ,CAAC;AAED,SAAS,WAAW,CAAC,EAAE,MAAM,EAAU;IACrC,IAAI,CAAC,MAAM,CAAC,SAAS,CAAC;QAAE,OAAO,IAAI,CAAC;IACpC,OAAO;QACL,QAAQ,EAAE,MAAM;QAChB,cAAc,EAAE,OAAO;QACvB,YAAY,EAAE,gBAAgB;QAC9B,WAAW,EAAE,aAAa;QAC1B,WAAW,EAAE,IAAI;QACjB,aAAa,EAAE,IAAI;QACnB,QAAQ,EAAE,EAAE,QAAQ,EAAE,SAAS,EAAE,QAAQ,EAAE,IAAI,EAAE;KAClD,CAAC;AACJ,CAAC;AAED,SAAS,YAAY,CAAC,EAAE,MAAM,EAAU;IACtC,MAAM,QAAQ,GAAG,MAAM,CAAC,cAAc,CAAC,CAAC,CAAC,CAAC,cAAc,CAAC,CAAC,CAAC,MAAM,CAAC,kBAAkB,CAAC,CAAC,CAAC,CAAC,kBAAkB,CAAC,CAAC,CAAC,IAAI,CAAC;IAClH,IAAI,QAAQ,KAAK,IAAI;QAAE,OAAO,IAAI,CAAC;IACnC,MAAM,MAAM,GAAG,MAAM,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC,WAAW,CAAC,CAAC,CAAC,QAAQ,CAAC;IAC1D,OAAO;QACL,QAAQ,EAAE,MAAM;QAChB,cAAc,EAAE,QAAQ;QACxB,YAAY,EAAE,GAAG,MAAM,QAAQ;QAC/B,WAAW,EAAE,GAAG,MAAM,OAAO;QAC7B,WAAW,EAAE,IAAI;QACjB,aAAa,EAAE,IAAI;QACnB,QAAQ,EAAE,EAAE,QAAQ,EAAE,QAAQ,EAAE,IAAI,EAAE;KACvC,CAAC;AACJ,CAAC;AAED,MAAM,SAAS,GAAgE,MAAM,CAAC,MAAM,CAAC;IAC3F,UAAU;IACV,YAAY;IACZ,UAAU;IACV,QAAQ;IACR,WAAW;IACX,YAAY;CACb,CAAC,CAAC;AAEH;;;;GAIG;AACH,MAAM,UAAU,eAAe,CAAC,QAAgB,EAAE,UAAkC,EAAE;IACpF,IAAI,OAAO,QAAQ,KAAK,QAAQ,IAAI,CAAC,QAAQ,CAAC,IAAI,EAAE,EAAE,CAAC;QACrD,OAAO,EAAE,QAAQ,EAAE,KAAK,EAAE,MAAM,EAAE,oDAAoD,EAAE,CAAC;IAC3F,CAAC;IACD,MAAM,MAAM,GAAG,UAAU,CAAC,QAAQ,EAAE,OAAO,CAAC,CAAC;IAC7C,KAAK,MAAM,QAAQ,IAAI,SAAS,EAAE,CAAC;QACjC,MAAM,QAAQ,GAAG,QAAQ,CAAC,MAAM,CAAC,CAAC;QAClC,IAAI,QAAQ,KAAK,IAAI,EAAE,CAAC;YACtB,OAAO,EAAE,QAAQ,EAAE,IAAI,EAAE,GAAG,QAAQ,EAAE,CAAC;QACzC,CAAC;IACH,CAAC;IACD,OAAO,EAAE,QAAQ,EAAE,KAAK,EAAE,MAAM,EAAE,kBAAkB,EAAE,CAAC;AACzD,CAAC;AAED,2GAA2G;AAC3G,MAAM,UAAU,kBAAkB,CAAC,KAAyC;IAC1E,IAAI,CAAC,KAAK,IAAI,KAAK,CAAC,QAAQ,KAAK,IAAI,EAAE,CAAC;QACtC,OAAO,uBAAuB,KAAK,EAAE,MAAM,IAAI,gBAAgB,EAAE,CAAC;IACpE,CAAC;IACD,MAAM,QAAQ,GAAG;QACf,KAAK,CAAC,YAAY,CAAC,CAAC,CAAC,WAAW,KAAK,CAAC,YAAY,IAAI,CAAC,CAAC,CAAC,IAAI;QAC7D,KAAK,CAAC,WAAW,CAAC,CAAC,CAAC,UAAU,KAAK,CAAC,WAAW,IAAI,CAAC,CAAC,CAAC,IAAI;QAC1D,KAAK,CAAC,WAAW,CAAC,CAAC,CAAC,UAAU,KAAK,CAAC,WAAW,IAAI,CAAC,CAAC,CAAC,IAAI;QAC1D,KAAK,CAAC,aAAa,CAAC,CAAC,CAAC,YAAY,KAAK,CAAC,aAAa,IAAI,CAAC,CAAC,CAAC,IAAI;KACjE,CAAC,MAAM,CAAC,CAAC,KAAK,EAAmB,EAAE,CAAC,KAAK,KAAK,IAAI,CAAC,CAAC;IACrD,MAAM,MAAM,GAAG,QAAQ,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC,CAAC,KAAK,QAAQ,CAAC,IAAI,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC,CAAC,oCAAoC,CAAC;IACxG,OAAO,GAAG,KAAK,CAAC,QAAQ,QAAQ,KAAK,CAAC,cAAc,IAAI,SAAS,GAAG,MAAM,EAAE,CAAC;AAC/E,CAAC"} \ No newline at end of file diff --git a/packages/loopover-miner/lib/stack-detection.ts b/packages/loopover-miner/lib/stack-detection.ts new file mode 100644 index 0000000000..a8c7132845 --- /dev/null +++ b/packages/loopover-miner/lib/stack-detection.ts @@ -0,0 +1,295 @@ +/** Stack auto-detection (#4785): inspect an already-cloned target repo's manifest / lockfile / config files and + * infer a structured description of its stack — language, package manager, and the build / test / lint / format + * commands — before any code-generation step runs. Like `miner-goal-spec.js` this reads the ALREADY-CLONED repo on + * disk (attempt-worktree.js's prepareAttemptWorktree runs first), so the injected `existsSync` / `readFileSync` + * always receive the FULL joined path, mirroring node:fs. It is pure and NEVER throws: an unreadable/unparseable + * file degrades to "no evidence" rather than crashing, and — per the acceptance criteria — a repo whose stack + * can't be confidently identified returns an explicit `{ detected: false, reason }` instead of guessing. */ +import { existsSync, readFileSync } from "node:fs"; +import { join } from "node:path"; + +/** Which manifest (and lockfile, when present) drove the detection. */ +export type StackEvidence = { + manifest: string; + lockfile: string | null; +}; + +/** A confidently-detected stack. Command fields are `null` when the command can't be inferred without guessing. */ +export type DetectedRepoStack = { + detected: true; + language: string; + packageManager: string | null; + buildCommand: string | null; + testCommand: string | null; + lintCommand: string | null; + formatCommand: string | null; + evidence: StackEvidence; +}; + +/** A repo whose stack could not be confidently identified. */ +export type UndetectedRepoStack = { + detected: false; + reason: string; +}; + +export type RepoStackResult = DetectedRepoStack | UndetectedRepoStack; + +export type DetectRepoStackOptions = { + existsSync?: (path: string) => boolean; + readFileSync?: (path: string, encoding: "utf8") => string; +}; + +type Access = { + exists: (relativePath: string) => boolean; + read: (relativePath: string) => string | null; +}; + +type DetectedStackFields = Omit; + +/** Manifests, in the precedence order detection tries them; the first matching primary manifest wins. A caller with + * a known polyglot repo can inspect `evidence.manifest` to see which one was chosen. */ +export const RECOGNIZED_MANIFESTS: readonly string[] = Object.freeze([ + "package.json", + "pyproject.toml", + "setup.py", + "setup.cfg", + "requirements.txt", + "Pipfile", + "Cargo.toml", + "go.mod", + "pom.xml", + "build.gradle", + "build.gradle.kts", +]); + +const NO_MANIFEST_REASON = + "No recognized dependency manifest (package.json, pyproject.toml, Cargo.toml, go.mod, pom.xml, or build.gradle) was found at the repository root."; + +const NODE_PACKAGE_MANAGERS = Object.freeze(["npm", "yarn", "pnpm", "bun"]); +const NODE_LOCKFILES: readonly [string, string][] = Object.freeze([ + ["pnpm-lock.yaml", "pnpm"], + ["yarn.lock", "yarn"], + ["bun.lockb", "bun"], + ["package-lock.json", "npm"], +]); + +/** Build a never-throwing accessor over the cloned repo. `exists` and `read` both swallow fs errors so the detector + * treats an EACCES/ENOENT/binary file as simply "absent" instead of crashing the attempt. */ +function makeAccess(repoPath: string, options: DetectRepoStackOptions): Access { + const existsImpl = options.existsSync ?? existsSync; + const readImpl = options.readFileSync ?? readFileSync; + const exists = (relativePath: string): boolean => { + try { + return existsImpl(join(repoPath, relativePath)) === true; + } catch { + return false; + } + }; + const read = (relativePath: string): string | null => { + try { + if (!exists(relativePath)) return null; + const content = readImpl(join(repoPath, relativePath), "utf8"); + return typeof content === "string" ? content : null; + } catch { + return null; + } + }; + return { exists, read }; +} + +function parseJson(text: string | null): Record | null { + if (typeof text !== "string") return null; + try { + const parsed: unknown = JSON.parse(text); + return parsed && typeof parsed === "object" ? (parsed as Record) : null; + } catch { + return null; + } +} + +/** Pick a package.json script by exact name first, then by pattern, considering only string-valued scripts. */ +function pickScript(scripts: Record, exactName: string, pattern: RegExp): string | null { + const names = Object.keys(scripts).filter((name) => typeof scripts[name] === "string"); + if (names.includes(exactName)) return exactName; + return names.find((name) => pattern.test(name)) ?? null; +} + +function nodeLockfile(exists: Access["exists"]): string | null { + const match = NODE_LOCKFILES.find(([file]) => exists(file)); + return match ? match[0] : null; +} + +function nodePackageManager(pkg: Record | null, lockfile: string | null): string { + const corepack = + typeof pkg?.packageManager === "string" ? pkg.packageManager.split("@")[0]!.trim().toLowerCase() : ""; + if (NODE_PACKAGE_MANAGERS.includes(corepack)) return corepack; + const byLock = NODE_LOCKFILES.find(([file]) => file === lockfile); + // A package.json with no lockfile is still a Node project; npm is its default runner (a default, not a guess). + return byLock ? byLock[1] : "npm"; +} + +function hasTypescriptDependency(pkg: Record | null): boolean { + const dependencies = (pkg?.dependencies ?? {}) as Record; + const devDependencies = (pkg?.devDependencies ?? {}) as Record; + const deps = { ...dependencies, ...devDependencies }; + return typeof deps.typescript === "string"; +} + +function detectNode({ exists, read }: Access): DetectedStackFields | null { + if (!exists("package.json")) return null; + const pkg = parseJson(read("package.json")); + const scripts = + pkg && typeof pkg.scripts === "object" && pkg.scripts && !Array.isArray(pkg.scripts) ? (pkg.scripts as Record) : {}; + const language = exists("tsconfig.json") || hasTypescriptDependency(pkg) ? "typescript" : "javascript"; + const lockfile = nodeLockfile(exists); + const packageManager = nodePackageManager(pkg, lockfile); + + const buildName = pickScript(scripts, "build", /^(build|compile|bundle)(:|$)/i); + const testName = pickScript(scripts, "test", /(^|:)test(:|$)/i); + const lintName = pickScript(scripts, "lint", /(^|:)lint(:|$)/i); + const formatName = pickScript(scripts, "format", /(^|:)(format|fmt)(:|$)/i); + + return { + language, + packageManager, + buildCommand: buildName ? `${packageManager} run ${buildName}` : null, + // ` test` is the built-in test lifecycle across npm/yarn/pnpm/bun; a non-"test" script uses `run`. + testCommand: testName ? (testName === "test" ? `${packageManager} test` : `${packageManager} run ${testName}`) : null, + lintCommand: lintName ? `${packageManager} run ${lintName}` : null, + formatCommand: formatName ? `${packageManager} run ${formatName}` : null, + evidence: { manifest: "package.json", lockfile }, + }; +} + +function detectPython({ exists, read }: Access): DetectedStackFields | null { + const manifest = ["pyproject.toml", "setup.py", "setup.cfg", "requirements.txt", "Pipfile"].find(exists); + if (manifest === undefined) return null; + const pyproject = read("pyproject.toml") ?? ""; + + let packageManager: string; + let lockfile: string | null = null; + if (exists("poetry.lock") || /\[tool\.poetry\]/.test(pyproject)) { + packageManager = "poetry"; + lockfile = exists("poetry.lock") ? "poetry.lock" : null; + } else if (exists("uv.lock")) { + packageManager = "uv"; + lockfile = "uv.lock"; + } else if (exists("Pipfile") || exists("Pipfile.lock")) { + packageManager = "pipenv"; + lockfile = exists("Pipfile.lock") ? "Pipfile.lock" : null; + } else { + packageManager = "pip"; + } + + // Commands are inferred only from real config so an undeclared tool is never guessed (acceptance: fail safe). + const hasRuff = exists("ruff.toml") || exists(".ruff.toml") || /\[tool\.ruff\]/.test(pyproject); + const hasPytest = exists("pytest.ini") || exists("tox.ini") || /\[tool\.pytest\b/.test(pyproject); + + return { + language: "python", + packageManager, + buildCommand: /\[build-system\]/.test(pyproject) ? (packageManager === "poetry" ? "poetry build" : "python -m build") : null, + testCommand: hasPytest ? "pytest" : null, + lintCommand: hasRuff ? "ruff check ." : null, + formatCommand: hasRuff ? "ruff format ." : null, + evidence: { manifest, lockfile }, + }; +} + +function detectRust({ exists }: Access): DetectedStackFields | null { + if (!exists("Cargo.toml")) return null; + return { + language: "rust", + packageManager: "cargo", + buildCommand: "cargo build", + testCommand: "cargo test", + lintCommand: "cargo clippy", + formatCommand: "cargo fmt", + evidence: { manifest: "Cargo.toml", lockfile: exists("Cargo.lock") ? "Cargo.lock" : null }, + }; +} + +function detectGo({ exists }: Access): DetectedStackFields | null { + if (!exists("go.mod")) return null; + const hasGolangci = exists(".golangci.yml") || exists(".golangci.yaml") || exists(".golangci.toml"); + return { + language: "go", + packageManager: "go", + buildCommand: "go build ./...", + testCommand: "go test ./...", + lintCommand: hasGolangci ? "golangci-lint run" : "go vet ./...", + formatCommand: "gofmt -l .", + evidence: { manifest: "go.mod", lockfile: exists("go.sum") ? "go.sum" : null }, + }; +} + +function detectMaven({ exists }: Access): DetectedStackFields | null { + if (!exists("pom.xml")) return null; + return { + language: "java", + packageManager: "maven", + buildCommand: "mvn -B package", + testCommand: "mvn -B test", + lintCommand: null, + formatCommand: null, + evidence: { manifest: "pom.xml", lockfile: null }, + }; +} + +function detectGradle({ exists }: Access): DetectedStackFields | null { + const manifest = exists("build.gradle") ? "build.gradle" : exists("build.gradle.kts") ? "build.gradle.kts" : null; + if (manifest === null) return null; + const runner = exists("gradlew") ? "./gradlew" : "gradle"; + return { + language: "java", + packageManager: "gradle", + buildCommand: `${runner} build`, + testCommand: `${runner} test`, + lintCommand: null, + formatCommand: null, + evidence: { manifest, lockfile: null }, + }; +} + +const DETECTORS: readonly ((access: Access) => DetectedStackFields | null)[] = Object.freeze([ + detectNode, + detectPython, + detectRust, + detectGo, + detectMaven, + detectGradle, +]); + +/** + * Detect the stack of an already-cloned repository at `repoPath`. Returns `{ detected: true, ... }` with the + * language, package manager, and any confidently-inferred commands, or `{ detected: false, reason }` when no + * recognized manifest is present. Never throws. + */ +export function detectRepoStack(repoPath: string, options: DetectRepoStackOptions = {}): RepoStackResult { + if (typeof repoPath !== "string" || !repoPath.trim()) { + return { detected: false, reason: "A repository path is required to detect the stack." }; + } + const access = makeAccess(repoPath, options); + for (const detector of DETECTORS) { + const detected = detector(access); + if (detected !== null) { + return { detected: true, ...detected }; + } + } + return { detected: false, reason: NO_MANIFEST_REASON }; +} + +/** One-line human summary of a detection result, suitable for a coding-agent prompt or an operator log. */ +export function renderStackSummary(stack: RepoStackResult | null | undefined): string { + if (!stack || stack.detected !== true) { + return `stack not detected: ${stack?.reason ?? "unknown reason"}`; + } + const commands = [ + stack.buildCommand ? `build=\`${stack.buildCommand}\`` : null, + stack.testCommand ? `test=\`${stack.testCommand}\`` : null, + stack.lintCommand ? `lint=\`${stack.lintCommand}\`` : null, + stack.formatCommand ? `format=\`${stack.formatCommand}\`` : null, + ].filter((entry): entry is string => entry !== null); + const suffix = commands.length > 0 ? ` (${commands.join(", ")})` : " (no validation commands detected)"; + return `${stack.language} via ${stack.packageManager ?? "unknown"}${suffix}`; +} diff --git a/test/unit/miner-attempt-log.test.ts b/test/unit/miner-attempt-log.test.ts index 7e43c2c35c..cdd81fe595 100644 --- a/test/unit/miner-attempt-log.test.ts +++ b/test/unit/miner-attempt-log.test.ts @@ -174,6 +174,13 @@ describe("loopover-miner attempt log (#4294)", () => { expect(() => log.exportAttemptLogJsonl(" ")).toThrow(/invalid_attempt_id/); }); + it("rejects an undefined attemptId from an untyped export caller instead of exporting everything", () => { + const log = tempAttemptLog(); + expect(() => log.exportAttemptLogJsonl(undefined as unknown as string)).toThrow( + /invalid_attempt_id/, + ); + }); + it("rejects a payload JSON would not round-trip verbatim, and accepts a nested JSON-safe one", () => { const log = tempAttemptLog(); expect(() => @@ -210,6 +217,34 @@ describe("loopover-miner attempt log (#4294)", () => { expect(() => log.readAttemptLogEvents()).toThrow("corrupted_attempt_log_row"); }); + it("rejects a payload blob that is valid JSON but not an object, distinct from unparseable JSON", () => { + const log = tempAttemptLog(); + log.appendAttemptLogEvent({ eventType: "attempt_started", ...baseEvent }); + const raw = new DatabaseSync(log.dbPath); + raw.prepare("UPDATE attempt_log_events SET payload_json = ? WHERE id = 1").run("[1,2,3]"); + raw.close(); + expect(() => log.readAttemptLogEvents()).toThrow("corrupted_attempt_log_row"); + }); + + it("REGRESSION: rolls the transaction back if the insert throws, leaving prior rows unchanged", () => { + const log = tempAttemptLog(); + log.appendAttemptLogEvent({ eventType: "attempt_started", ...baseEvent }); + + // Drops a column out from under the already-prepared INSERT statement, forcing node:sqlite to throw INSIDE + // appendAttemptLogEvent's try block (after BEGIN IMMEDIATE) -- exercising the ROLLBACK path (#4294's + // append-only invariant must not leave a stranded transaction or a partial row on a mid-insert failure). + const raw = new DatabaseSync(log.dbPath); + raw.exec("ALTER TABLE attempt_log_events DROP COLUMN mode"); + raw.close(); + + expect(() => log.appendAttemptLogEvent({ eventType: "attempt_started", ...baseEvent })).toThrow(); + + // Rolled back: still just the one row from before the schema was broken, not a partial second insert. + const raw2 = new DatabaseSync(log.dbPath); + expect(raw2.prepare("SELECT COUNT(*) AS count FROM attempt_log_events").get()).toEqual({ count: 1 }); + raw2.close(); + }); + it("uses the default singleton helpers and closes cleanly", () => { const root = mkdtempSync(join(tmpdir(), "loopover-miner-attempt-log-default-")); roots.push(root); diff --git a/test/unit/miner-ci-poller.test.ts b/test/unit/miner-ci-poller.test.ts index ba83895174..d2cf712cb8 100644 --- a/test/unit/miner-ci-poller.test.ts +++ b/test/unit/miner-ci-poller.test.ts @@ -432,4 +432,139 @@ describe("miner CI check-run poller (#2323)", () => { expect(timeoutSpy.mock.calls.every(([ms]) => ms === 2500)).toBe(true); timeoutSpy.mockRestore(); }); + + it("treats a whitespace-only apiBaseUrl the same as omitted, defaulting to the standard GitHub API host", async () => { + const fetchFn = vi.fn(async (input: RequestInfo | URL) => { + const url = String(input); + if (url === "https://api.github.com/repos/acme/widgets/pulls/42") return prResponse("head-sha"); + if (url === "https://api.github.com/repos/acme/widgets/commits/head-sha/check-runs?per_page=100&page=1") { + return checksResponse([checkRun("validate", "completed", "success")]); + } + return jsonResponse({}, { status: 404 }); + }); + + await expect( + pollCheckRuns("acme/widgets", 42, { apiBaseUrl: " ", fetchFn }), + ).resolves.toMatchObject({ conclusion: "success" }); + }); + + it("falls back to the real global fetch and a real timer-based backoff when both are omitted", async () => { + const fetchFn = vi.fn(async (input: RequestInfo | URL) => { + const url = String(input); + if (url.endsWith("/repos/acme/widgets/pulls/99")) return prResponse("head-sha"); + if (url.endsWith("/repos/acme/widgets/commits/head-sha/check-runs?per_page=100&page=1")) { + const checkRunAttempts = fetchFn.mock.calls.filter(([request]) => String(request).includes("/check-runs")).length; + return checkRunAttempts >= 2 + ? checksResponse([checkRun("validate", "completed", "success")]) + : checksResponse([checkRun("validate", "queued")]); + } + return jsonResponse({}, { status: 404 }); + }); + vi.stubGlobal("fetch", fetchFn); + + try { + const result = await pollCheckRuns("acme/widgets", 99, { + apiBaseUrl: API, + maxAttempts: 2, + minIntervalMs: 1, + maxIntervalMs: 1, + }); + expect(result).toMatchObject({ conclusion: "success", attempts: 2 }); + } finally { + vi.unstubAllGlobals(); + } + }); + + it("treats an unrecognized completed conclusion as pending (defensive default for a future GitHub value)", async () => { + const fetchFn = vi + .fn() + .mockResolvedValueOnce(prResponse()) + .mockResolvedValueOnce(checksResponse([checkRun("validate", "completed", "some_future_conclusion")])); + + await expect( + pollCheckRuns("acme/widgets", 20, { apiBaseUrl: API, fetchFn, maxAttempts: 1 }), + ).resolves.toMatchObject({ + conclusion: "pending", + checks: [{ name: "validate", conclusion: "pending" }], + }); + }); + + it("treats a non-object check-run entry as a safely-defaulted pending check instead of crashing", async () => { + const fetchFn = vi + .fn() + .mockResolvedValueOnce(prResponse()) + .mockResolvedValueOnce(jsonResponse({ total_count: 1, check_runs: [null] })); + + await expect( + pollCheckRuns("acme/widgets", 21, { apiBaseUrl: API, fetchFn, maxAttempts: 1 }), + ).resolves.toMatchObject({ + conclusion: "pending", + checks: [ + { + name: "", + status: "unknown", + conclusion: "pending", + detailsUrl: null, + startedAt: null, + completedAt: null, + }, + ], + }); + }); + + it("ignores a missing or invalid total_count and paginates by the link header alone", async () => { + const fetchFn = vi.fn(async (input: RequestInfo | URL) => { + const url = String(input); + if (url.endsWith("/repos/acme/widgets/pulls/22")) return prResponse("link-only-sha"); + if (url.endsWith("/repos/acme/widgets/commits/link-only-sha/check-runs?per_page=100&page=1")) { + return jsonResponse( + { total_count: -1, check_runs: [checkRun("first", "completed", "success")] }, + { + headers: { + link: `<${API}/repos/acme/widgets/commits/link-only-sha/check-runs?per_page=100&page=2>; rel="next"`, + }, + }, + ); + } + if (url.endsWith("/repos/acme/widgets/commits/link-only-sha/check-runs?per_page=100&page=2")) { + return jsonResponse({ check_runs: [checkRun("second", "completed", "success")] }); + } + return jsonResponse({}, { status: 404 }); + }); + + const result = await pollCheckRuns("acme/widgets", 22, { apiBaseUrl: API, fetchFn, maxAttempts: 1 }); + expect(result.checks.map((check) => check.name)).toEqual(["first", "second"]); + }); + + it("surfaces a GitHub error using only the status code when the payload carries no usable message", async () => { + const fetchFn = vi.fn(async () => jsonResponse({}, { status: 401 })); + + await expect( + pollCheckRuns("acme/widgets", 23, { apiBaseUrl: API, fetchFn, maxAttempts: 1 }), + ).rejects.toMatchObject({ code: "github_401", message: "github_401", githubMessage: null }); + }); + + it("throws when a page unexpectedly returns zero check runs despite pagination still being expected", async () => { + const fetchFn = vi.fn(async (input: RequestInfo | URL) => { + const url = String(input); + if (url.endsWith("/repos/acme/widgets/pulls/24")) return prResponse("incomplete-sha"); + if (url.endsWith("/repos/acme/widgets/commits/incomplete-sha/check-runs?per_page=100&page=1")) { + return jsonResponse({ total_count: 5, check_runs: [] }); + } + return jsonResponse({}, { status: 404 }); + }); + + await expect( + pollCheckRuns("acme/widgets", 24, { apiBaseUrl: API, fetchFn, maxAttempts: 1 }), + ).rejects.toThrow("github_check_runs_pagination_incomplete"); + }); + + it("rejects a non-string repoFullName from an untyped caller instead of crashing on .split", async () => { + const fetchFn = vi.fn(); + + await expect( + pollCheckRuns(42 as unknown as string, 1, { apiBaseUrl: API, fetchFn }), + ).rejects.toThrow("invalid_repo_full_name"); + expect(fetchFn).not.toHaveBeenCalled(); + }); }); diff --git a/test/unit/miner-coding-task-spec-path-guard.test.ts b/test/unit/miner-coding-task-spec-path-guard.test.ts new file mode 100644 index 0000000000..8cf10d4542 --- /dev/null +++ b/test/unit/miner-coding-task-spec-path-guard.test.ts @@ -0,0 +1,54 @@ +import { mkdtempSync, realpathSync, rmSync } from "node:fs"; +import { tmpdir } from "node:os"; +import { join } from "node:path"; +import { afterEach, describe, expect, it, vi } from "vitest"; + +// REGRESSION coverage for assertContainedPath's throw arm in coding-task-spec.ts (#5132): under normal +// operation ACCEPTANCE_CRITERIA_FILENAME is a fixed, safe basename ("acceptance-criteria.json"), so +// join(root, ACCEPTANCE_CRITERIA_FILENAME) can never actually escape root -- miner-coding-task-spec.test.ts +// exercises every other branch of this file but can't reach this one through that fixed constant. This file +// mocks @loopover/engine's ACCEPTANCE_CRITERIA_FILENAME export to a path-traversal value to prove the +// defense-in-depth guard actually fires if that upstream constant were ever a non-basename (e.g. a future +// @loopover/engine regression), rather than deleting the check as unreachable dead code. +vi.mock("@loopover/engine", async () => { + const actual = await import("../../packages/loopover-engine/src/index"); + return { ...actual, ACCEPTANCE_CRITERIA_FILENAME: "../escape.json" }; +}); + +import { writeAcceptanceCriteriaFile } from "../../packages/loopover-miner/lib/coding-task-spec.js"; + +const roots: string[] = []; + +afterEach(() => { + for (const root of roots.splice(0)) rmSync(root, { recursive: true, force: true }); +}); + +function tempDir() { + const root = mkdtempSync(join(tmpdir(), "loopover-miner-coding-task-spec-path-guard-")); + roots.push(root); + return realpathSync(root); +} + +function goAcceptanceCriteria() { + return { + version: 1, + verdict: "go" as const, + writable: true, + taskBrief: "brief", + constraints: "", + feasibilityNotes: "", + retrievalContext: "", + feasibilitySummary: "", + avoidReasons: [], + raiseReasons: [], + }; +} + +describe("coding-task-spec assertContainedPath (#5132)", () => { + it("REGRESSION: refuses to write outside the worktree when the acceptance-criteria filename escapes root", () => { + const workingDirectory = tempDir(); + expect(() => writeAcceptanceCriteriaFile(workingDirectory, goAcceptanceCriteria())).toThrow( + /Refusing to write acceptance criteria outside the worktree/, + ); + }); +}); diff --git a/test/unit/miner-self-review-context.test.ts b/test/unit/miner-self-review-context.test.ts index 3ae49eece4..5fe75a8fb0 100644 --- a/test/unit/miner-self-review-context.test.ts +++ b/test/unit/miner-self-review-context.test.ts @@ -126,6 +126,213 @@ describe("fetchSelfReviewContext (#5145)", () => { await expect(fetchSelfReviewContext("not-a-repo")).rejects.toThrow("invalid_repo_full_name"); }); + it("rejects a non-string repoFullName, without calling fetch", async () => { + const fetchImpl = vi.fn(); + await expect(fetchSelfReviewContext(42 as unknown as string, { fetchImpl: fetchImpl as never })).rejects.toThrow("invalid_repo_full_name"); + expect(fetchImpl).not.toHaveBeenCalled(); + }); + + it("falls back to every default option (apiBaseUrl/rawContentBaseUrl/gittensorApiBase/perPage/maxPages/contributorLogin/requestTimeoutMs/liveGateProbeTimeoutMs) when omitted", async () => { + const fetchImpl = routedFetch({ + "/repos/acme/widgets/issues": () => jsonResponse([]), + "/repos/acme/widgets/pulls": () => jsonResponse([]), + "/repos/acme/widgets": () => jsonResponse(REPO_PAYLOAD), + "raw.githubusercontent.com": () => jsonResponse(null, 404), + "api.gittensor.io/miners": () => jsonResponse([]), + }); + + const result = await fetchSelfReviewContext("acme/widgets", { + fetchImpl: fetchImpl as never, + loopoverAuth: null, + }); + expect(result.repo?.fullName).toBe("acme/widgets"); + expect(result.issues).toEqual([]); + expect(result.pullRequests).toEqual([]); + }); + + it("uses a custom apiBaseUrl/rawContentBaseUrl/gittensorApiBase when provided", async () => { + const requests: string[] = []; + const fetchImpl = async (url: string) => { + requests.push(url); + if (url.includes("/repos/acme/widgets/issues")) return jsonResponse([]); + if (url.includes("/repos/acme/widgets/pulls")) return jsonResponse([]); + if (url.includes("/repos/acme/widgets")) return jsonResponse(REPO_PAYLOAD); + if (url.includes("raw.example.internal")) return jsonResponse(null, 404); + if (url.includes("gittensor.example.internal")) return jsonResponse([]); + return jsonResponse(null, 404); + }; + + await fetchSelfReviewContext("acme/widgets", { + fetchImpl: fetchImpl as never, + apiBaseUrl: "https://ghe.example.internal/api/v3", + rawContentBaseUrl: "https://raw.example.internal", + gittensorApiBase: "https://gittensor.example.internal", + contributorLogin: "miner-bot", + loopoverAuth: null, + }); + expect(requests.some((url) => url.startsWith("https://ghe.example.internal/api/v3/"))).toBe(true); + expect(requests.some((url) => url.startsWith("https://raw.example.internal/"))).toBe(true); + expect(requests.some((url) => url.startsWith("https://gittensor.example.internal/"))).toBe(true); + }); + + it("defaults fetchImpl to the real global fetch when omitted", async () => { + const fetchSpy = vi.spyOn(globalThis, "fetch").mockResolvedValue(jsonResponse(null, 404) as unknown as Response); + try { + const result = await fetchSelfReviewContext("acme/widgets", { loopoverAuth: null }); + expect(fetchSpy).toHaveBeenCalled(); + expect(result.repo).toBeNull(); + } finally { + fetchSpy.mockRestore(); + } + }); + + it("treats whitespace-only apiBaseUrl/rawContentBaseUrl/gittensorApiBase as absent and falls back to the default", async () => { + const requests: string[] = []; + const fetchImpl = async (url: string) => { + requests.push(url); + if (url.includes("/repos/acme/widgets/issues")) return jsonResponse([]); + if (url.includes("/repos/acme/widgets/pulls")) return jsonResponse([]); + if (url.includes("/repos/acme/widgets")) return jsonResponse(REPO_PAYLOAD); + if (url.includes("raw.githubusercontent.com")) return jsonResponse(null, 404); + if (url.includes("api.gittensor.io/miners")) return jsonResponse([]); + return jsonResponse(null, 404); + }; + + await fetchSelfReviewContext("acme/widgets", { + fetchImpl: fetchImpl as never, + apiBaseUrl: " ", + rawContentBaseUrl: " ", + gittensorApiBase: " ", + contributorLogin: "miner-bot", + loopoverAuth: null, + }); + expect(requests.some((url) => url.startsWith("https://api.github.com/"))).toBe(true); + expect(requests.some((url) => url.startsWith("https://raw.githubusercontent.com/"))).toBe(true); + expect(requests.some((url) => url.startsWith("https://api.gittensor.io/"))).toBe(true); + }); + + it("resolves the ORB probe apiUrl from the loopover-mcp session when loopoverAuth omits its own apiUrl", async () => { + const requests: string[] = []; + const fetchImpl = async (url: string) => { + requests.push(url); + if (url.includes("/live-gate-thresholds")) return jsonResponse({ confidence_floor: 0.9, scope_cap_files: null, scope_cap_lines: null }); + if (url.includes("/repos/acme/widgets/issues")) return jsonResponse([]); + if (url.includes("/repos/acme/widgets/pulls")) return jsonResponse([]); + if (url.includes("/repos/acme/widgets")) return jsonResponse(REPO_PAYLOAD); + if (url.includes("raw.githubusercontent.com")) return jsonResponse(null, 404); + if (url.includes("api.gittensor.io/miners")) return jsonResponse([]); + return jsonResponse(null, 404); + }; + + // No env session on disk here, so resolveLoopoverBackendSession(env) returns null -- exercising the + // hardcoded "https://api.loopover.ai" fallback alongside options.loopoverAuth.apiUrl being omitted. + await fetchSelfReviewContext("acme/widgets", { + fetchImpl: fetchImpl as never, + loopoverAuth: { sessionToken: "mcp-test-token" }, + env: { LOOPOVER_CONFIG_DIR: "/nonexistent-loopover-config-dir" }, + }); + expect(requests.some((url) => url.startsWith("https://api.loopover.ai/v1/repos/acme/widgets/live-gate-thresholds"))).toBe(true); + }); + + it("stops paginating when maxPages is not a positive integer (falls back to the default page cap)", async () => { + let pageCount = 0; + const fetchImpl = async (url: string) => { + if (url.includes("/repos/acme/widgets/issues")) { + pageCount += 1; + return jsonResponse([issuePayload({ number: pageCount })]); + } + if (url.includes("/repos/acme/widgets/pulls")) return jsonResponse([]); + if (url.includes("/repos/acme/widgets")) return jsonResponse(REPO_PAYLOAD); + if (url.includes("raw.githubusercontent.com")) return jsonResponse(null, 404); + if (url.includes("api.gittensor.io/miners")) return jsonResponse([]); + return jsonResponse(null, 404); + }; + + const result = await fetchSelfReviewContext("acme/widgets", { + fetchImpl: fetchImpl as never, + maxPages: 0, + perPage: 1, + loopoverAuth: null, + }); + // Each 1-issue page exactly fills perPage:1, so it's never a "short" page -- pagination keeps going until + // the invalid maxPages:0 falls back to the real default (10), proven by getting exactly 10 issues back + // rather than looping forever or stopping at 0. + expect(result.issues).toHaveLength(10); + }); + + it("minimal repo payload: falls back to the target owner/repo, false, and null for every optional GitHub field", async () => { + const fetchImpl = routedFetch({ + "/repos/acme/widgets/issues": () => jsonResponse([]), + "/repos/acme/widgets/pulls": () => jsonResponse([]), + "/repos/acme/widgets": () => jsonResponse({}), + "raw.githubusercontent.com": () => jsonResponse(null, 404), + "api.gittensor.io/miners": () => jsonResponse([]), + }); + + const result = await fetchSelfReviewContext("acme/widgets", { fetchImpl: fetchImpl as never, loopoverAuth: null }); + expect(result.repo).toEqual({ + fullName: "acme/widgets", + owner: "acme", + name: "widgets", + installationId: undefined, + isInstalled: false, + isRegistered: false, + isPrivate: false, + htmlUrl: null, + defaultBranch: null, + registryConfig: null, + }); + }); + + it("minimal issue/PR payloads: falls back to '', null, and [] for every optional field, without a labels array", async () => { + const fetchImpl = routedFetch({ + "/repos/acme/widgets/issues": () => jsonResponse([{ number: 7, title: "Bare issue", state: "open" }]), + "/repos/acme/widgets/pulls": () => jsonResponse([{ number: 42, title: "Bare PR", state: "open" }]), + "/repos/acme/widgets": () => jsonResponse(REPO_PAYLOAD), + "raw.githubusercontent.com": () => jsonResponse(null, 404), + "api.gittensor.io/miners": () => jsonResponse([]), + }); + + const result = await fetchSelfReviewContext("acme/widgets", { fetchImpl: fetchImpl as never, loopoverAuth: null }); + expect(result.issues[0]).toEqual({ + repoFullName: "acme/widgets", + number: 7, + title: "Bare issue", + state: "open", + authorLogin: null, + authorAssociation: null, + htmlUrl: null, + body: "", + createdAt: null, + updatedAt: null, + closedAt: null, + labels: [], + linkedPrs: [], + }); + expect(result.pullRequests[0]).toEqual({ + repoFullName: "acme/widgets", + number: 42, + title: "Bare PR", + state: "open", + authorLogin: null, + authorAssociation: null, + headSha: null, + headRef: null, + baseRef: null, + htmlUrl: null, + mergedAt: null, + isDraft: null, + mergeableState: null, + reviewDecision: null, + body: "", + createdAt: null, + updatedAt: null, + closedAt: null, + labels: [], + linkedIssues: [], + }); + }); + it("builds a full context from live GitHub data: repo, issues, pull requests, manifest, contributor, duplicate cluster", async () => { // The PR title is deliberately unrelated to the issue title -- buildCollisionReport's pairwise term- // overlap clustering would otherwise ALSO cluster this pair (e.g. two titles both mentioning "retry"/ @@ -647,6 +854,16 @@ describe("live gate thresholds probe (#6487)", () => { scope_cap_lines: null, }); expect(notLoosened.gate.readinessMinScore).toBe(70); + + // No fields/manifest at all: applyLiveGateThresholdsToManifest returns the input manifest unchanged. + expect(applyLiveGateThresholdsToManifest(base, null)).toBe(base); + expect(applyLiveGateThresholdsToManifest(null as never, { confidence_floor: 0.9, scope_cap_files: null, scope_cap_lines: null })).toBeNull(); + + // No readiness gate configured at all (readinessMinScore is null, not a number): the confidence_floor + // overlay has nothing to compare against, so it leaves readinessMinScore untouched (still null). + const noReadinessGate = parseFocusManifestContent(null, "repo_file"); + const stillNull = applyLiveGateThresholdsToManifest(noReadinessGate, { confidence_floor: 0.9, scope_cap_files: null, scope_cap_lines: null }); + expect(stillNull.gate.readinessMinScore).toBeNull(); }); it("uses live ORB thresholds when the probe returns 200", async () => { diff --git a/test/unit/miner-stack-detection.test.ts b/test/unit/miner-stack-detection.test.ts index dd4d005eaa..38a86d8281 100644 --- a/test/unit/miner-stack-detection.test.ts +++ b/test/unit/miner-stack-detection.test.ts @@ -132,6 +132,10 @@ describe("detectRepoStack — Node (#4785)", () => { expect(detect({ "package.json": null })).toMatchObject({ detected: true, language: "javascript" }); }); + it("degrades safely on a package.json that is valid JSON but not an object (e.g. a bare null)", () => { + expect(detect({ "package.json": "null" })).toMatchObject({ detected: true, language: "javascript", buildCommand: null }); + }); + it("treats a non-string readFileSync result as no content", () => { const result = detectRepoStack(ROOT, { existsSync: (path: string) => path === join(ROOT, "package.json"),