From dee063ab90b5f00560ca48cb8b76aec2dbdbadb5 Mon Sep 17 00:00:00 2001 From: Ola Adebayo Date: Fri, 11 Sep 2026 16:16:02 +0100 Subject: [PATCH] fix(ci): run main-branch jobs that depend on the PR-only filter job MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Every push to main has been skipped since eb542e7. The `changes` job is gated `if: github.event_name == 'pull_request'`, so it is skipped on a push; the `ci` / `build-and-deploy` jobs that declare `needs: changes` were then skipped too, even though their own `if` evaluates true on a push. An `if` with no status-check function carries an implicit `success()` requirement on `needs`, and a skipped dependency does not satisfy it. Wrapping each condition in `!cancelled()` lets the job evaluate its own `if` instead. `!cancelled()` rather than `always()` so a genuine failure of `changes` still stops the job: `should_run` is then empty and the remaining clauses are false on pull_request events. Consequences of the bug: no docs deploy, no Go tests and no SDK tests have run on main for roughly six months. rep-protocol.dev is serving content from before #56, and `workflow_dispatch` could not be used to recover because it was skipped for the same reason. Also fixes the gateway download URLs in the installation guide, which returned 404 — GoReleaser publishes archives on the bare version tag (`v0.1.7`), not the `gateway/v0.1.7` tag release, and the documented version was 0.1.2. Adds a snippet that resolves the current release rather than pinning a version that goes stale. --- .github/workflows/docs.yml | 8 +++++--- .github/workflows/gateway.yml | 6 ++++-- .github/workflows/sdk.yml | 6 ++++-- docs/src/content/docs/guides/installation.mdx | 16 ++++++++++++++-- 4 files changed, 27 insertions(+), 9 deletions(-) diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml index 925870e..8369b4c 100644 --- a/.github/workflows/docs.yml +++ b/.github/workflows/docs.yml @@ -43,9 +43,11 @@ jobs: name: Build and Deploy Docs needs: changes if: | - github.event_name == 'push' || - github.event_name == 'workflow_dispatch' || - needs.changes.outputs.should_run == 'true' + !cancelled() && ( + github.event_name == 'push' || + github.event_name == 'workflow_dispatch' || + needs.changes.outputs.should_run == 'true' + ) runs-on: ubuntu-latest steps: diff --git a/.github/workflows/gateway.yml b/.github/workflows/gateway.yml index fc1c5e8..0c92c6d 100644 --- a/.github/workflows/gateway.yml +++ b/.github/workflows/gateway.yml @@ -30,8 +30,10 @@ jobs: name: Vet · Test · Build needs: changes if: | - github.event_name == 'push' || - needs.changes.outputs.should_run == 'true' + !cancelled() && ( + github.event_name == 'push' || + needs.changes.outputs.should_run == 'true' + ) runs-on: ubuntu-latest defaults: run: diff --git a/.github/workflows/sdk.yml b/.github/workflows/sdk.yml index 9f17ecd..465363b 100644 --- a/.github/workflows/sdk.yml +++ b/.github/workflows/sdk.yml @@ -40,8 +40,10 @@ jobs: name: Install · Build · Test needs: changes if: | - github.event_name == 'push' || - needs.changes.outputs.should_run == 'true' + !cancelled() && ( + github.event_name == 'push' || + needs.changes.outputs.should_run == 'true' + ) runs-on: ubuntu-latest steps: diff --git a/docs/src/content/docs/guides/installation.mdx b/docs/src/content/docs/guides/installation.mdx index 0aa2200..8ee1f44 100644 --- a/docs/src/content/docs/guides/installation.mdx +++ b/docs/src/content/docs/guides/installation.mdx @@ -129,16 +129,28 @@ COPY --from=ghcr.io/ruachtech/rep/gateway:latest /usr/local/bin/rep-gateway /usr Download from [GitHub Releases](https://github.com/ruachtech/rep/releases) for your platform: +Archives are published on the version tag — `v0.1.7`, not `gateway/v0.1.7`: + ```bash # Linux amd64 -curl -fsSL https://github.com/RuachTech/rep/releases/download/gateway/v0.1.2/rep-gateway_0.1.2_linux_amd64.tar.gz | tar -xz +curl -fsSL https://github.com/RuachTech/rep/releases/download/v0.1.7/rep-gateway_0.1.7_linux_amd64.tar.gz | tar -xz mv rep-gateway /usr/local/bin/ # macOS arm64 -curl -fsSL https://github.com/RuachTech/rep/releases/download/gateway/v0.1.2/rep-gateway_0.1.2_darwin_arm64.tar.gz | tar -xz +curl -fsSL https://github.com/RuachTech/rep/releases/download/v0.1.7/rep-gateway_0.1.7_darwin_arm64.tar.gz | tar -xz mv rep-gateway /usr/local/bin/ ``` +To always fetch the newest release instead of a pinned version: + +```bash +VERSION=$(curl -fsSL https://api.github.com/repos/RuachTech/rep/releases/latest | grep -m1 '"tag_name"' | cut -d'"' -f4) +curl -fsSL "https://github.com/RuachTech/rep/releases/download/${VERSION}/rep-gateway_${VERSION#v}_linux_amd64.tar.gz" | tar -xz +mv rep-gateway /usr/local/bin/ +``` + +Each release also ships a `checksums.txt` for verification. + ### Build from source Requires Go >= 1.24.5: