From 5c4cd9c65fa7311de2f29bc3b9e4683dbb868f08 Mon Sep 17 00:00:00 2001 From: Corbin Crutchley Date: Sat, 24 Feb 2024 23:45:05 -0800 Subject: [PATCH 1/2] chore!: remove subfield --- packages/form-core/src/FieldApi.ts | 17 ---------------- packages/form-core/src/tests/FieldApi.spec.ts | 20 ------------------- 2 files changed, 37 deletions(-) diff --git a/packages/form-core/src/FieldApi.ts b/packages/form-core/src/FieldApi.ts index 4b92d62a7..2035b8ca9 100644 --- a/packages/form-core/src/FieldApi.ts +++ b/packages/form-core/src/FieldApi.ts @@ -484,23 +484,6 @@ export class FieldApi< swapValues = (aIndex: number, bIndex: number) => this.form.swapFieldValues(this.name, aIndex, bIndex) - getSubField = < - TSubName extends DeepKeys, - TSubData extends DeepValue = DeepValue, - >( - name: TSubName, - ): FieldApi< - TData, - TSubName, - Validator | undefined, - Validator | undefined, - TSubData - > => - new FieldApi({ - name: `${this.name}.${name}` as never, - form: this.form, - }) as any - validateSync = (value = this.state.value, cause: ValidationCause) => { const validates = getSyncValidatorArray(cause, this.options) diff --git a/packages/form-core/src/tests/FieldApi.spec.ts b/packages/form-core/src/tests/FieldApi.spec.ts index 2e1106de8..a0b31a260 100644 --- a/packages/form-core/src/tests/FieldApi.spec.ts +++ b/packages/form-core/src/tests/FieldApi.spec.ts @@ -154,26 +154,6 @@ describe('field api', () => { expect(field.getValue()).toStrictEqual(['two', 'one']) }) - it('should get a subfield properly', () => { - const form = new FormApi({ - defaultValues: { - names: { - first: 'one', - second: 'two', - }, - }, - }) - - const field = new FieldApi({ - form, - name: 'names', - }) - - const subfield = field.getSubField('first') - - expect(subfield.getValue()).toBe('one') - }) - it('should not throw errors when no meta info is stored on a field and a form re-renders', async () => { const form = new FormApi({ defaultValues: { From b167a4ca9ae2e8dfb79c20f1813936b561093681 Mon Sep 17 00:00:00 2001 From: Corbin Crutchley Date: Sat, 24 Feb 2024 23:47:27 -0800 Subject: [PATCH 2/2] docs: remove old API from docs --- docs/reference/fieldApi.md | 6 ------ 1 file changed, 6 deletions(-) diff --git a/docs/reference/fieldApi.md b/docs/reference/fieldApi.md index 50623ce06..3f337c5ea 100644 --- a/docs/reference/fieldApi.md +++ b/docs/reference/fieldApi.md @@ -263,12 +263,6 @@ A class representing the API for managing a form field. - Swaps the values at the specified indices. -- ```tsx - getSubField(name: TName): FieldApi - ``` - - - Gets a subfield instance. - - ```tsx validate(): Promise ```