From 433a915fa2c6ac3fc173011edd397162b950e8cc Mon Sep 17 00:00:00 2001
From: Heran Yang <heran55@126.com>
Date: Fri, 8 Nov 2024 09:52:11 +0800
Subject: [PATCH] Fix heap buffer overflow when running simulation

---
 astra-sim-alibabacloud/astra-sim/system/MockNcclGroup.cc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/astra-sim-alibabacloud/astra-sim/system/MockNcclGroup.cc b/astra-sim-alibabacloud/astra-sim/system/MockNcclGroup.cc
index 52cfc03cd..484b6f11d 100644
--- a/astra-sim-alibabacloud/astra-sim/system/MockNcclGroup.cc
+++ b/astra-sim-alibabacloud/astra-sim/system/MockNcclGroup.cc
@@ -2022,7 +2022,7 @@ namespace MockNccl {
         q.push(current->right);
       }
     }
-    return node2treenode[(nodes[rank2index[root->node]+1]) % nodes.size()];
+    return node2treenode[nodes[(rank2index[root->node]+1) % nodes.size()]];
   }
 
   ncclInfo* MockNcclGroup::get_algo_proto_info(
@@ -2100,4 +2100,4 @@ namespace MockNccl {
     return info;
     }
   }
-}
\ No newline at end of file
+}