From 181eb5eead53a2a65633f532a6c538dead72e742 Mon Sep 17 00:00:00 2001 From: Anupam Yadav Date: Mon, 6 Jul 2026 05:47:00 +0000 Subject: [PATCH 1/2] Enable clang-tidy misc-include-cleaner for include hygiene (#73) --- .clang-tidy | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.clang-tidy b/.clang-tidy index e7e8abd33..0f6d21462 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -21,6 +21,7 @@ Checks: | clang-analyzer-*, google-*, modernize-*, + misc-include-cleaner, readability-identifier-naming, readability-isolate-declaration, -modernize-use-nodiscard, @@ -41,5 +42,7 @@ CheckOptions: value: '_' - key: modernize-use-scoped-lock.WarnOnSingleLocks value: 'false' + - key: misc-include-cleaner.IgnoreHeaders + value: 'arrow/.*;nanoarrow/.*;nlohmann/.*;spdlog/.*;roaring/.*;cpr/.*' HeaderFilterRegex: 'src/iceberg|example' From dfed960609cd71728e8de40dc2ef65c65ceceef0 Mon Sep 17 00:00:00 2001 From: Anupam Yadav Date: Sat, 11 Jul 2026 11:22:24 -0700 Subject: [PATCH 2/2] Apply suggestion from @wgtmac Co-authored-by: Gang Wu --- .clang-tidy | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.clang-tidy b/.clang-tidy index 0f6d21462..5b13a0551 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -43,6 +43,6 @@ CheckOptions: - key: modernize-use-scoped-lock.WarnOnSingleLocks value: 'false' - key: misc-include-cleaner.IgnoreHeaders - value: 'arrow/.*;nanoarrow/.*;nlohmann/.*;spdlog/.*;roaring/.*;cpr/.*' + value: 'arrow/.*;avro/.*;aws/.*;cpr/.*;gmock/.*;gtest/.*;nanoarrow/.*;nlohmann/.*;parquet/.*;roaring/.*;spdlog/.*;sqlpp23/.*;sqlite3\.h;thrift/.*;utf8proc\.h;zlib\.h' HeaderFilterRegex: 'src/iceberg|example'