From 07b67e347538816c0c4ddc6d459800927c03553b Mon Sep 17 00:00:00 2001 From: Luis Vega Date: Sat, 20 Feb 2021 17:52:24 +0000 Subject: [PATCH 1/3] remove destructor --- src/runtime/contrib/verilator/verilator_runtime.cc | 1 - 1 file changed, 1 deletion(-) diff --git a/src/runtime/contrib/verilator/verilator_runtime.cc b/src/runtime/contrib/verilator/verilator_runtime.cc index bc96b69f2ffe..3e4229e68aba 100644 --- a/src/runtime/contrib/verilator/verilator_runtime.cc +++ b/src/runtime/contrib/verilator/verilator_runtime.cc @@ -80,7 +80,6 @@ VerilatorRuntime::~VerilatorRuntime() { auto dealloc = reinterpret_cast(lib_->GetSymbol("VerilatorDealloc")); ICHECK(dealloc != nullptr); dealloc(device_); - lib_->~VerilatorLibrary(); } void VerilatorRuntime::SetLibrary(const std::string& lib_path) { lib_path_ = lib_path; } From 5cfb5fecd324863b33f1e5a5b96288c18e7b77b2 Mon Sep 17 00:00:00 2001 From: Luis Vega Date: Mon, 22 Feb 2021 16:40:19 +0000 Subject: [PATCH 2/3] add delete --- src/runtime/contrib/verilator/verilator_runtime.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/src/runtime/contrib/verilator/verilator_runtime.cc b/src/runtime/contrib/verilator/verilator_runtime.cc index 3e4229e68aba..876aff23086d 100644 --- a/src/runtime/contrib/verilator/verilator_runtime.cc +++ b/src/runtime/contrib/verilator/verilator_runtime.cc @@ -80,6 +80,7 @@ VerilatorRuntime::~VerilatorRuntime() { auto dealloc = reinterpret_cast(lib_->GetSymbol("VerilatorDealloc")); ICHECK(dealloc != nullptr); dealloc(device_); + delete lib_; } void VerilatorRuntime::SetLibrary(const std::string& lib_path) { lib_path_ = lib_path; } From 32b3aa846f64c87eff1c9ac962775e12d4d36ac0 Mon Sep 17 00:00:00 2001 From: Luis Vega Date: Mon, 8 Mar 2021 21:37:24 +0000 Subject: [PATCH 3/3] update comment --- src/runtime/contrib/verilator/verilator_runtime.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/runtime/contrib/verilator/verilator_runtime.cc b/src/runtime/contrib/verilator/verilator_runtime.cc index 876aff23086d..5dfb8441c864 100644 --- a/src/runtime/contrib/verilator/verilator_runtime.cc +++ b/src/runtime/contrib/verilator/verilator_runtime.cc @@ -108,7 +108,7 @@ void VerilatorRuntime::Init(const Array& consts) { // enable profiler if (prof_enable_) prof_ = VerilatorProfiler::ThreadLocal(); - // reset verilator device + // reset verilator device. reset(device_, reset_cycles_); CHECK_EQ(consts.size(), const_idx_.size())