Light mode: surface definition + drop washed-out hero glow#11
Merged
Conversation
The light page read flat/washed because white cards sat on a near-white bg with only a ~10% hairline and no rest shadow — measured-AA text, but no structural contrast. Without darkening the bg (which would drop the accent labels below AA), add definition: - tokens.css light: --border 0.10 -> 0.16, --border-2 0.17 -> 0.24, --card-soft -> #F0E6EC (stronger dividers/edges; also lifts docs chrome). - Landing.vue light: give project + principle cards a soft rest shadow so they separate from the background. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR refines the light-mode surface contrast for the shared theme and the website landing page so cards/dividers read less “washed out” while keeping text contrast unchanged.
Changes:
- Adjusts light-mode surface tokens (
--card-soft,--border,--border-2) to strengthen dividers and section separation. - Adds a light-mode rest shadow to landing-page project/principle cards to visually lift them off the near-white background.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/theme/src/tokens.css | Strengthens light-mode surface/divider tokens to improve structural contrast. |
| apps/website/.vitepress/theme/Landing.vue | Adds light-mode card rest shadow for better visual separation (but needs a hover-specificity fix). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+253
to
+258
| /* On near-white, the hairline alone leaves cards looking flat — give them a | ||
| soft rest shadow in light mode so they lift off the background. */ | ||
| :global(html:not(.dark)) .btv-pcard, | ||
| :global(html:not(.dark)) .btv-prin-card { | ||
| box-shadow: 0 1px 2px rgba(26, 12, 20, 0.05), 0 16px 32px -24px rgba(26, 12, 20, 0.22); | ||
| } |
The light rest-shadow selector outspecifies .pcard:hover, so the hover box-shadow stopped applying on project cards. Add a matching-specificity light hover override that restores var(--shadow-card). [Copilot] Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This was referenced Jun 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the light-mode review. The text-token fix (#10) made everything AA, but the page still read washed out — because the surfaces had no contrast: white cards on a near-white bg with a ~10% hairline and no rest shadow looked flat.
Fixed the structural contrast (not the text), keeping the bg light so the accent labels stay AA:
tokens.csslight:--border0.10 → 0.16,--border-20.17 → 0.24,--card-soft→#F0E6EC(stronger edges/dividers — also sharpens the docs chrome).Landing.vuelight: project + principle cards get a soft rest shadow so they lift off the background.Now the cards and sections clearly separate. Verified on the build (screenshots): cards have visible edges + lift; text contrast unchanged (still AA); no overflow/errors.