Skip to content

docs: document Conventional Commit PR-title requirement for release-please - #133

Merged
chrischall merged 1 commit into
mainfrom
docs/release-please-pr-conventions
Jun 14, 2026
Merged

chrischall merged 1 commit into
mainfrom
docs/release-please-pr-conventions

Conversation

@chrischall

Copy link
Copy Markdown
Owner

Fleet-wide release-please alignment. Squash-merge + release-please means the PR title is the only thing release-please parses; CLAUDE.md had no PR-title guidance. Docs-only.

🤖 Generated with Claude Code

…lease

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@github-actions github-actions Bot added the auto-review Auto-review pipeline is handling this PR label Jun 14, 2026
@claude

claude Bot commented Jun 14, 2026 •

Copy link
Copy Markdown

Claude finished @chrischall's task in 46s —— View job


PR Review: docs: document Conventional Commit PR-title requirement for release-please

  • Gather context
  • Review documentation accuracy
  • Verify against project configuration

Reviewing the added documentation section:

The PR adds a "Pull requests & releases" section documenting:

  1. Squash-merge + PR title as release source ✓ Accurate
  2. Conventional Commit requirement ✓ Accurate
  3. Type → action mapping (feat=minor, fix=patch, !=major) ✓ Accurate per release-please-config.json
  4. Changelog sections (perf/refactor/docs visible, ci/test/build/chore hidden) ✓ Matches lines 19-30 of release-please-config.json exactly
  5. Auto-merge workflow ✓ Matches pr-auto-review.yml + auto-merge.yml behavior

Verification against actual project state:

  • ✓ Squash-merge is the only allowed strategy (per the statement "squash-merges")
  • ✓ Recent commits follow the format (e.g., chore(deps-dev): bump esbuild…)
  • ✓ release-please-config.json confirms changelog-sections and hidden flag mappings
  • ✓ pr-auto-review.yml runs on PR events and adds ready-to-merge label on pass
  • ✓ auto-merge.yml uses gh pr merge --auto --squash (confirmed via reusable workflow stub)
  • ✓ Documentation accurately reflects the "don't run gh pr merge yourself" constraint

Quality observations:

  • Clear, well-structured explanation of the workflow
  • Properly formatted with Conventional Commit examples
  • Explains both what to do (branch + PR, conventional title) and what not to do (manual gh pr merge)
  • Practical guidance on which commit types trigger releases vs changelog-only

No issues found. The documentation is accurate, complete, and well-integrated into CLAUDE.md.

Verdict: pass


@github-actions

Copy link
Copy Markdown
Contributor

✅ Auto-review verdict: pass — Documentation accurately reflects the project's Conventional Commit PR-title requirement and auto-merge workflow. All claims verified against release-please-config.json, workflow files, and existing commit history.

@chrischall chrischall added the ready-to-merge Arms auto-merge — added by the pipeline on a pass/warn verdict, never by hand label Jun 14, 2026
@chrischall
chrischall enabled auto-merge (squash) June 14, 2026 02:51
@chrischall
chrischall merged commit fb4edff into main Jun 14, 2026
8 checks passed
@chrischall
chrischall deleted the docs/release-please-pr-conventions branch June 14, 2026 02:52
chrischall added a commit that referenced this pull request Jun 15, 2026
🤖 I have created a release *beep* *boop*
---


##
[1.3.4](v1.3.3...v1.3.4)
(2026-06-15)


### Documentation

* document Conventional Commit PR-title requirement for release-please
([#133](#133))
([fb4edff](fb4edff))
* refresh CLAUDE.md to current release-please + workflows pipeline
([#135](#135))
([5949757](5949757))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-review Auto-review pipeline is handling this PR ready-to-merge Arms auto-merge — added by the pipeline on a pass/warn verdict, never by hand

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant