From f79f04b728aa95d8e44079d908192a72fd002b1a Mon Sep 17 00:00:00 2001 From: Vaggelis Yfantis Date: Mon, 13 Nov 2023 22:30:54 +0200 Subject: [PATCH 1/4] fix(repo): Fix Sign Out integration test --- integration/tests/sign-out-smoke.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/integration/tests/sign-out-smoke.test.ts b/integration/tests/sign-out-smoke.test.ts index a6fa5a17964..6b31b9ce339 100644 --- a/integration/tests/sign-out-smoke.test.ts +++ b/integration/tests/sign-out-smoke.test.ts @@ -43,6 +43,6 @@ testAgainstRunningApps({ withEnv: [appConfigs.envs.withEmailCodes] })('sign out await m.po.expect.toBeSignedOut(); }); - expect(await mainTab.page.evaluate('!window.Clerk.user')).toBe(false); + expect(await mainTab.page.evaluate('!window.Clerk.user')).toBe(true); }); }); From fe1e38dd65950c1443888126199150465e1f500c Mon Sep 17 00:00:00 2001 From: Vaggelis Yfantis Date: Mon, 13 Nov 2023 22:38:34 +0200 Subject: [PATCH 2/4] fix(repo): Fix Sign Out integration test --- integration/tests/sign-out-smoke.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/integration/tests/sign-out-smoke.test.ts b/integration/tests/sign-out-smoke.test.ts index 6b31b9ce339..d0afda1ffc1 100644 --- a/integration/tests/sign-out-smoke.test.ts +++ b/integration/tests/sign-out-smoke.test.ts @@ -43,6 +43,6 @@ testAgainstRunningApps({ withEnv: [appConfigs.envs.withEmailCodes] })('sign out await m.po.expect.toBeSignedOut(); }); - expect(await mainTab.page.evaluate('!window.Clerk.user')).toBe(true); + await mainTab.po.expect.toBeSignedOut(); }); }); From 23fe98bd1842d22593a314a33937d2d9517b84c1 Mon Sep 17 00:00:00 2001 From: Vaggelis Yfantis Date: Mon, 13 Nov 2023 22:49:03 +0200 Subject: [PATCH 3/4] fix(repo): Remove unused import from integration test --- integration/tests/sign-out-smoke.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/integration/tests/sign-out-smoke.test.ts b/integration/tests/sign-out-smoke.test.ts index d0afda1ffc1..3047b40e068 100644 --- a/integration/tests/sign-out-smoke.test.ts +++ b/integration/tests/sign-out-smoke.test.ts @@ -1,4 +1,4 @@ -import { expect, test } from '@playwright/test'; +import { test } from '@playwright/test'; import { appConfigs } from '../presets'; import type { FakeUser } from '../testUtils'; From cfd68e454c82959d47399412316b4d962ab91c92 Mon Sep 17 00:00:00 2001 From: Vaggelis Yfantis Date: Mon, 13 Nov 2023 22:50:46 +0200 Subject: [PATCH 4/4] fix(repo): Adds changeset --- .changeset/rude-lamps-yawn.md | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 .changeset/rude-lamps-yawn.md diff --git a/.changeset/rude-lamps-yawn.md b/.changeset/rude-lamps-yawn.md new file mode 100644 index 00000000000..a845151cc84 --- /dev/null +++ b/.changeset/rude-lamps-yawn.md @@ -0,0 +1,2 @@ +--- +---