From e5571d44724abe5bed5ffa8ec89d0ac47fd4547d Mon Sep 17 00:00:00 2001 From: panteliselef Date: Tue, 19 Dec 2023 14:33:40 +0200 Subject: [PATCH] fix(clerk-js): Clear feedback when `undefined` is passed to `setError` We still have a lot of places in clerk-js where we call `setError(undefined)` instead of `clearFeedback` --- .changeset/thick-doors-smile.md | 5 +++++ packages/clerk-js/src/ui/utils/useFormControl.ts | 2 ++ 2 files changed, 7 insertions(+) create mode 100644 .changeset/thick-doors-smile.md diff --git a/.changeset/thick-doors-smile.md b/.changeset/thick-doors-smile.md new file mode 100644 index 00000000000..df5423549e4 --- /dev/null +++ b/.changeset/thick-doors-smile.md @@ -0,0 +1,5 @@ +--- +'@clerk/clerk-js': patch +--- + +Bug fix: Clear feedback of input field if `setError` is called with undefined. diff --git a/packages/clerk-js/src/ui/utils/useFormControl.ts b/packages/clerk-js/src/ui/utils/useFormControl.ts index 52f8200e9eb..e89ff65facc 100644 --- a/packages/clerk-js/src/ui/utils/useFormControl.ts +++ b/packages/clerk-js/src/ui/utils/useFormControl.ts @@ -110,6 +110,8 @@ export const useFormControl = ( const setError: FormControlState['setError'] = error => { if (error) { setFeedback({ message: translateError(error), type: 'error' }); + } else { + clearFeedback(); } }; const setSuccess: FormControlState['setSuccess'] = message => {