feat(clerk-js): Improve password error feedback animations#1776
Merged
desiprisg merged 3 commits intoOct 24, 2023
Merged
Conversation
🦋 Changeset detectedLatest commit: 26ef242 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
desiprisg
force-pushed
the
george/usr-195-revisit-animations-and-debouncing-behavior-for-password
branch
3 times, most recently
from
September 27, 2023 16:23
1fd9157 to
b6c7cbd
Compare
Member
|
@desiprisg can you please add a description and a couple of screenshots if needed? |
desiprisg
force-pushed
the
george/usr-195-revisit-animations-and-debouncing-behavior-for-password
branch
from
September 28, 2023 16:29
3d5378e to
16386f3
Compare
desiprisg
marked this pull request as ready for review
September 28, 2023 16:32
LekoArts
reviewed
Sep 29, 2023
desiprisg
force-pushed
the
george/usr-195-revisit-animations-and-debouncing-behavior-for-password
branch
3 times, most recently
from
October 3, 2023 16:39
a053296 to
8d9d71a
Compare
brkalow
reviewed
Oct 17, 2023
brkalow
left a comment
Member
There was a problem hiding this comment.
Looks good! Nothing blocking, just some questions and observations.
desiprisg
force-pushed
the
george/usr-195-revisit-animations-and-debouncing-behavior-for-password
branch
from
October 17, 2023 23:12
55cf3b0 to
b629fd3
Compare
panteliselef
self-requested a review
October 19, 2023 23:40
desiprisg
force-pushed
the
george/usr-195-revisit-animations-and-debouncing-behavior-for-password
branch
from
October 23, 2023 19:35
acef2d5 to
1ae3414
Compare
desiprisg
deleted the
george/usr-195-revisit-animations-and-debouncing-behavior-for-password
branch
October 23, 2023 22:49
desiprisg
restored the
george/usr-195-revisit-animations-and-debouncing-behavior-for-password
branch
October 23, 2023 22:55
panteliselef
self-requested a review
October 24, 2023 14:52
panteliselef
approved these changes
Oct 24, 2023
feat(clerk-js): Add PasswordInput validation debouncing refactor(clerk-js): Remove unused props fix(clerk-js): Add infoText for VerifyDomainPage fix(clerk-js): Smooth error animation and min height
test(clerk-js): Fix tests for password validation chore(clerk-js): Changeset chore(clerk-js): Improve changeset fix(clerk-js): Address PR comments refactor(clerk-js): Avoid useEffect usage for feedbacks and maxHeight fix(clerk-js): Add clearFeedback to types fix(clerk-js): Delay feedback after focus/blur on input elements
chore(clerk-js): Replace NodeJS.Timeout type refactor(clerk-js): Extract inAnimation ternary into variable refactor(clerk-js): Handle the undefined case in getElementProps
desiprisg
force-pushed
the
george/usr-195-revisit-animations-and-debouncing-behavior-for-password
branch
from
October 24, 2023 19:03
d14134d to
26ef242
Compare
desiprisg
added this pull request to the merge queue
Oct 24, 2023
desiprisg
deleted the
george/usr-195-revisit-animations-and-debouncing-behavior-for-password
branch
October 24, 2023 19:35
Collaborator
|
This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to refactor the form error animations and some internal methods. It also adds debouncing to the password validation, along with some small changes to the types of feedback shown based on the different conditions.
Screen.Recording.2023-09-28.at.19.30.00.mov
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/clerk-sdk-node@clerk/shared@clerk/fastify@clerk/chrome-extensiongatsby-plugin-clerkbuild/tooling/chore