feat(remix): Refactor getEnvVariable#1862
Merged
octoper merged 4 commits intoOct 14, 2023
Merged
Conversation
🦋 Changeset detectedLatest commit: 4717fef The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
octoper
force-pushed
the
vaggelis/js-786-remix-clerk-cloudflare-pages-secret-key-error
branch
from
October 12, 2023 10:00
044e205 to
9a11034
Compare
octoper
force-pushed
the
vaggelis/js-786-remix-clerk-cloudflare-pages-secret-key-error
branch
from
October 12, 2023 19:44
9a11034 to
c8d1c4d
Compare
octoper
marked this pull request as ready for review
October 12, 2023 19:58
getEnvVariable to support Cloudflare PagesgetEnvVariable
LekoArts
approved these changes
Oct 13, 2023
octoper
added this pull request to the merge queue
Oct 14, 2023
octoper
deleted the
vaggelis/js-786-remix-clerk-cloudflare-pages-secret-key-error
branch
October 14, 2023 16:50
Merged
Collaborator
|
This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors
getEnvVariablefunction to support Cloudflare Pages environment variables, until now we were trying to get the environment variables from the top level of the Remixcontextinstead of thecontext.envthat is mentioned in the Remix docs .Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/clerk-sdk-node@clerk/shared@clerk/fastify@clerk/chrome-extensiongatsby-plugin-clerkbuild/tooling/chore