fix(clerk-sdk-node): Fix types of ClerkExpressWithAuth/ClerkExpressRequireAuth args#1939
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 1238c22 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dimkl
force-pushed
the
fix-clerk-express-require-auth
branch
from
October 25, 2023 19:11
104818f to
1238c22
Compare
octoper
approved these changes
Oct 25, 2023
anagstef
suggested changes
Oct 25, 2023
dimkl
force-pushed
the
fix-clerk-express-require-auth
branch
from
October 26, 2023 01:12
42ea608 to
1238c22
Compare
anagstef
approved these changes
Oct 26, 2023
dimkl
added this pull request to the merge queue
Oct 26, 2023
desiprisg
approved these changes
Oct 26, 2023
Merged
LekoArts
pushed a commit
that referenced
this pull request
Oct 26, 2023
dimkl
added a commit
that referenced
this pull request
Oct 30, 2023
24 tasks
dimkl
added a commit
that referenced
this pull request
Oct 30, 2023
panteliselef
pushed a commit
that referenced
this pull request
Oct 30, 2023
octoper
pushed a commit
that referenced
this pull request
Oct 31, 2023
dimkl
added a commit
that referenced
this pull request
Oct 31, 2023
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Oct 31, 2023
* fix(clerk-sdk-node): Fix types of ClerkExpressWithAuth/ClerkExpressRequireAuth args (#1939) #1938 * fix(backend): Support NextJS 14 (#1948) * fix(backend): Fix for next 14 fetch bind issue * fix(nextjs): Use named imports for fetch runtime polyfill Next14 seems to have changed the way it handles default exports when using the webpack bundler for some of their build variants when using `npm run dev`. This commit ensures that we no longer use the default export in an effort to improve compat between the different nextjs versions. More information can be found here: https://esbuild.github.io/content-types/#default-interop and here: #612 * Create late-dolphins-peel.md --------- Co-authored-by: Nikos Douvlis <nikosdouvlis@gmail.com> --------- Co-authored-by: George Desipris <73396808+desiprisg@users.noreply.github.com> Co-authored-by: Nikos Douvlis <nikosdouvlis@gmail.com>
4 tasks
Collaborator
|
This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #1938
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/clerk-sdk-node@clerk/shared@clerk/fastify@clerk/chrome-extensiongatsby-plugin-clerkbuild/tooling/chore