fix(clerk-js): Deconstruct new feedback props to avoid prop polluting#1951
Merged
Conversation
🦋 Changeset detectedLatest commit: 4c75a23 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
panteliselef
approved these changes
Oct 26, 2023
anagstef
approved these changes
Oct 26, 2023
Contributor
|
Please, add a changeset! :) |
dimkl
approved these changes
Oct 30, 2023
desiprisg
force-pushed
the
fix_prop_polluting
branch
3 times, most recently
from
October 30, 2023 08:35
ef96716 to
7718a1a
Compare
nikosdouvlis
approved these changes
Oct 30, 2023
nikosdouvlis
added this pull request to the merge queue
Oct 30, 2023
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Oct 30, 2023
desiprisg
force-pushed
the
fix_prop_polluting
branch
from
October 30, 2023 13:04
7718a1a to
4c75a23
Compare
desiprisg
added this pull request to the merge queue
Oct 30, 2023
Closed
Contributor
|
@desiprisg please also cherry-pick this PR in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/clerk-sdk-node@clerk/shared@clerk/fastify@clerk/chrome-extensiongatsby-plugin-clerkbuild/tooling/chore