fix(read): lead file-inspection diagnosis with the cause - #1234
Closed
TheGreatAxios wants to merge 1 commit into
Closed
TheGreatAxios wants to merge 1 commit into
TheGreatAxios wants to merge 1 commit into
Conversation
Collapsed tool rows clip to 72 characters, so a long path buried the gap. The first sentence now names missing extractor, permission boundary, or malformed file, and the message uses the call path.
Collaborator
Author
|
Closing as duplicate of #1238. Stacked onto that PR: 1234 copy polish (lead-with-cause diagnosis + displayPath) plus 1238 UTF-8 .pdf text reads, quoted pdftotext, and tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pdftotexthint matches what the model should run.pdfthat is valid UTF-8 without magic is left as a normal text read; only NUL-without-magic.pdffiles count as malformedVerification
bun run typecheckpassesbun test src/plugins/file-inspection-diagnosis.test.ts src/plugins/read-file-guard-plugin.test.tspasses (50 pass, 0 fail)Related to CL-9474