fix(read): treat utf-8 pdf names as text and quote pdftotext - #1238
Merged
Merged
Conversation
Collapsed tool rows clip to 72 characters, so a long path buried the gap. The first sentence now names missing extractor, permission boundary, or malformed file, and the message uses the call path.
A .pdf suffix without %PDF magic is only malformed when the first chunk is binary. extractor_ready quotes the path so it pastes into bash.
TheGreatAxios
force-pushed
the
cl-9474-critic-nits
branch
from
September 29, 2026 23:40
82055d7 to
1f36f62
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.pdfwithout%PDFmagic still read as text throughreadFileBoundedand theread_filepluginextractor_readyquotes thepdftotextpath so spaces and metacharacters paste safely into bashVerification
bun run typecheck,bun run build, andbun run testpassbun run checkgreen (7808 pass, 0 fail)Related to CL-9474