Skip to content

ci(workflows): trigger CI on stacked-PR branches - #562

Merged
yacosta738 merged 1 commit into
mainfrom
ci/stack-pull-request-trigger
Aug 14, 2026
Merged

ci(workflows): trigger CI on stacked-PR branches#562
yacosta738 merged 1 commit into
mainfrom
ci/stack-pull-request-trigger

Conversation

@yacosta738

Copy link
Copy Markdown
Contributor

Description

Extend the CI workflow triggers so each layer of a stacked pull request runs the full pipeline instead of waiting for the top layer to merge.

Currently .github/workflows/ci.yml and .github/workflows/sonarcloud.yml only run on pull requests whose base is main. Layered stacked PRs that target intermediate branches (fix/*, feat/*, docs/*, qa/*, refactor/*, perf/*, chore/*, ci/*) only see the cross-cutting checks (CodeQL, Greetings, Labeler, Semgrep, Socket, GitGuardian), which leaves the build, test, lint, format, security audit, E2E, and Code Quality Analysis suites as "Expected — Waiting for status to be reported".

This change adds the conventional stacked-PR branch prefixes to both pull_request and push triggers so every layer is exercised end-to-end before review. The triggers still cover main and merge_group, and the push triggers now mirror pull_request for parity. No other behavior in the workflow files changes.

Fixes # (none)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Test A — cargo fmt --all -- --check
  • Test B — cargo clippy --all-targets --all-features -- -D warnings
  • Test C — cargo test --all-features
  • Test D — python3 -c "import yaml; yaml.safe_load(open('.github/workflows/ci.yml')); yaml.safe_load(open('.github/workflows/sonarcloud.yml'))"

Test Configuration:

  • OS/Distribution: macOS 26.6.1
  • Rust version: rustc 1.97.1
  • Node/pnpm version: Node 24.19.0, pnpm 11.21.0
  • Test command used: pre-commit hooks and YAML syntax validation
  • Environment variables: None required
  • Reproduction steps: run the pre-commit hooks (lefthook run pre-commit) and the YAML validator before pushing

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works — pre-commit hooks and YAML validation pass
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules — N/A

Chain Context

Field Value
Strategy github-stacked-prs
Chain stacked-pr-ci-triggers
Position 1 of 1
Base main
Head ci/stack-pull-request-trigger
Depends on None
Follow-up None
Review budget 40 changed lines / 400
Issue None
Linear None
Starts at 7465d920
Ends with Every stacked-PR layer running the full CI suite

Chain Overview

main
└── [current] ci/stack-pull-request-trigger

Add the conventional stacked-PR branch prefixes to the ci.yml and
sonarcloud.yml pull_request and push triggers so each layer of a
stacked PR (fix/, feat/, docs/, qa/, refactor/, perf/, chore/, ci/)
runs the full build, test, lint, format, security audit, and code
quality pipeline instead of waiting for the top layer to merge.

The full CI still runs on main and merge_group as before; only the
list of trigger branches expands. The change keeps the existing
main branch in the list and adds the conventional prefixes used by
the project's stacked-PR workflow.

Refs: #558
Refs: #559
Refs: #560
@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 98028263-0111-4ba7-b76a-a59577606e14

📥 Commits

Reviewing files that changed from the base of the PR and between 7465d92 and 4148010.

📒 Files selected for processing (2)
  • .github/workflows/ci.yml
  • .github/workflows/sonarcloud.yml

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Automated quality checks now run for pushes and pull requests across designated development branches, in addition to main.
    • Expanded automated code analysis coverage for feature, fix, documentation, testing, refactoring, performance, maintenance, and CI-related branches.

Walkthrough

The CI and SonarCloud workflows now trigger for main and the listed development and maintenance branch patterns on pushes and pull requests.

Changes

Workflow trigger coverage

Layer / File(s) Summary
Expand workflow branch filters
.github/workflows/ci.yml, .github/workflows/sonarcloud.yml
Push and pull-request filters now include main, fix/**, feat/**, docs/**, qa/**, refactor/**, perf/**, chore/**, and ci/** branches.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 41480

This change expands CI coverage to stacked-PR branches without altering workflow jobs or other behavior; no actionable merge-blocking risk remains after normal checks and review.

Poem

A rabbit checks the workflow gate,
Branches hop in, no longer late.
CI runs bright on every trail,
SonarCloud follows the same detail.
Main and features join the queue,
With fixes and chores in view.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the workflow change and the stacked-PR branch scope.
Description check ✅ Passed The description directly explains the workflow trigger changes and their purpose for stacked pull requests.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/stack-pull-request-trigger

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the ci label Aug 14, 2026
@linear-code
linear-code Bot marked this pull request as ready for review August 14, 2026 17:26
@yacosta738
yacosta738 enabled auto-merge August 14, 2026 17:26
@codecov

codecov Bot commented Aug 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@sonarqubecloud

Copy link
Copy Markdown

@yacosta738
yacosta738 added this pull request to the merge queue Aug 14, 2026
Merged via the queue into main with commit 97df9d2 Aug 14, 2026
44 checks passed
@yacosta738
yacosta738 deleted the ci/stack-pull-request-trigger branch August 14, 2026 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants