From 8f5093cd2a50d0747bad47b4620bd1a0a700ede7 Mon Sep 17 00:00:00 2001 From: pasta Date: Thu, 21 Apr 2022 21:05:01 -0500 Subject: [PATCH 1/2] refactor(llmq): separate llmq/utils into llmq/utils and llmq/complex_utils llmq/utils should remain very slim including only trivial headers, while llmq/complex_utils for the time being may continue to include more complex includes such as. This helps us break some circular dependancies and makes llmq/utils a nice simple neighborhood to live. This also includes substancial include refactoring as well as moving a function into its own util files ``` ``` --- src/Makefile.am | 4 + src/bloom.cpp | 1 + src/evo/cbtx.cpp | 3 + src/evo/deterministicmns.cpp | 5 +- src/evo/deterministicmns.h | 4 +- src/evo/mnhftx.cpp | 1 + src/init.cpp | 1 + src/llmq/blockprocessor.cpp | 8 +- src/llmq/commitment.cpp | 32 +- src/llmq/commitment.h | 13 +- src/llmq/complex_utils.cpp | 733 ++++++++++++++++++++++++ src/llmq/complex_utils.h | 83 +++ src/llmq/debug.cpp | 3 +- src/llmq/dkgsession.cpp | 10 +- src/llmq/dkgsession.h | 12 +- src/llmq/dkgsessionhandler.cpp | 7 +- src/llmq/dkgsessionmgr.cpp | 12 +- src/llmq/dkgsessionmgr.h | 1 + src/llmq/quorums.cpp | 13 +- src/llmq/quorums.h | 10 +- src/llmq/signing.cpp | 7 +- src/llmq/signing_shares.cpp | 7 +- src/llmq/snapshot.cpp | 1 + src/llmq/snapshot.h | 3 +- src/llmq/utils.cpp | 726 +---------------------- src/llmq/utils.h | 61 +- src/miner.cpp | 4 +- src/net_processing.cpp | 1 + src/rpc/rpcquorums.cpp | 12 +- src/test/evo_utils_tests.cpp | 32 +- src/util/hexstr.cpp | 17 + src/util/hexstr.h | 13 + test/lint/lint-circular-dependencies.sh | 36 +- 33 files changed, 1030 insertions(+), 846 deletions(-) create mode 100644 src/llmq/complex_utils.cpp create mode 100644 src/llmq/complex_utils.h create mode 100644 src/util/hexstr.cpp create mode 100644 src/util/hexstr.h diff --git a/src/Makefile.am b/src/Makefile.am index 1467a26cba53..7fa3738be100 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -212,6 +212,7 @@ BITCOIN_CORE_H = \ llmq/snapshot.h \ llmq/signing.h \ llmq/signing_shares.h \ + llmq/complex_utils.h \ llmq/utils.h \ llmq/params.h \ logging.h \ @@ -292,6 +293,7 @@ BITCOIN_CORE_H = \ util/check.h \ util/error.h \ util/fees.h \ + util/hexstr.h \ util/irange.h \ util/spanparsing.h \ util/system.h \ @@ -402,6 +404,7 @@ libdash_server_a_SOURCES = \ llmq/snapshot.cpp \ llmq/signing.cpp \ llmq/signing_shares.cpp \ + llmq/complex_utils.cpp \ llmq/utils.cpp \ mapport.cpp \ masternode/node.cpp \ @@ -700,6 +703,7 @@ libdash_util_a_SOURCES = \ util/error.cpp \ util/fees.cpp \ util/getuniquepath.cpp \ + util/hexstr.cpp \ util/system.cpp \ util/asmap.cpp \ util/moneystr.cpp \ diff --git a/src/bloom.cpp b/src/bloom.cpp index b409b007b7ae..5d67a8dfa87a 100644 --- a/src/bloom.cpp +++ b/src/bloom.cpp @@ -13,6 +13,7 @@ #include