From fb2648a63bee7c1400e6ce0406546f6d1e3ffbc8 Mon Sep 17 00:00:00 2001 From: Kittywhiskers Van Gogh <63189531+kwvg@users.noreply.github.com> Date: Fri, 18 Jul 2025 09:52:55 +0000 Subject: [PATCH 1/4] fix: compare against lower version first to avoid short-circuiting --- test/get_previous_releases.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/get_previous_releases.py b/test/get_previous_releases.py index 2ae9ba4c3e1c..2ffb4d6c755b 100755 --- a/test/get_previous_releases.py +++ b/test/get_previous_releases.py @@ -130,8 +130,6 @@ def download_binary(tag, args) -> int: platform = "win32" elif platform in ["x86_64-w64-mingw32"]: platform = "win64" - elif tag < "v20" and platform in ["x86_64-apple-darwin", "arm64-apple-darwin"]: - platform = "osx64" elif tag < "v0.12.2.3": if platform in ["arm-linux-gnueabihf"]: platform = "RPi2" @@ -141,6 +139,8 @@ def download_binary(tag, args) -> int: platform = "linux32" elif platform in ["x86_64-linux-gnu"]: platform = "linux64" + elif tag < "v20" and platform in ["x86_64-apple-darwin", "arm64-apple-darwin"]: + platform = "osx64" tarball = 'dashcore-{tag}-{platform}.tar.gz'.format( tag=tag[1:], platform=platform) tarballUrl = 'https://github.com/dashpay/dash/{bin_path}/{tarball}'.format( From 722997e0deed185a975dd5736fbe7db9e51714eb Mon Sep 17 00:00:00 2001 From: Kittywhiskers Van Gogh <63189531+kwvg@users.noreply.github.com> Date: Fri, 18 Jul 2025 09:56:15 +0000 Subject: [PATCH 2/4] fix: avoid exclusion of v0.12.2.3 from platform identifier v0.12.2.3 is the last version to use the old platform identification scheme but the less than check inadvertently excludes it. Let's correct that and set it to less than the v0.12.3.x series instead as that marks the start the newer identification scheme --- test/get_previous_releases.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/get_previous_releases.py b/test/get_previous_releases.py index 2ffb4d6c755b..035bdad342d7 100755 --- a/test/get_previous_releases.py +++ b/test/get_previous_releases.py @@ -130,7 +130,7 @@ def download_binary(tag, args) -> int: platform = "win32" elif platform in ["x86_64-w64-mingw32"]: platform = "win64" - elif tag < "v0.12.2.3": + elif tag < "v0.12.3": if platform in ["arm-linux-gnueabihf"]: platform = "RPi2" elif platform in ["x86_64-apple-darwin", "arm64-apple-darwin"]: From 5c38d5c51c8174ca68531228b77537893061cd35 Mon Sep 17 00:00:00 2001 From: Kittywhiskers Van Gogh <63189531+kwvg@users.noreply.github.com> Date: Fri, 18 Jul 2025 10:07:22 +0000 Subject: [PATCH 3/4] fix: don't download v0.12.2.x on macOS due to missing releases --- test/get_previous_releases.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test/get_previous_releases.py b/test/get_previous_releases.py index 035bdad342d7..9492738d1736 100755 --- a/test/get_previous_releases.py +++ b/test/get_previous_releases.py @@ -134,7 +134,8 @@ def download_binary(tag, args) -> int: if platform in ["arm-linux-gnueabihf"]: platform = "RPi2" elif platform in ["x86_64-apple-darwin", "arm64-apple-darwin"]: - platform = "osx" + print(f"Binaries not available for {tag} on {platform}") + return 1 elif platform in ["i686-pc-linux-gnu"]: platform = "linux32" elif platform in ["x86_64-linux-gnu"]: From 7ace51227d90ae668346959c1d1ca0b25c3936ca Mon Sep 17 00:00:00 2001 From: Kittywhiskers Van Gogh <63189531+kwvg@users.noreply.github.com> Date: Fri, 18 Jul 2025 10:12:29 +0000 Subject: [PATCH 4/4] fix: restrict `feature_unsupported_utxo_db` to Linux --- test/functional/feature_unsupported_utxo_db.py | 1 + 1 file changed, 1 insertion(+) diff --git a/test/functional/feature_unsupported_utxo_db.py b/test/functional/feature_unsupported_utxo_db.py index 67f9ef15f98f..e57b1567ed54 100755 --- a/test/functional/feature_unsupported_utxo_db.py +++ b/test/functional/feature_unsupported_utxo_db.py @@ -20,6 +20,7 @@ def set_test_params(self): def skip_test_if_missing_module(self): self.skip_if_no_previous_releases() + self.skip_if_platform_not_linux() def setup_network(self): self.add_nodes(