Skip to content

fix(ci): skip network-dependent OCI tests in goreleaser pre-hook - #309

Merged
skevetter merged 2 commits into
mainfrom
0b89-ws-release-fix
May 17, 2026
Merged

fix(ci): skip network-dependent OCI tests in goreleaser pre-hook#309
skevetter merged 2 commits into
mainfrom
0b89-ws-release-fix

Conversation

@skevetter

Copy link
Copy Markdown
Contributor

Summary

  • Root cause: TestOCIFeatureTestSuite/TestProcessOCIFeature_HappyPath in pkg/devcontainer/feature makes a live OCI pull from ghcr.io/devcontainers/features/go:1. On macOS runners, the XDG_CACHE_HOME override in the test does not remap the cache directory (macOS uses ~/Library/Caches, not XDG paths), so the extracted directory is never written where the test expects it, causing pre hook failed: exit status 1 and blocking the release build.
  • Fix: Add -short to all three goreleaser build pre-hook go test invocations (devsy, devsy-linux, devsy-darwin). The test already contains if testing.Short() { t.Skip(...) }, so it is intentionally designed to be skipped in CI/release contexts.
  • v1.2.1-rc will need to be re-triggered after this merges.

Add -short flag to all goreleaser build pre-hooks so that
TestOCIFeatureTestSuite/TestProcessOCIFeature_HappyPath is skipped
during release builds. The test pulls a live OCI image from ghcr.io
and the XDG_CACHE_HOME override doesn't work on macOS runners, causing
the extracted directory to be missing and the build to fail.
@netlify

netlify Bot commented May 17, 2026

Copy link
Copy Markdown

Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit af0dfb5
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/6a09e4a6b80dc500080c6ba5

@coderabbitai

coderabbitai Bot commented May 17, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@skevetter has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 20 minutes and 14 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7a4b5ee2-70e9-4748-ad62-41f20728103f

📥 Commits

Reviewing files that changed from the base of the PR and between 686368c and af0dfb5.

📒 Files selected for processing (2)
  • .goreleaser.yml
  • .pre-commit-config.yaml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@skevetter
skevetter merged commit 87d893e into main May 17, 2026
89 of 90 checks passed
@skevetter
skevetter deleted the 0b89-ws-release-fix branch May 17, 2026 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant