From ca06eb5369563936a1d59a78daa7714de9fc3a3b Mon Sep 17 00:00:00 2001
From: "github-actions[bot]"
 <41898282+github-actions[bot]@users.noreply.github.com>
Date: Fri, 7 Aug 2026 01:58:41 +0000
Subject: [PATCH] Select gen-debug-dump-docs post-command shell by WindowsShell

The gen-debug-dump-docs Helix post-command chose cmd vs POSIX syntax based
on $(TargetOS) == 'windows', but the actual work-item shell is determined by
$(WindowsShell). For linux-bionic (Android) and MacCatalyst work items that
run on a Windows Helix queue, WindowsShell is true while TargetOS is not
'windows', so the POSIX $HELIX_PYTHONPATH form was emitted into cmd.exe and
failed with "'$HELIX_PYTHONPATH' is not recognized", failing the work item
after tests had already run.

Key the shell selection off $(WindowsShell) to match the rest of the file.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---
 src/libraries/sendtohelixhelp.proj | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/libraries/sendtohelixhelp.proj b/src/libraries/sendtohelixhelp.proj
index 14ab6568ae292b..b71e0872b4eb3a 100644
--- a/src/libraries/sendtohelixhelp.proj
+++ b/src/libraries/sendtohelixhelp.proj
@@ -268,11 +268,11 @@
     <Message Importance="High" Text="Using Timeout: $(_workItemTimeout)" />
 
     <PropertyGroup Condition="'$(RuntimeFlavor)' == 'CoreCLR' and '$(BUILD_BUILDID)' != ''">
-      <HelixPostCommands Condition="'$(TargetOS)' == 'windows'">
+      <HelixPostCommands Condition="'$(WindowsShell)' == 'true'">
         $(HelixPostCommands);
         %HELIX_PYTHONPATH% %HELIX_CORRELATION_PAYLOAD%\gen-debug-dump-docs.py -buildid $(BUILD_BUILDID) -workitem %HELIX_WORKITEM_FRIENDLYNAME% -jobid %HELIX_CORRELATION_ID% -outdir %HELIX_WORKITEM_UPLOAD_ROOT% -templatedir %HELIX_CORRELATION_PAYLOAD% -dumpdir %HELIX_DUMP_FOLDER% -productver $(ProductVersion)
       </HelixPostCommands>
-      <HelixPostCommands Condition="'$(TargetOS)' != 'windows' and '$(TargetOS)' != 'browser' and '$(TargetOS)' != 'wasi'">
+      <HelixPostCommands Condition="'$(WindowsShell)' != 'true' and '$(TargetOS)' != 'browser' and '$(TargetOS)' != 'wasi'">
         $(HelixPostCommands);
         $HELIX_PYTHONPATH $HELIX_CORRELATION_PAYLOAD/gen-debug-dump-docs.py -buildid $(BUILD_BUILDID) -workitem $HELIX_WORKITEM_FRIENDLYNAME -jobid $HELIX_CORRELATION_ID -outdir $HELIX_WORKITEM_UPLOAD_ROOT -templatedir $HELIX_CORRELATION_PAYLOAD -dumpdir $HELIX_DUMP_FOLDER -productver $(ProductVersion)
       </HelixPostCommands>