From ee52cc931e4010d3c13be8f8bda2edcea51f56b4 Mon Sep 17 00:00:00 2001 From: Larry Ewing Date: Sat, 5 Sep 2026 20:18:56 -0500 Subject: [PATCH] [Mono][browser] Quarantine double Min/Max NaN payload tests (#133312) Quarantines the four double generic-math `Max`/`Min` cases tracked by #133311 on Mono browser-WASM without splitting the shared test methods or data sets. The affected NaN sign-and-payload rows remain in `MaxDouble` and `MinDouble` for every other runtime. Each pair is conditionally omitted only when `PlatformDetection.IsMonoRuntime && PlatformDetection.IsWasm`; all other Max/Min coverage remains unchanged. Validation: - `PATH=/opt/homebrew/bin:$PATH ./build.sh mono+libs -os browser` - Focused Mono browser-WASM runs: 17/17 applicable `MaxTest` cases passed and 17/17 applicable `MinTest` cases passed Contributes to #133311 > [!NOTE] > This pull request description was generated with GitHub Copilot. --------- Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> --- .../tests/System/GenericMathTestMemberData.cs | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/src/libraries/Common/tests/System/GenericMathTestMemberData.cs b/src/libraries/Common/tests/System/GenericMathTestMemberData.cs index 6161d414e92b41..6e29ad5e95b6fd 100644 --- a/src/libraries/Common/tests/System/GenericMathTestMemberData.cs +++ b/src/libraries/Common/tests/System/GenericMathTestMemberData.cs @@ -1372,8 +1372,12 @@ public static IEnumerable MaxDouble yield return new object[] { double.NegativeInfinity, double.NaN, double.NaN }; yield return new object[] { double.NaN, double.PositiveInfinity, double.NaN }; yield return new object[] { double.NaN, double.NegativeInfinity, double.NaN }; - yield return new object[] { PositiveNaNDouble, -0.0, PositiveNaNDouble }; - yield return new object[] { -0.0, NegativeNaNDouble, NegativeNaNDouble }; + // [ActiveIssue("https://github.com/dotnet/runtime/issues/133311")] + if (!(PlatformDetection.IsMonoRuntime && PlatformDetection.IsWasm)) + { + yield return new object[] { PositiveNaNDouble, -0.0, PositiveNaNDouble }; + yield return new object[] { -0.0, NegativeNaNDouble, NegativeNaNDouble }; + } yield return new object[] { -0.0f, 0.0f, 0.0f }; yield return new object[] { 0.0f, -0.0f, 0.0f }; yield return new object[] { 2.0f, -3.0f, 2.0f }; @@ -1572,8 +1576,12 @@ public static IEnumerable MinDouble yield return new object[] { double.NegativeInfinity, double.NaN, double.NaN }; yield return new object[] { double.NaN, double.PositiveInfinity, double.NaN }; yield return new object[] { double.NaN, double.NegativeInfinity, double.NaN }; - yield return new object[] { PositiveNaNDouble, -0.0, PositiveNaNDouble }; - yield return new object[] { -0.0, NegativeNaNDouble, NegativeNaNDouble }; + // [ActiveIssue("https://github.com/dotnet/runtime/issues/133311")] + if (!(PlatformDetection.IsMonoRuntime && PlatformDetection.IsWasm)) + { + yield return new object[] { PositiveNaNDouble, -0.0, PositiveNaNDouble }; + yield return new object[] { -0.0, NegativeNaNDouble, NegativeNaNDouble }; + } yield return new object[] { -0.0f, 0.0f, -0.0f }; yield return new object[] { 0.0f, -0.0f, -0.0f }; yield return new object[] { 2.0f, -3.0f, -3.0f };