Skip to content

Commit 65f9a4f

Browse files
committed
fix(envd): restore stdout logging in local dev mode
When isNotFC=true (local dev/Docker mode) and verbose=false, the exporters slice was empty, causing all logs to be silently discarded. Fixed by ensuring stdout is always enabled in local dev mode (isNotFC=true) since there's no page-dirtying concern, while keeping it opt-in via -verbose flag in FC mode to avoid dirtying guest pages on snapshots.
1 parent f48305f commit 65f9a4f

1 file changed

Lines changed: 5 additions & 4 deletions

File tree

‎packages/envd/internal/logs/logger.go‎

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,11 @@ func NewLogger(ctx context.Context, isNotFC bool, verbose bool, mmdsChan <-chan
2121
if !isNotFC {
2222
exporters = append(exporters, exporter.NewHTTPLogsExporter(ctx, isNotFC, mmdsChan))
2323
}
24-
// Stdout is opt-in via -verbose. Inside FC stdout flows into journald and
25-
// dirties guest pages on every snapshot, so we keep it off by default and
26-
// rely on the HTTP exporter to ship debug logs to the orchestrator.
27-
if verbose {
24+
// Stdout is opt-in via -verbose inside FC mode. Inside FC, stdout flows into
25+
// journald and dirties guest pages on every snapshot, so we keep it off by
26+
// default and rely on the HTTP exporter. In local dev mode, stdout is always
27+
// enabled since there's no page-dirtying concern.
28+
if verbose || isNotFC {
2829
exporters = append(exporters, os.Stdout)
2930
}
3031

0 commit comments

Comments
 (0)