From 7053d7b6ec1d90471de05285e3acca4ce071adaa Mon Sep 17 00:00:00 2001 From: ysyneu Date: Mon, 20 Jul 2026 03:15:02 -0700 Subject: [PATCH] fix(skills): monit cards invoked four nonexistent tools MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit `monit-agent.md` ran `host.top` / `host.disk` and `monit.md` ran `host.cpu` / `host.mem`. None of the four exist. monit-agent v0.0.7 registers exactly: host → os.overview, os.top_processes, net.tcp_ping, http.get, shell.exec; mysql → mysql.overview, mysql.lock_contention, mysql.query. An agent copying these gets `unknown_tool`, and the `host.top` example also passed `limit`, which is not a parameter of anything (`os.top_processes` takes `top_n` / `sort_by`, and the agent validates with `additionalProperties:false`, so a wrong key is a hard `invalid_args`, not a silent no-op). The generated help in this repo (zz_generated_diagnostics.go, zz_generated_response_help.go) was already correct — only these hand-written cards drifted, because nothing checks their JSON bodies against the registry. Replacements verified live against a real dev target. Deliberately kept separate from the SDK-bump branch so it can land without waiting on that. --- skills/flashduty/reference/monit-agent.md | 4 ++-- skills/flashduty/reference/monit.md | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/skills/flashduty/reference/monit-agent.md b/skills/flashduty/reference/monit-agent.md index f7572ef..8d95897 100644 --- a/skills/flashduty/reference/monit-agent.md +++ b/skills/flashduty/reference/monit-agent.md @@ -20,7 +20,7 @@ Prereq: `SKILL.md` read. On-box diagnostics: run diagnostic tools on a host or d fduty monit-agent catalog --target-locator --output-format toon # 2. invoke up to 8 tools concurrently; tool names taken verbatim from the catalog fduty monit-agent invoke --target-locator \ - --data '{"tools":[{"tool":"host.top","params":{}},{"tool":"host.disk","params":{}}]}' + --data '{"tools":[{"tool":"os.overview"},{"tool":"os.top_processes","params":{"top_n":10}}]}' ``` @@ -60,6 +60,6 @@ Run up to 8 monit-agent tools concurrently on a target ```bash fduty monit-agent invoke --target-locator web-prod-3 \ - --data '{"tools":[{"tool":"host.top","params":{"limit":10}},{"tool":"host.disk","params":{}}]}' \ + --data '{"tools":[{"tool":"os.overview"},{"tool":"os.top_processes","params":{"top_n":10}}]}' \ --output-format toon ``` diff --git a/skills/flashduty/reference/monit.md b/skills/flashduty/reference/monit.md index 2cdaa72..84e20a9 100644 --- a/skills/flashduty/reference/monit.md +++ b/skills/flashduty/reference/monit.md @@ -65,7 +65,7 @@ fduty monit tools-catalog --target-locator --output-format toon # 3. invoke tools (up to 8 concurrently); use heredoc to avoid shell quoting hell fduty monit tools-invoke --target-locator --output-format toon --data - <<'EOF' -{"tools":[{"tool":"host.cpu","params":{}},{"tool":"host.mem","params":{}}]} +{"tools":[{"tool":"os.overview"},{"tool":"os.top_processes","params":{"top_n":10}}]} EOF ```