From db04cb578458ca78b36447c0e811de46a42c4a13 Mon Sep 17 00:00:00 2001 From: Lauris Skraucis Date: Mon, 14 Aug 2023 18:11:53 +0200 Subject: [PATCH] temporary: only check changelogs --- .../actions/created/commands/go/index.ts | 18 ++++++++++++------ .../go/source/breaking-changes/report.ts | 16 +++++++++++++++- 2 files changed, 27 insertions(+), 7 deletions(-) diff --git a/source/events/issue_handler/actions/created/commands/go/index.ts b/source/events/issue_handler/actions/created/commands/go/index.ts index ce61cc1..c557c52 100644 --- a/source/events/issue_handler/actions/created/commands/go/index.ts +++ b/source/events/issue_handler/actions/created/commands/go/index.ts @@ -30,9 +30,10 @@ export const go = async (payload: IssueCommentEvent, installationId: number, oct return; } - await setupRepositoryLocally(payload, installationId, octokit); + // await setupRepositoryLocally(payload, installationId, octokit); const breakingChangesReports = await getBreakingChangesReports(updatedDependencies); + Logger.info(`Prepared breaking changes reports`, { repository: payload.repository.full_name, PR: `#${payload.issue.number}`, @@ -41,16 +42,21 @@ export const go = async (payload: IssueCommentEvent, installationId: number, oct await reportBreakingChangesReports(breakingChangesReports, payload, octokit); - await postRefactorsLoading(payload, octokit); - const refactorsReports = await getRefactorsReports(breakingChangesReports, payload); - await reportRefactorsReports(refactorsReports, payload, octokit); + // await postRefactorsLoading(payload, octokit); + // const refactorsReports = await getRefactorsReports(breakingChangesReports, payload); + // await reportRefactorsReports(refactorsReports, payload, octokit); await upsertDatabaseState( payload, - refactorsReports.map((refactor) => refactor.dependencyUpdate) + breakingChangesReports.map((update) => update.dependencyUpdate) ); - await deleteRepositoryLocally(payload); + // await upsertDatabaseState( + // payload, + // refactorsReports.map((refactor) => refactor.dependencyUpdate) + // ); + + // await deleteRepositoryLocally(payload); }; function allVersionsChecked(updatedDependencies: DependencyUpdate[]): boolean { diff --git a/source/events/issue_handler/actions/created/commands/go/source/breaking-changes/report.ts b/source/events/issue_handler/actions/created/commands/go/source/breaking-changes/report.ts index 971c628..3a23ba1 100644 --- a/source/events/issue_handler/actions/created/commands/go/source/breaking-changes/report.ts +++ b/source/events/issue_handler/actions/created/commands/go/source/breaking-changes/report.ts @@ -15,6 +15,20 @@ export async function reportBreakingChangesReports( octokit: Octokit ): Promise { let counter = 1; + + if (breakingChangesReports.every((report) => report.breakingChanges.length === 0)) { + const loadingCommentId = await getBreakingChangesLoadingCommentId(payload, octokit); + const message = `:white_check_mark:  All versions checked successfully! This PR looks good to me!\n\n`; + + if (loadingCommentId) { + await updateComment(payload.repository.full_name, loadingCommentId, message, octokit); + } else { + await postComment(payload.repository.full_name, payload.issue.number, message, octokit); + } + + return; + } + for (const report of breakingChangesReports) { const message = await getBreakingChangesMessage(report.dependencyUpdate, report.breakingChanges); @@ -41,7 +55,7 @@ async function getBreakingChangesMessage(dependencyUpdate: DependencyUpdate, bre if (breakingChanges.length) { const releaseUrl = await getReleaseUrl(dependencyUpdate.dependencyRepoUrl, dependencyUpdate.cursorVersion); - message = `:information_source:  Breaking Changes in the Dependency's Changelog\n\nPackage: [${dependencyUpdate.dependencyName}](${dependencyUpdate.dependencyUrl})\nVersion: [${dependencyUpdate.cursorVersion}](${releaseUrl})\n`; + message = `:information_source:  Breaking Changes in the Dependency's Changelog. Check breaking changes and run \`/adaptly go\` to continue checking next versions.\n\nPackage: [${dependencyUpdate.dependencyName}](${dependencyUpdate.dependencyUrl})\nVersion: [${dependencyUpdate.cursorVersion}](${releaseUrl})\n`; let breakingChangeNumber = 1;