From 3b5f9246b5fe254f4ea47883b1cb7eba2b1892cf Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E8=B6=85=E8=B6=85=E8=B6=85=E8=B6=85=E8=B6=85=E7=BA=A7?=
 =?UTF-8?q?=E5=96=9C=E6=AC=A2=E4=BD=A0=E7=9A=84=E8=BE=BE=E5=A6=AE=E5=A8=85?=
 <176143450+My-Denia@users.noreply.github.com>
Date: Fri, 11 Sep 2026 00:47:03 +0800
Subject: [PATCH] ci(whisper-stt): drop the msvc-dev-cmd step the Windows build
 never used

ilammy/msvc-dev-cmd was the last node20 action in the repo, and its upstream
stopped in 2024, so there is no newer major to bump to (#317). The issue
assumed the step fed a Ninja build, but scripts/build-whisper-stt.sh calls
cmake without -G: on Windows CMake picks the Visual Studio generator (the job
log reads "Building for: Visual Studio 18 2026"), locates MSVC through the
Visual Studio installer and builds with MSBuild, none of which reads the
vcvarsall environment the action exported. vcpkg finds the compiler on its
own the same way, and windows-latest ships a single VS instance, so there is
nothing for vcvars to disambiguate.

Remove the step instead of replacing it, and leave a comment at the spot
saying why there is none, and when one would become necessary again (a move
to Ninja).
---
 .github/workflows/build-whisper-stt.yml | 20 +++++++++++++++-----
 1 file changed, 15 insertions(+), 5 deletions(-)

diff --git a/.github/workflows/build-whisper-stt.yml b/.github/workflows/build-whisper-stt.yml
index 9fe27584f..86fd52df7 100644
--- a/.github/workflows/build-whisper-stt.yml
+++ b/.github/workflows/build-whisper-stt.yml
@@ -91,11 +91,21 @@ jobs:
         if: startsWith(matrix.os, 'macos')
         run: brew install ninja
 
-      - name: Setup MSVC (Windows)
-        if: matrix.os == 'windows-latest'
-        uses: ilammy/msvc-dev-cmd@v1
-        with:
-          arch: x64
+      # There is deliberately no "Setup MSVC" step for the Windows leg. It used to
+      # run ilammy/msvc-dev-cmd here, and nothing consumed what that action set up:
+      # scripts/build-whisper-stt.sh calls cmake without -G, so on Windows CMake
+      # picks its Visual Studio generator (the job log reads "Building for: Visual
+      # Studio 18 2026"), which locates MSVC through the Visual Studio installer
+      # and builds with MSBuild, whose VC targets set up the compiler environment
+      # themselves rather than inheriting the PATH/INCLUDE/LIB vcvarsall exported.
+      # vcpkg, in the SPIRV-Headers step below, finds the
+      # compiler on its own the same way, and windows-latest ships a single VS
+      # instance, so there is nothing for vcvars to disambiguate either. The
+      # action was also the last node20 action in the repo, with an upstream that
+      # stopped in 2024 (#317), so this drops a dependency rather than replacing
+      # it. Should the Windows build ever move to Ninja, that is the point where a
+      # vcvars step becomes necessary again; scripts/msvcEnv.mjs already has the
+      # vcvarsall discovery for it.
 
       - name: Install Vulkan SDK
         if: matrix.vulkan