Fix criteria for valid user data - #1108
Merged
ste93cry merged 7 commits intoOct 12, 2020
Merged
Conversation
Jean85
suggested changes
Oct 6, 2020
Jean85
left a comment
Contributor
There was a problem hiding this comment.
Thank you for your PR; please add at least a test and a changelog entry.
Contributor
|
@ahaurat after the answer of @kamilogorek in the referenced issue, there is some more work to do, if you are willing to contribute it. We should:
In the next major version considering that none of the attributes of the |
…rname-only # Conflicts: # CHANGELOG.md
Collaborator
Contributor
Author
|
@stayallive no problem at all; thanks for tackling it. Apologies I didn't have time to get to it this week. |
ste93cry
approved these changes
Oct 12, 2020
Jean85
approved these changes
Oct 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1107 to allow
usernameoremailto identify a user in addition toidorip_address.