Send stacktrace with events, not just exceptions - #1123
Merged
Merged
Conversation
ste93cry
suggested changes
Nov 1, 2020
ste93cry
left a comment
Contributor
There was a problem hiding this comment.
Good catch! Can you please add a CHANGELOG entry and also a test case for this?
Jean85
approved these changes
Nov 2, 2020
Contributor
|
I pushed a commit to the |
ste93cry
approved these changes
Nov 2, 2020
|
We've found (on an old version of the SDK - ^1.10) that for fatal errors/OOMs, sentry only gets the error but not the stack trace. Does this PR fix that? (Has it already been fixed since ^1.10?) |
Contributor
|
This is on a completely different version (3.0), the issue is completely unrelated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that if I set a stacktrace on an event, it is not sent to Sentry. This patch should resolve the issue.