Add Scope::removeTag() method - #1126
Merged
Merged
Conversation
ste93cry
suggested changes
Nov 4, 2020
ste93cry
left a comment
Contributor
There was a problem hiding this comment.
Apart from fixing the CS and adding an entry in the CHANGELOG, changes are fine for me, however if I don't recall wrong there has been some discussion in the past about adding such removal methods. I'm sure @HazAT can give us some advice on whether we want or not such feature, but I am personally not contrary though
Contributor
|
Can you please target this PR against the |
Contributor
Author
|
@ste93cry Feedback incorporated (changelog, removing one of two, base on develop). |
Contributor
|
@vojtech-dobes can you 🙏 rebase the PR once more? Build should now be green |
Contributor
Author
|
@ste93cry done :) |
ste93cry
approved these changes
Nov 6, 2020
ste93cry
left a comment
Contributor
There was a problem hiding this comment.
Thank you for your hard work!
Contributor
Author
|
You're welcome! |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was cheap to put together, so feel free to cheaply kill this. But I can't find other way how to remove tag other than clear the whole
Scope, which is something I don't believe is desired (I don't want to lose default tags + I don't want to lose tags set by myself in higher level of the code).