Dont overwrite Event properties - #1148
Merged
Merged
Conversation
ste93cry
suggested changes
Dec 2, 2020
ste93cry
left a comment
Contributor
There was a problem hiding this comment.
Can you please add the CHANGELOG and (hopefully they are not missing) fix the tests?
ste93cry
suggested changes
Dec 6, 2020
Contributor
|
@matthijsthoolen are you still open to making the necessary changes to merge this PR? Otherwise, can I continue your work? |
Contributor
Author
|
@ste93cry I'm really sorry, having a busy period and couldn't find the time to fix this issue. I am still willing to fix it, but if you have the time to continue with this merge request earlier than next week. Feel free to do so! |
ste93cry
force-pushed
the
patch-1
branch
2 times, most recently
from
January 7, 2021 01:03
6b42a0a to
72976b2
Compare
…ge tags from options and event.
SDK identifier is no longer overwritten if the event already has a value set
ste93cry
approved these changes
Jan 7, 2021
Jean85
approved these changes
Jan 7, 2021
stayallive
approved these changes
Jan 7, 2021
soundsgoodsofar
pushed a commit
to soundsgoodsofar/sentry-php
that referenced
this pull request
Jan 8, 2021
…ing `captureEvent()` (getsentry#1148) Co-authored-by: Stefano Arlandini <sarlandini@alice.it>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not overwrite Event properties if they are already configured. Merge tags from options and event.
See bug #1146 the bug was only for tags, but also SdkIdentifier, sdkversion, serverName, release, and Environment are always overwritten.