Conversation
stayallive
approved these changes
Dec 27, 2020
stayallive
left a comment
Collaborator
There was a problem hiding this comment.
Maybe you could point people to traces_sampler in case they were using before_send before?
But otherwise nice catch!
Contributor
Author
Do you mean in the CHANGELOG? |
Collaborator
|
Yeah, no sense putting it in the UPGRADE, maybe something like: |
Contributor
Author
|
Makes sense, done! |
ste93cry
deleted the
fix/transaction-should-not-go-through-before-send-callback
branch
December 27, 2020 12:57
ste93cry
added a commit
to jarstelfox/sentry-php
that referenced
this pull request
Dec 29, 2020
soundsgoodsofar
pushed a commit
to soundsgoodsofar/sentry-php
that referenced
this pull request
Jan 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reading the Tracing documentation I found out that the
before_sendcallback shouldn't be called for the transactions. This PR fixes the behaviour, but it kinda of breaks the BC because users that were relying on this behaviour will not be able to do it anymore. Since this is a bug I consider the BC justified and I don't see any other way to avoid it anyway