Fix the logger option not being applied to the event object - #1165
Merged
ste93cry merged 1 commit intoJan 7, 2021
Merged
Conversation
stayallive
approved these changes
Jan 7, 2021
soundsgoodsofar
pushed a commit
to soundsgoodsofar/sentry-php
that referenced
this pull request
Jan 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported in #1162, the
loggeroption is not being applied on the event object. This is a regression from2.x, probably the code went missing during a refactoring and noone noticed it until now.Side note: I don't have the full historic context of this option, however as of now I cannot find any references to this option in either the JS SDK or the Python SDK, so I believe it was removed at some point. I will open a separate PR, targeting the next minor version, to deprecate it. The field of the same name in the event payload is not affected