Skip to content

[sdk-platform-java] Implement maxAttempts inside the RetrySettings for GAPICs #12460

Description

@lqiu96

RetrySettingsComposer doesn't have logic to create set the maxAttempts value: https://github.com/googleapis/sdk-platform-java/blob/087253a41e8c1e1328710c19505e1198fc755003/gapic-generator-java/src/main/java/com/google/api/generator/gapic/composer/common/RetrySettingsComposer.java#L495-L588 even if it's set in the grpc_service.json file.

Searching through google-cloud-java shows that there aren't any occurrences of setMaxAttempts being generated in the StubSettings: https://github.com/search?q=repo%3Agoogleapis%2Fgoogle-cloud-java%20setMaxAttempts&type=code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    priority: p3Desirable enhancement or fix. May not be included in next release.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions