[assignment 2] Convert version route to plugin by MylesBorins · Pull Request #44 · outmoded/university

MylesBorins · 2015-03-18T17:27:37Z

Closes #43

AdriVanHoudt · 2015-03-18T17:28:22Z

newline after function

hueniverse · 2015-03-18T18:50:44Z

This is a callback so return

ai10 · 2015-03-19T00:20:00Z

Do we want to check if the version is a valid semver?

AdriVanHoudt · 2015-03-19T08:03:30Z

@Sschuck the version comes from package.json and that should always follow semver, so no need to check

hueniverse · 2015-03-22T17:43:42Z

This is odd. Just var Version = require('./version'); at the top and then use that in register().

hueniverse · 2015-03-23T07:50:08Z

No empty line here.

In personal projects I have always put a new line between modules that are included from node_modules and modules that are being included locally from the project.

That aside the style has been fixed.

I also like to do this, makes it easier to see what are local modules

I just sort them: node, npm, local.

Reasonable... I follow the same pattern (with spaces).

Thanks for taking the tie to discuss

same sorting here only with newlines in between

Closes outmoded#43

[assignment 2] Convert version route to plugin

AdriVanHoudt reviewed Mar 18, 2015
View reviewed changes

MylesBorins force-pushed the assignment-2 branch 5 times, most recently from bb0485c to 462de95 Compare March 18, 2015 17:32

hueniverse reviewed Mar 18, 2015
View reviewed changes

hueniverse added the submission label Mar 18, 2015

hueniverse added this to the 0.0.2 milestone Mar 18, 2015

MylesBorins force-pushed the assignment-2 branch from 462de95 to c0d9d04 Compare March 18, 2015 18:56

hueniverse reviewed Mar 22, 2015
View reviewed changes

MylesBorins force-pushed the assignment-2 branch 2 times, most recently from 8ae937a to 6961d7f Compare March 22, 2015 19:51

hueniverse reviewed Mar 23, 2015
View reviewed changes

[assignment 2] Convert version route to plugin

dc5005c

Closes outmoded#43

MylesBorins force-pushed the assignment-2 branch from 6961d7f to dc5005c Compare March 23, 2015 07:54

hueniverse pushed a commit that referenced this pull request Mar 24, 2015

Merge pull request #44 from TheAlphaNerd/assignment-2

fa3f5cc

[assignment 2] Convert version route to plugin

hueniverse merged commit fa3f5cc into outmoded:master Mar 24, 2015

hueniverse pushed a commit that referenced this pull request Mar 24, 2015

cleanup for #44

3f9c122

hueniverse pushed a commit that referenced this pull request Mar 24, 2015

Additional cleanup for #44

3c0bc69

MylesBorins pushed a commit to MylesBorins/hueniversity that referenced this pull request Mar 31, 2015

cleanup for outmoded#44

19c3e09

MylesBorins pushed a commit to MylesBorins/hueniversity that referenced this pull request Mar 31, 2015

Additional cleanup for outmoded#44

7fd06ad

Uh oh!

Conversation

MylesBorins commented Mar 18, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ai10 commented Mar 19, 2015

Uh oh!

AdriVanHoudt commented Mar 19, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants