Skip to content

fix: Keep the Setup Wizard skill target dropdown available#1842

Merged
hatayama merged 1 commit into
v3-betafrom
fix/setup-wizard-keep-first-install-ui
Jul 19, 2026
Merged

fix: Keep the Setup Wizard skill target dropdown available#1842
hatayama merged 1 commit into
v3-betafrom
fix/setup-wizard-keep-first-install-ui

Conversation

@hatayama

@hatayama hatayama commented Jul 19, 2026

Copy link
Copy Markdown
Owner

Summary

  • Keep the skill target dropdown visible after the first fallback is shown.
  • Allow users to install multiple targets during one Setup Wizard session.

User Impact

  • Installing the first target no longer switches the wizard to the multi-target list immediately.
  • Closing and reopening the wizard still allows the normal folder-based mode to be selected.

Changes

  • Latch the effective first-install mode in the workflow controller for the wizard lifetime.
  • Use the latched mode consistently for rendering and installation.
  • Add regression coverage for the latched resolver behavior.

Verification

  • Unity compile: 0 errors, 0 warnings.
  • Focused resolver tests: 4 passed.
  • Full EditMode suite: 2 pre-existing unrelated failures, 7 skipped; the new tests passed.

Review in cubic

Keep the first-install target dropdown visible for the lifetime of the wizard after the initial fallback is selected, even when installing a target creates a skills directory.
@coderabbitai

coderabbitai Bot commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@hatayama, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 44 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 505b4d20-863f-4fb2-81d5-f2f0744d46d7

📥 Commits

Reviewing files that changed from the base of the PR and between 7deb9d2 and 21d580f.

📒 Files selected for processing (3)
  • Assets/Tests/Editor/SetupWizardWindowTests.cs
  • Packages/src/Editor/Presentation/Setup/SetupWizardSkillsStepPresenter.cs
  • Packages/src/Editor/Presentation/Setup/SetupWizardSkillsWorkflowController.cs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/setup-wizard-keep-first-install-ui

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@hatayama
hatayama merged commit 2d73535 into v3-beta Jul 19, 2026
10 checks passed
@hatayama
hatayama deleted the fix/setup-wizard-keep-first-install-ui branch July 19, 2026 06:33
@github-actions github-actions Bot mentioned this pull request Jul 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant