fix: Rename the global uloop launcher to dispatcher in user-facing text#1994
Conversation
Align CLI output, help, comments, and tests with docs/glossary.md so "launcher" is not confused with the uloop launch command. Leave legacy npm uloop-cli launcher cleanup wording unchanged. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Warning Review limit reached
Next review available in: 51 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe change consistently renames user-facing and test terminology from “launcher” to “dispatcher” across command metadata, help, install/update/uninstall flows, project-runner messaging, documentation comments, and generated input hashes. ChangesDispatcher terminology alignment
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The launcher-to-dispatcher wording left tautologies that no longer explained what each test distinguishes. Co-authored-by: Cursor <cursoragent@cursor.com>
Summary
uloopbinary a dispatcher, matchingdocs/glossary.mduloop launch(Unity Editor launch)User Impact
uloop update/ install / uninstall / help said "launcher", which is not a glossary term and can be misread as the Unity launch commanduloop-cli launcherscleanup wording is unchangedChanges
launcher→dispatcherprintLauncherHelp→printDispatcherHelpand matching test identifiersshared-inputs-stamp.jsonfor both components after touching shared release inputsremoveLegacyLaunchers,uloop launch, or unrelatedSKILL.md/ changelog historyVerification
scripts/check-go-cli.sh— passscripts/test-install-release-filter.sh— passscripts/test-stamp-release-inputs.sh— passdist/darwin-arm64/uloop --helpstarts withDispatcher. Finds the Unity project, ...uloop install --help/uloop uninstall --helpuse dispatcher wording; legacy npm launcher lines remainuloop compile— 0 errors / 0 warningslauncherhits are only the intentional exclusions (legacy npm cleanup,removeLegacyLaunchers, etc.)Known pre-existing test failure (not caused by this PR)
NativeCliInstallerTests: 32 / 33 passedGetInstallCommand_RemoteBootstrapsEmitProgressLinesInStageOrderorigin/v3-betatree with this PR's changes stashedManualCommandis wrapped viaBuildLoginShellPosixInstallScriptCommand, which escapes inner single quotes throughQuotePosixShellValue, soIndexOf("echo 'Downloading installer script...'")returns-1. Production output is correct; the assertion is wrong. Unrelated to the launcher→dispatcher renameSuggested follow-up (out of scope here)
QuotePosixShellValuerules. Do not change the productionechoprogress text to make the brittle assertion pass.