From eeca30eda0835f8e8828fd2af46acafe5bd3788d Mon Sep 17 00:00:00 2001 From: "Jonathan D.A. Jewell" <6759885+hyperpolymath@users.noreply.github.com> Date: Wed, 26 Aug 2026 18:22:55 +0100 Subject: [PATCH 1/2] fix(scripts): backticks in a double-quoted echo run as command substitution MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Line 19 wrapped an example in backticks inside a double-quoted string. Backticks there are COMMAND SUBSTITUTION, so bash tried to execute '+ uses: …@' and printed the message with the example silently deleted. Switched to single quotes. Same defect class as hyperpolymath/Axiom.jl#82. Found by an estate-wide shellcheck sweep of 5,111 tracked scripts across 375 repos. This file was one of 11 that fail to PARSE (SC1073/SC1072) — shellcheck stops analysing at the failure, so anything after it was never checked either. Verified: shellcheck -S error now reports 0 findings for this file. --- scripts/fix-close-obsolete-pr.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/fix-close-obsolete-pr.sh b/scripts/fix-close-obsolete-pr.sh index 2a8ef006..a2444b21 100755 --- a/scripts/fix-close-obsolete-pr.sh +++ b/scripts/fix-close-obsolete-pr.sh @@ -16,7 +16,7 @@ REPO_NWO=$(echo "$URL" | awk -F'/' '{print $4"/"$5}') DIFF=$(gh pr diff "$URL" 2>/dev/null) PR_USES=$(echo "$DIFF" | grep -E "^\+[[:space:]]+uses:[[:space:]]+[^@[:space:]]+@[0-9a-f]{40}" || true) if [ -z "$PR_USES" ]; then - echo "SKIP: PR has no `+ uses: …@` lines" + echo 'SKIP: PR has no `+ uses: …@` lines' exit 0 fi From 33454e35a88b62cf7a880d60445b269b5c7ad81c Mon Sep 17 00:00:00 2001 From: "Jonathan D.A. Jewell" <6759885+hyperpolymath@users.noreply.github.com> Date: Wed, 26 Aug 2026 21:01:51 +0100 Subject: [PATCH 2/2] Update scripts/fix-close-obsolete-pr.sh Co-authored-by: codacy-production[bot] <61871480+codacy-production[bot]@users.noreply.github.com> Signed-off-by: Jonathan D.A. Jewell <6759885+hyperpolymath@users.noreply.github.com> --- scripts/fix-close-obsolete-pr.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/fix-close-obsolete-pr.sh b/scripts/fix-close-obsolete-pr.sh index a2444b21..554c979d 100755 --- a/scripts/fix-close-obsolete-pr.sh +++ b/scripts/fix-close-obsolete-pr.sh @@ -16,7 +16,7 @@ REPO_NWO=$(echo "$URL" | awk -F'/' '{print $4"/"$5}') DIFF=$(gh pr diff "$URL" 2>/dev/null) PR_USES=$(echo "$DIFF" | grep -E "^\+[[:space:]]+uses:[[:space:]]+[^@[:space:]]+@[0-9a-f]{40}" || true) if [ -z "$PR_USES" ]; then - echo 'SKIP: PR has no `+ uses: …@` lines' + echo "SKIP: PR has no \`+ uses: …@\` lines" exit 0 fi