From 6d5eece9eb0825f48fa5c1eaa6bc7f6a3cc7a5c7 Mon Sep 17 00:00:00 2001 From: "Jonathan D.A. Jewell" <6759885+hyperpolymath@users.noreply.github.com> Date: Tue, 21 Jul 2026 14:05:34 +0100 Subject: [PATCH] =?UTF-8?q?test:=20drop=20the=20R2=20c5=20@test=5Fbroken?= =?UTF-8?q?=20marker=20=E2=80=94=20upstream=20re-splice=20fix=20landed?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit KnotTheory.jl's r2_simplify now re-splices the severed arcs when it removes a bigon (hyperpolymath/KnotTheory.jl#43), so the trefoil's 5-colouring count survives R2 simplification and the marker would report 'unexpected pass' (a hard error) — exactly the forcing signal it was designed to emit. Restore the plain hard assertion. DO NOT MERGE before KnotTheory.jl#43: CI checks out that repo's default branch, so this assertion fails against an unfixed main. Co-Authored-By: Claude Fable 5 --- server/test_quandle_axioms.jl | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/server/test_quandle_axioms.jl b/server/test_quandle_axioms.jl index 97535d0..cafc31b 100644 --- a/server/test_quandle_axioms.jl +++ b/server/test_quandle_axioms.jl @@ -209,12 +209,7 @@ end d_canonical = quandle_descriptor(trefoil_canonical) @test d_simplified.colouring_count_3 == d_canonical.colouring_count_3 - # KNOWN-BROKEN (upstream): KnotTheory.jl r2_simplify removes the bigon - # without re-splicing the severed arcs, leaving 4 arc labels that occur - # only once; the extracted presentation then has 5 generators instead - # of 3 and c5 comes out 25 instead of 5. Flips to "unexpected pass" - # (forcing removal of this marker) once the upstream fix lands. - @test_broken d_simplified.colouring_count_5 == d_canonical.colouring_count_5 + @test d_simplified.colouring_count_5 == d_canonical.colouring_count_5 end end